- 13 May, 2013 1 commit
-
-
Dwight Engen authored
The problem is that the fd table is shared between threads and if a thread forks() while another thread has an open fd to the monitor, the duped fd in the fork()ed child will not get closed, thus causing monitord to stay around since it thinks it still has a client. This only happened when calling lxcapi_start() in the daemonized case since that is the only time we try to get the status from the monitor. Signed-off-by:
Dwight Engen <dwight.engen@oracle.com> Signed-off-by:
Serge Hallyn <serge.hallyn@ubuntu.com>
-
- 09 May, 2013 1 commit
-
-
Dwight Engen authored
Signed-off-by:
-
- 08 May, 2013 2 commits
-
-
Dwight Engen authored
Signed-off-by:
-
Serge Hallyn authored
A few months ago cgroup handling in lxc was updated so that if /sys/fs/cgroup/$cgroup/lxc/$container already exists (most often due to another container by the same name under a different lxcpath), then /sys/fs/cgroup/$cgroup/lxc/${container}-N would be used. lxc-ps was never updated to handle this. Fix that. (Note, the ns cgroup is being special cased there, but I don't really believe ns cgroup works any more.) It would be preferable to rewrite lxc-ps in python or in C, but this at least makes the basic lxc-ps work in the case of multiple containers with the same name. Changelog: fix missing fi. replace 'z1' with '$container' as pointed out by Christian Signed-off-by:
-
- 07 May, 2013 8 commits
-
-
Serge Hallyn authored
commit ab81cef0 meant to remove the added break, but apparently i had not done 'git add' before commit --amend. Remove the added break. Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
also break once we have found root, no need to search the rest of the mounts Changelog: May 6: Serge: don't add the break. (see m-l) Signed-off-by:
-
- 06 May, 2013 3 commits
-
-
Harald Dunkel authored
Signed-off-by:
Harald Dunkel <harald.dunkel@aixigo.de> Signed-off-by:
-
Harald Dunkel authored
Signed-off-by:
-
Harald Dunkel authored
Signed-off-by:
-
- 03 May, 2013 9 commits
-
-
Dwight Engen authored
also fixed some error strings while here Signed-off-by:
-
Serge Hallyn authored
Signed-off-by: -
Dwight Engen authored
The check for flen < 0 could never have been true since flen was declared to be size_t (unsigned). Declare flen to be long since that is what ftell returns. Signed-off-by:
-
Serge Hallyn authored
Signed-off-by: -
Dwight Engen authored
Signed-off-by:
-
Dwight Engen authored
Since lxc_execute() is available through the library and is exposed via the API we cannot be sure the caller will immediately exit, so we should take care to free the allocated memory. Signed-off-by:
-
Dwight Engen authored
error case Signed-off-by:
-
Weng Meiling authored
When running lxc-start command with valgrind, it reports a memory leak error. When lxc-start command fails, the conf which is from malloc has not been released. This patch fix the problem. Signed-off-by:
Weng Meiling <wengmeiling.weng@huawei.com> Signed-off-by:
-
Weng Meiling authored
when releasing the conf, add free conf->rcfile which is from malloc Signed-off-by:
-
- 02 May, 2013 3 commits
-
-
Serge Hallyn authored
Signed-off-by: -
Serge Hallyn authored
clean up error case in clone, which in particular could cause double lxc_container_put(c2) for overlayfs, handle (with error message) all bdev types. Signed-off-by: -
Dwight Engen authored
On Mon, 29 Apr 2013 14:44:47 -0500 Serge Hallyn <serge.hallyn@ubuntu.com> wrote: > Quoting Dwight Engen (dwight.engen@oracle.com): > > So I did this, only to realize that lxc-init is passing "none" for > > the file anyway, so it currently doesn't intend to log. This makes > > me think that passing NULL for lxcpath is the right thing to do in > > this patch. If you want me to make it so lxc-init can log, I can do > > that but I think it should be in a different change :) > > That actually would be very useful, but as you say that's a different > feature - thanks. ... and here is said change. Signed-off-by:
-
- 01 May, 2013 1 commit
-
-
Serge Hallyn authored
Don't allow write to /dev/rtc0, and remove sys_time. Thanks, Christoph. v2: drop sys_time, sys_module, mac_admin and mac_override in all templates. Reported-by:
Christoph Mitasch <cmitasch@thomas-krenn.com> Signed-off-by:
-
- 30 Apr, 2013 12 commits
-
-
Dwight Engen authored
Signed-off-by:
-
Serge Hallyn authored
Reported by both Dwight and S.Çağlar - thanks. Signed-off-by: -
Serge Hallyn authored
Reported-by:
S.Çağlar Onur <caglar@10ur.org> Signed-off-by:
-
Serge Hallyn authored
Signed-off-by: -
S.Çağlar Onur authored
Signed-off-by:
-
S.Çağlar Onur authored
Signed-off-by:
-
Serge Hallyn authored
It's a tiny program (exported through the api) wrapping the util.c helpers for reading /etc/lxc/lxc.conf variables, and replaces the kludgy shell duplication in lxc.functions.in Changelog: Apr 30: address feedback from Dwight (exit error on failure, and use 'lxcpath' as name, not 'default_path'). Signed-off-by:
-
Serge Hallyn authored
also make sure to drop spaces between = and variable in lxc.conf Signed-off-by: -
Serge Hallyn authored
/etc/lxc/lxc.conf can contain zfsroot = custom1 lvm_vg = vg0 (Otherwise the defaults are 'lxc' for lvm_vg, and 'lxc' for zfsroot) Signed-off-by: -
Serge Hallyn authored
allow copy clones from other bdevs for lvm and zfs, as we don't yet support passing options, only default VG of 'lxc' and default zfsroot of 'tank' are supported when converting another backing store type. refuse deletion of container which has lvm or zfs snapshots. Note that since a zfs clone must be made from a zfs snapshot, which is made from the original zfs fs, even after we lxc-destroy the snapshotted container we still must manually remove the snapshot. This can be handled automatically, by looking for snapshots where c1 is the original, c2 is the clone, tank/c2 no longer exists, but tank/c1@c2 does. We can then remove tank/c1@c2 and feel free to remove tank/c1. This patch does NOT do that yet. Make sure not to return when we're a forked child. Signed-off-by: -
Serge Hallyn authored
Signed-off-by: -
Serge Hallyn authored
1. commonize waitpid users to use a single helper. We frequently want to run something in a clean namespace, or fork off a script. This lets us keep the function doing fork:(1)exec(2)waitpid simpler. 2. start a blockdev backend implementation. This will be used for mounting, copying, and snapshotting container filesystems. 3. implement btrfs, lvm, directory, and overlayfs backends. 4. For overlayfs, support a new lxc.rootfs format of 'bdevtype:<extra>'. This means you can now use overlayfs-based containers without using lxc-start-ephemeral, by using lxc.rootfs = overlayfs:/readonly-dir:writeable-dir 5. add a set of simple clone testcases 6. Write a new lxc_clone.c based on api clone. Still to do (there's more, but off top of my head): 1. support zfs, aufs 2. have clone handle other mount entries (right now it only clones the rootfs) 3. python, lua, and go bindings (not me :) 4. lxc-destroy: if lvm backing store, check for snapshots of it. (what about directories which have overlayfs clones?) Changes since v2: Initialize random generator when picking new macaddr (reported by caglar@10ur.org) Fix wrong use of bitmask flags On copy-clone of btrfs, create a subvolume lxc_clone.c: respect the command line usage of the old script lxc-clone(1): update documentation Refuse to try changing backing stores expect to overlayfs, as it is not implemented (yet) anyway. Signed-off-by:
-
