- 21 Jan, 2010 3 commits
-
-
Michel Normand authored
Signed-off-by:
Michel Normand <normand@fr.ibm.com> Signed-off-by:
Daniel Lezcano <dlezcano@fr.ibm.com>
-
Michel Normand authored
Signed-off-by:
-
Michel Normand authored
Signed-off-by:
Cedric Le Goater <clg@fr.ibm.com> Signed-off-by:
-
- 20 Jan, 2010 7 commits
-
-
Michel Normand authored
warning with git am, white before tab correction Signed-off-by:
-
Greg Kurz authored
The handler argument to lxc_fini() is never null. Signed-off-by:
Greg Kurz <gkurz@fr.ibm.com> Signed-off-by:
-
Greg Kurz authored
sv[0] has already been closed when reaching out_abort label. Signed-off-by:
-
Michel Normand authored
Signed-off-by:
-
Clement Calmels authored
Signed-off-by:
Clement Calmels <clement.calmels@fr.ibm.com> Signed-off-by:
-
Greg Kurz authored
It makes sense to use goto when there's some rollback work to be done. And it's nice for code clarity to add an explicit suffix to goto labels. Signed-off-by:
-
Michel Normand authored
Signed-off-by:
-
- 18 Jan, 2010 4 commits
-
-
Taisuke Yamada authored
I noticed lxc-console uses '^a' as command-mode prefix to escape out of console session, so created a patch to make it configurable. With this, you can do lxc-console -n foo -e ^t and exit the session with 'Ctrl+t q'. For emacs-binding addicts (like me), it's always nice to let shell handle '^a' as 'beginning-of-line' command... Signed-off-by:
Taisuke Yamada <tai@rakugaki.org> Signed-off-by:
-
Clement Calmels authored
Signed-off-by:
-
Clement Calmels authored
The getline function allocate the needed memory. Fix buffer can lead to 'hard to find' bug. I don't test the pivot_root part but the other parts are ok. Signed-off-by:
-
Clement Calmels authored
Correct the way the struct dirent **namelist structure is freed. Signed-off-by:
-
- 14 Jan, 2010 5 commits
-
-
Daniel Lezcano authored
lxc_config_define_load should an int Signed-off-by: -
Cedric Le Goater authored
Signed-off-by:
-
Cedric Le Goater authored
Signed-off-by:
-
Cedric Le Goater authored
Signed-off-by:
-
Cedric Le Goater authored
lxc_config_define_add() and lxc_config_define_load() define the interface to load a list of KEY=VAL buffers in the configuration Signed-off-by:
-
- 13 Jan, 2010 8 commits
-
-
Daniel Lezcano authored
Signed-off-by: -
Cedric Le Goater authored
lxc_config_readline() will be used to parse configuration variable assigned from the command line with --define Signed-off-by:
-
Clement Calmels authored
Just use a list instead of array for dynamically allocated stuff. It's more appropriated. Signed-off-by:
-
Clement Calmels authored
A simple test program to show up the issue: -8<--- #include <stdio.h> #include <unistd.h> #include "mainloop.h" struct lxc_epoll_descr loop; int cb1(int fd, void *data, struct lxc_epoll_descr *descr) { fprintf(stderr, "cb1\n"); return 1; } int cb2(int fd, void *data, struct lxc_epoll_descr *descr) { fprintf(stderr, "cb2\n"); return 1; } int main(int argc, char *argv[]) { int ret; int fds[2]; ret = pipe(fds); if (ret) { perror("pipe:"); return -1; } ret = lxc_mainloop_open(&loop); if (ret) { fprintf(stderr, "lxc_mainloop_open: %d\n", ret); return -1; } ret = lxc_mainloop_add_handler(&loop, fds[1], cb1, NULL); if (ret) { fprintf(stderr, "lxc_mainloop_add_handler(fds[1]): %d\n", ret); return -1; } ret = lxc_mainloop_add_handler(&loop, fds[0], cb2, NULL); if (ret) { fprintf(stderr, "lxc_mainloop_add_handler(fds[0]): %d\n", ret); return -1; } write(fds[1], &ret, sizeof(ret)); ret = lxc_mainloop(&loop); if (ret) { fprintf(stderr, "lxc_mainloop: %d\n", ret); return -1; } ret = lxc_mainloop_close(&loop); if (ret) { fprintf(stderr, "lxc_mainloop_close: %d\n", ret); return -1; } return 0; } Compile and run: $ gcc test.c -o test -I ./src/lxc/ ./src/lxc/liblxc_so-mainloop.o && ./test cb2 -
Clement Calmels authored
Let's take an example: fd = open(..) /* fd = 3 for example */ lxc_mainloop_add_handler(descr, fd, cb1, data1) fails. the program take care of the error, it closes the fd Later, reopen a fd (get 3 for again) lxc_mainloop_add_handler(desc, fd, cb2, data2) is ok. When something happen on fd, cb1 with data1 will be called instead of cb2 with data2, because descr->ev contains 2 entries for fd == 3. Signed-off-by:
-
Clement Calmels authored
Fix bad index. Signed-off-by:
-
Cedric Le Goater authored
lxc_<cmd>.c and <cmd>.c files use the same log category : lxc_<cmd>. The symbol is multiply defined and linking statically lxc commands is not possible. The patch introduces new log categories with a '_ui' suffix to differentiate the command line interface from the library routine. Reported-by:
Ciprian Dorin, Craciun <ciprian.craciun@gmail.com> Signed-off-by:
-
Cedric Le Goater authored
Signed-off-by:
-
- 08 Jan, 2010 9 commits
-
-
Daniel Lezcano authored
Removed extra </command>. Signed-off-by: -
Michael Holzt authored
When the configuration path does not exist, lxc_create misleadingly tells that it was not set. Signed-off-by:
Michael Holzt <lxc@my.fqdn.org> Signed-off-by:
-
Michael Holzt authored
lxc.pc and scripts/lxc-busybox are missing from .gitignore Signed-off-by:
-
Michael Holzt authored
Rename doc/examples/lxc-complex-config.in to lxc-complex.conf.in as all other examples in this directory have a .conf ending as well. Signed-off-by:
-
Daniel Lezcano authored
Remove dead code. Signed-off-by: -
Michael Holtz authored
lxc currently does a chroot into the target rootfs. chroot is insecure and can easily be broken, as demonstrated here: | root@synergy:~# touch /this_is_the_realrootfs_ouch | # touch /container/webhost/this_is_the_container | # lxc-start -n webhost /bin/sh | # ls this* | this_is_the_container | # ./breakchroot | # ls this* | this_is_the_realrootfs_ouch code to break chroot taken from http://www.bpfh.net/simes/computing/chroot-break.html Now this can be fixed. As our container has his own mount namespace, we can easily pivot_root into the rootfs and then unmount all old mounts. The patch attached add a new config keyword which contains the path to a temporary mount for the old rootfs (inside the container). This stops the chroot break method shown before. Example: | root@synergy:~# grep pivotdir /var/lib/lxc/webhost/config | lxc.pivotdir = /oldrootfs | root@synergy:~# ls -lad /container/webhost/oldrootfs | drwxr-xr-x 2 root root 4096 2010-01-02 03:59 /container/webhost/oldrootfs | root@synergy:~# lxc-start -n webhost /bin/sh | # mount -t proc proc /proc | # cat /proc/mounts | rootfs / rootfs rw 0 0 | /dev/root / ext3 rw,relatime,errors=remount-ro,data=writeback 0 0 | devpts /dev/console devpts rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=000 0 0 | proc /proc proc rw,relatime 0 0 | # ls this* | this_is_the_container | # ./breakchroot | # ls this* | this_is_the_container Signed-off-by:
-
Michel Normand authored
conf object is on stack and is used in forked process. Signed-off-by:
-
Michel Normand authored
this is a side effect of previous patch I made on this same function in commit a6ddef61Signed-off-by:
-
Michel Normand authored
few added lines to document the new lxc-create -t option Signed-off-by:
-
- 05 Jan, 2010 1 commit
-
-
Paul Fee authored
Fix and clarify some parts of the lxc.conf man page. Signed-off-by:
-
- 28 Dec, 2009 1 commit
-
-
Daniel Lezcano authored
The future kernel 2.6.33 will incorporate the macvlan bridge mode where all the macvlan will be able to communicate if they are using the same physical interface. This is an interesting feature to have containers to communicate together. If we are outside of the container, we have to setup a macvlan on the same physical interface than the containers and use it to communicate with them. Signed-off-by:
-
- 27 Dec, 2009 2 commits
-
-
Daniel Lezcano authored
This script builds a busybox rootfs and provides the associated configuration to run the busybox. Signed-off-by: -
Daniel Lezcano authored
Cleanup the script, simplify it and pass the arguments to this script to be callable by lxc-create template logic. Signed-off-by:
-
