Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • src
  • Pipeline
  • Constants.cpp
Find file
BlameHistoryPermalink
  • David 'Digit' Turner's avatar
    Remove two minor compiler warnings/errors: · 48f3f6cb
    David 'Digit' Turner authored Mar 23, 2020
    Found when building with the Fuchsia toolchain, which
    uses a recent clang version:
    
    - The constants '1.0f / 0x7FFFFFFF' and
      '1.0f / 0xFFFFFFFF' cannot be computed directly without
      losing one bit of accuracy, and the compiler was complaining
      about it, so use intermediate double values
      to get the correct, final result.
    
    - The MemoryMapped class needs to be declared final to
      have a final destructor, otherwise the compiler complains
      with:
    
        error: class with destructor marked 'final' cannot be inherited from
        [-Werror,-Wfinal-dtor-non-final-class]
    
    Bug: None
    Change-Id: I9728df87fd5d12418ef7d73aa651eca02b0e36f9
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42888
    Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarBen Clayton <bclayton@google.com>
    Tested-by: 's avatarBen Clayton <bclayton@google.com>
    48f3f6cb
Constants.cpp 13.8 KB
EditWeb IDE
×

Replace Constants.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.