Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
S
swiftshader
  • Project
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Chen Yisong
  • swiftshader
  • Repository

Switch branch/tag
  • swiftshader
  • third_party
  • subzero
  • src
  • IceASanInstrumentation.cpp
Find file
BlameHistoryPermalink
  • Nicolas Capens's avatar
    Discern between load and store addresses · 8d50b556
    Nicolas Capens authored Feb 05, 2021
    There were InstLoad::getSourceAddress() and InstStore::getAddr()
    methods, which aren't very clear and consistently named. This change
    replaces them with getLoadAddress() and getStoreAddress(), respectively.
    
    This will also enable moving these methods to the Inst class to make
    them available for SubVectorLoad and SubVectorStore intrinsics. While
    these methods don't make sense for other instructions, note that
    Inst::getSrc() already provides access to all operands and has to be
    used with knowledge of the operand meaning and layout. So this only
    provides a name to these operands, and it would stick out as a sore
    thumb if used incorrectly.
    
    Bug: b/179497998
    Change-Id: I86b1201b8a1c611682f4f91541bdb49e17ef71a8
    Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/52530
    Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
    Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
    Kokoro-Result: kokoro <noreply+kokoro@google.com>
    Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
    8d50b556
IceASanInstrumentation.cpp 19 KB
EditWeb IDE
×

Replace IceASanInstrumentation.cpp

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.