Uniform block instance name validation

This cl adds validation that uniform block instance names aren't reserved names. Fixes 2 tests: dEQP-GLES3.functional.shaders.uniform_block.invalid.invalid_identifier_instance_name_* Change-Id: I4a39c734cdf4d11ea4221c73c1f639fa2f56921d Reviewed-on: https://swiftshader-review.googlesource.com/15868Tested-by: Alexis Hétu <sugoi@google.com> Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Uniform block instance name validation
152997c9 · Alexis Hetu · Alexis Hétu · 73771b1f · 152997c9
Commit 152997c9 authored Jan 05, 2018 by Alexis Hetu Committed by Alexis Hétu Jan 05, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

ParseHelper.cpp src/OpenGL/compiler/ParseHelper.cpp +3 -0

No files found.
--- a/src/OpenGL/compiler/ParseHelper.cpp
+++ b/src/OpenGL/compiler/ParseHelper.cpp
@@ -2431,6 +2431,9 @@ TIntermAggregate* TParseContext::addInterfaceBlock(const TPublicType& typeQualif
 	}
 	else
 	{
+		if(reservedErrorCheck(nameLine, *instanceName))
+			recover();
+
 		// add a symbol for this interface block
 		TVariable* instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false);
 		instanceTypeDef->setQualifier(typeQualifier.qualifier);