Skip to content

S
swiftshader
Commit 152997c9 by Alexis Hetu Committed by Alexis Hétu
Options

Uniform block instance name validation

This cl adds validation that uniform block instance names aren't reserved names. Fixes 2 tests: dEQP-GLES3.functional.shaders.uniform_block.invalid.invalid_identifier_instance_name_* Change-Id: I4a39c734cdf4d11ea4221c73c1f639fa2f56921d Reviewed-on: https://swiftshader-review.googlesource.com/15868Tested-by: 's avatarAlexis Hétu <sugoi@google.com> Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent 73771b1f
Showing with 3 additions and 0 deletions
src/OpenGL/compiler/ParseHelper.cpp
...@@ -2431,6 +2431,9 @@ TIntermAggregate* TParseContext::addInterfaceBlock(const TPublicType& typeQualif ...@@ -2431,6 +2431,9 @@ TIntermAggregate* TParseContext::addInterfaceBlock(const TPublicType& typeQualif
} }
else else
{ {
if(reservedErrorCheck(nameLine, *instanceName))
recover();
// add a symbol for this interface block // add a symbol for this interface block
TVariable* instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); TVariable* instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false);
instanceTypeDef->setQualifier(typeQualifier.qualifier); instanceTypeDef->setQualifier(typeQualifier.qualifier);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment