Skip to content

S
swiftshader
Commit 2dd86447 by Nicolas Capens
Options

Revert "Produce MSVC error when virtual class misses virtual destructor"

This reverts commit cd09f8e9. Reason for revert: Kokoro build failures Bug: b/130335507 Change-Id: I5479cc40723ae3a95e3d9fb7b74de8506f188e08 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44928Reviewed-by: 's avatarNicolas Capens <nicolascapens@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
parent 45be4684
Showing with 0 additions and 1 deletion
CMakeLists.txt
...@@ -356,7 +356,6 @@ if(MSVC) ...@@ -356,7 +356,6 @@ if(MSVC)
# Treat specific warnings as errors # Treat specific warnings as errors
list(APPEND SWIFTSHADER_COMPILE_OPTIONS list(APPEND SWIFTSHADER_COMPILE_OPTIONS
"/we4265" # class has virtual functions, but its non-trivial destructor is not virtual; instances of this class may not be destructed correctly
"/we4018" # 'expression' : signed/unsigned mismatch "/we4018" # 'expression' : signed/unsigned mismatch
"/we4471" # 'enumeration': a forward declaration of an unscoped enumeration must have an underlying type (int assumed) "/we4471" # 'enumeration': a forward declaration of an unscoped enumeration must have an underlying type (int assumed)
"/we4838" # conversion from 'type_1' to 'type_2' requires a narrowing conversion "/we4838" # conversion from 'type_1' to 'type_2' requires a narrowing conversion
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment