Skip to content

S
swiftshader
Commit ee98b422 by Nicolas Capens Committed by Nicolas Capens
Options

Normalize B8G8R8A8 identically to R8G8B8A8

In https://swiftshader-review.googlesource.com/c/SwiftShader/+/33028 we modified the conversion of 8-bit color elements to 16-bit ones from duplicating the byte, to putting 0 in the lower byte, and adjusting the normalization factor from 0xFFFF to 0xFF00 accordingly. However, the latter wasn't being done for B8G8R8A8. Bug: chromium:979652 Bug: swiftshader:122 Change-Id: I621a600128e1b028b3303917acd826a7bf4630dd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34228 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by: 's avatarNicolas Capens <nicolascapens@google.com> Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com> Reviewed-by: 's avatarChris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
parent 0662a4af
Showing with 2 additions and 0 deletions
src/Pipeline/SamplerCore.cpp
......@@ -181,6 +181,7 @@ namespace sw
case VK_FORMAT_R8_UNORM:
case VK_FORMAT_R8G8_UNORM:
case VK_FORMAT_R8G8B8A8_UNORM:
case VK_FORMAT_B8G8R8A8_UNORM:
case VK_FORMAT_A8B8G8R8_UNORM_PACK32:
case VK_FORMAT_B8G8R8A8_SRGB:
case VK_FORMAT_R8G8B8A8_SRGB:
......@@ -234,6 +235,7 @@ namespace sw
case VK_FORMAT_R8_UNORM:
case VK_FORMAT_R8G8_UNORM:
case VK_FORMAT_R8G8B8A8_UNORM:
case VK_FORMAT_B8G8R8A8_UNORM:
case VK_FORMAT_A8B8G8R8_UNORM_PACK32:
case VK_FORMAT_B8G8R8A8_SRGB:
case VK_FORMAT_R8G8B8A8_SRGB:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment