Skip to content

S
swiftshader
Switch branch/tag
  1. 21 Jul, 2016 4 commits
  3. 20 Jul, 2016 1 commit
  5. 19 Jul, 2016 2 commits
    • Improve LoopAnalyzer Interface · adf352bc
      Manasij Mukherjee authored 
      Make LoopAnalyzer compute loop bodies and depth only.
Move the logic for finding out loop headers and pre-headers to LoopInfo, which provides a visitor to iterate over the loops and easy access to the information.
This does not change the core algorithm.

BUG=None
R=jpp@chromium.org, stichnot@chromium.org

Review URL: https://codereview.chromium.org/2149803005 .
    • Subzero: Fix lowering for x86 div/rem instructions. · 017a5538
      Jim Stichnoth authored 
      The x86 lowering sequences for sdiv/udiv/srem/urem all have a problem, in that they don't reflect the fact that two registers are affected by the instruction.

For example, the urem instruction:
  dest = src0 urem src1
lowers to something like this:
  t1:eax = src0
  t2:edx = 0
  t2:edx = (t1:eax and t2:edx) div src1
  dest = t2:edx

The problem is that there is no indication that the div instruction smashes eax.  As such, it's possible that the register allocator could erroneously assume that src0 is still available in eax after the div instruction.

To fix this, we make use of the FakeDef instruction.  In this example, we change the div instruction to "officially" produce eax as its result, then fakedef edx in terms of eax.  This means that as long as the urem result is actually used, the definitions of eax and edx will be preserved, but if the urem result is unused, then the whole sequence can be dead-code eliminated.

  t1:eax = src0
  t2:edx = 0
  t1:eax = (t1:eax and t2:edx) div src1  # dest var changed to t1:eax
  t2:edx = fakedef t1:eax                # fakedef instruction added
  dest = t2:edx

BUG= none
R=jpp@chromium.org

Review URL: https://codereview.chromium.org/2158213002 .
  7. 14 Jul, 2016 2 commits
  9. 13 Jul, 2016 2 commits
  11. 12 Jul, 2016 3 commits
  13. 10 Jul, 2016 1 commit
    • Subzero: Allow deeper levels of variable splitting. · fe62f0a2
      Jim Stichnoth authored 
      This fixes some existing problems with the Variable::LinkedTo splitting/linking mechanism.  The problem was that if B is linked to A, and B needs a stack slot, but A doesn't get a stack slot, B's stack offset would never get initialized.  This could happen if A ends up with no explicit references in the code, or A's live range gets truncated such that it actually has a register while B doesn't.

It gets even more complicated if you have a link chain like A<--B<--C<--D etc. where some of them have stack slots (which should ultimately all be the same slot) and some don't.

The solution here is that if B is linked to the root A, and B has a stack slot but A doesn't, we can do a tree rotation so that B is the new root and A links to B.

In addition, we initialize Variable::StackOffset to an invalid value and always make sure a value used is valid.  Earlier attempts at extending the variable splitting would sometimes silently fail because the default StackOffset value of 0 ended up being used.

BUG= none
R=jpp@chromium.org

Review URL: https://codereview.chromium.org/2116213002 .
  15. 07 Jul, 2016 2 commits
  17. 06 Jul, 2016 3 commits
  19. 30 Jun, 2016 1 commit
  21. 29 Jun, 2016 3 commits
  23. 27 Jun, 2016 6 commits
  25. 25 Jun, 2016 4 commits
  27. 22 Jun, 2016 4 commits
  29. 21 Jun, 2016 2 commits