- 22 May, 2019 8 commits
-
-
Ben Clayton authored
Remove the 'removed' condition_variable field. It is not used. Don't bother copying and unlocking before returning a field - this is not required. Bug: b/133127573 Change-Id: Ic8e29e6b6008e16b6abd043ccfa9014e203ce69a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31678 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <headlessclayton@gmail.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
This is a pure move with no changes. The goal here is to centralize the concurrent synchronization primitives, and not have them scattered around the codebase. Bug: b/133127573 Change-Id: I6abdfc34bf13ce455983610ff0c686778e0e9e4c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31677 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Antonio Maiorano authored
- Use boost::stacktrace instead of libbacktrace so that we get can get callstacks on Windows as well. Note that on non-Windows, we tell boost::stacktrace to use libbacktrace. - REACTOR_EMIT_DEBUG_INFO can now be enabled on all platforms - Fix RR_LOG not building on MSVC by using __FUNCSIG__ instead of __PRETTY_FUNCTION__. - Enable CMake option REACTOR_EMIT_PRINT_LOCATION so that EmitLocation in LLVMReactorDebugInfo.cpp injects printfs with func/file/line. Sample output: rr> sw::Blitter::generate [c:\src\swiftshader\src\renderer\blitter.cpp:1303] rr> sw::Blitter::generate [c:\src\swiftshader\src\renderer\blitter.cpp:1304] rr> sw::Blitter::ComputeOffset [c:\src\swiftshader\src\renderer\blitter.cpp:1148] rr> sw::Blitter::generate [c:\src\swiftshader\src\renderer\blitter.cpp:1312] rr> sw::Blitter::generate [c:\src\swiftshader\src\renderer\blitter.cpp:1314] rr> sw::SetupRoutine::edge [c:\src\swiftshader\src\shader\setuproutine.cpp:566] Bug: b/131425026 Change-Id: Ia3b78652f4a76dcd6597ce2df61a236c4a90acc2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30030Tested-by: -
Antonio Maiorano authored
Includes only what's necessary for boost::stacktrace. See third_party/boost/README.md for instructions on how create/update this minimal boost version. Bug: b/131425026 Change-Id: I61643a0ba09d8b27517ec94f88c31d3a5aef09f4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30008Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
-
Chris Forbes authored
Device functions can be queried through GIPA. There is no device to check for enabled extensions here, so return anything that is supported. Test: dEQP-VK.wsi.* Change-Id: I3be086b4cd0ad6f5e80595aa4401a424780333d2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31749 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
If a device extension isn't enabled, then the associated extension functions shouldn't be exposed through vkGetDeviceProcAddr(). Bug b/117974925 Change-Id: I828cf9ff9d8aaf22c15a5379cfb9d93612d23360 Tests: dEQP-VK.api.version_check.entry_points Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31696 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: I5bb5f9ead2bb92beeb67ece6e0021a7ab81dc88b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31819 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
Change-Id: Id09bcb2b9ecfb90321ab94d3d9589055f0234252 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31769Tested-by:
-
- 21 May, 2019 2 commits
-
-
Saman Sami authored
gn files are tested on linux only. Test: * Built GL Swiftshader using ninja on Linux, Mac, and Windows. * Built and ran viz_unittests on Linux, Mac, and Windows. * Built Chromium ToT on Linux, Android, Mac. * Built Chromium + Vulkan Swiftshader on Linux by applying crrev.com/c/1615710 and ran viz_unittests with --enable-vulkan Bug: chromium:963988 Change-Id: Ic1529b8be0b508786863e03722acf610045a98ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31529Tested-by:
Saman Sami <samans@chromium.org> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: Ie2099d22e26108d4db22130cd804fc8965852bb6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31808Reviewed-by:
-
- 20 May, 2019 2 commits
-
-
Ben Clayton authored
The returned whole and frac must have the same sign as the input parameter. Tests: dEQP-VK.glsl.builtin.precision.modf.* Tests: dEQP-VK.glsl.builtin.function.common.modf.* Bug: b/126873455 Change-Id: I791891fdf46f9285e12d770e2b15b91ebfa3f0b1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31590 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: Iff3192ce8b4132c61f5b3c716627f5d1d59502ad Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31676 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 19 May, 2019 2 commits
-
-
SwiftShader Regression Bot authored
Change-Id: I771c053d1d28563cf5e8c8ee13ae5d49adcd0c57 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31674 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
Vulkan 1.1 spec section 15.6.7. Scale Factor Operation, Level-of-Detail Operation and Image Level(s) Selection clarifies that the first returned parameter is the clamped LOD, rounded to the nearest integer if mipmapMode is VK_SAMPLER_MIPMAP_MODE_NEAREST, and the second parameter is the unclamped LOD with base level and sampler bias applied (we don't take maxSamplerLodBias into account, it is infinite). Bug: b/129523279 Tests: dEQP-VK.glsl.texture_functions.query.texturequerylod.* Tests: dEQP-VK.ycbcr.query.lod.* Change-Id: I4aa2f16716e1e23548b6fb3e0862e7cc442e3678 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31629 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
- 18 May, 2019 10 commits
-
-
Chris Forbes authored
Previously we replicated the high bits into the low and from that point on treated these values as 16 bits. Unfortunately, that causes a snorm channel value of 0xff to yield -1/32767 rather than the expected -1/127. Bug: b/129523279 Test: dEQP-VK.image.mutable.*snorm* Change-Id: I6e329490f92562d6edac86043e80fef978682c88 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31728Reviewed-by:
-
Antonio Maiorano authored
Bug: b/131224705 Change-Id: I7f971cd72ab623ba3798231b8b2a1b77e7744f78 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31369 Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I261d70ecdc7637c08d8cb461ea60e649472bc99e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31673 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
- Sampler lod bias and limits do not apply - Fetch samplerfunction has a lod parameter, pass it Bug: b/129523279 Test: dEQP-VK.glsl.texture_functions.* Change-Id: Ia06bb5ff181068b29cf3e88acd9a0272ad1a54c9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31748Tested-by:
-
Chris Forbes authored
Test: dEQP-VK.api.info.get_physical_device_properties2.features Change-Id: Ia181128e7018658e40020ff4ab75b041f00d754d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31750Tested-by:
-
Hernan Liatis authored
third_parth/llvm-7.0/BUILD.gn needed to update in order to add additional required files as listed in chromium:961729. Same needs to be done to the equivalent Android.bp file. Bug: chromium:961729 Change-Id: I0afce6f8f4a8fa3b0d5e2001fe98c1686f410f78 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31768Reviewed-by:
Hernan Liatis <hliatis@google.com>
-
Nicolas Capens authored
Whichever direction was chosen as the 'major' one, a division by zero occurred when trying to project to its corresponding face. Prevent it by ensuring 'M' is greater than zero. Bug: b/132981873 Test: dEQP-VK.glsl.opaque_type_indexing.sampler.const_literal.compute.samplercube Change-Id: I71c25be4d8e17409cc9bf32a2f6180db9a948d34 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31729 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
The SPIR-V spec states: "Coordinate must be a scalar or vector of floating-point type. It contains (u[, v] … [, array layer]) as needed by the definition of Sampled Image. It may be a vector larger than needed, but all unused components will appear after all used components." Bug b/129523279 Tests: dEQP-VK.glsl.texture_functions.texture.* Change-Id: I951f679b7794fef5fbbe504c753db052c5cf124b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31694 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Nicolas Capens authored
Divide Dref by the projection coordinate. The SPIR-V spec states that "Dref /q is the depth-comparison reference value." Bug b/129523279 Tests: dEQP-VK.glsl.texture_functions.textureproj.* Change-Id: Ib1c4ad09f829b84b6b1065ff604fe88f8b1c1426 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31693 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
The imageView's baseMipLevel is already taken into account when obtaining each level's parameters, so don't offset a second time. Bug b/129523279 Tests: dEQP-VK.texture.mipmap.* Change-Id: I5a5c35f36d2f8517136c095f8c80202984a777bd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31690 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 17 May, 2019 12 commits
-
-
Hernan Liatis authored
The swapchain images were being freed with an allocator despite never being created with one. Tests: dEQP-VK.wsi.xlib.swapchain.simulate_oom.* Bug: b/132451407 Change-Id: I26c6ecd18d04f514cdae171100de6a89c919a777 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31692 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Hernan Liatis authored
Physical device was using the wrong allocations scope. Tests: dEQP-VK.wsi.xlib.surface.create_custom_allocator Tests: dEQP-VK.wsi.xlib.surface.create_simulate_oom Bug: b/132451407 Change-Id: I242d97548bdf01cbdab5cc708469bca02a845a66 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31691 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
-
Fabrice de Gans-Riberi authored
Fuchsia has no mallinfo() or getrusage(). This silences the build warnings. Bug: chromium:921807 Change-Id: Ifbb274efdc99ebdf38a6b6b8760ffd42be6fafa4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31708Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
Unnormalized texture coordinates are pretty much the same as rectangle texture coordinates, with a few extra addressing modes to support. ADDRESSING_CLAMP and ADDRESSING_BORDER work properly. Other modes can't used with unnormalized texture coordinates, according to the Vulkan spec: "If unnormalizedCoordinates is VK_TRUE, addressModeU and addressModeV must each be either VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_EDGE or VK_SAMPLER_ADDRESS_MODE_CLAMP_TO_BORDER" Bug b/129523279 Change-Id: I3e39c16172bc5825ec48c6395f52e9b177df1304 Tests: dEQP-VK.texture.filtering.unnormal.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31648Tested-by:
-
Alexis Hetu authored
If an image is created with flags including the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT bit, then the compressed image may be used with an image view which has an uncompressed format that is size-compatible with the image's compressed format. Tests: dEQP-VK.image.texel_view_compatible.*.texture_read.e* Bug b/119620767 Change-Id: Ia1af959780af12e9014f7852aaf991d313f75bf1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31620Tested-by:
-
Ben Clayton authored
Change-Id: Idb051ef0af8510cbb65dffbbe94be34951928c48 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31670 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
They're not just a Clang thing. Change-Id: Ibf66e13997dbd59ec7b1d4f9bbaf0d20ea244200 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31669 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Should provide more context when ASAN actually catches something bad. Change-Id: Ia0021ca21538747855d725a2116d51b3b0480a1c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31591Reviewed-by:
-
Ben Clayton authored
Bug: chromium:963658 Change-Id: I7db9bd4b5cec57c65298cdef512d18e31d4182f5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31594 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
Bug: b/129523279 Change-Id: I894b11a58fcde956312ad92f934aaa0c60a0f837 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30808Tested-by:
-
Chris Forbes authored
Bug: b/117974925 Change-Id: I7a5cb6f8bbee13322e1d2524c9ecb8df20fe8e04 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31208Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: Ib3b20d2268fc7db22817d2d073ecfec60eb1c30a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31668 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 16 May, 2019 4 commits
-
-
Chris Forbes authored
- Renderer fence signaling only really worked for work in the same submission. If the fence was submitted standalone later, there would be no renderer work tagged with this fence, and so no ordering. - Get rid of old uncounted fence operations. This is a landmine. Bug: b/132897411 Test: dEQP-VK.api.copy_and_blit.* Test: dEQP-VK.binding_model.* Test: dEQP-VK.query_pool.* Test: dEQP-VK.api.object_management.* Test: dEQP-VK.memory.pipeline* Change-Id: I9050b96d111a6c348c5675724c8017c483c06182 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31188Reviewed-by:
-
Chris Forbes authored
Bug: b/118386749 Test: dEQP-VK.memory_model.* Change-Id: Ie0962df8e17264ec93265cd56b4a79e0d5f37c33 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31528Tested-by:
-
Chris Forbes authored
Test: dEQP-VK.memory_model.* Bug: b/127472316 Change-Id: I96447aba539e2ae9b4d42637fbe4a829f35093f5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31513Tested-by:
-
Chris Forbes authored
Helps drive out the test bugs we're running into. Bug: b/132879304 Test: dEQP-VK.renderpass.suballocation.* Change-Id: I33e168a9bdc2385beff9f5d42e44f8632934febe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31568Tested-by:
-
