- 30 Aug, 2019 3 commits
-
-
Nicolas Capens authored
Windows DLLs are not systematically prefixed with "lib". This change follows the implicit and explict expectations set out in: https://vulkan.lunarg.com/doc/view/1.0.21.0/windows/LoaderAndLayerInterface.html http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html#AEN49 Also make the vk_swiftshader target a dependency of vk-unittests so that building the latter also allows running it. Bug: b/139189696 Change-Id: I070871e63c5cefc3f80a6f441a1d5097c85b82b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35630 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Jamie Madill authored
This CL enables the Windows build integration with ANGLE. Several instances of "build_with_chromium" in the GN are changed to use build_overrides instead. Also in several places in the GN support is added for Windows builds. Also Add guards for WIN32_LEAN_AND_MEAN, and removes an unused variable that shows up when building with GN on Windows configs. Bug: angleproject:3876 Bug: b/140251624 Change-Id: I7a470c7605c2b62420dca44e4797c29983ed7c13 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35631Reviewed-by:
Jamie Madill <jmadill@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
The BlendState structure is part of the cache key used to look up pixel routines, which must not contain any uninitialized bits. The PixelProcessor::States structure gets zero-initialized as a whole by the Memset<> base class, but when writing BlendState structures into it any uninitialized bits may get copied over. Thus BlendState must also be zero-initialized, using Memset<>. Bug: b/140286664 Bug: b/140193782 Change-Id: I031ec1a5f3be4329ae16366bfd4c8f17e2371384 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35768Tested-by:
Ben Clayton <bclayton@google.com>
-
- 29 Aug, 2019 9 commits
-
-
Alexis Hetu authored
ANGLE needs to be able to sample surfaces in order to emulate things like glBlitFramebuffer or use EGL images as textures. Section 32.3. Required Format Support of the Vulkan 1.1 spec dictates that all formats which must support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT, also support VK_IMAGE_USAGE_TRANSFER_SRC_BIT, VK_IMAGE_USAGE_TRANSFER_DST_BIT, and VK_IMAGE_USAGE_SAMPLE_BIT. It should already work properly in SwiftShader, so this cl just adds the bit. Bug b/139412450 b/139479506 Change-Id: I0f79d042789a8b6372f75ecf6cda5f28c6955652 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35709Reviewed-by:
-
Alexis Hetu authored
A few blend related context members were changed from scalars to arrays in order to support independent blend. Bug b/140193782 Change-Id: I5ca1153e952fe0d3899f68dc6cd7cc5d8a244b72 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34113Tested-by:
-
Nicolas Capens authored
The Visual Studio 2017 solution will be deprecated in favor of using Visual Studio 2019 for building the CMake project. For now we're keeping it for just the legacy OpenGL ES and Direct3D builds, but Vulkan related projects are removed since they break the full solution build frequently and fixing them may be more involved than running build/cmake.sh again. Bug: swiftshader:134 Bug: b/139189696 Change-Id: I5225a291c6cf4bb8c5d0b9a2f7a16f2e85823feb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35708 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Ben Clayton authored
Reduce the test timeout to 2 minutes, 10 is excessive. Include the stderr / stdout in the error message when a test crashes. Up the max proc memory limit from 3GB to 4GB. While our tests haven't started using dramatically more memory, Golang (which wraps the process) seems to use more recently. Reduce delay in killing a timedout process. Change-Id: I4634a788a5cae2cb088d70d2f35909a0264600d6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35692Reviewed-by:
-
Ben Clayton authored
Much like XlibSurfaceKHR, doesn't cope with any formats aside from 24-bit RGB. Bug: b/124265819 Bug: b/139412276 Bug: b/139491466 Change-Id: I1146f6ff672a9016be04e6b4d595de40fa03346f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35149 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: I33a38b285c02ce33fe17e662fd9be93fda97f6d5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35689Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
-
Chris Forbes authored
Storage image support for these formats is mandatory, but this was not covered in previous versions of CTS. Bug: b/140208021 Test: dEQP-VK.image.format_reinterpret.* Change-Id: I823e6ebf02b0aee4d3d33f12710304f8eb922d19 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35669Tested-by:
-
Ben Clayton authored
MemorySanitizer has no visibility into writes performed by JIT'd code. If we have built the project with the MemorySanitizer enabled, memset the Triangle and Primitive structs so the sanitizer has a write to see. This is only cleared in MemorySanitizer enabled builds, as this adds a non negligable cost to Renderer construction. Bug: chromium:998457 Change-Id: I3b4f9e48783c6e8a1109a578988567b0a42eb1f9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35688 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
Per Vulkan spec 2.9.2, when converting from a floating point value to unsigned normalized, we must first clamp to [0,1]. When converting from a floating point value to signed normalized, we must first clamp to [-1,1]. This wasn't done to clear values. Test: dEQP-VK.rasterization.provoking_vertex.* Bug: b/140203285 Change-Id: I3f8c421b187b6a7e8bcb22d45142dc1664221605 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35668Tested-by:
-
- 28 Aug, 2019 8 commits
-
-
Nicolas Capens authored
This also fixes running them from within Visual Studio without requiring setting any environment variables. Change-Id: I5592b2d6a0abfeaeffbe1b788529c77adf5764ed Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35629 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
Chris Forbes authored
This wasn't ever called by previous versions of deqp. Test: dEQP-VK.wsi.xlib.surface.query_devgroup_present_modes Bug: b/140182247 Change-Id: Id77bdc726681922b99f3fa8d098cad7853293d29 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35648Tested-by:
-
Chris Forbes authored
Bug: b/140178640 Test: dEQP-VK.renderpass.suballocation.unused* Change-Id: I3ad3ef55946e4f63e941e6df11a02ca4e2ac6e26 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35554Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I0c457c4a128180b804dddb736951612a094862b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35574Reviewed-by:
-
Nicolas Capens authored
Change-Id: I1230607ebbf0e7dadf8603d2fde5e7a95441c713 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35628 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
Chris Forbes authored
Change-Id: I6c50a3626297aaec7a249068687643f53da4b475 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35553Reviewed-by:
-
Ben Clayton authored
Caught by Chromium's MSAN tests: https://chromium-review.googlesource.com/c/chromium/src/+/1774264/3#message-8031b1ce1959519ccdbfa83113f0d989560148d5 Bug: b/139010488 Bug: chromium:998457 Change-Id: If14f0777155ab892f29eb9b01c0bc6781510381b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35575Reviewed-by:
-
Nicolas Capens authored
Addresses TSAN error in Chromium viz_unittests and cc_unittests. Bug: b/139010488 Change-Id: I1a53487c4787170c38898cca47bf76145ebdf6bd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35608 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
-
- 27 Aug, 2019 9 commits
-
-
Ben Clayton authored
Drop the complex task scheduling logic for yarn. Performance gains seen up to around ~30% FPS. Bug: b/139142453 Change-Id: I264fee36323425a791088565d99dc586670a948a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35572Tested-by:
-
Ben Clayton authored
Pass the cluster count to the QuadRasterizer instead of using a rather nasty back dependency to the renderer. This allows the cluster count to be adjusted per-draw without requiring synchronization around the count. The primary goal of this change is that we can scale the number of clusters based on the complexity of the draw. Bug: b/139142453 Change-Id: I0379e16568de402f186ee2dd1e8b2346bed30efd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35571Tested-by:
-
Ben Clayton authored
These were part of a larger stack of changes for Yarn, but aren't specific to anything in particular. Change-Id: I863d8bbb316b5c255be9557b83511bb9cdef70b0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35570Tested-by:
-
Ben Clayton authored
Bug: b/139142453 Change-Id: I466b7c935db03104cb4df90735fafe10905bef9e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35568Tested-by:
-
Ben Clayton authored
Nothing is actually scheduled, but is a first step towards using yarn. As yarn is now actually used by SwiftShader, drop the BUILD_YARN build flags, as failing to build yarn would result in linker errors. Bug: b/139142453 Change-Id: Ibd9a69f72a248f58a62bb41eeb196c4647876e82 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35153Tested-by:
-
Ben Clayton authored
They're big and take a while to initialize. Only construct them if we need them. This also pushes the construction onto the queue, speeding up the main thread. Bug: b/139010488 Change-Id: I2d1d25f24162339de62cea4d946532b1a2e346ca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34330Tested-by:
-
Ben Clayton authored
TIL: For POD type T, `new T` and `new T()` are not the same. new T() will zero initialize, which for large arrays can be very costly. Bug: b/139142453 Change-Id: I9a1a3ef1bb0a167d9955310d1cf331e917019397 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35569 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
There is no reason to plumb this through Context. Bug: b/132280877 Change-Id: I92819af587505b75b279a6aed70aa8067455df8d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35549Reviewed-by:
-
Chris Forbes authored
We only support these as far as is required for Vulkan 1.1 core functionality. If we expose the extension bits, we have to support more. Change-Id: I2a8b1648e88fb55b4c87075efc696792540144fc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35548Tested-by:
-
- 26 Aug, 2019 4 commits
-
-
Chris Forbes authored
Bug: b/119621736 Change-Id: I8a25e6a5dba7e05649c35dc65160f69300bf5791 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35508Tested-by:
-
Chris Forbes authored
Bug: b/119621736 Change-Id: I9be8dc680f68622e795fccf4ff8213dccd5debb2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35488Tested-by:
-
Chris Forbes authored
This function works with VkFormat, not spv::ImageFormat (due to input attachments) Change-Id: I36a36a94127533a009df8f806b55ff2845162a76 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35528Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: Iba8f2c6f469c7c34dfaa25811c6bcc8f784b600d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35448Reviewed-by:
-
- 23 Aug, 2019 1 commit
-
-
Chris Forbes authored
A single RenderPass object may be used to record multiple command buffers simultaneously. Storing the subpass index there produces crosstalk between the command buffer recordings, and incorrect rendering. Bug: b/139824232 Change-Id: Ib8689a47733a991c61785d2d6332584f7a96f05d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35468 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
-
- 22 Aug, 2019 5 commits
-
-
SwiftShader Regression Bot authored
Change-Id: I8189bb729fb5843979bc719638d25474c2d69308 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35428 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Nicolas Capens authored
Section 15.2.1. RGB to Shared Exponent Conversion of the Vulkan 1.1 spec states "NaN, if supported, is handled as in IEEE 754-2008 minNum() and maxNum(). That is the result is a NaN is mapped to zero." This currently does not affect anything because E5B9G9R9 is not a renderable format. The blitter merely has to support writing this format for computing the corner texel of cube map borders, which are averaged from other E5B9G9R9 format texels and thus no NaN can be encountered. Bug: b/138944025 Change-Id: Ib69aca3af5afee240d9b697c47b2f1a0204fe697 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35008 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Sean Risser <srisser@google.com> Reviewed-by:
-
Nicolas Capens authored
The Vulkan 1.1 spec states that: "For VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE, VK_DESCRIPTOR_TYPE_STORAGE_IMAGE, or VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT, only the imageView and imageLayout members of each element of VkWriteDescriptorSet::pImageInfo are accessed." Also remove the zeroing of sampler descriptor data in SampledImageDescriptor when no sampler handle is provided. This was intended to detect bugs but we didn't do it consistently for all descriptor types (VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER also uses SampledImageDescriptor and has no sampler data). We now pass a null pointer to the sampling routine when no sampler descriptor is available (specifically for OpImageFetch) so it is less likely to still access it unintentionally. Bug: b/139401791 Change-Id: Id1394493e88b7465fe3628c4c7d410cd3eaa3ccf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35388 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
OpImageFetch takes an Image operand, not a SampledImage, and thus we don't explicitly have a sampler descriptor. However, our vk::SampledImageDescriptor structure includes both image view descriptor data and sampler data, and we were relying on the sampler descriptor data to be present for setting the addressing mode. Other state would also inadvertently be affected. This change ensures that the sampler descriptor for fetch operations is null and we set the addressing mode to repeat but leave other unused state at their defaults. Bug: b/139401791 Change-Id: I9f1af35940c2fa9c7d30e771ebdb244f72f5bdbe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35348 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Chris Forbes authored
This is a mandatory feature for 1.1, but Vulkan CTS 1.1.3 doesn't enforce that -- it only tests the feature if it is present. Highlights: - Multiple views implemented by running each draw multiple times. We could do something more efficient, but this is a fringe feature so far. - Render targets and input attachments are adjusted to use the layer corresponding to the current view. - Explicit attachment clears and end-of-subpass resolves are broadcast to the layers corresponding to the current subpass's view mask. - Renderpass attachment load ops are executed for the layers corresponding to the union of the subpass view masks for all subpasses which use the attachment. The actual load ops are still performed together at the beginning of the renderpass. - ViewIndex builtin variable is exposed to the shaders. In a non-multiview draw call, ViewIndex is still available, but is always zero. Bug: b/139862810 Test: dEQP-VK.*multiview* Change-Id: Iaf40cfdb2f5afa61253cc756f97c0db30fb4d813 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35408 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 21 Aug, 2019 1 commit
-
-
Chris Forbes authored
Change-Id: I8090e55dae72f1b48b46147bad0439d22b513b74 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35409Reviewed-by:
-
