Will be upstreamed.

Bug: b/140546382
Change-Id: Ifbbc14d5c5cd1cb6940642a1e6cc690c224e9bfe
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36068Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Having submodules inside subtrees breaks submodule update.

Bug: b/140546382
Change-Id: I0e3e9591bfd1aa8813d1e8764f702d87c5ac5e84
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36030
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

* changes:
  Initial drop of Marl @ d3b8558c
  Squashed 'third_party/marl/' content from commit d3b8558ce

Change-Id: Iac5636d2b9c947bfc14216be70ad8fe46a9a29c5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36088
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

../../third_party/SwiftShader/src\Yarn/Pool.hpp(254): note: see reference to function template instantiation 'std::shared_ptr<yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage> std::make_shared<yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage,>(void)' being compiled
C:\dev\depot_tools\win_toolchain\vs_files\418b3076791776573a815eb298c8aa590307af63\win_sdk\bin\..\..\VC\Tools\MSVC\14.16.27023\include\memory(1866): warning C4316: 'std::_Ref_count_obj<_Ty>': object allocated on the heap may not be aligned 16
        with
        [
            _Ty=yarn::BoundedPool<sw::DrawCall::BatchData,16,yarn::PoolPolicy::Preserve>::Storage
        ]

../../third_party/SwiftShader/src/Vulkan/VkQueue.cpp(122): warning C4316: 'sw::Renderer': object allocated on the heap may not be aligned 16

Bug: angleproject:3876
Bug: b/140251624
Bug: b/140575360
Change-Id: I3016b8ba4e6557c9b7f1c27a387f03ff307e17de
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36048Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

This fixes the GN header check with Yarn. Enables further ANGLE
integration. Also fixes a number of MSVC build errors and changes
the output name of the Vulkan ICD on Windows to "vk_swiftshader"
so that it matches the .def file used in CMake.

Bug: angleproject:3876
Bug: b/140251624
Change-Id: Ie23ba965a2ee7f8b678499db22d6614f0a6666fa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36009Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

Commands:
git subtree add --prefix third_party/marl https://github.com/google/marl d3b8558ce8d2cf2cad1009a99aa3ff453b048639 --squash

To update:
git subtree pull --prefix third_party/SPIRV-Tools https://github.com/KhronosGroup/SPIRV-Tools <sha> --squash

Bug: b/140546382
Change-Id: If3471eb3897b128613c874a9260e0ac390d27cf1

git-subtree-dir: third_party/marl
git-subtree-split: d3b8558ce8d2cf2cad1009a99aa3ff453b048639

Change-Id: I9deb5a9975674b8664eb11f6de312548087010df
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/36008Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Vulkan CTS 1.1.5 is stricter about edge cases here, and sinhf/coshf
aren't cutting it.

Test: dEQP-VK.*cosh*
Test: dEQP-VK.*sinh*
Bug: b/140501860
Change-Id: I21895cbff9f54bccb7d40fb75e09eebe7db18fa1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35988Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

When building the vulkan library (libvk_swiftshader.so) for Fuchsia,
do not place the stripped binary to $OUT_DIR/swiftshader/ instead of
its default location (i.e. $OUT_DIR/lib/).

That's because the Fuchsia packaging scripts rely on the location
of the unstripped library ($OUT+DIR/lib.unstripped/) to find the
release one (i.e. by replacing 'lib.unstripped' with 'lib').

This resulted in a build error (see bug for details). This CL
works around the issue rather than fixing the scripts.

Bug chromium:1000668

Change-Id: I4137c9edbdc04b3b35a8a43e3f37b9e64fe5b1d7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35968Tested-by: David Turner <digit@google.com>
Kokoro-Presubmit: David Turner <digit@google.com>
Presubmit-Ready: David Turner <digit@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Change-Id: Icbf160f40c433b8d90f73862f9980da6cb55655a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35948Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Change-Id: I8f9324f40343d84c57bca76a33d1ce98311b8bf4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35931
Kokoro-Presubmit: David Turner <digit@google.com>
Tested-by: David Turner <digit@google.com>
Presubmit-Ready: David Turner <digit@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

pthread_setname_np() is not provided by the Fuchsia C library
so do not try to call it in Thread::setName().

Change-Id: I7db37e6da52d665ff6535d735e9a2da5d9845143
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35930
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: David Turner <digit@google.com>
Presubmit-Ready: David Turner <digit@google.com>

A solution to blocking, non-yielding function calls.

Bug: b/139010488
Change-Id: I8f2a9458980f83fbecafb22a5531aa6e3dbbc040
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35573
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

This finishes our KHR_swapchain v70 implementation.

Test: dEQP-VK.wsi.*
Change-Id: I512e0c086db687ca7ffb8cd5e5375fa7a9d432cd
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35929Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Previous versions of dEQP never called this function.

Test: dEQP-VK.wsi.*.swapchain.render.*
Test: dEQP-VK.api.version_check.entry_points
Change-Id: I3d64403984ff60fea9ef2921f7f53f0ca4b94240
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35928Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

Change-Id: Ie970829b56e46ffd1a6cc6028148ecd46d0f098d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35908
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

A few changes were made to make this work:
- activeLaneMask now contains cMask. Since it's only used in
  loads, stores and atomics, it should be fine to include it
- Added a storesAndAtomicsMask, which also contains sMask
  (stencil) and zMask (depth) for early fragment tests.
  The mask affects all atomic operations and store operations
  into storage buffer and images.
- support for spv::BuiltInHelperInvocation was added

Bug b/140294254

Test: dEQP-VK.*

Change-Id: I42b97a766ddfe331bb2767d80d4360104a221482
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34114
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

This fixes a few missing dependencies for the Chromium uses of
SwiftShader. It will allow us to turn on the 'gn check' in
Chromium.

Bug: angleproject:3876
Bug: b/140251624
Change-Id: I875a59701a4437cf94b503f6430d858a5285a961
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35811Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Jamie Madill <jmadill@chromium.org>

Bug: b/139687059
Change-Id: Ie0084a5f320f2ac36d55ff0950812a77401f4741
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35848Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Tested with ANGLE running dEQP-GLES2.*rbo_rgb5_a1*

Bug: b/139411772
Change-Id: I5681b008ae7bfb2df2705189f28667dac8d4c983
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35812Reviewed-by: Nicolas Capens <nicolas.capens@gmail.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: Id38fc9787e37108d723edcac73711dc801c46403
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35889
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Commands:
git subtree pull --prefix third_party/SPIRV-Tools https://github.com/KhronosGroup/SPIRV-Tools 65e362b7ae2acb8aa5bd2ad516fb793961e673ee --squash

Bug: b/123642959
Change-Id: Idf19b4f893af1967c97d03e984abd1beb14622ca

65e362b7a AggressiveDCEPass: Set modified to true when appending to to_kill_ (#2825)
d67130cac Replace SwizzleInvocationsAMD extended instruction. (#2823)
ad71c057c Replace SwizzleInvocationsMaskedAMD extended instruction. (#2822)
4ae9b7165 Fix gn check (#2821)
35d98be3b Amd ext to khr (#2811)
5a581e738 spvtools::Optimizer - don't assume original_binary and optimized_binary are aliased (#2799)
73422a0a5 Check feature mgr in context consistency check (#2818)
15fc19d09 Refactor instruction folders (#2815)
1eb89172a Add missing files to BUILD.gn (#2809)
8336d1925 Extend reducer to remove relaxed precision decorations (#2797)
b00ef0d26 Handle Id overflow in private-to-local (#2807)
aef8f92b2 Even more id overflow in sroa (#2806)
c5d1dab99 Add name for variables in desc sroa (#2805)
0cbdc7a2c Remove unimplemented method declaration (#2804)
bc62722b8 Handle overflow in wrap-opkill (#2801)
9cd07272a More handle overflow in sroa (#2800)
06407250a Instrument: Add support for Buffer Device Address extension (#2792)
7b4e5bd5e Update remquo validation to match the OpenCL Extended Instruction Set Specification (#2791)
dac9210dc Use ascii code based characters (#2796)
ff872dc6b Change the way to include header (#2795)
bbd80462f Fix validation of constant matrices (#2794)
60043edfa Replace OpKill With function call. (#2790)
f701237f2 Remove useless semi-colons (#2789)
95386f9e4 Instrument: Fix version 2 output record write for tess eval shaders. (#2782)
22ce39c8e Start SPIRV-Tools v2019.5
d65513e92 Finalize SPIRV-Tools v2019.4
4b64beb1a Add descriptor array scalar replacement (#2742)
c26c2615f Update CHANGES
29af42df1 Add SPV_EXT_physical_storage_buffer to opt whitelists (#2779)
b029d3697 Handle RelaxedPrecision in SROA (#2788)
370375d23 Add -fextra-semi to Clang builds (#2787)
698b56a8f Add 'copy object' transformation (#2766)
4f14b4c8c fuzz: change output extension and fix usage string (#2778)
0b70972a2 Remove extra ';' after member function definition. (#2780)
5ada98d0b Update WebGPU validation rules of OpAtomic*s (#2777)
3726b500b Treat access chain indexes as signed in SROA (#2776)
31590104e Add pass to inject code for robust-buffer-access semantics (#2771)
4a28259cc Update OpMemoryBarriers rules for WebGPU (#2775)
7621034aa Add opt test fixture method SinglePassRunAndFail (#2770)
ac3d13105 Element type is const for analysis::Vector,Matrix,RuntimeArray (#2765)
49797609b Protect against out-of-bounds references when folding OpCompositeExtract (#2774)
7fd2365b0 Don't move debug or decorations when folding (#2772)
7bafeda28 Update OpControlBarriers rules for WebGPU (#2769)

git-subtree-dir: third_party/SPIRV-Tools
git-subtree-split: 65e362b7ae2acb8aa5bd2ad516fb793961e673ee

Instead of using a batch size of 1, divide the batch size by 3 so that
we have enough room for 3x more primitives to render. Also use local
Triangle data structures to copy the vertices for the extra primitives,
instead of adding them to the input batch.

Bug: b/139872671
Change-Id: I1bc860d291b53fdd266b6c018ac0c47c876aaa09
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35588Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Implements Vulkan's 'fillModeNonSolid' feature.

Mostly a copy-and-paste of src/Renderer logic. It sets the batch size
for non-solid triangles to 1 so their edges or vertices can get
individually rasterized as lines or points.

Bug: b/139872671
Tests: dEQP-VK.rasterization.culling.*
Change-Id: Ifbae8dad32e8b43159fee459c75d7e593fc08041
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35031Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

LLVM takes liberties with NaN float constants, which can arise in integer
constant values.

Bug b/140294254

Test: dEQP-VK.spirv_assembly.type.vec3.u32.constant_composite_frag
Change-Id: Ibfff77b9e0bacf81756bb50801615369dfc51ab6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35728
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Change-Id: Ie2c5c11c029ddd41944ef2def2560176ebd244b7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35729
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

https://swiftshader-review.googlesource.com/c/SwiftShader/+/35630
renamed the version scripts with corresponding changes in CMake, but
other build files were overlooked.

Bug: b/139189696
Change-Id: Ib6354e0fb4f62d1e7f4d4f335d03b45ad205c87e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35808
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Windows DLLs are not systematically prefixed with "lib".
This change follows the implicit and explict expectations set out in:
https://vulkan.lunarg.com/doc/view/1.0.21.0/windows/LoaderAndLayerInterface.html
http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html#AEN49

Also make the vk_swiftshader target a dependency of vk-unittests so that
building the latter also allows running it.

Bug: b/139189696
Change-Id: I070871e63c5cefc3f80a6f441a1d5097c85b82b6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35630
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

This CL enables the Windows build integration with ANGLE. Several
instances of "build_with_chromium" in the GN are changed to use
build_overrides instead. Also in several places in the GN support
is added for Windows builds.

Also Add guards for WIN32_LEAN_AND_MEAN, and removes an unused
variable that shows up when building with GN on Windows configs.

Bug: angleproject:3876
Bug: b/140251624
Change-Id: I7a470c7605c2b62420dca44e4797c29983ed7c13
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35631Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Jamie Madill <jmadill@chromium.org>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

The BlendState structure is part of the cache key used to look up pixel
routines, which must not contain any uninitialized bits. The
PixelProcessor::States structure gets zero-initialized as a whole by
the Memset<> base class, but when writing BlendState structures into it
any uninitialized bits may get copied over.

Thus BlendState must also be zero-initialized, using Memset<>.

Bug: b/140286664
Bug: b/140193782
Change-Id: I031ec1a5f3be4329ae16366bfd4c8f17e2371384
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35768Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

ANGLE needs to be able to sample surfaces in
order to emulate things like glBlitFramebuffer
or use EGL images as textures.

Section 32.3. Required Format Support of the
Vulkan 1.1 spec dictates that all formats
which must support
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT,
also support
VK_IMAGE_USAGE_TRANSFER_SRC_BIT,
VK_IMAGE_USAGE_TRANSFER_DST_BIT,
and VK_IMAGE_USAGE_SAMPLE_BIT.

It should already work properly in SwiftShader,
so this cl just adds the bit.

Bug b/139412450 b/139479506

Change-Id: I0f79d042789a8b6372f75ecf6cda5f28c6955652
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35709Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>

A few blend related context members were changed from scalars to
arrays in order to support independent blend.

Bug b/140193782

Change-Id: I5ca1153e952fe0d3899f68dc6cd7cc5d8a244b72
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/34113Tested-by: Alexis Hétu <sugoi@google.com>
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

The Visual Studio 2017 solution will be deprecated in favor of using
Visual Studio 2019 for building the CMake project.

For now we're keeping it for just the legacy OpenGL ES and Direct3D
builds, but Vulkan related projects are removed since they break the
full solution build frequently and fixing them may be more involved than
running build/cmake.sh again.

Bug: swiftshader:134
Bug: b/139189696
Change-Id: I5225a291c6cf4bb8c5d0b9a2f7a16f2e85823feb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35708
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Reduce the test timeout to 2 minutes, 10 is excessive.

Include the stderr / stdout in the error message when a test crashes.

Up the max proc memory limit from 3GB to 4GB. While our tests haven't started using dramatically more memory, Golang (which wraps the process) seems to use more recently.

Reduce delay in killing a timedout process.

Change-Id: I4634a788a5cae2cb088d70d2f35909a0264600d6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35692Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Much like XlibSurfaceKHR, doesn't cope with any formats aside from 24-bit RGB.

Bug: b/124265819
Bug: b/139412276
Bug: b/139491466
Change-Id: I1146f6ff672a9016be04e6b4d595de40fa03346f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35149
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Change-Id: I33a38b285c02ce33fe17e662fd9be93fda97f6d5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35689Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Storage image support for these formats is mandatory, but this was not
covered in previous versions of CTS.

Bug: b/140208021
Test: dEQP-VK.image.format_reinterpret.*
Change-Id: I823e6ebf02b0aee4d3d33f12710304f8eb922d19
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/35669Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>