- 13 Mar, 2020 4 commits
-
-
Ben Clayton authored
Makes for easier reading of the assertion macros. Bug: b/148401179 Change-Id: Icc48baa9c476967c6dea19c2f0e91ed253dce323 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42194Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Acts as a placeholder for no-debug-info. Implemented as nullptr. Bug: b/148401179 Change-Id: I6cbfb227296d98befa6a7d2baa29128cb0c7bd29 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42193 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Bug: b/148401179 Change-Id: I3a5cacc24bcb31a0b7e7cc3319ba500de59baa8a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42192Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
The inlined-at isn't currently used, but this unblocks tests that emit this instruction. Bug: b/145351270 Change-Id: I787e0de3d7ede8225ad3a86544f867559ea9c387 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42095 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 12 Mar, 2020 9 commits
-
-
Alexis Hetu authored
According tot he Vulkan spec, about vkCmdBlitImage: "As the sizes of the source and destination extents can differ in any dimension, texels in the source extent are scaled and filtered to the destination extent." Logic was added to allow filtering in 3 dimensions in the Blitter. Since it requires more instructions, a state member was added in order to only filter in Z whenever we actually to do so (when the number of slices differ between source and destination regions). Fixes all tests mentioned in the issue. Bug: b/150155499 Change-Id: I63da92db94d8d0394a06271cd47d4930cf5f726a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42208 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Bug: b/151314247 Change-Id: Ib10831c42a0c18f86397ed3b6c5d32a578653c89 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42288 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
We currently rely on limiting the mipmap level count of YCbCr images and the presence of sampler YCbCr conversion to disable mipmapping. This is valid, but fragile. The Vulkan 1.2 spec guarantees that when sampler Y'CbCr conversion is used, the image view must have a Y'CbCr format: "If the descriptor refers to a sampler that performs Y'CbCr conversion, the sampler must only be used to sample the image in the same descriptor." "If the image view is to be used with a sampler which supports sampler Y'CbCr conversion, an identically defined object of type VkSamplerYcbcrConversion to that used to create the sampler must be passed to vkCreateImageView in a VkSamplerYcbcrConversionInfo included in the pNext chain of VkImageViewCreateInfo. Conversely, if a VkSamplerYcbcrConversion object is passed to vkCreateImageView, an identically defined VkSamplerYcbcrConversion object must be used when sampling the image." "maxMipLevels is the maximum number of mipmap levels. maxMipLevels must be equal to the number of levels in the complete mipmap chain based on the maxExtent.width, maxExtent.height, and maxExtent.depth, except when one of the following conditions is true, in which case it may instead be 1: * ... * image format is one of those listed in Formats requiring sampler Y′CBCR conversion for VK_IMAGE_ASPECT_COLOR_BIT image views" Bug: b/151263485 Change-Id: Ibb8e3fe34ecda04d6fb41308437fa4c66815f1fb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42228 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Bug: b/149537975 Change-Id: Ia589e0015437e5257991fe2e8b5f6459384a76de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42048 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
SetupRoutine uses V0 == V1 == V2 when drawing points, so we don't have to duplicate those vertices explicitly. Bug: b/149537975 Change-Id: I723a7139f5eb5735bedb0c17796c00dc4b414fa7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42028 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
If the Reactor backend is Subzero, there's no need to build LLVM. This is accomplished by excluding the LLVM target from the "all" target. Bug: b/151250656 Change-Id: I26dc44921cc44d379c619700c6dd03f6fe94ee27 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42229 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Ben Clayton authored
A single change to fix windows breakage due to 'alloc' requiring an underscore prefix on some toolchains. Changes: 64d123947 thread.cpp: Replace use of alloca with vector. Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash Bug: b/140546382 Bug: angleproject:4474 Change-Id: If15baa2531a5b49537bb0ba9f190454f2044ad9b -
Ben Clayton authored
64d123947 thread.cpp: Replace use of alloca with vector. git-subtree-dir: third_party/marl git-subtree-split: 64d123947e4dbc741217ea7b49f3d2b6275be117
-
Ben Clayton authored
Also contains the following changes: * Replace the use of `unsigned char` with `uint8_t`. `char` is not guaranteed to be 8-bit. * Remove the `dstW` and `dstH` parameters from `BC_Decoder::Decode` and `ETC_Decoder::Decode`. They're always the same as the `w` and `h` parameters. * Add BC6 types to various switch cases. The actual decode logic is not implemented for these formats. Tests: *bc7* Bug: b/151203718 Change-Id: I7b232b9dc3a9b02d172f87a62c88ce56b2cca956 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41508Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 11 Mar, 2020 8 commits
-
-
Ben Clayton authored
Contains a fix for an arm linker error (chromium:1058107) and scaling beyond 64 threads on Windows. Changes: 94a361cf0 thread.cpp Fix minor bug in getProcessorGroups() 0249a2624 Thread: Use WaitForObject for Thread::join() 62f209bbb arm: Annotate marl_fiber_swap as type %function 00f091e08 Update README.md 773d9f475 Add new example 'tasks_in_tasks' 3f69e73ce Scheduler: Replace use of std::thread with marl::Thread Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash Bug: b/140546382 Bug: chromium:1058107 Change-Id: Ic5a96ad5f054a19f6a5a77e1f106c73ba60c0a78 -
Ben Clayton authored
94a361cf0 thread.cpp Fix minor bug in getProcessorGroups() 0249a2624 Thread: Use WaitForObject for Thread::join() 62f209bbb arm: Annotate marl_fiber_swap as type %function 00f091e08 Update README.md 773d9f475 Add new example 'tasks_in_tasks' 3f69e73ce Scheduler: Replace use of std::thread with marl::Thread git-subtree-dir: third_party/marl git-subtree-split: 94a361cf0b5187a5845f3a37c9e67c8406ccb40b
-
Nicolas Capens authored
By setting the RPATH to $ORIGIN, Linux executables can behave like on Windows and search for shared libraries in the exectuables directory before looking elsewhere. We copy SwiftShader's Vulkan library into this directory, naming it vulkan.so.1 to match the loader name the executables look for. This also relies on SwiftShader exporting all Vulkan API entry functions like the loader library does: b/148240133 Bug: b/141361933 Change-Id: I617303cc11faead7aac9e689142a4400731a58a5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41970Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Ben Clayton authored
Test: none Change-Id: I10ca476ed7dade95b516fabc1279fe751285114f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42128Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
Using --dailynow --dailychange <hash> makes Regres check out the specified change to obtain the vk-master.txt from and perform a full run of all the tests. Also fix --keep usage. Bug: none Change-Id: Ia126bfc136e6b86a6fcc570f79a9293ae97ca392 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42109Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Nicolas Capens authored
https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788 and https://swiftshader-review.googlesource.com/c/SwiftShader/+/41968 cause us to use different compile flags for Subzero's LLVM dependencies than the rest of SwiftShader. Suppress the warnings that this has unleashed. Bug: b/132445520 Change-Id: I1f20e32b487035e953c02cd4829460c072e38ac3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41969 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Ben Clayton authored
Add `filter` flag to run_testlist so that tests can be filtered by wildcard or regex. Update `run_testlist.sh` and `run_testlist.bat` to automatically use the vk-master.txt test list. Change-Id: I94ef1d2e9220f18bdf50555db8c291b3736ec3f3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42089Reviewed-by:
Paul Thomson <paulthomson@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
The http URL now results in a redirect to an https URL. Update the URL to the new redirect URL. Also add the `-L` flag to curl so that future redirects don't break our presubmits. Also verify with the provided PGP signatures instead of using a more vulnerable sha1. Bug: none. Fixing presubmits. Change-Id: I715c45f7083bf0f5528d82ba93d008464d0d7f88 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42093Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 10 Mar, 2020 1 commit
-
-
Antonio Maiorano authored
On some ABIs, C++ functions that return bool only set the least significant bits of the return register (e.g. AL on x64). The Call implementation in SubzeroReactor would use uninitialized i32 target to hold the result of a bool-returning function, but this would return erroneous results when the called function would return false by setting the LSB to 0, but with a non-zero MSB, thus returning true. This change makes sure to truncate the i32 result to i8 (bool), returning true only if the lsb is non-zero. Bug: b/151158858 Change-Id: I41055a94d7f8045da503f27881ed887c1926f77b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/42068Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 09 Mar, 2020 1 commit
-
-
SwiftShader Regression Bot authored
Change-Id: I57d7aaaaf85f009721b791ad15f20ea7971a9092 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41988Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 06 Mar, 2020 2 commits
-
-
Marc-Antoine Desroches authored
Bug: b/149537975 Tests: dEQP-VK.*point* Change-Id: I22ee0c0ebc4e7b414e055e2b87010004dfc8741a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41948Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Marc-Antoine Desroches <madesroches@google.com>
-
Nicolas Capens authored
This is a partial revert of https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788 where .c files were renamed to .cpp to avoid a warning treated as error: command line option ‘-fno-operator-names’ is valid for C++/ObjC++ but not for C [-Werror] This appears to have caused macOS linker issues: chromium:1059196 Instead, explicitly add the flag to compile with warnings-as-errors (when enabled) for code that is actively maintained by us, and make Subzero's legacy LLVM dependencies a separate library compiled without warnings-as-errors. Also revert CMakeSettings.json changes that were inadvertently committed. Bug: b/141361933 Bug: chromium:1059196 Change-Id: I27dd57d954a413a710613b0bfa2e69bd5242853a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41968Reviewed-by:
Marc-Antoine Desroches <madesroches@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 05 Mar, 2020 1 commit
-
-
Nicolas Capens authored
On Windows placing the vulkan-1.dll next to the executables suffices for them to load SwiftShader instead of the system's Vulkan ICD loader (if present). Also make warnings-as-errors only affect our own projects, and put things into project folders. Bug: b/141361933 Change-Id: Ibdf8bcb992aa484d4bebaaf52ae77a8ced61709a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40788 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 04 Mar, 2020 4 commits
-
-
Antonio Maiorano authored
Implement non-optimized version. Should generalize and optimize code in UShort4::UShort4(RValue<Float4> cast, bool saturate) so we can use it here. Bug: b/145754674 Change-Id: I16a24dab2979bb97d2d5f36a406aeb62aeb976e8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41928Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Antonio Maiorano authored
On x86-32/64, assume that loads and stores are atomic, and that strictest memory order is supported. Bug: b/150475088 Change-Id: I5f99a0309eca668d0c1197387bcf687b32381179 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41790Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Antonio Maiorano authored
CMake variables were renamed in https://swiftshader-review.googlesource.com/c/SwiftShader/+/39909 This means regres has been running without DCHECK_ALWAYS_ON enabled, possibly resulting in false positives when SwiftShader would assert. Bug: n/a Change-Id: Ifc4963a6c562bd21db9e1775e06dc5d4ff20f290 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41908Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
Regression was introduced in https://swiftshader-review.googlesource.com/c/SwiftShader/+/41269 When detecting and removing intermediate stores, if the storeValue is a constant, we skip it; however, we must make sure to set unmatchedLoads to true, or the optimizer will incorrectly eliminate the skipped store on a later iteration. This bug lead to incorrect generated code, which failed certain deqp-vk tests, e.g. dEQP-VK.clipping.user_defined.clip_cull_distance.vert.2_6 Bug: b/148272103 Change-Id: I024d75decdc4f1d13e7f82cade50f8be09d68f3e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41888Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 03 Mar, 2020 2 commits
-
-
James Price authored
This fixes the Vulkan Loader for CMake builds. Bug: b/150626933 Change-Id: I600597c95c4a41f3242028fd9ccd65fced4ead33 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41848Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
James Price <jrprice@google.com>
-
Nicolas Capens authored
Defines in BUILD.gn files don't apply transitively to dependencies, so we have to repeat the SWIFTSHADER_ENABLE_ASTC for the Device subdirectory. Note we could also use 'public_configs = [:swiftshader_libvulkan_private_config]' but this adds more defines and build flags than what we need. Since this is intended as a temporary workaround anyway, we're keeping it simple. Bug: b/150600814 Change-Id: Ib06f4a22559ee58114da5841e66e59bfce9aec4a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41868Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
- 02 Mar, 2020 2 commits
-
-
SwiftShader Regression Bot authored
Change-Id: I05b0a9fbad99116a7163a6cb4ad43e7eccb060f3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41808 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
To temporarily work around build issues related to Google3 integration, make ASTC support optional and only enable it for CMake, Chromium, and Android builds. Bug: b/150600814 Change-Id: Iac6a404322c65a6f2727807ea8af2edfb219a5a2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41828Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Sean Risser <srisser@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 28 Feb, 2020 3 commits
-
-
Jamie Madill authored
It's valid in Vulkan for a shader to have specialization constants and the pipeline to be lacking specialization constant data. This could lead to a key match between the two even though there should be a different shader payload. From the spec: > It is legal for a SPIR-V module with specializations to be > compiled into a pipeline where no specialization info was provided. > SPIR-V specialization constants contain default values such that > if a specialization is not provided. Fix this by adding in the required checks. Should not affect perf. Bug: b/150449637 Bug: angleproject:4426 Change-Id: I5f384420bdc1f03a36852db0b20393ae56452b62 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41728Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: Jamie Madill <jmadill@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
This cl adds both LDR and HDR support for ASTC compressed textures. Only LDR formats are exposed in the PhysicalDevice's properties, but HDR support can be added trivially later by adding the HDR formats and exposing "VK_EXT_texture_compression_astc_hdr". Pulled from: https://github.com/ARM-software/astc-encoder Git hash: 81a5e50741b4c8302cf7d78f314a53e44ee68e1f The astc-encode git repo was added to third-party, with a few minor modifications: 1) All encoding related code has been ripped out, only decoding related code remains 2) Replaced ASTC_CODEC_INTERNAL_ERROR() with UNREACHABLE() in a switch statement in astc_color_unquantize.cpp 3) Some functions were using a lot of stack memory, so I added a unique_ptr to allocate the same objects on the heap, to avoid potential issues. LDR ASTC is decoded to 8bit unsigned RGBA. HDR ASTC is decoded to 32b floating point. Tests: dEQP-VK.*astc* Bug: b/150130101 Change-Id: I6b03fed6e1f326a95c7aefe9f9a9d0a89cf24428 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41568Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Jonah Ryan-Davis authored
EGL_ANGLE_iosurface_client_buffer added a new attribute to the config: EGL_BIND_TO_TEXTURE_TARGET_ANGLE, which needed to be properly exposed in the EGL frontend. Bug: chromium:1015454 Change-Id: I58881df18d711ed7974a0a06e53fed42b1f28638 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41709 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 27 Feb, 2020 3 commits
-
-
Jamie Madill authored
Set squash uploads to false. This should make git cl upload work properly from SwiftShader for those who prefer that over 'git push' to a ref. Bug: None Change-Id: Ib80fdbd28c2a7a5808ab73ceec8ddb98f8962e0b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41708Tested-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Antonio Maiorano authored
For the System V ABI, variadic calls must store the number of floating point arguments into RAX. This was mostly working by accident for our calls to printf since RAX is used as a scratch register, and was often non-zero, which is all that's really needed for printf with float args to work; however, when RAX would become 0, printf would print the wrong thing. Bug: b/149913889 Change-Id: Id4b519c5416927d537fca078109c0dc850f08359 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41668Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Jamie Madill authored
The code in VkPipelineCache was correctly comparing all the attributes of the specialization constants and then was also doing a faulty shared pointer comparison. This was causing major drag on draw calls as every draw call in ANGLE was recompiling the shader. Bug: angleproject:4426 Change-Id: Ia0466738eb7de78c0c3b53e61e2f2bc6831bbcca Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41688 Kokoro-Presubmit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-