These will be used to create a synthetic file for all the commands in the command buffer, which can be stepped over using the new debugger.

Bug: b/145351270
Change-Id: If5728463c1cf333d635c46e2d3b6314ce7d27326
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38910Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Also add SPIRV-Tools, as this was missing and caused red squiggles.

Bug: b/145351270
Change-Id: I22e664bb662f75284cf93cf6e446e775521c7b26
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38908Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Change-Id: I4c2ca30b1cc9edda07c83056d9798fe8c202152b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39313Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

The Subzero JIT now has sufficient functionality to support running
the Vulkan unit tests.

Bug: b/130461828
Change-Id: I8c398b976899151ac4a82549df21e06127a115f1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39328Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Both code paths will be tested for Windows, macOS, Linux for both LLVM and Subzero backends.

Bug: b/145836207
Change-Id: I707b1551fe1a65549c47a6d7756ab94aeb8d80e2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39312
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

VkPhysicalDeviceFeatures::imageCubeArray implies both the ImageCubeArray
and SampledCubeArray SPIRV capabilities are supported. We had only
accepted SampledCubeArray so far.

Bug: b/144988970
Change-Id: I93fb93a95047f73c677de38757660ea1321a4654
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39289Tested-by: Chris Forbes <chrisforbes@google.com>
Presubmit-Ready: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

EventListener is an interface that is used to listen for thread events.
Thread holds the state for a single thread of execution.
Frame holds a number of variable scopes for one of a thread's stack frame.
Scope is a container for frame variables.

Bug: b/145351270
Change-Id: Ic61e17f32cfd6929dbd7b0fce1ffb716301fc73e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38897Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

It holds a file path and line number.

Bug: b/145351270
Change-Id: I0f54d00bda151be529d912562061052abff2fe81
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38896Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Files represent either physical, filesystem-backed files, or virtual debugger-produced files.

Bug: b/145351270
Change-Id: Ib085a1244cc10dc644546d1d049d1bfa030744ff
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38895Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

WeakMap is an associative container of keys of type K to values of type std::weak_ptr<V>.
WeakMap's iterators will skip over elements where the value has no more remaining std::shared_ptr<V> references.

Used to automatically track live debug objects.

Bug: b/145351270
Change-Id: I87b9a9be4b83ff887510f292a4e03770ccc9eeaf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38894Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

The Value interface exposes values to the debugger.
Variables are named values.
VariableContainer is a collection of Variables.

Bug: b/145351270
Change-Id: Iae3749447554977f84bfc6e58f37b52aa6ed262f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38893Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

This implements a very basic runtime type information used by debug-exposed values.

Bug: b/145351270
Change-Id: I6bd9fe292bd7058307789300d562f7699e12f02b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38892Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

set() does not evaluate conditional expressions like if() does.
BUILD_CPPDAP was being set to "${BUILD_VULKAN};AND;${ENABLE_VULKAN_DEBUGGER}", so cppdap was always required as a submodule dependency.

Bug: b/145351270
Change-Id: I86c3e43b8e22aa283bd2a5a20e0c03c01a965e8a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39310Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Change-Id: Ia1fb2619484845e1d7f26174baed791500493890
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39208
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

This is required by vkmark and various other workloads. The present mode
handling is not really correct -- both our fifo and mailbox modes behave
more like IMMEDIATE due to XPutImage etc being completely unthrottled

Future changes will introduce proper present mode handling for the Xlib
and Xcb WSI implementations.

Bug: b/124265819
Change-Id: Ia71ff928848be9925ffb30a27fe6c35732b68590
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39288
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Chris Forbes <chrisforbes@google.com>

Limit CI results to the owner when things are good.
Limit CI results to owner + reviewers when things are not so good.

Should reduce email spam.

Change-Id: I1b71f17f306bf04ecb9fb87ffd95aea42a8e84b4
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39308Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Made this change in code review without proper testing.
The "level" being set here was the input argument, rather than the data
member.

Bug: b/145685985
Change-Id: I8641701cc0600837f4dc612d29ffaa4cd63390b1
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39269
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

CMake (without or without Visual Studio 2019) should be used instead
for the Vulkan build.

Bug: b/139189696
Change-Id: I8583ecf4605c89edffefa10050f7d6ef85ecb72c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39228
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

vk::dbg::ID is a strongly-typed identifier backed by an int.
ID is used to prevent implicit casts between idenfitifers of different T types.

Bug: b/145351270
Change-Id: Ia51ee8cca19eaa86cab4e009340fdcf9072360e5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38891Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

In LLVM3, this conversion was subtly broken. We're now on LLVM7, where this should be
fixed.

Mostly a revert of
https://swiftshader-review.googlesource.com/c/SwiftShader/+/7354, but
also includes a subzero implementation

Bug: b/31816482
Change-Id: I154a221b44b985a35bcc5e15923a0deb9b51c711
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39148Tested-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Conversion from floating-point to unsigned integer is not a native
instruction on some CPU architectures, so excercise the case where it
overflows signed int.

Bug: b/31816482
Change-Id: I4ce924bbf4eb4c371e25d800fd4d7794edfa62cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39188
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Allows us to configure Reactor backend optimization level via
preprocessor macro. Can be set via CMake arg.

Bug: b/145685985
Change-Id: I27a80b15846a8b43be5bff0505632213852a5dc6
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39168Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Only breaks in Om1 optimization mode because this code path is specific
to Om1. Broke after 01386d17 was merged because maxOutArgsSizeBytes()
now returns 32 bytes for the shadow store, so this is a rarely exercised
code path. Problem is that on x64, the new register being created needs
to match the size of the destination register, so 64 bits, not 32 as it
was assuming.

Fixes ReactorUnitTests Call_ArgsMixed, Call_ArgsPointer, IntrinsicTest_*
which were asstering with:
Assertion failed: !isScalarIntegerType(Dest->getType()) || (typeWidthInBytes(Dest->getType()) <= typeWidthInBytes(Source->getType())), file C:\src\SwiftShader2\third_party\subzero\src\IceInstX86Base.h, line 1308

Bug: b/145685985
Change-Id: I298edd5b4a286a242b351cc6267d70ecb37943fb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39169
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Reverted the hack fix from bb222a10, and implemented a proper fix.

The fix in TargetX86Base<TraitsType>::lowerCast
(IceTargetLoweringX86BaseImpl.h) was suggested by Jim Stichnoth. The
original problem is that we're trying movd an i32 to an i4i32, and since
the target Variable is long-lived, it may not get a register allocated
for it, and when that happens, we end up tripping the assert in
InstX86Movd::emitIAS() that expects the destination to have been
allocated a register. The solution that Jim suggested, and is
implemented here, is to create a temporary, short-lived, variable to
first movd into, which should guarantee a register target, since
short-lived Variables usually get registers. Then we 'mov' the temporary
register Variable to Dest, which *should* support moving the i4i32
register operand to an i32 memory operand.

I said *should* above, because with the above fix, we now trip another
assert in InstX86Mov::emitIAS (Mov, not Movd). The reason being that it
doesn't actually support moving an i4i32 reg -> i32 memory operand. I
added support for this as well (IceInstX86BaseImpl.h). Note that this
assert only tripped when building with Om1 optimization level, since O2
ostensibly optimized out the mov call.

Bug: b/145529686
Change-Id: I3c998a3e308838123cb415fcbf9f277113ac7d28
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39068
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

`ENABLE_VULKAN_DEBUGGER` is the new option to enable building of the Vulkan debugger, which defaults to off.

`cppdap` is a new library that implements the debugger protocol.

Added a stub .cpp file to try and detect any build systems that are recursively globbing into the new src/Vulkan/Debug directory.

Actual debugger implementation will come in future changes.

Bug: b/145351270
Change-Id: I48619f1d8352c0525c8adbaa4bc3f2373a237d61
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38890
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Used by the new Vulkan debugger.

Bug: b/145351270
Change-Id: I4419fa208b52ed2db17422e3c14fe01dfb55cde9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38889
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Required by cppdap, which is used by the new Vulkan debugger.

Bug: b/145351270
Change-Id: Ibf65a63ed3c508722993578c57d72b1884a06ff9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38888Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Reactor's 'Int' type is specified to be 32-bit, always, and it was
implicitly assumed the C++ 'int' type has the same size. Likewise for
'short' being 16-bit.

Make this assumption explicit with static asserts.

Bug: b/145913083
Change-Id: Ie47346358487f8152f68654b75ea44b5d4f8823b
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39129
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

This cl adds logic to propagate the 4th texture coordinate,
which is only used for cubemap arrays, and use it as the
cubemap array id.

Tests: dEQP-VK.glsl.texture_functions*cubearray*
Bug: b/144988970
Change-Id: I241b9a50a87424461647f00d442774ead8aaa0f7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38876
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>

This reverts commit 51d98676.
No longer needed, as the root problem was fixed in
7fefd483
(https://swiftshader-review.googlesource.com/c/SwiftShader/+/37273)

Bug: b/129757459
Change-Id: I70da0bf00fd737e395a264c1f8bfd4b25325e4bc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/37930
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

This appears to be accidentally missing.

Bug: b/145836207
Change-Id: Iaeb71c362f3b8450f91355e8d1f16c8d58c56548
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39108Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

These asserts were put in place to warn us if they got test coverage.
They do since https://swiftshader-review.googlesource.com/38929. All
seven are hit by the new test.

Bug: b/145836207
Change-Id: I1aba531a1d005b48185d0b3ba72b923d2997a88e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39088
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: David Turner <digit@google.com>

The assert() can be safely removed. This was tested by doing the
following on my Linux machine.

  1) remove the assert() in third_party/swiftshader/third_party/subzero/src/IceTargetLoweringX86BaseImpl.h:6491
  2) change the 11 into 1 in src/Reactor/ReactorUnitTests.cpp:492 (to ensure full coverage of the Blend operation)
  3) cd build && cmake .. -DCMAKE_BUILD_TYPE=Debug -DREACTOR_BACKEND=Subzero && make -j32 && ./ReactorUnitTests

Without step 1), ReactorUnitTests crasehs with an assertion in debug
builds only.

Bug: None
Change-Id: I3ab3600eee0bb7a9c9a1bfc3fe091e24c4dfc366
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39053
Kokoro-Presubmit: David Turner <digit@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Nicolas Capens <nicolascapens@google.com>

Instead of calling a function with two uint32_t parameters, pass a MemoryElement structure that has named and documented fields.

This structure includes the Type field, which will be used by the debugger for knowing how to interpret the value.

Bug: b/145351270
Change-Id: I21e86b9ba117bcde21150b408d8a7552729203e2
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38911
Presubmit-Ready: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Should fix the dEQP-VK.synchronization.basic.fence.* flakes.

Change-Id: I9995af6bdb25907b97848f1fc249f6fb8ee15e7d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39051Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>

• Place all commands into an anonymous namespace. Prevents needless symbol pollution across the SwiftShader library.
• Don't use a mix of class and struct for commands - stick to using class.
• Prefix commands with 'Cmd' to avoid a symbol collision with Win32 ResetEvent.
• Remove pointless 'protected' modifiers.

Bug: b/116336664
Change-Id: I05a7d5a196f1b49144be7a685a0923dee1c55fbc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38909Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Chris Forbes <chrisforbes@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Based on the discussions on: b/145746360#comment2

Bug: b/145746360
Change-Id: I4b390ebf448a8015d39dfe832ea5d5066637342e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39050Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

Change-Id: I126bd580694a7f26211745d16747d395d1875b65
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39009
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

This migrates from 2-bit swizzle codes per lane to 4-bit, which reads more fluently in hex.
The order has been reversed so that the most significant nibble (leftmost on little-endian CPUs) represents the first output lane.

Fixed up Swizzle, Mask, and ShuffleLowHigh

Bug: b/145746360
Change-Id: I132bd757801a5ca543ef2b9b0ed34d0527db5bfa
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39049
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: David Turner <digit@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

As the name suggest, this CL adds many operations related
to arithmetic subgroup operations, i.e.:

  - Reduction / Inclusive Scan / Exclusive Scans for:

    - IntAdd, UIntAdd, FloatAdd
    - IntMul, UIntMul, FloatMul,
    - IntMin, UIntMin, FloatMin,
    - IntMax, UIntMax, FloatMax,
    - BitwiseAnd, BitwiseOr, BitwiseXor
    - LogicalAnd, LogicalOr, LogicalXor

The implementation uses a single template function to
implement all these, based on the fact that these are
all binary commutative operations.

NOTE: Only 32-bit values are supported.

To make scans efficient, a new Reactor operation, named
Blend() is introduced. It is used to mix two input vectors
using 4 3-bit indices (encoded in a single 16-bit value)
to select the result's lane values.

A new unit-test is added to ReactorUnittests to check its
behaviour. Unfortunately, the test takes about 2 minutes
on a fast workstation when doing a full scan, so it will
by default only check 1/11th of all possible values
(see comments in the patch for more details).

Also, Float4::positive_inf() and Float4::negative_inf()
methods were added, since trying to build Float4(INFINITY)
will trigger a DCHECK() in the Float4(float) constructor,
and the infinity values are required by the subgroup
floating-point scan operations.

Bug: b/142002682
Test: dEQP-VK.subgroups.arithmetic.*
Change-Id: I86f509fc47f7475ca126615ed698ee493ae835ef
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/38929Reviewed-by: Chris Forbes <chrisforbes@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: David Turner <digit@google.com>