- 24 Feb, 2020 2 commits
-
-
Ben Clayton authored
Also applies a fix for `spvOpcodeString` being moved to the public spirv-tools interface. Changes: 8910ea5f1 Fix Wrange-loop-analysis warnings in SPIRV-Tools. (#3201) c316fb15f Add missing dependencies when generating spvtools_core_tables (#3199) 03c9effb5 Brief guide to writing a spirv-fuzz fuzzer pass (#3190) dea1040fa Fix ignored const qualifier warning in static_cast (#3197) 4a80497a8 Make spvOpcodeString part of the public API (#3174) 03794b8f5 Fix static libraries linking order (#3189) 79f8caf91 vscode: Add missing fields to schema.Opcode (#3169) 4d912f4e6 spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186) 77fefe765 spirvfuzz: Fix type-related bug, change undef to zero, and add assert (#3188) 6c218ec60 spirv-fuzz: Fuzzer pass that adds access chains (#3182) 77fb303e5 spirv-fuzz: Fuzzer pass to add function calls (#3178) 3d4a0dd48 spirv-fuzz: Ensure that donated variables are always initialized (#3181) fe10239f9 spirv-fuzz: Add fuzzer passes to add loads/stores (#3176) 1f03ac102 spirv-fuzz: Fuzzer passes to add local and global variables (#3175) 9e52bc0d0 utils/vscode: LSP - Support OpExtInst (#3140) a3b5ad909 Fix typos in opt's help. Update environment version. (#3170) da5457f6b Start SPIRV-Tools v2020.2 8dd174809 Finalize SPIRV-Tools v2020.1 76616bab6 Update CHANGES bb56e892f spirv-fuzz: Fuzzer pass to add composite types (#3171) fdd0c8776 Update script that checks copyright years. (#3173) b7e0998e3 spirv-fuzz: Disallow copying of null and undefined pointers (#3172) a9624b4d5 Handle TimeAMD in AmdExtensionToKhrPass. (#3168) ddcc11763 Update CHANGES 0265a9d4d Implement constant folding for many transcendentals (#3166) 7a2d408de Fix typo in comment. (#3163) 1fc7a9ec7 spirv-fuzz: Arbitrary variable facts (#3165) dd3f8d492 spirv-fuzz: Add outlining test (#3164) 521223b70 spirv-fuzz: Make functions "livesafe" during donation (#3146) 97f1d485b Dead branch elim fix (#3160) 1b3441036 Fix chromium build (#3152) 5d786f6cc Clarify mapping of target env to SPIR-V version (#3150) e7afeb060 Use dummy switch instead of dummy loop in MergeReturn pass. (#3151) 6729c4a7c Fix structured exit validation (#3141) bb236c326 Add spvParseVulkanEnv (#3142) dd37d73c5 Handle conflict between debug info and existing validation rule (#3104) b97057e7f Use spirv-headers' BUILD.gn (#3148) 6a1a1b326 Roll external/spirv-headers/ af64a9e82..dc77030ac (4 commits) (#3147) ab7ac60f1 spirv-fuzz: Refactoring and type-related fixes (#3144) 323a81fc5 Validate Vulkan 1.2 capabilities d46a1b048 Add basic support for Vulkan 1.2: SPV_ENV_VULKAN_1_2 f8d7df760 Fix OpLine bug of merge-blocks pass (#3130) 8013d477a spirv-fuzz: add dead blocks (#3135) 18b3b9456 Remove names and decorations of imported symbols (#3081) fb2e81981 Fix GN build for OpenCL.DebugInfo.100 update (#3134) c86dc0bcd Fix bad parameter names in error message (#3129) 899735f45 Revert PR #3093 (#3131) a466b99db Disallow forward references in arrays (#3093) 31acc7882 spirv-fuzz: Add fuzzer pass to perform module donation (#3117) c8bf14393 GetOperandConstants operand can be const (#3126) Commands: git subtree pull --prefix third_party/SPIRV-Tools https://github.com/KhronosGroup/SPIRV-Tools master --squash Bug: b/123642959 Bug: angleproject:4425 Change-Id: I73076a22b474893d900a017d94a5d122061381bc -
Ben Clayton authored
8910ea5f1 Fix Wrange-loop-analysis warnings in SPIRV-Tools. (#3201) c316fb15f Add missing dependencies when generating spvtools_core_tables (#3199) 03c9effb5 Brief guide to writing a spirv-fuzz fuzzer pass (#3190) dea1040fa Fix ignored const qualifier warning in static_cast (#3197) 4a80497a8 Make spvOpcodeString part of the public API (#3174) 03794b8f5 Fix static libraries linking order (#3189) 79f8caf91 vscode: Add missing fields to schema.Opcode (#3169) 4d912f4e6 spirv-val: Add support for SPV_AMD_shader_image_load_store_lod (#3186) 77fefe765 spirvfuzz: Fix type-related bug, change undef to zero, and add assert (#3188) 6c218ec60 spirv-fuzz: Fuzzer pass that adds access chains (#3182) 77fb303e5 spirv-fuzz: Fuzzer pass to add function calls (#3178) 3d4a0dd48 spirv-fuzz: Ensure that donated variables are always initialized (#3181) fe10239f9 spirv-fuzz: Add fuzzer passes to add loads/stores (#3176) 1f03ac102 spirv-fuzz: Fuzzer passes to add local and global variables (#3175) 9e52bc0d0 utils/vscode: LSP - Support OpExtInst (#3140) a3b5ad909 Fix typos in opt's help. Update environment version. (#3170) da5457f6b Start SPIRV-Tools v2020.2 8dd174809 Finalize SPIRV-Tools v2020.1 76616bab6 Update CHANGES bb56e892f spirv-fuzz: Fuzzer pass to add composite types (#3171) fdd0c8776 Update script that checks copyright years. (#3173) b7e0998e3 spirv-fuzz: Disallow copying of null and undefined pointers (#3172) a9624b4d5 Handle TimeAMD in AmdExtensionToKhrPass. (#3168) ddcc11763 Update CHANGES 0265a9d4d Implement constant folding for many transcendentals (#3166) 7a2d408de Fix typo in comment. (#3163) 1fc7a9ec7 spirv-fuzz: Arbitrary variable facts (#3165) dd3f8d492 spirv-fuzz: Add outlining test (#3164) 521223b70 spirv-fuzz: Make functions "livesafe" during donation (#3146) 97f1d485b Dead branch elim fix (#3160) 1b3441036 Fix chromium build (#3152) 5d786f6cc Clarify mapping of target env to SPIR-V version (#3150) e7afeb060 Use dummy switch instead of dummy loop in MergeReturn pass. (#3151) 6729c4a7c Fix structured exit validation (#3141) bb236c326 Add spvParseVulkanEnv (#3142) dd37d73c5 Handle conflict between debug info and existing validation rule (#3104) b97057e7f Use spirv-headers' BUILD.gn (#3148) 6a1a1b326 Roll external/spirv-headers/ af64a9e82..dc77030ac (4 commits) (#3147) ab7ac60f1 spirv-fuzz: Refactoring and type-related fixes (#3144) 323a81fc5 Validate Vulkan 1.2 capabilities d46a1b048 Add basic support for Vulkan 1.2: SPV_ENV_VULKAN_1_2 f8d7df760 Fix OpLine bug of merge-blocks pass (#3130) 8013d477a spirv-fuzz: add dead blocks (#3135) 18b3b9456 Remove names and decorations of imported symbols (#3081) fb2e81981 Fix GN build for OpenCL.DebugInfo.100 update (#3134) c86dc0bcd Fix bad parameter names in error message (#3129) 899735f45 Revert PR #3093 (#3131) a466b99db Disallow forward references in arrays (#3093) 31acc7882 spirv-fuzz: Add fuzzer pass to perform module donation (#3117) c8bf14393 GetOperandConstants operand can be const (#3126) git-subtree-dir: third_party/SPIRV-Tools git-subtree-split: 8910ea5f1c7bc38f79a8b70b265cd9d1571f4b56
-
- 23 Feb, 2020 1 commit
-
-
Nico Weber authored
Bug: chromium:1039697 Change-Id: I5af47f44696a0eb1da7516ea57f3ae766651cae3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41548 Presubmit-Ready: Nico Weber <thakis@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 21 Feb, 2020 2 commits
-
-
Antonio Maiorano authored
A recent change was made that failed when building nacl, because despite the target_cpu being set to x86, current_cpu is x64 for nacl, as it is cross-compiled to x64 using a different toolchain. As such, we were building and linking the x86 version of Subzero with the x64 version of nacl, resulting in a linker error. See the following doc for more info: https://chromium.googlesource.com/dart/dartium/src/+/refs/heads/master/tools/gn/docs/cross_compiles.md#as-a-build_gn-author Bug: b/150008309 Change-Id: I581538cb7bb090e5b30819052eb7e245bc90ab12 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41528Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hétu authored
This reverts commit f50cc82b. Reason for revert: Skia roll broken. See: https://chromium-review.googlesource.com/c/chromium/src/+/2067664 "lld-link: error: undefined symbol: _chkstk" Change-Id: I2ac508c9560e3a49e8a856906c3a5f6141c45207 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41489Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 20 Feb, 2020 7 commits
-
-
Antonio Maiorano authored
If the stack size is > 4K, emit chkstk, which probes the stack to commit the pages required to support the large stack. Bug: swiftshader:25 Change-Id: Iac1850c528460f4244f6f14f851ef47ee5a737d0 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41388Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Alexis Hetu authored
VK_EXT_shader_stencil_export is a simple extension to implement in SwiftShader. Added PixelRoutine::stencilReplaceRef(), which can be trivially modified to output Byte4 instead of Byte8, should the stencil code be refactored. Verified that these tests still pass with SwANGLE dEQP-GLES3.functional.fbo.blit.depth_stencil.depth32f_stencil8_basic dEQP-GLES3.functional.fbo.blit.depth_stencil.depth32f_stencil8_stencil_only dEQP-GLES3.functional.fbo.blit.depth_stencil.depth24_stencil8_basic dEQP-GLES3.functional.fbo.blit.depth_stencil.depth24_stencil8_stencil_only Change-Id: Ia5829489ccba75ee7c41e365ca2d3d586c987c2d Tests: dEQP-VK.pipeline.shader_stencil_export.op_replace Bug: b/148175198 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41469 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
sw::Thread and rr::Thread uses have been replaced by std::thread. Note the latter does not support controlling the stack size, but it appears to default to 2 MiB on Linux, 1 MiB on Windows, and 512 KiB on macOS. Bug: b/149829034 Change-Id: Ie4ad8af12c111e951761248b69f8206dd143af24 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41368Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
On platforms where the calling thread has a very small stack, LLVM can overflow the stack. Work around it by creating a temporary thread for performing LLVM optimizations and codegen. Bug: b/149829034 Change-Id: I59edd0f7d02b4724ea30f9413ea3efbb4d200290 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41389Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hétu authored
This reverts commit f9881ba0. Reason for revert: Causes failures. See: https://ci.chromium.org/p/chromium/builders/try/linux_optional_gpu_tests_rel/36449 https://ci.chromium.org/p/chromium/builders/try/mac_optional_gpu_tests_rel/36978 https://ci.chromium.org/p/chromium/builders/try/win_optional_gpu_tests_rel/37221 Change-Id: Ib95459cefea22001fa43e07bc20a15002976a9da Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41468Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hétu authored
VK_EXT_shader_stencil_export is a simple extension to implement in SwiftShader. Added PixelRoutine::stencilReplaceRef(), which can be trivially modified to output Byte4 instead of Byte8, should the stencil code be refactored. Verified that these tests still pass with SwANGLE dEQP-GLES3.functional.fbo.blit.depth_stencil.depth32f_stencil8_basic dEQP-GLES3.functional.fbo.blit.depth_stencil.depth32f_stencil8_stencil_only dEQP-GLES3.functional.fbo.blit.depth_stencil.depth24_stencil8_basic dEQP-GLES3.functional.fbo.blit.depth_stencil.depth24_stencil8_stencil_only Tests: dEQP-VK.pipeline.shader_stencil_export.op_replace Bug: b/148175198 Change-Id: Ib98e9917a42aa487d2ee6ffed8b8e317b4fec5d3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41208 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
When available, the decorations for the array member of the structure used in EmitArrayLength should be used to find the array stride and use it in the length computation. This cl should fix these tests with SwANGLE: dEQP-GLES31.functional.compute.basic.write_multiple_unsized_arr_* Bug: b/148459131 Change-Id: I5722ebc761b81faf75bb9bab7c60f240afa50446 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41271 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Reviewed-by:
Chris Forbes <chrisforbes@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 18 Feb, 2020 2 commits
-
-
Corentin Wallez authored
Bug: dawn:283 Change-Id: I8abd042ce1cb1a278d77b6639aeda650630963a8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41328Tested-by:
Corentin Wallez <cwallez@google.com> Kokoro-Presubmit: Corentin Wallez <cwallez@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
When sampling an sRGB texture format, we have a vector of 16-bit elements where 0xFF00 represents 1.0, but we were using a lookup table which produced results in a 0xFFFF base. Also on linear to sRGB conversion, precision was lost due to truncating to 12-bit. Adding a rounding factor before truncating preserves precision. Bug: b/149574741 Change-Id: I19218c958867c4b5e97dc3b62b4ea83f37161134 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41268 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 17 Feb, 2020 5 commits
-
-
Antonio Maiorano authored
This works well as our use-case is to lookup the same addresses multiple times (loops, helper functions, etc.). With a simple timing of ReactorUnitTests.exe, with this optimization enabled, total time dropped from 16.72 seconds to 2.24 seconds (~7.5X faster). This optimization is especially important for Mac where resolving stack addresses takes much longer than on other platforms. With this optimization, running a specific gles-unittests test, it was able to output the callstack trace in about 30 seconds; without, it was still emitting jit code after 10 minutes at which point I gave up. Bug: b/131425026 Change-Id: I97e76256220f73fba0a1fc4099532e833f561551 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/32369 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Antonio Maiorano authored
Adds support for emitting print locations when using the Subzero backend. Very useful for debugging. Bug: b/149572931 Change-Id: I32fc14486cd7a021f424fb926dc776072374b931 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41288Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
I find myself copy and pasting the commands out of the previous change, looking in the squash change for the SHAs and descriptions, and amending the top merge change with all this info. It's tedious. This script does all of this with a one-liner. Bug: b/140546382 Change-Id: I2ecfd8074b053cbf6de4001a56bca2ffbaccba42 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41230 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Antonio Maiorano authored
Factored out most of the rr::Print code in LLVMReactor.cpp to Reactor.cpp, and rewritten in terms of Nucleus. Added a couple of new Nucleus functions to support this. Bug: b/149477527 Change-Id: I0a28626f1aa6133a37f9e75abc08544f3de15a45 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41188 Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Antonio Maiorano authored
When I (hack) fixed the fact that Subzero fails to load from a constant source because it interprets it as an offset, I did so by routing all loads into sz::createLoad, and in there, making sure to bitcast constant sources to variables. I thought this covered all loads, but it turns out that one of our optimization passes optimizes stores by removing intermediate stores. This would sometimes replace a variable source with a constant one, so I applied a similar hack here to avoid doing replace in this case. Bug: b/148272103 Change-Id: I809688e2c79fa1b62918d3b484a8e2a9e601bd90 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41269 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 15 Feb, 2020 1 commit
-
-
SwiftShader Regression Bot authored
Change-Id: I1b54ba532578106fc4906b1d1b2bf284d7b27002 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41231 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Nicolas Capens <nicolas.capens@gmail.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
- 14 Feb, 2020 1 commit
-
-
Antonio Maiorano authored
Bug: b/149328074 Change-Id: Ia5af4622f2a024ea08395f7b7412e086fdb34c39 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41270Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
- 13 Feb, 2020 7 commits
-
-
Jonah Ryan-Davis authored
From VK_EXT_external_memory_host, there is a type of VkDeviceMemory that takes a pointer to host mapped foreign memory, where the underlying memory is owned by the host, not the device. This is used by ANGLE on Mac when creating a VkDeviceMemory given an IOSurface. Tests: dEQP-VK.* Bug: chromium:1965434 Change-Id: I944a5d3cd23ad8b193f58981829a8847419a4b0d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39968 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Jonah Ryan-Davis <jonahr@google.com>
-
Ben Clayton authored
Fixes another hairy bug in condition-variable timeouts, adds docs Changes: a047dd0bb Include benchmarks on project's README.md 4c702da52 Scheduler: Fix lock state on Fiber::wait timeout. b4e305525 Docs: Add documentation for marl::Scheduler. 5f18ac0e0 ConditionVariable: Delete copy and move constructors f78eb441f Scheduler: document requirement to unbind() before destruction 9f9f6d32e Defer benchmark - avoid benchmark::DoNotOptimize() 3b610e902 Fix compiler warnings with MARL_FIBERS_USE_UCONTEXT 0dbab1184 Scheduler: Delete copy and move constructors / assignment ops. cbef55d58 Kokoro: Build benchmarks e923c3d96 Rework the 'hello task' example to be more idiomatic Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash Bug: b/140546382 Change-Id: I3412287ec95bdf761d84fd9f0dffae8f08bcec3c -
Ben Clayton authored
a047dd0bb Include benchmarks on project's README.md 4c702da52 Scheduler: Fix lock state on Fiber::wait timeout. b4e305525 Docs: Add documentation for marl::Scheduler. 5f18ac0e0 ConditionVariable: Delete copy and move constructors f78eb441f Scheduler: document requirement to unbind() before destruction 9f9f6d32e Defer benchmark - avoid benchmark::DoNotOptimize() 3b610e902 Fix compiler warnings with MARL_FIBERS_USE_UCONTEXT 0dbab1184 Scheduler: Delete copy and move constructors / assignment ops. cbef55d58 Kokoro: Build benchmarks e923c3d96 Rework the 'hello task' example to be more idiomatic git-subtree-dir: third_party/marl git-subtree-split: a047dd0bbbd6a65ee4d03d0ceb4fedfa56da02a5
-
Ben Clayton authored
Bug: b/140546382 Change-Id: I2045aad2afc0918003117561dfe49aafbb4ef13a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41048 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
SwiftShader Regression Bot authored
Change-Id: If4a2966a3ce353a45c0d1f14e59993ef34a8af25 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41168 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Antonio Maiorano authored
After the normal build and unit tests run, incrementally build ReactorUnitTests with REACTOR_ENABLE_PRINT enabled, and run only the unit tests that exercise the print code. This should add very little extra time to our Kokoro builds, while ensuring we don't break the rr::Print stuff. Bug: b/149328074 Change-Id: I26c0db727c8edd269243f17192020a3435893c14 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41148 Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com>
-
Antonio Maiorano authored
* CMake: add REACTOR_ENABLE_PRINT to enable rr::Print macros (default 0). When enabled, defines ENABLE_RR_PRINT. Formerly, ENABLE_RR_PRINT was only defined in NDEBUG builds. * CMake: REACTOR_EMIT_PRINT_LOCATION enables REACTOR_ENABLE_PRINT. * Add missing includes of Print.hpp. * Fix rr::Print compilation of non-const pointers. * Fix rr::Print compilation of Int2 and UInt2. * Fix rr::Print of Float outputting in square brackets. * Fix rr::Print of Bool to output a '1' or '0' for 'true' and 'false'. * Add unit tests for rr::Print of all primitive and Reactor types. * Includes changes bclayton@ made to output "true"/"false" for Bool, and to correctly compare against implementation-specific printf of pointers. Bug: b/149328074 Change-Id: Ibb17985201f1c2b432539cd1153293d1e1cbb5bb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41108Reviewed-by:
Ben Clayton <bclayton@google.com> Tested-by:
Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
- 12 Feb, 2020 2 commits
-
-
Anton D. Kachalov authored
SwiftShader segfaults when trying to resolve missed symbol. The symbol is requested at least on ARM32 (armv7l). Bug: b/149229646 Change-Id: I5436b244c2e7ec9a0d557f57697adbdb5e29a0cb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41089 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
SwiftShader Regression Bot authored
Change-Id: I3c8451ca5036da69021a117d68d3aae55cce96fc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41128 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
- 11 Feb, 2020 10 commits
-
-
Ben Clayton authored
Marl now exposes this as PUBLIC on the target, so it is automatically and implicitly included. Bug: b/140546382 Change-Id: I9ed331559c7b5cccad3065b4fadeca8380d6e910 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40973 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Ben Clayton authored
Two changes landed that failed style checks Bug: None - just reformatting. Change-Id: Id021ad6c4c87f0499428af6fb65ffbd83fd65116 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41090 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Files that are #included in a non-standard header way usually have a .inc or .inl extension. Reactor already has Reactor/Traits.inl, so let's be consistent and stick with this extension. Bug: b/148778720 Change-Id: Ie69951c254921b9cf86c3ab201533a3b21489b97 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40977 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
* changes: Update Marl to 246091e81 Squashed 'third_party/marl/' changes from 14e4d862a..246091e81
-
Jiaxun Yang authored
Accorading to GCC and Clang documents, march=mipsel/mips64el doesn't really exist. So we use real CPU arch instead, and apply '-EL' flag to indicate endianess. Also, to deal with link failure, we add '-mxgot' to increase GOT size. Change-Id: I21706da3423412c968f6e80a9d21f5266255a0cf Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41028Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
The team debated whether this was legal or not at the time. It seems that at least one of Android's compilers generates code that stomps the list data after the `std::initializer_list` is declared and before it is used. Switch to using regular C arrays with constexpr / std::array. Fixes: b/149235682 Change-Id: Ief95dc4c6b4aee0c181bbe34aff19aa95f5fac8c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41051Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hetu authored
This cl adds support for the VK_KHR_separate_depth_stencil_layouts. It doesn't add any new functionality, since SwiftShader has historically supported quad layout stencil and non quad layout depth. Bug: b/148881874 Change-Id: I6ed77ee1261bfda1468595474cf0840564f2553d Tests: dEQP-VK.* Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41068 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Alexis Hetu authored
This cl adds support for the VK_KHR_create_renderpass2. It doesn't add any new functionality and ignores any new performance hints that are part of this extension, but it properly supports the new API entries that are part of this extension. Bug: b/148884281 Tests: dEQP-VK.* Change-Id: I15d9d00658e65380f4e93e59299a8c5e5212f95e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40988 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
-
Ben Clayton authored
This reverts commit 5f5a0648. Reason for revert: Breaks Android build ld.lld: error: undefined symbol: __aeabi_idivmod >>> referenced by LLVMJIT.cpp:547 (external/swiftshader/src/Reactor/LLVMJIT.cpp:547) >>> LLVMJIT.o:((anonymous namespace)::JITRoutine::JITRoutine(std::__1::unique_ptr<llvm::Module, std::__1::default_delete<llvm::Module> >, llvm::Function**, unsigned int, rr::Config const&)::'lambda'(llvm::StringRef const&)::operator()(llvm::StringRef const&) const) in archive <omitted>/libswiftshader_llvm.a Change-Id: I153ac3a3a9bc395201024d4b38e43c064691a5ad Bug: None - build fix. Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41088Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-
Anton D. Kachalov authored
SwiftShader segfaults when trying to resolve missed symbol. The symbol is requested at least on ARM32 (armv7l).. Change-Id: I96dd157afc1832ef39daaf46d818c8033820d86b Bug: b/149229646 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41049Reviewed-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Kokoro-Presubmit: Lingfeng Yang <lfy@google.com> Tested-by:
Ben Clayton <bclayton@google.com>
-