- 15 May, 2019 10 commits
-
-
Hernan Liatis authored
This is just a small hack to prevent screen tearing. Later, we should properly implement VkSemaphore to prevent this. Bug: b/132458423 Change-Id: I825f100a73c4b5b9b909eba83552cbec51ff1792 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31152Reviewed-by:
Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Hernan Liatis <hliatis@google.com>
-
Nicolas Capens authored
Change-Id: Iaf147233a0703360a2fb95a36aae5b2cf011dfc7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31512Reviewed-by:
Chris Forbes <chrisforbes@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Chris Forbes authored
This was masked by the incorrect assert -- we did the wrong thing in MRT cases, but the assert intended to protect us would only fire if logic ops were also enabled. Fix this properly. We still only have one shared set of blend state, but each attachment has its masks set now. Some of the tests exercising this are dubious on a device which doesn't support independent blending -- the color write masks are technically part of the state which must be the same across all attachments. Bug: b/132433217 Test: dEQP-VK.renderpass.* Change-Id: Ia22f9cbf156a9f3c24d47142211bde67f06a0d46 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31350Tested-by:
-
Chris Forbes authored
SPIRV-Tools' pass to do this is incomplete, and implementing the remaining pieces as a SPIRV->SPIRV transform is more work than implementing them here. Related SPIRV-Tools issues: 2585 2586 Bug: b/127454276 Test: dEQP-VK.*quantize* Change-Id: I892de80dff366fb3bc417315b5db15d850577c47 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31348Tested-by:
-
Alexis Hetu authored
In order to easily add 32 bit support, this cl adds a header which essentially uses a union to make sure that even when we have 32 bit pointers, the Vulkan handles are 64 bit. This change should be noop. Bug b/129979580 b/127920555 Change-Id: I54254929186584ec4544a1da5a7def7cf56e392e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31070 Presubmit-Ready: Alexis Hétu <sugoi@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
Vulkan always has separate alpha blend. No test change expected Bug: b/132280877 Change-Id: Ie76094fcc82070c20b78b846e4d2e30810339f98 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31349Tested-by:
-
Chris Forbes authored
Bug: b/119620767 Change-Id: If258773373426ed404cc396a672d4bc4078458d6 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31389Tested-by:
-
Chris Forbes authored
When we decompress ETC2 RGB into a 4-channel texture, *almost* everything just works as long as we ensure the alpha channel has the correct values -- except that to the sampler, this is now a 4-channel texture and so no channel replacement will be performed. This interacts badly with border texel replacement, which occurs before channel replacement. When a transparent border mode is used, we end up with non-1 values in the returned alpha channel, which is wrong. Instead, drive missing channels to 0/1 with the swizzle, which we control independently of the texture format. Bug: b/119620767 Test: dEQP-VK.pipeline.sampler.* Change-Id: I2816e18fc1c36bd4de51a3e3871c75c7dc1b8867 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31388Tested-by:
-
Ben Clayton authored
This is failing the Windows builds. There is no equivalent warning on Clang or GCC, and this seems harmless, so just silence it. Bug: b/132445520 Change-Id: I4c9498d87490fe892183e2d24c80979d785c37e8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31428 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I688c02f375ff9a1935cdd08f553afdc0c14e27a5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31408Reviewed-by:
-
- 14 May, 2019 5 commits
-
-
Ben Clayton authored
Adds support for a2b10g10r10_unorm_pack32 render targets, and input attachments. Tests: dEQP-VK.renderpass.dedicated_allocation.formats.a2b10g10r10_unorm_pack32.* Tests: dEQP-VK.renderpass.suballocation.formats.a2b10g10r10_unorm_pack32.* Bug: b/131896622 Bug: b/131171141 Change-Id: I925723754858c6b3515d142d0c7abae275685d6d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31271 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Antonio Maiorano authored
* Respect WARNINGS_AS_ERRORS option for msvc builds. * Disable a bunch of warnings for msvc builds. These were gathered from all the hand-crafted vcxproj files and merged into one set. Eventually we need to disable some of these and fix the actual warnings. * Treat specific warnings as errors for msvc builds. These were gathered from the hand-crafted vcxproj files. * Fix LLVM build showing warning 4141 despite being disabled in CMakeLists. Something wonky happens when using set with the first string argument. Going with list(APPEND,...) works, and is symmetrical with the non-msvc script. * Define _SCL_SECURE_NO_WARNINGS for all modules, not just LLVM. * Fix double to float conversion warning in SprivShader.cpp * Fix mismatched type compare in IceTargetLoweringX664Traits.h Bug: b/132445520 Change-Id: I1143e9fdd386e26d4f0b0f9e34c4d6b3ac2f2311 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31149 Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Loops attempted to special-case phis with allocas to deal with their non-ssa nature, but this didn't handle divergent loops correctly. Rearchitect phis to always use an alloca, and mask the updates with the edge masks. This handles all cases in a cleaner, more unified implementation. Tests: dEQP-VK.glsl.switch.* Tests: dEQP-VK.glsl.functions.control_flow.* Bug: b/128527271 Change-Id: I5b450cd3f5f10b1076d65750d326fedc286abfe5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31269 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Combine all the active lane masks for the merge block. Previously this was only using the lane mask of the last loop iteration. Loop phis were being overridden even for disabled lanes. Now fixed. Made EmitBranch() use addActiveLaneMaskEdge(). This is effectively a noop change, but keeps the code more consistent. dEQP-VK.glsl.switch.switch_in_do_while_loop_dynamic_vertex still seems broken, which I'm investigating. Tests: dEQP-VK.glsl.switch.* Bug: b/128527271 Change-Id: I49bafe5cdb49d6878dde98134f9cbb9a3ad4d384 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31268 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I6f90c060f388b932002d92b107473edf30e1f52a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31270Reviewed-by:
-
- 13 May, 2019 7 commits
-
-
Chris Forbes authored
Tracks the first subpass to touch an attachment. Test: dEQP-VK.renderpass.suballocation.unused* Change-Id: Idc0998da022fd4c0b1785f6020c795916ba475f7 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31308Tested-by:
-
Hernan Liatis authored
This is the minimum amount of code to get a triangle on an Android device using Swiftshader Bug: b/122837237 Change-Id: I8d2af6c104d70650c8750c9dd54d5be32ded0a39 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30828Tested-by:
-
Chris Forbes authored
Test: dEQP-VK.glsl.texture_functions.* Change-Id: I326ccb88b0f93168d2f005abbc083d93ae239c3f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31049Tested-by:
-
Chris Forbes authored
Bug: b/126871859 Test: dEQP-VK.compute.device_group.dispatch_base Change-Id: I15446caa46d9711f86cf0e1b3a0d8d0fe9b4eec9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31288 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
-
Chris Forbes authored
Also jettison all the context-level perspective enable plumbing; it serves no purpose in Vulkan. Test: dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.* Change-Id: If823c099a82750a57bca16f04ff2ddbeee3a8f45 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31228 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Add additional required files as listed in chromium:961729. Bug: chromium:961729 Change-Id: Ifbbab3e14fc6e243ada9c6b4c43e8a70971d9a72 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31114 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I7399b421b5dbf02732f2f90848578ad5b19fb269 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31118 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 12 May, 2019 1 commit
-
-
SwiftShader Regression Bot authored
Change-Id: I056c93010be2369275bd4fd3673a20c5d944737f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31117 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 11 May, 2019 2 commits
-
-
Chris Forbes authored
We had assumed in Context in various places that negative pixel values would be clamped to zero, which is incorrect for floating-point color attachments. TODO: on the assumption that there is value in these blend optimizations themselves, we should split the context blend state to be per-attachment. This would give us the `independentBlend` optional feature, and also allow us to keep the optimization for those attachments which do have clamping in a mixed MRT scenario. Bug: b/132433217 Test: dEQP-VK.pipeline.blend.format.r16* Change-Id: I5434475aba5d21a8c8342b42cccc575b517f0900 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31050Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: Iaff54e52db2757ffac7d9fd5cee62eaeca4746fd Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31116Reviewed-by:
-
- 10 May, 2019 11 commits
-
-
Ben Clayton authored
The float16 loads and stores are horrendously unoptimized, but this can be addressed as a later pass. Tests: dEQP-VK.renderpass.suballocation.formats.r16_sfloat.* Tests: dEQP-VK.renderpass.suballocation.formats.r16g16_sfloat.* Tests: dEQP-VK.renderpass.suballocation.formats.r16g16b16a16_sfloat.* Tests: dEQP-VK.pipeline.blend.format.r16_sfloat.* Tests: dEQP-VK.pipeline.blend.format.r16g16_sfloat.* Tests: dEQP-VK.pipeline.blend.format.r16g16b16a16_sfloat.* Bug: b/132434966 Bug: b/132433217 Change-Id: Ifa8feaeecefa1926b1f500e6c9d23e6c242a6844 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31113Tested-by:
-
Ben Clayton authored
Tests: dEQP-VK.glsl.texture_functions.query.texturesamples.* Bug: b/129523279 Change-Id: I17008f03f5e86313249b4bcb061b8b3f16e56b19 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31112 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Tests: dEQP-VK.compute.device_group.device_index Bug: b/130937460 Change-Id: I994632be31b7c8c53dc86b0de900ab9f9ff62ae3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31111Tested-by:
-
Ben Clayton authored
Unlike getPointer() with just returns the raw pointer, GetPointerToData() derefs the buffer data for DescriptorSets. Test: dEQP-VK.spirv_assembly.instruction.compute.opcopymemory.struct Change-Id: I5d8d6139952673a2680f9e05f2f64785198b0797 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31110Tested-by:
-
Ben Clayton authored
Tests: dEQP-VK.glsl.texture_functions.query.texturequerylevels.* Bug: b/129523279 Change-Id: I385eaa4a8d5fc50c12c7cf284c26037ed93aa469 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31109 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
We don't have to actually do anything for either of these as all the features introduced are gated by capabilities which we don't have to support. We must accept the OpExtension though. Bug: b/130937460 Change-Id: Iea869e32f165c4a2457f89fcf953fc08f1e346b1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31128Tested-by:
-
Alexis Hetu authored
This cl is a very basic implementation of primitive restart which records every segment of at least 1 primitive into a vector of index buffers and primitive counts which are then looped over at draw time. There's no caching involved, so the primitive restart segments will get recomputed at every draw, until a caching mechanism is introduced. Tests: dEQP-VK.pipeline.input_assembly.primitive_restart.* Bug b/118619338 Change-Id: If2f88ffb7971d1aa7d1451c7916f0ba65a2e09de Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31032Tested-by:
-
Chris Forbes authored
Bug: b/129523279 Change-Id: I0f124103375372e28688298eddf976069a41f211 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/30968Tested-by:
-
Chris Forbes authored
This has really spotty coverage [see VK-GL-CTS #1770], but is legal. Test: dEQP-VK.api.descriptor_set.descriptor_set_layout_lifetime.graphics Change-Id: I1452fb7a2146e882f6d792d153135ff8b474aca4 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31069Tested-by:
-
SwiftShader Regression Bot authored
Change-Id: I5f53ac2e8b21d7c23d5feffed377ab4591cb0ff2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31108Reviewed-by:
-
Chris Forbes authored
We're supposed to validate the request against what we can actually support, and return VK_ERROR_FORMAT_NOT_SUPPORTED if not supported. We had previously only considered total lack of support for the format. Test: dEQP-VK.texture.shadow.* Change-Id: Ic5aa81f232bf04583060e88334f7f38dd5f2b2e9 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31068Tested-by:
-
- 09 May, 2019 4 commits
-
-
Ben Clayton authored
Only one will be used. Tests: dEQP-VK.spirv_assembly.instruction.compute.multiple_shaders.* Bug: b/132341142 Change-Id: I75588f3281f325dc1753222a1f89476267c56ad3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31011 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
Chris Forbes authored
There is nothing unimplemented here. We produce the correct error. Test: dEQP-VK.api.device_init.create_device_unsupported_features Change-Id: I663fa376bda0752e1c17992be29aac7bd1cbecda Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31028Reviewed-by:
-
Chris Forbes authored
We don't support any of the variable pointers capabilities, but we must accept the extension token. Bug: b/130937460 Test: dEQP-VK.spirv_assembly.instruction.graphics.pointer_parameter.buffer_memory_variable_pointers_frag Change-Id: Icb6511b6e1de85c3736e12b4a4e21aa4d1be6622 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31030Tested-by:
-
Chris Forbes authored
Avoids collisions in the dynamic sampling function cache. Change-Id: I41b5e5723c3f23f67722e006bdbc603ba1ba18f5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/31029Tested-by:
-
