More specifically, crash occurs when viewport.Y is negative, and scissoring isn't explicitly set by user. Problem was a combination of computing invalid scissor bounds, and after clamping to these bounds, proceeding to index buffers when yMin >= yMax. Fixed both computation of scissor bounds, and making sure to early out when yMin >= yMax to avoid OOB buffer indexing. Bug: chromium:904276 Change-Id: I14580d7c4f0d9888c19e037b47113624a247ede1 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/29971Tested-by:Antonio Maiorano <amaiorano@google.com> Presubmit-Ready: Antonio Maiorano <amaiorano@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .. | ||
| BUILD.gn | Loading commit data... | |
| Constants.cpp | Loading commit data... | |
| Constants.hpp | Loading commit data... | |
| PixelPipeline.cpp | Loading commit data... | |
| PixelPipeline.hpp | Loading commit data... | |
| PixelProgram.cpp | Loading commit data... | |
| PixelProgram.hpp | Loading commit data... | |
| PixelRoutine.cpp | Loading commit data... | |
| PixelRoutine.hpp | Loading commit data... | |
| PixelShader.cpp | Loading commit data... | |
| PixelShader.hpp | Loading commit data... | |
| SamplerCore.cpp | Loading commit data... | |
| SamplerCore.hpp | Loading commit data... | |
| SetupRoutine.cpp | Loading commit data... | |
| SetupRoutine.hpp | Loading commit data... | |
| Shader.cpp | Loading commit data... | |
| Shader.hpp | Loading commit data... | |
| ShaderCore.cpp | Loading commit data... | |
| ShaderCore.hpp | Loading commit data... | |
| VertexPipeline.cpp | Loading commit data... | |
| VertexPipeline.hpp | Loading commit data... | |
| VertexProgram.cpp | Loading commit data... | |
| VertexProgram.hpp | Loading commit data... | |
| VertexRoutine.cpp | Loading commit data... | |
| VertexRoutine.hpp | Loading commit data... | |
| VertexShader.cpp | Loading commit data... | |
| VertexShader.hpp | Loading commit data... |