We only need to know the array size during materialization of Array<> types, so store it only for that class and make the allocation a virtual method. This change removes the REACTOR_MATERIALIZE_LVALUES_ON_DEFINITION option, since it requires knowing the full size of Variable at construction, which would require Array<> to still pass that into the Variable constructor. If we need an debugging feature like this again, we could also materialize variables on first use instead of at construction. Bug: b/155302798 Change-Id: I65b02c1258643dcbd3ae18f3f097cb815efa0830 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45148 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:Nicolas Capens <nicolascapens@google.com> Kokoro-Result: Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Antonio Maiorano <amaiorano@google.com>
| Name |
Last commit
|
Last update |
|---|---|---|
| .vscode | Loading commit data... | |
| build | Loading commit data... | |
| build_overrides | Loading commit data... | |
| docs | Loading commit data... | |
| extensions | Loading commit data... | |
| include | Loading commit data... | |
| src | Loading commit data... | |
| tests | Loading commit data... | |
| third_party | Loading commit data... | |
| tools/cmake_generate_graphviz | Loading commit data... | |
| .clang-format | Loading commit data... | |
| .dir-locals.el | Loading commit data... | |
| .gitignore | Loading commit data... | |
| .gitmodules | Loading commit data... | |
| .travis.yml | Loading commit data... | |
| AUTHORS.txt | Loading commit data... | |
| Android.bp | Loading commit data... | |
| BUILD.gn | Loading commit data... | |
| CMakeLists.txt | Loading commit data... | |
| CMakeSettings.json | Loading commit data... | |
| CONTRIBUTING.txt | Loading commit data... | |
| CONTRIBUTORS.txt | Loading commit data... | |
| LICENSE.txt | Loading commit data... | |
| OWNERS | Loading commit data... | |
| README.md | Loading commit data... | |
| codereview.settings | Loading commit data... |