Skip to content

S
swiftshader
Switch branch/tag
  1. 25 May, 2020 1 commit
    • Eliminate the array size from rr::Variable · 5e16bc45
      Nicolas Capens authored 
      We only need to know the array size during materialization of Array<>
types, so store it only for that class and make the allocation a
virtual method.

This change removes the REACTOR_MATERIALIZE_LVALUES_ON_DEFINITION
option, since it requires knowing the full size of Variable at
construction, which would require Array<> to still pass that into the
Variable constructor. If we need an debugging feature like this again,
we could also materialize variables on first use instead of at
construction.

Bug: b/155302798
Change-Id: I65b02c1258643dcbd3ae18f3f097cb815efa0830
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/45148
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
Kokoro-Result: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
  3. 20 May, 2020 1 commit
  5. 16 May, 2020 6 commits
  7. 15 May, 2020 1 commit
  9. 14 May, 2020 1 commit
  11. 13 May, 2020 3 commits
  13. 11 May, 2020 1 commit
  15. 08 May, 2020 1 commit
  17. 07 May, 2020 3 commits
  19. 06 May, 2020 4 commits
  21. 05 May, 2020 3 commits
  23. 04 May, 2020 1 commit
    • Remove typeinfo from GLES exported symbols · c4bbd378
      Nicolas Capens authored 
      This typeinfo was added for UBSan failures reported in crbug.com/737384,
but it didn't address other 'Incorrect-function-pointer-type' failures
for crbug.com/746914. We've suppressed sanitization for these functions
with the NO_SANITIZE_FUNCTION macro, refactored interfaces used across
library boundaries into purely abstract ones for crbug.com/732667, and
use '-mllvm -asan-use-private-alias=1' to address b/128551743.

It's unclear whether this typeinfo still serves ay purpose We shouldn't
have to export typeinfo for objects used only inside the shared library,
to avoid ODR violations.

Remove it entirely for now. If this causes a regression and we still
have to export any typeinfo, we should do so more selectively. For
example to only export typeinfo for objects in the egl namespace:
_ZTS*egl*;
_ZTI*egl*;
Alternatively, or in addition, we can try using
'-mllvm -asan-use-private-alias=1' for more build systems.

Bug: b/155441530
Change-Id: Ia966c40dfe45817f356d11725910afef1bb94d6e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/44688
Presubmit-Ready: Nicolas Capens <nicolascapens@google.com>
Tested-by: 's avatarNicolas Capens <nicolascapens@google.com>
Kokoro-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: 's avatarAlexis Hétu <sugoi@google.com>
Reviewed-by: 's avatarAntonio Maiorano <amaiorano@google.com>
  25. 02 May, 2020 6 commits
  27. 01 May, 2020 2 commits
  29. 30 Apr, 2020 6 commits