WebGL: Remove error spam on separate stencil masks.

It's fully conformant to not support separate stencil masks in WebGL, so we only need to print the error if we're failing validation from the limitation. BUG=angleproject:1523 Change-Id: Iaa08567180dee839a7b78e61e5a4ad7208c41924 Reviewed-on: https://chromium-review.googlesource.com/425488Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>

WebGL: Remove error spam on separate stencil masks.
cbcde724 · Jamie Madill · Commit Bot · 63d82626 · cbcde724
Commit cbcde724 authored Jan 06, 2017 by Jamie Madill Committed by Commit Bot Jan 06, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

validationES.cpp src/libANGLE/validationES.cpp +7 -4

No files found.
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -3131,6 +3131,8 @@ bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)
        return false;
    }

+    // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
+    // Section 6.10 of the WebGL 1.0 spec.
    Framebuffer *framebuffer = state.getDrawFramebuffer();
    if (context->getLimitations().noSeparateStencilRefsAndMasks ||
        context->getExtensions().webglCompatibility)
@@ -3150,10 +3152,11 @@ bool ValidateDrawBase(ValidationContext *context, GLenum mode, GLsizei count)

        if (differentRefs || differentWritemasks || differentMasks)
        {
-            // Note: these separate values are not supported in WebGL, due to D3D's limitations. See
-            // Section 6.10 of the WebGL 1.0 spec
-            ERR("This ANGLE implementation does not support separate front/back stencil "
-                "writemasks, reference values, or stencil mask values.");
+            if (!context->getExtensions().webglCompatibility)
+            {
+                ERR("This ANGLE implementation does not support separate front/back stencil "
+                    "writemasks, reference values, or stencil mask values.");
+            }
            context->handleError(Error(GL_INVALID_OPERATION));
            return false;
        }