Zero-sized loops or loops that might never be executed may be unrolled into
constant array accesses that are invalid, generating HLSL compiler errors.

This issue showed up with the passthrough command decoder because it only does
a single compilation step of WebGL shader -> HLSL instead of the validating
decoder which does WebGL shader -> ESSL -> HLSL and eliminates these zero-
sized loops in the process.

BUG=angleproject:3269
BUG=945346

Change-Id: Iaa14149c542f23a6da58c90cf6de51f4df7e27d6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1524696Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
(cherry picked from commit 96a387f8)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1539260Reviewed-by: Geoff Lang <geofflang@chromium.org>

The EXT_color_buffer_half_float spec states:

    If OES_texture_half_float is supported, textures created with:

        <internalformat> = RGBA
        <format> = RGBA
        <type> = HALF_FLOAT_OES

    are renderable.

But WebGL content relies on being able to render to both RGB and RGBA unsized
HALF_FLOAT_OES textures.

Framebuffers may still return unsupported for this format.

BUG=941671

Change-Id: I42d909d26508b9cdf7cda6d1dc025b0e2ed87732
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1523530Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
(cherry picked from commit 979f3bbe)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1539261Reviewed-by: Geoff Lang <geofflang@chromium.org>

The sampler/texture type validation validation added in
https://chromium-review.googlesource.com/c/1377611 did not correctly
consider sampler objects. This is a minimal change to disable the
validation temporarily, which I intend to merge back to 74. A fix
for the validation is in progress at:
https://chromium-review.googlesource.com/c/angle/angle/+/1522364

Bug: 940080, 809237
Change-Id: If8a1ae46af7daf23cd92ccb8a985329dfd404dc9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1524475
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
(cherry picked from commit 3ce7f960)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1529524Reviewed-by: James Darpinian <jdarpinian@chromium.org>

Bug: chromium:930993, chromium:938602
Change-Id: Ie2e07369eca663b1507c7811a1a06ce5efc892ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1516007
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
(cherry picked from commit 37b99642)
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1529200Reviewed-by: Kai Ninomiya <kainino@chromium.org>

This reverts commit f30808db.

Reason for revert: build/android/gyp/assert_static_initializers.py thinks this adds a static initializer.

See https://ci.chromium.org/p/chromium/builders/try/android-marshmallow-arm64-rel/208664

Need to revert since this is blocking the roll.

Original change's description:
> Use a constexpr array for es3 copy conversion table.
> 
> With the relaxed C++14 constexpr rules allowed in Chromium, we can
> use a constexpr sorted array to store our table data. This can lead
> to very fast lookups while being more maintanable than using auto-
> generator scripts for every lookup table.
> 
> Note that to be sure this syntax is permitted, we should land this
> through the bots and let it sit for a little while.
> 
> Bug: angleproject:1389
> Change-Id: I9395c40276470108ce3e5786d8f1b8d85462c517
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/777544
> Commit-Queue: Jamie Madill <jmadill@google.com>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

TBR=ynovikov@chromium.org,jmadill@google.com,syoussefi@chromium.org,jmadill@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:1389
Change-Id: I482729b6f16975896b0e5c29999f9a081056e800
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1506238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This reverts commit f094bac9.

Reason for revert: Causes timeouts on Debug bots in the BufferDataTest.NULLData

Original change's description:
> Allow enabling trace annotations
> 
> Tracing was never allowed to happen because getStatus always returned
> false. Also want to allow tracing for release builds for perf analysis.
> 
> Bug: angleproject:3176
> Change-Id: I7aa94ed9fe3d7f67fe6dd10123c9badc7fb49d82
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1475248
> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
> Reviewed-by: Jamie Madill <jmadill@google.com>

TBR=ynovikov@chromium.org,geofflang@chromium.org,jmadill@google.com,courtneygo@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3176
Change-Id: I91d28d15a092519551811a9a07c01987c9e028e7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1505799Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:2950
Change-Id: Idcb907587abea99ff6b1c2cbe6bb327af0222b10
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1506007Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

To support future work where RendererVk functionality is moved to
ContextVk.  Given multiple contexts, EGLSync can no longer rely on a
single serial as it can be used in multiple contexts.  Instead, the
fence corresponding to the submission in which the EGLSync object
signals is kept so it can be waited on.

Introduces a `vk::Shared` class that includes a ref-counted reference to
a Vulkan object (vk::Fence in this case).  This is specially made to
`destroy()` object when reference count reaches zero.

Bug: angleproject:2464
Change-Id: I68c8229eea8df77974e28fcc2a9563dae5d204f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1493131
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill (use @chromium please) <jmadill@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:2361
Change-Id: I39eb34b3c415fa165fa7803b2bc09338833f6773
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1496039Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The macro was introducing an additional scope that was not the
scope we intend to trace.

Test: ./external/chromium-trace/systrace.py -t 10 -o /tmp/maps.html -a com.google.android.apps.maps gfx sched freq idle am wm gfx view sync irq binder_driver
Examine trace for markers and verify they are expected size.

Bug: angleproject:3176
Change-Id: I593b8685c5e72a844bebec4b98e1373110a235ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1492012
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

Bug: angleproject:1944
Change-Id: Idd1cf50a1751bf0d5a04159fffbc91a3225f9768
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1496038
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

With the relaxed C++14 constexpr rules allowed in Chromium, we can
use a constexpr sorted array to store our table data. This can lead
to very fast lookups while being more maintanable than using auto-
generator scripts for every lookup table.

Note that to be sure this syntax is permitted, we should land this
through the bots and let it sit for a little while.

Bug: angleproject:1389
Change-Id: I9395c40276470108ce3e5786d8f1b8d85462c517
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/777544
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

glmark2 is a an OpenGL ES 2.0 benchmark licensed under GPL v3.
See https://github.com/glmark2/glmark2

ANGLE can use glmark2 as a metric and guide for optimization. It will
add a number of useful performance tests. This CL adds the initial
build integration.

A follow-up CL will integrate glmark2 into our performance tests. Note
that glmark2 will not be shipped with Chrome or Android. It will only
be used on our test infrastructure.

Note that the data path solution is temporary. When integrated into
ANGLE we will make sure we CWD into the glmark2 directory before
running the benchmark.

Bug: angleproject:3139
Change-Id: I5c4f605221c255ab19abd10b321b5867ab459105
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1449984
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Tracing was never allowed to happen because getStatus always returned
false. Also want to allow tracing for release builds for perf analysis.

Bug: angleproject:3176
Change-Id: I7aa94ed9fe3d7f67fe6dd10123c9badc7fb49d82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1475248
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

Isolate variables better. And add a check for out-of-date hases.
Currently if a generator is removed the hashes will stick around.

Bug: angleproject:3227
Change-Id: I9b9da245b9b29093b1f3f320a81810cd7da82395
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1500575
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:2682
Change-Id: If9100bee246dfb99fca3f0470742a337a126c9a5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1476951Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

Sync with chromium, primarily to shave the kOsFuchsia yak.

Bug: angleproject:2475
Change-Id: I76ce607095d02e805a41f63315b4237e57f1cc4e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1497392
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

SecondaryCommandBuffer is a CPU-side command buffer construct intended
to delay allocation/construction of GPU-side command buffers until
absolutely necessary.

Initially ANGLE was batching commands into Vulkan secondary command
buffers and then submitting those command buffers when rendering was
required. On at least some devices we saw two areas of overhead that
SecondaryCommandBuffers are intended to reduce:
1. Commands in secondary cmd buffers taking longer than equivalent
commands in a single primary cmd buffer.
2. Allocation/free/reset overhead of the secondary command buffers was
a hotspot for some workloads.

Bug: angleproject:3136
Change-Id: Ife8ffe2968eee423d89ff433d62596c432156661
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1492016
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

This reverts commit 0e1ce2e5.

Reason for revert: I think this was my fault. Was maybe using an
outdated version locally. Should probably add a presubmit bot to
the CQ.

Original change's description:
> Vulkan: Update code hash after roll.
> 
> Bug: angleproject:3905
> Change-Id: I3cd7eecd5f0ab9990fd714d5fab3b94008fb9488
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1498129
> Reviewed-by: Jamie Madill <jmadill@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@google.com>

TBR=jmadill@google.com,syoussefi@chromium.org,jmadill@chromium.org

Change-Id: I387721af7dcbb002d54bd9e785fa782d77cd186d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:3905
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1500077Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jamie Madill <jmadill@google.com>

Unpack as much of the binary steam as possible before passing the final loading
of the shader programs off to a worker thread.  Reporting as many possible link
errors before becoming asynchronous means that linking should only fail due to
unexpected system issues at that point.

This also allows other backends to asynchronously load program binaries.

BUG=angleproject:2857

Change-Id: I587917a3e54522114dabd41d1b14fc491c8fd18a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1473451
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

To be specific regarding what being "shared" entails.  Also, avoids
confusion w.r.t to an upcoming vk::Shared class.

Bug: angleproject:2464
Change-Id: Ib9c112bbb822ae30dab39c75a8cde25dd79b2258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1499693Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3905
Change-Id: I3cd7eecd5f0ab9990fd714d5fab3b94008fb9488
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1498129Reviewed-by: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@google.com>

This reverts commit 0c01e367.

Reason for revert: Its dependency that was reverted has now relanded:

    https://chromium-review.googlesource.com/c/angle/angle/+/1489153

Original change's description:
> Revert "Vulkan: Implement debug markers"
>
> This reverts commit 983e4469.
>
> Reason for revert: Depends on a CL that's reverted: https://chromium-review.googlesource.com/c/angle/angle/+/1470605
>
> Original change's description:
> > Vulkan: Implement debug markers
> >
> > Covers both GL_KHR_debug and GL_EXT_debug_marker.
> >
> > Debug markers are used to specify events or hierarchically categorize a
> > set of commands within the command buffer.  When debugging, this allows
> > for quicker navigation to the draw calls of interest, and otherwise
> > provides context to debug output.
> >
> > Bug: angleproject:2853
> > Change-Id: Id65e11fc877d9e70b6fd0fae7f0bbbcb1164bf10
> > Reviewed-on: https://chromium-review.googlesource.com/c/1403956
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Reviewed-by: Geoff Lang <geofflang@chromium.org>
>
> TBR=geofflang@chromium.org,jmadill@chromium.org,syoussefi@chromium.org
>
> Change-Id: I7fcfc8683195d396aec61848719f52c0fa049ece
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:2853
> Reviewed-on: https://chromium-review.googlesource.com/c/1470606
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=geofflang@chromium.org,jmadill@google.com,syoussefi@chromium.org

Bug: angleproject:2853
Change-Id: Ie19ae103244d54dcf7108d5f61c24e318fc44057
Reviewed-on: https://chromium-review.googlesource.com/c/1489154
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>

This reverts commit 3805122b.

Reason for revert: The OOM issue that coincidentally happened at the time this CL landed, and for which this CL was reverted, turned out to be irrelevant to this change.

Original change's description:
> Revert "Roll Vulkan repos"
>
> This reverts commit 55ea947c.
>
> Reason for revert: Seems to be causing a memory corruption on Windows/Intel bots.
>
> Original change's description:
> > Roll Vulkan repos
> >
> > Bug: angleproject:3095
> > Change-Id: I6ae9d61304981223f9e2f1869ed32612aa38952c
> > Reviewed-on: https://chromium-review.googlesource.com/c/1405714
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
>
> TBR=ynovikov@chromium.org,jmadill@chromium.org,syoussefi@chromium.org
>
> Change-Id: I61879770c9bb16ac2231b081bda08e6211ba6831
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:3095
> Reviewed-on: https://chromium-review.googlesource.com/c/1470605
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=ynovikov@chromium.org,jmadill@google.com,syoussefi@chromium.org

Bug: angleproject:3095
Change-Id: Iabe8ea215b44c65c4c22b9b158c5dad3ffffdbb0
Reviewed-on: https://chromium-review.googlesource.com/c/1489153
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>

This reverts commit fe14b2e5.

Reason for revert: failing test is reworked not to run angle_unittests
itself, but another binary.

Previously, this test was calling angle_unittests itself, but with a
different target.  On the bots, that was in turn calling angle_unittests
with even more arguments, including the addition of a log file location.
Under some configurations, this separate process was thus trying to
access files that were already opened by the parent process, leading to
a test failure.

In this CL, a new helper executable is created for the sake of this
unittest.

> Revert "Add system util to execute app and retrieve its output"
>
> This reverts commit c63d9552.
>
> Reason for revert: Test fails on Win7
>
> Original change's description:
> > Add system util to execute app and retrieve its output
> >
> > This will be useful to run external applications, such as benchmarks,
> > and process their output.
> >
> > Bug: angleproject:3125
> > Change-Id: Ic13c69f2e034f4b47498fb2f299c62423c355c4a
> > Reviewed-on: https://chromium-review.googlesource.com/c/1452534
> > Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@google.com>

Bug: angleproject:3125, angleproject:3168
Change-Id: I74815750484a79f33c36e0b4f941d4dd98f99aa5
Reviewed-on: https://chromium-review.googlesource.com/c/1487631
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Fixes the format table so the correct Vulkan format for the types are
generated.  Additionally, implements CHROMIUM_copy_compressed_texture as
well as other functions relevant to initializing compressed textures.

Bug: angleproject:2670, angleproject:2904
Change-Id: I682d36574262525027cddf8f329515f38cd77dc0
Reviewed-on: https://chromium-review.googlesource.com/c/1468048
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>

Causes random timeouts.

Bug: angleproject:2932, angleproject:3153
Change-Id: I69a200684afab9e00642850bfa8e8efd0da5ad1d
Reviewed-on: https://chromium-review.googlesource.com/c/1495229Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

warningsAsErrors should be falsed on Windows 7 because we may
legitimately get a warning about loading the old d3dcompiler DLL on that
platform. The logic for this was reversed in the initial change. This
change flips the logic, changes the cutoff OS version, and always sets
the flag to something.

Bug: chromium:920704
Change-Id: Ibf8a7c9a48bffc183479b7614148d6c00c122a07
Reviewed-on: https://chromium-review.googlesource.com/c/1496015
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>

Migrated pool allocator used by compiler to common.

Planning to use this for ANGLE custom command buffers so this some
refactoring in preparation for that work.

Added a unit test to check PoolAllocator functionality.

Bug: angleproject:2951
Reviewed-on: https://chromium-review.googlesource.com/c/1476953Reviewed-by: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>
Change-Id: I0b4f3d55ea1799e35c9799c221f7129233f30b24
Reviewed-on: https://chromium-review.googlesource.com/c/1492972

Bug: None
Change-Id: I75255cfda3793c539ac8a6ee2c50b8526bfc9286
Reviewed-on: https://chromium-review.googlesource.com/c/1493113
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

Bug: chromium:930993
Change-Id: I8edbd01c5c9f1ed63243cc4a42f6de44c92db8bd
Reviewed-on: https://chromium-review.googlesource.com/c/1481242
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

Even though VK_EXT_queue_family_foreign is required by
VK_ANDROID_external_memory_android_hardware_buffer,
Pixel 2 PQ2A.190205.002 supports the latter but not the former.

Also print the names of unsupported extensions to ease debugging in the future.

Bug: angleproject:3121, chromium:857138

Change-Id: Ib1195153cfb74f079a93ee9ce93b9b78e6f6e00a
Reviewed-on: https://chromium-review.googlesource.com/c/1493114Reviewed-by: Jamie Madill <jmadill@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ANGLE devs can keep tabs on subfolders like in Chromium.

Bug: none
Change-Id: Ib507b758d2ee3b00808e798c23361f56930b3f95
Reviewed-on: https://chromium-review.googlesource.com/c/1495034Reviewed-by: Jamie Madill <jmadill@google.com>
Commit-Queue: Jamie Madill <jmadill@google.com>

Applies to all Windows because we currently don't have a way to check
which version we're on. The fallback to the old compiler is generating
a warning. This test was being overly conservative. Also updates a few
message strings.

Bug: chromium:920704
Change-Id: If83677881e85d6a6f9ad98b33cd5f7d917bbec6b
Reviewed-on: https://chromium-review.googlesource.com/c/1492311
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Jamie Madill <jmadill@google.com>

This re-enables Vulkan ES3 context creation and adds the necessary dEQP
suppressions.

Bug: angleproject:2950
Change-Id: Ic24a9fb4f867f3bce08f101e056f208abf84bb5e
Reviewed-on: https://chromium-review.googlesource.com/c/1483311
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The workaround in https://chromium-review.googlesource.com/430887
was intended only for NVIDIA.

Re-creating the test window causes new native display to be created every time.
Normally, re-using the same native display with different implementation
would release the old implementation.
When new display is created instead of re-using the old one,
old implementation is never released, leaking memory.

Use SystemInfo to check if any of GPUs is NVIDIA
and apply the workaround only then,
reducing the leak on other platforms.

Bug: angleproject:1810, angleproject:3153
Change-Id: I6198c01c82a01e2adc0bcd1fad303c47cd7328d8
Reviewed-on: https://chromium-review.googlesource.com/c/1490379
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@google.com>

BUG=angleproject:2668
BUG=angleproject:3121

Change-Id: I0dfb2ec0737ebd963b0fadb78cf720a90874f00b
Reviewed-on: https://chromium-review.googlesource.com/c/1452264
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

ANGLE can use this library to output the test results format used by
the Chromium infrastructure. We have a rapidjson mirror located on
chromium.googlesource.com.

Also updates rapidjson to the latest version and adds GN integration.
Currently this library was unused in ANGLE.

Bug: angleproject:3162
Change-Id: Ie349026f68028e3acc46055655e321c2d710b828
Reviewed-on: https://chromium-review.googlesource.com/c/1487633
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This should highlight problems with array buffer state changes even
more than the single attribute test.

Bug: angleproject:3014
Change-Id: I7f42ddb48f0f794fa279b81c8378dab8dc9db489
Reviewed-on: https://chromium-review.googlesource.com/c/1413788
Commit-Queue: Jamie Madill <jmadill@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This reverts commit 94171749.

Reason for revert: crashes on Debug bots

Original change's description:
> Vulkan:Adding custom pool allocator
> 
> Migrated pool allocator used by compiler to common.
> 
> Planning to use this for ANGLE custom command buffers so this some
> refactoring in preparation for that work.
> 
> Added a unit test to check PoolAllocator functionality.
> 
> Bug: angleproject:2951
> Change-Id: I29618cfdb065b8a5fefd40719a35d27b1f6e99ef
> Reviewed-on: https://chromium-review.googlesource.com/c/1476953
> Reviewed-by: Jamie Madill <jmadill@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Commit-Queue: Tobin Ehlis <tobine@google.com>

TBR=ynovikov@chromium.org,jmadill@google.com,tobine@google.com,syoussefi@chromium.org

Change-Id: Id8c522bd1d94154e871211d975e801a55cc9c257
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2951, angleproject:3169
Reviewed-on: https://chromium-review.googlesource.com/c/1487977Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>