Commits · 120b61d34ba8da345ea08087a98959c3fa034356 · Chen Yisong / angle

29 Aug, 2019 10 commits

Use ShaderProgramID in place of GLuint handles · 120b61d3

authored Aug 21, 2019

Bug: angleproject:3804
Change-Id: I5dc640004c2cc054c53261e8e939b6a9f5fc23bb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762363
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>

120b61d3

Revert "Reland "Vulkan: Use VK repos' internal BUILD.gn files"" · aae21ef6

authored Aug 29, 2019

This reverts commit 0ad1559f.

Reason for revert: linux-rel no-op build issue showing up in Chromium integration. Tracking in chromium:997016

Original change's description:
> Reland "Vulkan: Use VK repos' internal BUILD.gn files"
> 
> This is a reland of 552f5fcb
> 
> Original change's description:
> > Vulkan: Use VK repos' internal BUILD.gn files
> >
> > This retires custom BUILD.gn files for the Vulkan Headers, Tools,
> > Validation-Layers, and Loader repos. They now have integrated BUILD.gn
> > files so switched ANGLE to use those by default.
> > Also Validation Layer, Loader, and Tools repos no longer uses codegen
> > so this speeds up the build overall.
> > Switched over from old VK_LAYER_LUNARG_standard_validation meta-layer
> > to VK_LAYER_KHRONOS_validation unified layer.
> >
> > This changes includes a temporary workaround to the Vulkan-Loader repo
> > to remove its Window's build dependence on WDK. There are plans to
> > remove that depenedence in Loader master, but until then we can use
> > our custom branch workaround.
> > It also includes a custom branch for validation layers that includes
> > some build fixes for ANGLE.
> > Finally, the layers were crashing on Android when attempting to use
> > DebugUtils extension so forcing DebugReport on Android for now.
> >
> > Bug: angleproject:2449
> > Bug: angleproject:3320
> > Bug: angleproject:3852
> > Bug: chromium:997009
> > Bug: chromium:997016
> > Change-Id: I48b36acefcc7f2bc930eb72d6fdbc87bca24f833
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610438
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Tobin Ehlis <tobine@google.com>
> 
> Bug: angleproject:2449, angleproject:3320, angleproject:3852
> Change-Id: I9597be99000083b135e19b6ee68d4ae222158e72
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1769036
> Commit-Queue: Tobin Ehlis <tobine@google.com>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

TBR=tobine@google.com,syoussefi@chromium.org,jmadill@chromium.org

Change-Id: I88afdaff07e9f414f9de02f6d3651eaba9a5045f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:2449, angleproject:3320, angleproject:3852
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1776920Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

aae21ef6

Reland "Vulkan: Use VK repos' internal BUILD.gn files" · 0ad1559f

authored Jul 18, 2019

This is a reland of 552f5fcb

Original change's description:
> Vulkan: Use VK repos' internal BUILD.gn files
>
> This retires custom BUILD.gn files for the Vulkan Headers, Tools,
> Validation-Layers, and Loader repos. They now have integrated BUILD.gn
> files so switched ANGLE to use those by default.
> Also Validation Layer, Loader, and Tools repos no longer uses codegen
> so this speeds up the build overall.
> Switched over from old VK_LAYER_LUNARG_standard_validation meta-layer
> to VK_LAYER_KHRONOS_validation unified layer.
>
> This changes includes a temporary workaround to the Vulkan-Loader repo
> to remove its Window's build dependence on WDK. There are plans to
> remove that depenedence in Loader master, but until then we can use
> our custom branch workaround.
> It also includes a custom branch for validation layers that includes
> some build fixes for ANGLE.
> Finally, the layers were crashing on Android when attempting to use
> DebugUtils extension so forcing DebugReport on Android for now.
>
> Bug: angleproject:2449
> Bug: angleproject:3320
> Bug: angleproject:3852
> Bug: chromium:997009
> Bug: chromium:997016
> Change-Id: I48b36acefcc7f2bc930eb72d6fdbc87bca24f833
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1610438
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Tobin Ehlis <tobine@google.com>

Bug: angleproject:2449, angleproject:3320, angleproject:3852
Change-Id: I9597be99000083b135e19b6ee68d4ae222158e72
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1769036
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0ad1559f

Expand the TextureGL::releaseTexImage size reset workaround to Win AMD. · d8e821aa

authored Aug 29, 2019

Windows 10 AMD drivers have also had issues with generating errors when calling
glTexImage2D with zero size after unbinding a surface.

BUG=angleproject:3859

Change-Id: Iae3e31418b6c89056d0d4aab954519598d8f25f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1775111Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

d8e821aa

Vulkan: DispatchIndirect in graph dump output · d3b31037

authored Aug 29, 2019

Bug: angleproject:3601
Change-Id: Ib7e5abea3a9fced88f415c6395a3f790aadafdaa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1776008Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

d3b31037

Vulkan: Fix compute shader bug affecting 10_10_10_2 formats · 324b3915

authored Aug 29, 2019

When the source format is 10_10_10_2, valueBits needs to be
"2" if the component is "3" i.e, the alpha channel. It was
incorrectly set to "10" for all components

Bug: angleproject:3866
Change-Id: If206c63d704a7a485681e483e12ae9ab611b0d99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1775105Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

324b3915

Various fixes for frame capture · c43852aa

authored Aug 27, 2019

1. Use contextId as identifier to separate captures for different GL
context.
2. Fix write string params. In order to keep consistent between replay
and capture, changes have been made to store C style string (with '\0'
suffix) for string param capture, which breaks cpp frame capture. This
change fixes it.
3. On Android device, it use a custom path to save captures and it
breaks the loadBinaryData(). Here differentiate file name and file path
to fix it.

Bug: angleproject:3804
Change-Id: I378cf26697d15f0c1a8cf7afea2b758f5c58498b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1774469
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

c43852aa

Roll ./third_party/glslang/src f27bd2aa2e3f..796df2d74e05 (4 commits) · 80b1ba63

authored Aug 29, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f27bd2aa2e3f..796df2d74e05


Created with:
  gclient setdep -r ./third_party/glslang/src@796df2d74e05

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cwallez@chromium.org
Change-Id: I7d13d5d751fc94dd74fc7ae2ee6d96650aae2bc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1775635Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

80b1ba63

Roll ./third_party/spirv-tools/src 15fc19d0912d..73422a0a5ee1 (1 commits) · 589f4fc1

authored Aug 29, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/15fc19d0912d..73422a0a5ee1


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@73422a0a5ee1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cwallez@chromium.org
Change-Id: I806db63c94f004827f790e2d968b746a990b3cac
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1775636Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

589f4fc1

Support separable shader programs · 5d27a696

authored Aug 13, 2019

The spec states:
  Shader stages including vertex shaders, fragment shaders, and compute
  shaders...A single program object can contain all of these shaders, or
  any subset thereof.

This change allows shader programs without a fragment shader. The
biggest driver of this change is dEQP since a large number of tests
create shader programs without a fragment shader.

Bug: angleproject:3803
Test: dEQP-GLES31.functional.program_interface_query
Change-Id: Id6cb098c62a1489a14b9ec1b31bd4cd59f655e49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1752010
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

5d27a696

28 Aug, 2019 12 commits

Use ProgramPipelineID in place of GLuint handle · 378c1881

authored Aug 22, 2019

Bug: angleproject:3804
Change-Id: Ice37a4b3d43008e5bcd5d0a7528514d5bb504066
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1767322Reviewed-by: Jiacheng Lu <lujc@google.com>
Commit-Queue: Jiacheng Lu <lujc@google.com>

378c1881

Vulkan: Expose EXT_instanced_arrays · 8933de85

authored Aug 28, 2019

Implemented in

    https://chromium-review.googlesource.com/c/angle/angle/+/1452740

was missing exposure from the Vulkan backend.

Bug: angleproject:3105
Change-Id: If82e6f3dfa5ff8fafbc401258a5e324ea311123d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1773906Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

8933de85

Use PathID in place of GLuint handle · 7b5744f4

authored Aug 22, 2019

Bug: angleproject:3804
Change-Id: Ibadfc2c33e4af1cca22caa1dbe96ac48a4a85ffa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1766822Reviewed-by: Jiacheng Lu <lujc@google.com>
Commit-Queue: Jiacheng Lu <lujc@google.com>

7b5744f4

Supress dEQP ETC texture tests on Mac. · 83785d06

authored Aug 28, 2019

These tests generate native GL errors because ETC formats are not supported.
The test does not verify the data so it previously passed.

BUG=angleproject:3853

Change-Id: I21ed60f46031fe9fdc3a38c6a9a1e9197c56a5eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1774471
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

83785d06

Suppress error messages in ANGLE end2end tests on Nexus6P. · 780bdace

authored Aug 28, 2019

GL errors are generated during initialization on this device. Suppress
them until enough logging is in place to debug.

BUG=998503
BUG=angleproject:3020

Change-Id: I74a51a661a930ea89b0234dcb3e6213288e75c86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1774468Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

780bdace

Suppress correct failure on Android FYI Release (NVIDIA Shield TV) · 566c2e3c

authored Aug 28, 2019

TBR=geofflang@chromium.org
BUG=chromium:998505

Change-Id: I8e49ee063c2e06f5031a288c5fe32fd7683fcd7d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1774723Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

566c2e3c

Use QueryID in place of GLuint handle · 814a0a1b

authored Aug 22, 2019

Bug: angleproject:3804
Change-Id: I921bbe7f67c025ab2b624fe14530c04ac17346f3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1765889Reviewed-by: Jiacheng Lu <lujc@google.com>
Commit-Queue: Jiacheng Lu <lujc@google.com>

814a0a1b

Move default ANGLE platform type out of main switch/case · 7cd5f64a

authored Aug 21, 2019

The "default" platform type isn't really a discrete type, and treating it
that way leads to duplication. Make the default platform just map to
another platform enum.

After this change, setting args to angle_enable_opengl=false
angle_enable_vulkan=true under X11 results in a default of vulkan;
previously we would hit UNREACHABLE() due to not handling this case.

Bug: angleproject:3847
Change-Id: I1dc093ef8a2f5b93721cb1ebda0a8c3ec4a7d2f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1521321Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

7cd5f64a

Suppress crashing perftests on Win Intel Exp Rel · f8e8fcf8

authored Aug 26, 2019

Also moves ANGLE_SKIP_TEST_IF to a header shared between end2end and
perf tests.

BUG=chromium:997674

Change-Id: I7c5968e6d861c4bff703ddc6ae0e4e021e47061f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1768374
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f8e8fcf8

Suppress end2end tests failures on Android FYI Release (NVIDIA Shield TV) · 7f00d338

authored Aug 28, 2019

These were fixed on desktop drivers but not this Android driver.

TBR=geofflang@chromium.org
BUG=chromium:998505

Change-Id: Ie5f434c52753beff4d8f119713ef55f229ee7b95
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1773253
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

7f00d338

Support in memory frame capture replay · 05114fe7

authored Aug 09, 2019

Enable FrameCapture to dispatch its calls back to Context and replay
them.

Bug: angleproject:3785
Change-Id: I580eff1fca3e39414a9b45bb296e0f3866ea33bc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1747055
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

05114fe7

Roll ./third_party/glslang/src a3bc04b278ed..f27bd2aa2e3f (4 commits) · 6f24d8a7

authored Aug 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a3bc04b278ed..f27bd2aa2e3f


Created with:
  gclient setdep -r ./third_party/glslang/src@f27bd2aa2e3f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cwallez@chromium.org
Change-Id: I44f87512fe0fcc54038f5ceb986a2bf458e98a5d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1774267Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6f24d8a7

27 Aug, 2019 8 commits

Vulkan: Style cleanups to TextureVk. · 886698bc

authored Aug 27, 2019

Pass params by const & and use "CPU instead of "Cpu" naming. Also
prefer "ContextVk *contextVk" to "ContextVk *context".

Bug: angleproject:2464
Change-Id: I887de5b2e5494d14f0e9c7db269eb63744f2a3cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1771499Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

886698bc

Vulkan: Remove command buffer param from initImage. · 9288dcf6

authored Aug 27, 2019

This method didn't use the parameter. Removing it simplifies the code.

Bug: angleproject:2464
Change-Id: Ib8f5f649f66eae405fb91f7cfcc8cefc4c44bda2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1771992
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

9288dcf6

Vulkan: Enable the official GLES1 conformance tests · 14a9be44

authored Aug 26, 2019

Needed to suppress 3 tests for Vulkan.

Bug: angleproject:3408
Bug: angleproject:3862
Bug: angleproject:3863
Bug: angleproject:3864
Bug: angleproject:3867
Change-Id: I87379125f7f794f5c8ed8eccff7e24bd0d9fab94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1771938
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

14a9be44

GL: Check for errors around GL calls. · 2a19c59f

authored Aug 23, 2019

Add a macro to check for GL errors after each GL call to catch errors as they
happen even if the debug callbacks are unavailable. GL errors are only checked
when asserts are enabled unless explicitly requested with the
ANGLE_GL_TRY_ALWAYS_CHECK macro to verify GL calls that may allocate memory.

Updated TextureGL to use the macro.

BUG=angleproject:3020

Change-Id: I7678b204899e940824b010ab4be7e7f159bee6de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1764476Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

2a19c59f

Fix a typo in the GL_NUM_REQUESTABLE_EXTENSIONS_ANGLE enum value. · 5c81d94f

authored Aug 26, 2019

GL_NUM_REQUESTABLE_EXTENSIONS_ANGLE had a typo between the spec and the
header but any user who used our header would still get the correct
beaviour.

BUG=angleproject:3861

Change-Id: Ibc85607ad41a8419246e057065ab4ce797f0ce66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1772376Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

5c81d94f

Remove skipping of several tests on NVIDIA since they are now passing · 76a93c33

authored Aug 21, 2019

Remove skipping of several tests on NVIDIA since they are now passing.

  - MissingReturnStructOfArrays
  - DrawWithLevelsOutsideRangeWithInconsistentDimensions
  - TextureFormatChangesWithBaseLevel
  - TextureLuminance16Implicit

BUG=angleproject:3849
BUG=angleproject:1305
BUG=angleproject:596

Change-Id: Ie3c3ba6634a251a7320a61c6c4cc03cb178db925
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1763964Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

76a93c33

Roll ./third_party/spirv-tools/src 1eb89172a82b..15fc19d0912d (1 commits) · 2697f1f0

authored Aug 27, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1eb89172a82b..15fc19d0912d


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@15fc19d0912d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
TBR=cwallez@chromium.org
Change-Id: I1ea8b23204c09ff214e38a5ed1bdb0cd02739757
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1768885Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2697f1f0

Vulkan: Introduce ContextScoped · 57ad1e12

authored Aug 23, 2019

Scoped is changed to DeviceScoped and a ContextScoped class is added.
The former destroys objects at the end of scope, and the latter releases
them.

Bug: angleproject:3757
Change-Id: Ia0bbded53e94af9c8c72c77d07306d6724c6c409
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1769060Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

57ad1e12

26 Aug, 2019 7 commits

Implement Draw base vertex and base instance functions · cd31f286

authored Jun 25, 2019

This patch implements functionality of  glDrawArraysInstancedBaseInstanceANGLE,
glDrawElementsInstancedBaseVertexBaseInstanceANGLE,
glMultiDrawArraysInstancedBaseInstanceANGLE,
and glMultiDrawElementsInstancedBaseVertexBaseInstanceANGLE

Workaround for OpenGL driver on Mac:
gl_VertexID on Mac with AMD GPU doesn't include baseVertex value.
So replace gl_VertexID with (gl_VertexID + angle_BaseVertex) if any.

Workaround for Vulkan GLSL:
gl_InstanceIndex on Vulkan includes baseInstance. So replace
gl_InstanceIndex with (gl_InstanceIndex - angle_BaseInstance) when
angle_BaseInstance is declared.

Bug: chromium:891861, angleproject:3402
Change-Id: Ia1d94b5d4d7da7e635468c05c962c4f7eb1b1919
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1750126
Commit-Queue: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cd31f286

Try to list files instead of directory in isolate for gl_cts data. · 52cc70fa

authored Aug 26, 2019

Bug: angleproject:3827
Change-Id: I65ed81886dce185bfc7542c321f43cc9bde6ef92
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1771979Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

52cc70fa

Use FenceNVID in place of GLuint handles · 962503e7

authored Aug 21, 2019

Bug: angleproject:3804
Change-Id: I29c16e17c3a426efbbf0b60670581962ee505f3e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1764298
Commit-Queue: Jiacheng Lu <lujc@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

962503e7

Fix trace logging in Debug. · 87b106a0

authored Aug 26, 2019

- fix crash when logging an invalid context
- output to trace even when platform logging is on

Bug: angleproject:3815
Change-Id: I725f5728e1d839e3d8458579ad1958cb775d9ecf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1769505Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

87b106a0

Vulkan: Enable ES1_VULKAN testing in end2end tests. · 27a8b32f

authored Aug 23, 2019

Bug: angleproject:3408
Change-Id: I19b3c0f4795130638f43eabfe9c6f41ff85521fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1771547Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

27a8b32f

LoggingAnnotator: don't output to trace file if there is no platform · f2f111d7

authored Aug 26, 2019

This is a revert of a small chunk of
https://chromium-review.googlesource.com/c/angle/angle/+/1761163 that is
suspect to cause weird failures on the GPU FYI waterfall in Debug on
Windows, maybe because the many disk writes are too slow.

BUG=chromium:997667
TBR=jmadill@chromium.org

Change-Id: Ifb799d2ed90682e55e5cc7c0ce21d2598bf30c9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1768371Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

f2f111d7

Roll ./third_party/spirv-tools/src aef8f92b2bb6..1eb89172a82b (3 commits) · 39e2669a

authored Aug 26, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/aef8f92b2bb6..1eb89172a82b

Created with:
gclient setdep -r ./third_party/spirv-tools/src@1eb89172a82b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

Bug: None
TBR=jonahr@chromium.org,jonahr@google.com
Change-Id: Iacbec76c6c8667fdf818206f1fe8f4577c026d82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1770175Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

39e2669a

23 Aug, 2019 3 commits

More improvements to trace logging. · 3c6b2e16

authored Aug 23, 2019

- output 'glDrawArrays' instead of 'DrawArrays'
- output context IDs for multithreaded scenarios
- output to trace even when platform logging is on
- fix newlines in trace file output

Bug: angleproject:3815
Change-Id: Ie07c5c91d9eae6204aaf6f6319ef318b88d292aa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1761163
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

3c6b2e16

Vulkan: Improve cubemap emulation seam handling · 83a369bb

authored Aug 14, 2019

Changes seamful cubemap emulation to always compute the derivative,
emulating the bias parameter by scaling the provided derivatives.
This results in more accurate mipmap levels for seams within primitives.
There are some artifacts as a result of how derivatives are calculated,
but this matches the native driver.

Bug: angleproject:3243
Bug: angleproject:3732
Change-Id: Icb976e2a7e14cb4210645571edc037d4e607bd0d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1754383
Commit-Queue: James Dong <dongja@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

83a369bb

Refactor perf tests to fix metric/story swapping · 2f4a7518

authored Aug 16, 2019

Refactors the perf tests to fix the issue of metric and story being
swapped, which causes issues when trying to convert to histograms.

Specifically, does the following:
1. Rolls the version of src/tests/perf_tests/third_party/perf/ to
   Chromium 476dae823269c8d05b544271af97ad1adb0db8ee
2. Switch to using PerfResultReporter instead of PrintResult directly.
3. Split RenderTestParams::suffix into backend and story; backend is
   used as part of the metric, while story is used as the story.
4. Remove the "average" metric that was being automatically reported
   by ANGLEPerfTest, as reported results are automatically averaged.
5. Update the reported metric to more clearly distinguish between
   test, backend, and metric. It is now name_backend.metric. e.g.
   DrawCallPerf_vulkan.wall_time.

Bug: chromium:923564,chromium:924618
Change-Id: I00cc191407052f23df57dbfa53b6fb088fc26960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1762360
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

2f4a7518