Commits · 18c6d628c19af1c79aa4526ffc4e2d7151b53128 · Chen Yisong / angle

13 Apr, 2021 16 commits

GL: Support VAOs without native VAOs. · 18c6d628

authored Mar 09, 2021

Share the default VAO state between all frontend VAO when
there is no native VAO support. Forcefully sync state every
time a new frontend VAO is bound.

Bug: angleproject:5577, chromium:1167179
Change-Id: Ieaedb5108ad28fc78e7e58b74495639c5246bb05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2665266Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

18c6d628

Add the jdk dep when building standalone for Android. · fe790824

authored Apr 09, 2021

Chrome started requiring this dep to 'gn gen' on Android so
ANGLE needs it too.

Bug: angleproject:5839
Change-Id: Ia8df8520975ed426667f2c59f0fd7761652b92ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818141
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

fe790824

Reland "Vulkan: Add features to modify sampling parameters" · 065c2329

authored Apr 08, 2021

This reverts commit a51b57fa.

Original change's description:
> Revert "Vulkan: Add features to modify sampling parameters"
>
> Bug: b/167404532
> Change-Id: Iae19dfe165074e8c01216312bddd744c4fb504a4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2510012
> Commit-Queue: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Tim Van Patten <timvp@google.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: b/167404532
Change-Id: I2c756b8eb0f61701ef6e33275e557bc199a4d3b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815259Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

065c2329

Translator: Track nameless interface block field indices in type · c2d1a464

authored Apr 09, 2021

Fields of nameless interface blocks are stored as TVariables and
referenced through a TIntermSymbols (unlike named blocks which use
EOpIndexDirectInterfaceBlock with a constant field indices).  With this
change, the field index is stored in the variable's type which let's the
TField of the TInterfaceBlock be directly accessible (and not need a
search by name).

This will be helpful in translation to SPIR-V as interface block members
are accessed by field index.

Bug: angleproject:4889
Change-Id: If3ab45b1e5f5f9576721dc52e2bdf1161882514f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818242
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c2d1a464

Vulkan: Use AST transformation for gathering default uniforms · 6ec55494

authored Apr 08, 2021

... instead of generating text.  This will keep the tree in a consistent
state, as previously the references to uniform values where to
TVariable's whose declarations were removed.

Bug: angleproject:2461
Bug: angleproject:4889
Change-Id: I2ef3787dede371514a5f495f4cc8fc67ea45f451
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815564
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

6ec55494

Capture/Replay: Serialize only a hash of the shader binary · faa86bc9

authored Apr 13, 2021

It doesn't make much sense to keep the actual values and it makes
the diff needlessly large when the binaries differ.

Bug: angleproject:5856
Change-Id: I55664d6cb60ef680669c1243c2eabcb67cd4db23
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822256
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

faa86bc9

JsonSerializer: add method to store only a hash for vectors · 6d2f9cb4

authored Apr 13, 2021

This can be used to make the Json comaprison less noisy.

Bug: angleproject:5856
Change-Id: I57df41eed3926647aaf8bcf97a7aea050e1c3d51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822255
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6d2f9cb4

Translator: Validate consistent variable references · 58eabfd7

authored Apr 08, 2021

Some transformations change variable declarations.  This validation
ensures that all references to said variables are appropriately replaced
as well.

Bug: angleproject:2733
Change-Id: I6c2873968eeed4cba66e70069f84eb69a1f77074
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

58eabfd7

JsonSerializer: Fix rapidjson define usage · 79402fbd

authored Apr 13, 2021

The correct define is ANGLE_HAS_RAPIDJSON

Bug: angleproject:5858
Change-Id: I21e3f3e632d5ceb4fce43f1d6be34e4fbbdafbc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822254
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

79402fbd

Capture/Replay: Print context diff on failure when verbose · 41c66442

authored Apr 12, 2021

When run with the --verbose flag, and a test fails because the context
comparison fails, then print the unified diff between the JSON
serialization of context that was captured and the context when it
was replayed.

Bug: angleproject:5715
Change-Id: I86210d96e5bbdf63f1ed663ddf8dfcb33764cbea
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821535
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

41c66442

Skip IOBlocksSeparate xfb test on Linux/ARM/Vulkan · 5faed621

authored Apr 12, 2021

Bug: angleproject:5493
Change-Id: I894e08a86157032d1e68a3d2b460bfdbbaeb6680
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821415
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5faed621

Generate CL stubs in libGLESv2 · 1d7046ca

authored Apr 12, 2021

Bug: angleproject:5758
Change-Id: I6440dacf0db57a56923d2cab5a7c791981ba3b9d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822248
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

1d7046ca

Capture/Replay: write context serializations on failure · f7891766

authored Apr 12, 2021

With this data available as JSON text files further analysis
can be executed to drill down to what the actual difference is.

Bug: angleproject:5715
Change-Id: I7012668ff9617f6232a6bbe1798a02d8c795321d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821534
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f7891766

Roll Chromium from 497fa2f8d899 to ab36e1e42f00 (427 revisions) · 71786e94

authored Apr 13, 2021

https://chromium.googlesource.com/chromium/src.git/+log/497fa2f8d899..ab36e1e42f00

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/563f147c85..79006bea8b
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/85de9f3f89..e5f83f632d
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..db7e7f8a5d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cabb17575..057831ef1f
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/006bc90fc4..7168936235
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/luci-go: git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926..git_revision:99ac75773c6241b6ddf82ade4c54553faa084530
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/a2223becbd..bfc3b95479
* tools/skia_goldctl/linux: hppkAohY9Cc45kW6zZWYXtdLKzo9CQ9XvcqLNIBaqQQC..mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC
* tools/skia_goldctl/mac: JnqYnN3TwP__L0jvUBgcLpPQsBgz9ZcBk8-bsbiez6QC..TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC
* tools/skia_goldctl/win: 0el4SjlMxSJWhUyzmXXYXqGT59IZHXzEaDTufNH8bOwC..Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ia8f524d620a3b474cf74487a693455abdfd4491b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823568
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

71786e94

Restore EGL_EXT_buffer_age for SwiftShader Vulkan · 15f4925a

authored Apr 12, 2021

EGL_EXT_buffer_age was previously disabled for SwiftShader Vulkan
because of an Android test timing out on Cuttlefish when the buffer
age is queried. aosp/1672445 addresses the root cause of the timeout,
so EGL_EXT_buffer_age can be supported again.

Bug: b/182521420
Bug: angleproject:3529
Change-Id: I5949f721316855d9138eb9f657a6df4e7b49ed71
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821750Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>

15f4925a

Vulkan: More perf warning for vertex format conversion · 3813c361

authored Apr 12, 2021

The perf warning was previously only issued when a GPU buffer had to be
converted.  This change adds a warning when client data needs to change
format too.

Bug: b/184355822
Change-Id: I3539e22f277593d60e5e1ce172baf7b8db0477fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821751
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

3813c361

12 Apr, 2021 8 commits

Reland "Fix multithreaded crash on draw commands on D3D11 backend." · fdba40fe

authored Mar 31, 2021

This is a reland of 8b9889bf

The previous CL relied on a define which now only exists in
a specific gn configuration. This reland removes D3D11 as a
multithread-supported platform in the test configuration.

Original change's description:
> Fix multithreaded crash on draw commands on D3D11 backend.
>
> A crash can occur if thread A is executing eglDestroyContext while
> thread B issues a draw call, if the threads are interleaved in such a
> manner that a makeCurrent occurs without triggering a change to the
> global context and a dirtyAllState call. We handle that case by
> explicitly making current the proper contexts in the eglDestroyContext
> call.
>
> A test has been added that triggers a crash without this fix when
> running on the D3D11 backend. In addition, all of MultithreadingTest
> is enabled for the D3D11 backend.
>
> Test: Ran MultithreadingTest. Test exhibits a crash before this
> change, and does not after this change. Also ran:
>     dEQP-EGL.functional.sharing.gles2.multithread.*
>     dEQP-EGL.functional.multithread.*
>
> Bug: b/183756357
> Change-Id: Ic6f76a062868b2f3b4e60d29dc087ec180bfb7cd
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2798591
> Reviewed-by: Geoff Lang <geofflang@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Doug Horn <doughorn@google.com>

Bug: b/183756357
Change-Id: I5be9a011ea99a69730eddc9e4da23bcf92ed3bf2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815243Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Doug Horn <doughorn@google.com>

fdba40fe

Ignore internal format attribute for YUV D3D11 EGLImages · 923f6a6f

authored Apr 06, 2021

Internal format doesn't play any role in this case, and causes confusion
due to mixing sized and unsized formats resulting in more complicated
code in Chromium.

Bug: angleproject:5538, chromium:1116101
Change-Id: Ie200026f014850053108aa0416e1da15bcda7b84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808855
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

923f6a6f

Remove EvqBaseVertex and EvqBaseInstance qualifiers · 1f8e35b5

authored Apr 09, 2021

They are only used to mark angle_BaseVertex and angle_BaseInstance
uniforms, but they make it complicated for the rest of the code to
identify them as uniforms.

Bug: angleproject:4889
Change-Id: I0c632bb595dc9a7fcda19db11ecb27539b1c33e6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818144Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

1f8e35b5

Ignore subclass when finding GPU PCI devices · 0615bbde

authored Apr 12, 2021

When enumerating PCI devices to find GPUs, only filter on the base
class. This allows devices with class PCI_CLASS_DISPLAY_OTHER to be
found.

Bug: b/178748337
Change-Id: Ia0cd29dddc49a16428da16c1ef1b94040c1221f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2817973Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

0615bbde

infra: Remove named vs_toolchain cache. · 77600bcb

authored Apr 11, 2021

This is no longer needed now that ANGLE uses the pinned depot_tools.
We should land this after the recipe updates to no longer use the
cache.

Patch series:
1. http://crrev.com/c/2819943
2. http://crrev.com/c/2819472
3. This CL

Bug: angleproject:5842
Change-Id: I5d166c7cd66a9d7f077c09b4149de08b22724af8

Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819945Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

77600bcb

DEPS: Include a pinned version of depot_tools. · 33505f03

authored Apr 11, 2021

This will align the ANGLE standalone build more with Chromium.
It can catch some kinds of build break on the CQ, preventing
some churn, and also will let us cache the vs_toolchain without
needing a special named cache.

Also includes a necessary tool to cross-compile Win on Linux.

Patch series:
1. This CL
2. http://crrev.com/c/2819472
3. http://crrev.com/c/2819945

Bug: angleproject:5842
Change-Id: Idaee3b44d970d1171076a8eaa09e3e0555331d49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819943Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

33505f03

Roll SwiftShader from 4c0f888d7ef8 to 77edad299907 (1 revision) · 81401be2

authored Apr 12, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/4c0f888d7ef8..77edad299907

2021-04-09 capn@google.com Remove the OpenGL ES 1.1 build target

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ifcf34ec0ac6f78b6d7c0655b8ec642baadd50254
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821188
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

81401be2

Roll Chromium from 920c6c5ffe65 to 497fa2f8d899 (507 revisions) · 7093777b

authored Apr 12, 2021

https://chromium.googlesource.com/chromium/src.git/+log/920c6c5ffe65..497fa2f8d899

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/0006b44d1f..563f147c85
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/75df5ad7e8..85de9f3f89
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..ab687ea7be
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/6e92ef6460..006bc90fc4
* tools/luci-go: git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926
* tools/luci-go: git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926
* tools/luci-go: git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b..git_revision:f784260b204b2d93c7bd6d1a619f09c6822e5926
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e509f34db2..a2223becbd
No update to Clang.

Bug: None
Tbr: geofflang@google.com
Change-Id: I2bacfdbbb2205c3da9f37c546e82917fe2adc59d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820525
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7093777b

11 Apr, 2021 1 commit

Vulkan: All builtins of gl_out needs to be considered as active · f92eb43c

authored Mar 25, 2021

All builtins of gl_out, like gl_out[].gl_Position need to be
considered active as well.

Bug: angleproject:5557
Test: dEQP-GLES31.functional.tessellation.shader_input_output.gl_position_tcs_to_tes
Change-Id: I74aeef86be573dc8df17472b88acd521032d7921
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2786630
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f92eb43c

10 Apr, 2021 5 commits

Vulkan: Use RGBA16_FLOAT for buffer format fallback · 0273ea3f

authored Apr 06, 2021

... instead of RGBA32_FLOAT.  VK_FORMAT_R16G16B16A16_SFLOAT has
mandatory support for vertex buffers.

Bug: b/184163871
Change-Id: I7ef2933cd15e46bb984e6fd1b020d2ec15b9c60e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807780
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

0273ea3f

Vulkan: damage rectangles must never be pre-rotated · b17a9317

authored Apr 09, 2021

Remove the SurfaceVk::present() code that rotated damage rectangles
and the feature flag that controlled that rotation.

The Vulkan specification was changed so that the rectangles provided
to the VK_KHR_incremental_present extension must never be pre-rotated.
The spec change requires the same behavior on all platforms (just in
case), even though Android is the only platform known to support
rotation.

FYI: the Vulkan spec change was merge request 4442.

Bug: b/182930524
Change-Id: I5128fd76e718f3d964c9091830bcc5886d265543
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818826
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

b17a9317

Vulkan: Warn for unsupported vertex attrib format · fedb85b7

authored Apr 07, 2021

Provide both a performance warning and a debug-util label (for AGI)
when loading a vertex attribute requires a format conversion.

Bug: b/184355822
Change-Id: Id8cbb34f70214327e1f5cc96559e4ea66dc17889
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2801154
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

fedb85b7

Remove unused translator option bits · 795d7543

authored Apr 07, 2021

Usage of SH_DONT_REMOVE_INVARIANT_FOR_FRAGMENT_INPUT is removed from
ANGLE by [1], and from the validating command decoder by [2].  The flag
is only ever disabled in Firefox.

SH_REMOVE_POW_WITH_CONSTANT_EXPONENT is removed from the validating
command decoder by [3].  Not used in Firefox.

[1]: https://chromium-review.googlesource.com/c/angle/angle/+/1558678
[2]: https://chromium-review.googlesource.com/c/chromium/src/+/2810880
[3]: https://chromium-review.googlesource.com/c/chromium/src/+/2810879

Bug: angleproject:4889
Change-Id: If7d9c31c48510b1486a2285a88475b3c01a77527
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2810806Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

795d7543

Really fix iOS build · 82cc2d21

authored Apr 09, 2021

Complete the fix started in http://crrev.com/c/2812698

Bug: angleproject:5811
Change-Id: I9fa50b31dda116e01203d65d47dc6420391e999d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818243
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

82cc2d21

09 Apr, 2021 10 commits

Add TextureType::Buffer to RecordBindTextureTypeError() · af58be7e

authored Apr 08, 2021

Bug: b/184767884
Change-Id: I67098de503748c86f2b957db76539e73c87bd179
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818818Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

af58be7e

Android: Call getExternalStorageDirectory natively. · 147adcfa

authored Apr 09, 2021

This changes the call to base.test.util.UrlUtils to a native OS
method. We may need to update this when Chromium starts running
tests on "R". At that point we'll need a non-base mechanism to
pass the right folder to ANGLE. This could be via env vars,
debug properties, command-line arguments, or #defines.

The prior implementation is left as commented-out code as a
reminder to fix later.

Also updates WARN() to std::cerr because WARN() was not showing
up when testing.

Bug: chromium:1097957
Change-Id: I4a84ea007341dbe7fe2184eac3aae0ddca44cc9c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818240
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

147adcfa

Skip TracePerfTest.Run/native_real_gangster_crime on Linux AMD · 5902753b

authored Apr 09, 2021

Bug: angleproject:5822
Change-Id: Id4dc458dc71fcd20f8982052fa789fb04e420c8c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2818241Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

5902753b

Add tests that use, then update, then use buffers · ba7531da

authored Apr 07, 2021

This triggers vk::DynamicBuffer allocations in BufferVk.

Bug: angleproject:5719
Change-Id: Ida855b23618497f76102e55f89ab1678f9c08753
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809856Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

ba7531da

Vulkan: Add featue flag to force highp to mediump in fragment shader. · e249239c

authored Apr 08, 2021

Adding feature flag that forces highp in fragment shader to mediump. It
is disabled by default. You can enable it for experiment.

Bug: b/184850002
Change-Id: I73980be4ad160eb1b17a3a3ecfc09f2e4aeb468c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815240Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

e249239c

Fix angle_expose_non_conformant_extensions_and_versions · 085044d1

authored Apr 08, 2021

The GN arg angle_expose_non_conformant_extensions_and_versions was not
being referenced correctly in the Vulkan backend, so it was not being
properly enabled in RendererVk.cpp. This CL updates the BUILD.gn files
to fix this issue.

Bug: b/184767884
Change-Id: I7244aad9112c38bf76544f8c767563a7f0cf1b2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2816165Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

085044d1

Consider AOSP ANGLE path as well during SHA generation · d3c8d543

authored Apr 08, 2021

Account for an in-tree AOSP build of ANGLE while generating
ANGLE commit SHA

Bug: angleproject:5838
Change-Id: I81d6d821810544c35daf6af9b167f18a4b095e99
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815241
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d3c8d543

Translator: Validate multi-declarations are separated · a7b60f13

authored Apr 08, 2021

Many transformations only look at the first variable in a
TIntermDeclaration.  This change validates that once the
SeparateDeclarations transformation has been run, multi-declarations are
not reintroduced.

Bug: angleproject:2733
Change-Id: If5f96689cbdd28817c479dd7c495b91535f87199
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815565Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

a7b60f13

Remove unused translator option bit · 2feb3db5

authored Apr 07, 2021

SH_DONT_PRUNE_UNUSED_FUNCTIONS was only used by tests, and never used by
ANGLE or chromium.

Bug: angleproject:4889
Change-Id: I4926f86125e69b07e9d4d95134b7b70522e0d64f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2607491Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2feb3db5

Roll Chromium from 6cad7c765c8b to 920c6c5ffe65 (341 revisions) · 41dbfe9c

authored Apr 09, 2021

https://chromium.googlesource.com/chromium/src.git/+log/6cad7c765c8b..920c6c5ffe65

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/8df5f2532b..0006b44d1f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/b134bc315e..75df5ad7e8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..69936de9be
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/a387faa2a6..6e92ef6460
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/luci-go: git_revision:0f11e003d56071a19f4403570ebfdb8f197c2f87..git_revision:6b7ff5a4d7e3247a449a8dfa5511541dffebba8b
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/93c8ae3a54..e509f34db2
No update to Clang.

Bug: angleproject:5417
Tbr: geofflang@google.com
Change-Id: Icaf720255a92c10111226d330fc2a055e1d4950d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2815103
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

41dbfe9c