Commits · 2e660d5627c8ef47daa2be82fa359baee13ab640 · Chen Yisong / angle

15 May, 2014 9 commits

Use lowercase d3d header includes to fix ANGLE compilation on case sensitive OSes · 2e660d56

authored May 12, 2014

The actual D3D header filenames are all lowercase.

Change-Id: I8f78d618d44360d34b5b01eb5a1972b35f2f15b7
Reviewed-on: https://chromium-review.googlesource.com/199692Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

2e660d56

Add READ/DRAW_FRAMEBUFFER_BINDING_ANGLE to getQueryParameterInfo · 1e514358

authored May 13, 2014

Change-Id: I3e7f5cb0b4d2829eef86b878ffede0ac86279f57
Reviewed-on: https://chromium-review.googlesource.com/199684Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1e514358

Fix code style violation in compiler/preprocessor · d526f989

authored May 13, 2014

BUG=angle:650
TEST=no behavior change

Change-Id: Ib52f15f6471fc7897b66d11baee11216cf08158a
Reviewed-on: https://chromium-review.googlesource.com/199591Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

d526f989

Track if uniform data has been updated to avoid extra Map calls. · ae1990c8

authored May 12, 2014

Compare all uniform data to the values currently stored in the uniform and
only mark the uniform as dirty if the data is new. This saves lots of
buffer map calls when the same data is set on a uniform many times.

BUG=260069

Change-Id: Ic4df8a276a81b074211712ff50e5cc4d0d9bb612
Reviewed-on: https://chromium-review.googlesource.com/199346Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ae1990c8

Remove references to software rendering in Renderer9. · 64c83249

authored May 06, 2014

BUG=angle:641

Change-Id: I3724c2504d43eae0528e8c72eb51e96c9d7c7a71
Reviewed-on: https://chromium-review.googlesource.com/198377Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

64c83249

Minimize the API calls done by InputLayoutCache::applyVertexBuffers. · f98e63a5

authored May 12, 2014

Reduce the number of IASetInputLayout calls to 1 in all cases and set the
fewest number of buffers at once.

BUG=260069

Change-Id: I059337fc6601ecefd801ef37546935becaa0d355
Reviewed-on: https://chromium-review.googlesource.com/199345Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f98e63a5

Optimize Texture*::updateStorage by iterating over fewer levels. · 946b948d

authored May 12, 2014

Only update the storage on levels that exist.  Especially helps for cube
maps which have 90 images that would be iterated over in all cases.  Added
an additional early-out check if the image is dirty for cube maps to match
the other texture types.

BUG=260069

Change-Id: I3d298f4f9ebdc23136a31138a3ef8364667fa78c
Reviewed-on: https://chromium-review.googlesource.com/199344Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

946b948d

Split register allocation of varyings from the translator. · ff0d2ba6

authored May 14, 2014

The translator gl::Varying struct does not need to know about register
allocation. We can put that entirely in the API library. This makes
exposing Varying variables with the new translator types cleaner.

BUG=angle:466

Change-Id: Ib85ac27de003913a01f76d5f4dc52454530859e6
Reviewed-on: https://chromium-review.googlesource.com/199736Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

ff0d2ba6

Remove gl::Varying::elementIndex. · 4f8fcc24

authored May 14, 2014

We only assigned to elementIndex, and never referenced the value
at any point in our code.

BUG=angle:466

Change-Id: I541a353110bcd1863b07b21bcf21fad38be19ca1
Reviewed-on: https://chromium-review.googlesource.com/199735Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4f8fcc24

13 May, 2014 4 commits

Revert "Fix binary serialization to use explicit size and type." · 11c3b30f

authored May 13, 2014

This reverts commit 26198851.

Change-Id: I959ca14fcbb257f12005f7f0b64a600e906a118c
Reviewed-on: https://chromium-review.googlesource.com/199630Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>

11c3b30f

Attempt an Mac build fix · c8f7232e

authored May 13, 2014

BUG=
TEST=mac bots build on GPU.FYI

Change-Id: I3dd2b07702e8c0a40d64ab973eb969ba50954640
Reviewed-on: https://chromium-review.googlesource.com/199611Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

c8f7232e

Fix code styles in OutputGLSLBase, SymbolTable, and Types. · 9eedea03

authored May 12, 2014

I came across these three classes in the last CL, so do some
cleanup as I touched these classes.

BUG=
TEST=webgl conformance, no regressions

Change-Id: I2819bab5965fcb4917f85c2eded571a7f95ab9a2
Reviewed-on: https://chromium-review.googlesource.com/199423Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

9eedea03

Fix missing <algorithm> include. · 487456a3

authored May 13, 2014

Change-Id: Id6952fa07223217c9dde6798d3ea701b49e6089e
Reviewed-on: https://chromium-review.googlesource.com/199313Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

487456a3

12 May, 2014 7 commits

Regenerate public projects. · 0f55498b

authored May 12, 2014

BUG=angle:618

Change-Id: I516ad4a5639b021fb467aa7c7889a5f9f9bf4b33
Reviewed-on: https://chromium-review.googlesource.com/199342Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

0f55498b

Fix nested struct scope support in GL backend. · 904a9164

authored May 09, 2014

Basically we should be able to reuse a struct name once the previous
use is out of the scope, or we can reuse it if we are in a inner scope
than where it is defined before.

BUG=368910
BUG=angle:618
TEST=conformance/glsl/bugs/nested-structs-with-same-name.html

Change-Id: Icfac76b844deaca0c8a0501d7426ff3802e657dc
Reviewed-on: https://chromium-review.googlesource.com/199137Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

904a9164

Fix binary serialization to use explicit size and type. · 26198851

authored May 12, 2014

Loading program binaries across different architectures would cause
runtime errors due to use of size_t.

Also fix the ANGLE major and minor version that were clobbered in an
earlier commit.

BUG=angle:647
BUG=371435

Change-Id: If2ad4c8fc246cc9ff0b4d95ba87b7d1ed109a064
Reviewed-on: https://chromium-review.googlesource.com/199102Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

26198851

Attempt skipping D3D11 shader optimization if compilation fails. · 2c27db6f

authored May 10, 2014

BUG=angle:648,chromium:371868

Change-Id: I1de854aad6e002bd1349f08eb8d6b597c535c90b
Reviewed-on: https://chromium-review.googlesource.com/199312Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Brandon Jones <bajones@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2c27db6f

Attempt skipping validation if D3D11 shader compilation fails. · 1408bae6

authored May 10, 2014

Some shaders fail to compile with validation error messages that make no sense.

BUG=angle:648,chromium:372016

Change-Id: Ief0e28efa6bc7eaa483c95f45c00ce4f9f20e541
Reviewed-on: https://chromium-review.googlesource.com/199311Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

1408bae6

Refactor attempting shader compilation with different flags. · 93faad9f

authored May 10, 2014

BUG=angle:648

Change-Id: Ie340eaa708820cc13be6d1f5ba04555b6c1918ea
Reviewed-on: https://chromium-review.googlesource.com/199310Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

93faad9f

Fix D3D11 'units' polygon offset bias. · aea8e947

authored May 09, 2014

D3D11 DepthBias is an integer corresponding directly to GL polygon offset units.

BUG=371604

Change-Id: I20a126bd9c6298efff95f3edbf1babc0dd495b18
Reviewed-on: https://chromium-review.googlesource.com/199200Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

aea8e947

09 May, 2014 2 commits

Fix D3D11 polygon offset. · 5075e13b

authored May 09, 2014

We were not taking the state of GL_POLYGON_OFFSET_FILL into account.

BUG=371604

Change-Id: I9b490ed043faeece86665acaef0b865bf1f7b60d
Reviewed-on: https://chromium-review.googlesource.com/199121Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Nicolas Capens <nicolascapens@chromium.org>

5075e13b

Shaders should fail compile if a boolean's precision is specified · ed14b79d

authored May 08, 2014

Tested and no regression on WebGL conformance 1.0.3

BUG=angle:628
BUG=368874
TEST=http://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/misc/boolean_precision.html

Change-Id: Ie74616c3ab846eea19f4bd4a041fc0f00d55f151
Reviewed-on: https://chromium-review.googlesource.com/198884Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

ed14b79d

08 May, 2014 5 commits

Fix BufferStorage11::getLatestStorage not finding the latest buffer. · 7b827596

authored May 08, 2014

If there are only buffers with data revision 0, getLatestStorage will skip
over them.  Fixed the if statement so that it will always find a buffer if
one exists.

BUG=angle:644

Change-Id: I24fc426383c9ae18b7ccf2f8937a9daa7a071ebe
Reviewed-on: https://chromium-review.googlesource.com/198826Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

7b827596

Add support for querying GL_MAX_VARYING_COMPONENTS. · d3ff9009

authored May 08, 2014

BUG=angle:645

Change-Id: I2e33798bd7fe6cabb1237224aeb9e59cdf03f73c
Reviewed-on: https://chromium-review.googlesource.com/198836Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d3ff9009

Implement copies from pack buffers to native buffers. · 5fedd017

authored May 08, 2014

Full support for using pack buffers as vertex buffers or other
binding points requires us to copy through the staging buffer.

BUG=angle:511

Change-Id: Ife0f5390a1a83dfbe0fa0b19db72f3a8b82b6b83
Reviewed-on: https://chromium-review.googlesource.com/198435Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

5fedd017

Implement internal copies from pack buffers. · 14764a09

authored May 08, 2014

Pack buffers used in different binding points when combined
with other buffer operations require us to be able to read
from the pack buffer then write to the native buffer.

BUG=angle:511

Change-Id: I2e859695235eb649ddd5dfc1332ecb19b57c1933
Reviewed-on: https://chromium-review.googlesource.com/198434Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

14764a09

Fix regression with BufferStorage11 and latest storage. · 235a6ab5

authored May 08, 2014

With our fix to huge buffer allocations, an extra check was preventing
pixel pack from running on the first try.

BUG=angle:511

Change-Id: Idabafe4e204ad3b7bf2010595dc455affe93dae0
Reviewed-on: https://chromium-review.googlesource.com/198825Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

235a6ab5

07 May, 2014 6 commits

Add a DXGI format for GL_LUMINANCE16F_EXT in ES3. · b69d39ba

authored May 06, 2014

BUG=angle:642

Change-Id: I41eb64b8e9963cfe33e4c127f84a16eef9b118d3
Reviewed-on: https://chromium-review.googlesource.com/198379Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

b69d39ba

Move the implementations of shader var init to the header. · 07d68856

authored May 06, 2014

Making the contructors for shader variables inline saves us from
exporting them across DLL boundaries. This makes it easier to use
them in the translator when building the translator as a DLL.

BUG=angle:466

Change-Id: Iee0556e06dc1f9e98fe9eea6577819305de0dd0b
Reviewed-on: https://chromium-review.googlesource.com/198555Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

07d68856

Replace libEGL catch bad_alloc clauses with ellipses. · d127d8e6

authored May 06, 2014

Since we incur some kind of type confusion that stops us from properly
catching bad_alloc exceptions generated when compiled with exceptions
or when ANGLE is compiled with C++ exceptions, use catch-all clauses.

BUG=angle:634

Change-Id: I6d6efbf1fc7a4ebf8f13150b2814bfcd5edaad91
Reviewed-on: https://chromium-review.googlesource.com/198421Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

d127d8e6

Adds the PBO extension test · 6b6fd54a

authored May 06, 2014

BUG=angle:581

Change-Id: I50a1181d0547c5629c9037f6d8e989c505c7e5ed
Reviewed-on: https://chromium-review.googlesource.com/198239Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

6b6fd54a

Advertises the NV_pixel_buffer_object extension · 6667f76b

authored May 06, 2014

BUG=angle:581

Change-Id: I1e55582e94a36e56ef3e0f53ff9233c1a31408f5
Reviewed-on: https://chromium-review.googlesource.com/198238Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

6667f76b

Adds PBO buffer targets when extension is present · 158c4384

authored May 06, 2014

BUG=angle:581

Change-Id: I125cdd995e538db4a275657770149071406a6ad1
Reviewed-on: https://chromium-review.googlesource.com/198237Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

158c4384

06 May, 2014 7 commits

Adds conversion for USHORT2N decltype · 334f19b7

authored May 06, 2014

BUG=angle:643

Change-Id: I90a5e5c91351b9dd43a841cc5612f3f3656dc5b1
Reviewed-on: https://chromium-review.googlesource.com/198233Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

334f19b7

Handle buffer memory allocation failures gracefully. · 80b9528d

authored May 06, 2014

When we would allocate huge buffers, we would not always gracefully
fail and return a GL error back to the application. We should be able
to better handle buffer allocation failures with this patch.

BUG=angle:634

Change-Id: Ic3edce6d22b731ec52666a2a0e82f9a4fbbb23ae
Reviewed-on: https://chromium-review.googlesource.com/197994Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

80b9528d

Store current pack operation as a queued command. · 2b5c9cbc

authored Apr 29, 2014

The pack pixels operation is split in two halves: a GPU
copy then a CPU readback. We defer the CPU readback until
we can't wait any longer. That is, we do the readback when
the user maps the buffer, or there's another readback or
internal operation.

This offers the benefits of doing as much GPU work as
asynchronously as possible, and only doing the readback
work on related API calls (map or subsequent pack calls).

BUG=angle:511

Change-Id: I95a01da2b0e842438b180e8cdbb382c9a46ae210
Reviewed-on: https://chromium-review.googlesource.com/197836Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2b5c9cbc

Stop generating duplicate vertex binaries. · 7a29e4ae

authored May 02, 2014

We would generate multiple vertex binaries that result in the same
HLSL code, eg for vec2 and vec3 vertex attributes. Eliminate
duplicates by using the converted attribute type for testing
for matching binaries.

BUG=angle:599

Change-Id: I061588164577ff9fa69ebb7d8a3f2bf6bb6fe013
Reviewed-on: https://chromium-review.googlesource.com/197830Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

7a29e4ae

Replace catch blocks from std::bad_alloc to ellipses. · de0ec75e

authored May 05, 2014

It seems we weren't catching bad_alloc despite using the correct syntax.
Using ellipses solves the problem, and since we only expect bad_alloc
it does the equivalent result of catching and returning out of memory.

I'm currently not aware of the proper syntax to catch bad_alloc.

BUg=angle:634

Change-Id: Ib3154546d1b72d180cb565c71f35716696863cdd
Reviewed-on: https://chromium-review.googlesource.com/198245Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

de0ec75e

Use a static function instead of a static initializer for defaultBlockInfo. · cc14f104

authored May 05, 2014

BUG=angle:640

Change-Id: I5fe568c9a2b492a5bd8a42142762229c5f992c7e
Reviewed-on: https://chromium-review.googlesource.com/198248Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

cc14f104

Add tests for pack buffer corner cases. · 8a7bed8c

authored May 01, 2014

BUG=angle:511

Change-Id: I72ff4f8fa83d9dda4d186d727035085ecc39a9dc
Reviewed-on: https://chromium-review.googlesource.com/197703Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

8a7bed8c