Commits · 34e287786a4e7bb1d2b7d0cc76ac19b5ca156d5f · Chen Yisong / angle

22 Mar, 2021 9 commits

Reorder ShaderVariable functions and members · 34e28778

authored Mar 17, 2021

ShaderVariable's functions and members are all mixed up. This CL
reorders things to move the functions before the members, to better
match ANGLE's coding style.

This also adds a note that any new members that are added need to be
added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are
actually implemented in Program.cpp, since ShaderVars.h/cpp can't
include libANGLE/BinaryStream.h. There are currently several members
that are missing, leading to save/load errors, which are fixed in a
follow-on CL in this chain.

Bug: b/182409935
Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

34e28778

Handle inactive structure type varyings correctly · 2be71410

authored Mar 19, 2021

Correctly handle inactive varyings of structure type when collecting
transform feedback varyings. Previously, all varyings of structure type
were marked as active by mistake.

Bug: angleproject:5557
Test: TransformFeedbackTest.InactiveStructureVarying*
Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

2be71410

Vulkan: Handle compilation error involving gl_InvocationID · 570970f9

authored Mar 19, 2021

We need to generate a compiler error only when the vertex index
of an output variable as an l-value, in a tessellation control shader,
is not the indentifier gl_InvocationID.

Bug: angleproject:5557
Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier
Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

570970f9

Vulkan: Rename onImageHelperRelease to finalizeImageLayout · 81432c24

authored Mar 19, 2021

Make the API name reflect what it does. With recent changes, this get
called from places that are not releasing ImageHelper object, but is try
to reference the current layout. This new name makes more sense than
onImageHelperRelease (at that time when this API was introduced, it was
only called when ImageHelper is being released).

Bug: b/175584609
Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

81432c24

Vulkan: More cleanups to perf counters. · 02acc5ee

authored Mar 18, 2021

This refactors the pipeline type in the ContextVk class to also use
a packed enum map. It also expands the object perf counters to store
both a specific and cumulative version for use in different cases.

Bug: angleproject:5736
Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

02acc5ee

Tests: Add Avakin Life - 3D Virtual World trace · ecbd870f

authored Mar 21, 2021

Test: angle_perftest --gtest_filter="*avakin_life*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/183344915
Bug: angleproject:5779
Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

ecbd870f

Skip ResizeWindow test on Linux. · 0380f115

authored Mar 18, 2021

ARM Linux doesn't support window surface resize.

Bug: angleproject:4453
Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0380f115

Vulkan: Don't acquire new BufferHelper for external buffers · 7fe44a53

authored Mar 20, 2021

EXT_external_buffer spec -
    This extension allows the data store for an immutable buffer to be
    sourced from an external EGLClientBuffer, allowing sharing of EGL
    client buffers across APIs, across processes, and across different
    processing cores such as the GPU, CPU, and DSP.

The intent is for a single backing memory to be reused across various
processes and processors. Ensure that a glBuffer backed by external
memory does not orphan the memory when glBuffer APIs like
glBufferSubData or glMapBufferRangeEXT modify the glBuffer.

Bug: angleproject:4380
Bug: angleproject:5073
Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan
Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7fe44a53

Roll Chromium from c33e21cce932 to 3eced2421f5a (477 revisions) · 7e9b497c

authored Mar 22, 2021

https://chromium.googlesource.com/chromium/src.git/+log/c33e21cce932..3eced2421f5a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba8be7fd2f..120a8d610c
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/55b74c093b..f13f2e366c
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..999f35f30e
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9629038820..24cecabb89
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4e23350e..c94714a14b
* tools/skia_goldctl/linux: GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC..PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC
* tools/skia_goldctl/mac: 0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC..Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC
* tools/skia_goldctl/win: _LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC..3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: Ia49b1a9a909ceea201b65fd2f8d823e967a90ffa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776747
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7e9b497c

21 Mar, 2021 1 commit

Add multi-thread/context test for compute shaders · 90cf278c

authored Mar 19, 2021

The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts
shared a VkCommandBuffer.  The one context was used by one thread for
rendering, and the other context/thread dispatched compute shaders.
When the rendering thread destroyed a VkCommandBuffer, future compute
dispatches crashed because the new VkCommandBuffer didn't have a
compute pipeline bound.

Bug: b/181711029
Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

90cf278c

20 Mar, 2021 1 commit

Disable EGL_EXT_buffer_age for SwiftShader Vulkan · 135385a1

authored Mar 19, 2021

Cuttlefish with SwANGLE failed to pass the android.graphics.cts.
BitmapTest#testDrawingHardwareBitmapNotLeaking test, due to a timeout in
dequeueBuffer (error = -110) during an EGL_BUFFER_AGE_EXT surface query.

This change conservatively works around the issue by leaving
EGL_EXT_buffer_age support disabled for SwiftShader.

Further investigation is required to check whether this timeout can also
occur with other Vulkan drivers, and if it can be addressed robustly.

Bug: b/182521420
Bug: angleproject:3529
Change-Id: I54e3767e74bf922f273d8860f9f4cfc8b6589536
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774030Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Nicolas Capens <nicolascapens@google.com>

135385a1

19 Mar, 2021 9 commits

Vulkan: Add VUID-vkCmdDraw-None-04584 validation error to ignore list · d5bc8a27

authored Mar 17, 2021

Aztec ruins is using the same texture (but different level controlled by
a uniform variable) for textureLod and rendering. This triggers vulkan
validation error. This CL put it in the ignore list so that it can pass.

Bug: b/175584609
Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d5bc8a27

Vulkan: Track images used for both attachment and sampler · 867411a4

authored Mar 08, 2021

This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We
detect that the same ImageHelper object is used for both sampler and
attachment and will pick this new layout instead of ColorAttachment.

Bug: b/175584609
Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

867411a4

Add isYUV to angle::Format · 5163cd0c

authored Mar 18, 2021

In preparation for adding support for more YUV formats
add an 'isYUV' field that tracks whether a format is a
YUV format. For now it is set if the format string contains
the substring 'PLANE'. This is not the case for all known YUV
formats but the condition can be expanded when required.

Bug: angleproject:5773
Change-Id: Icb574037dc8105584931835dab0b60e8bafa3262
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774762Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

5163cd0c

Vulkan: Defer color image layout changes at endRenderPass time · da437f26

authored Mar 08, 2021

Right now color render target's image's layout change are done at
beginRenderPass time. The problem is that the layout also depends on
whether texture is also being used as a sampler or not. That information
is not known when renderpass starts. We did some special treatment for
depth stencil attachment so that its layout determination is deferred
until endRenderPass time. This CL expands that same mechanism to color
attachment as well. Right now the color attachment will still pick the
same ImageLayout::ColorAttachment layout since the logic to detect it is
also used for texture sampling is not there yet.

Bug: b/175584609
Change-Id: Id7486174d475f894461578b31d0d40fdd90e808a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744121Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

da437f26

D3D: Mark images dirty after recovering from storage · 0a80f2e1

authored Mar 15, 2021

When images are recovered from storage due to resizing storage, they
were marked as clean and not always re-copied to the new storage.

Bug: angleproject:5757
Bug: chromium:1188854
Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Alexey Knyazev <lexa.knyazev@gmail.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

0a80f2e1

Roll vulkan-deps from 6ea3512e6349 to 91a2a0b15f23 (6 revisions) · 5067fccf

authored Mar 19, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/6ea3512e6349..91a2a0b15f23

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d18bcd64fa..979319b9b1
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f498774db..a732e4c03c
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d5bf0be344..309d9bea09

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ifb1845a82a8ae3c3cd19e7023bb20048a6486ff3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774761
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5067fccf

Roll Chromium from e7ef5f7d0368 to c33e21cce932 (451 revisions) · 15a1e735

authored Mar 19, 2021

https://chromium.googlesource.com/chromium/src.git/+log/e7ef5f7d0368..c33e21cce932

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/17a38f4bb2..ba8be7fd2f
* buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c93be42a40..4e078437d0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/3b69bfd940..55b74c093b
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8e820e32d0..74cb518d98
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/168ccba7af..9629038820
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98db359fc..df4e23350e
* tools/skia_goldctl/linux: NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC..GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC
* tools/skia_goldctl/mac: Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C..0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC
* tools/skia_goldctl/win: 3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC.._LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I36906d996c7474ebf61c329ad7622f32c00ec960
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774452
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

15a1e735

Tests: Add Ragnarok M: Eternal Love trace · 9b3b5733

authored Mar 17, 2021

Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*"
TBR: timvp@google.com,jmadill@google.com
Bug: b/181800519
Bug: angleproject:5772
Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

9b3b5733

Fix the assert error and inbalence parens for SSBO · ba0bd785

authored Mar 15, 2021

This PR strengthens below two cases:
1. Support calculate unsized array size for any type. Previously,
it reported error when the type was a structure.
2. Correctly add the right paren for store function when any
load/length functions are nested in it.

Bug: angleproject:5734
Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

ba0bd785

18 Mar, 2021 8 commits

Vulkan: Use packed enum map for descriptor set index. · b717952e

authored Mar 18, 2021

This simplifies a lot of the data structure indexing in the program
executable class. Also renames the "DriverUniforms" and
"InternalShader" index into a single "Internal" index.

Bug: angleproject:5736
Change-Id: I2a51d8b14d5b16b438dbe636f77b11bbc045ba9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773321
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

b717952e

Vulkan: Clean up shader buffer DS allocation. · 1b08cfcb

authored Mar 18, 2021

We were using repeated code patterns in several places.

Bug: angleproject:5736
Change-Id: I206783dd792c3b0f9d38027235445ec600a60d88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773320Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1b08cfcb

Vulkan: Move CommandBufferHelper::reset() closer to constructor · 378b3261

authored Mar 08, 2021

This is a mechanical change. Similar to constructor, the reset()
function is doing initialization of data members. Move them next to each
other helps adding a new data members which requires modifications to
both functions.

Bug: b/175584609
Change-Id: I11386677bc5c9838104025d6a4ecf6f2b58fa92c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745842Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

378b3261

Vulkan: Test render and sample the same texture but with different LOD · 1f1b4ffe

authored Mar 08, 2021

This simulates aztec ruin's usage. This works properly on native OpenGL
but generates validation error on vulkan backend and renders incorrect
as well.

Bug: b/175584609
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD
Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

1f1b4ffe

scripts: Ignore "rapidsjon/..." when checking includes · f201c9d2

authored Mar 17, 2021

These include stubs are given in the comments within
rapidjson.h and are preported as error by the presubmission
check.

Bug: angleproject:5765
Change-Id: Ic200a860de7337aefcd3bb0f82686d62a1349d89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765648Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>

f201c9d2

Roll Chromium from 60fea25f23e6 to e7ef5f7d0368 (472 revisions) · 57d8b3e1

authored Mar 18, 2021

https://chromium.googlesource.com/chromium/src.git/+log/60fea25f23e6..e7ef5f7d0368

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/37b76d6fba..17a38f4bb2
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/2408fca90b..3b69bfd940
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/752611e5f2..168ccba7af
* tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
* tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
* tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/67f01522b1..c98db359fc
* tools/skia_goldctl/linux: 3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC..NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC
* tools/skia_goldctl/mac: TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC..Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C
* tools/skia_goldctl/win: wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC..3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC
No update to Clang.

Bug: angleproject:2424,angleproject:2880,angleproject:2994,angleproject:3033,angleproject:3753,angleproject:4377,angleproject:5014
Tbr: timvp@google.com
Change-Id: Ib964474c19e613fedb9ab3ac0d474fc1829289ab
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770687
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

57d8b3e1

Roll vulkan-deps from 105af117f053 to 6ea3512e6349 (13 revisions) · 39296f39

authored Mar 18, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/105af117f053..6ea3512e6349

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b2e5b5c559..d18bcd64fa
* spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/faa570afbc..bcf55210f1
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/478754c005..4f498774db
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/053e2bf22d..d5bf0be344

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I190a577538fb3a2178c1e82f1c9fc4e52749a322
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770144
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

39296f39

Fix immutable texture base level validation · bb7c1442

authored Mar 17, 2021

Jeff's new rendering feedback loop test
(https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of
issues with texture base level validation. For immutable textures the
base level is clamped to the valid range, so setting an out of range
base level does not make an immutable texture sampler incomplete, and
we need to use the clamped value when checking for rendering feedback
loops.

Bug: angleproject:5768
Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

bb7c1442

17 Mar, 2021 7 commits

Tests: Add June's Journey trace · f6eccc20

authored Mar 12, 2021

Test: angle_perftests --gtest_filter="*junes_journey*"
TBR: jmadill@google.com,timvp@google.com
Bug: b/182566407
Bug: angleproject:5752
Change-Id: I083507949c9bc16bf701028a678540df9a3531dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

f6eccc20

Use bitset masks for active shader buffers. · 716b2cba

authored Mar 12, 2021

This switches the tracking for the uniform, shader storage, and atomic
counter buffers to use bitset masks to determine where there are
active buffers. This will make iterating these buffer sets faster.

Also renames the limit for atomic counter buffers to be consistent
with the other buffer types.

Also applies the implementation limit to atomic counter buffer
bindings. This fixes out-of-bounds access on some Linux platforms that
expose a large number of bindings.

Bug: angleproject:5736
Change-Id: Ice801645697592d1dda6aebf0cb69767594cc0c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757509
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

716b2cba

Reland "Vulkan: Support EXT_sRGB_write_control" · 81dcf078

authored Mar 08, 2021

This is a reland of 6073af53
with 2 changes -
1. Don't enable the extension even in nonConformant mode
2. Don't enable VK_KHR_image_format_list for swiftshader

Original change's description:
> Vulkan: Support EXT_sRGB_write_control
>
> Implement support for EXT_sRGB_write_control. This extension
> requires VK_KHR_image_format_list to be supported.
>
> The spec requires this functionality to work with glBlitFramebuffer
> as well but support for that will be added in a follow up change.
> As such, this extension is only exposed in non-conformant mode.
>
> Bug: angleproject:5075
> Tests: SRGBFramebufferTest.*Vulkan*
> Change-Id: I59b38f6cd810a3d0d67ec29f4f19c25f65f70862
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2617243
> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:5075
Change-Id: I8e149d196a39c3c4769bfa8690792f3c53831299
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762647Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>

81dcf078

Vulkan: Fix missing dirty bits for compute · 629f66ce

authored Mar 16, 2021

In the following scenario:

- Dispatch
- Flush outside render pass commands
- Dispatch

The second dispatch doesn't rebind the pipeline because it assumes it's
recording to the same primary command buffer.

This assumption is broken if another thread causes a submission before
the second dispatch.  It's also broken if using Vulkan secondary command
buffers.

Bug: b/181711029
Change-Id: I5335be95208f41724cf8e9c60ae5322ad91840fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763143Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

629f66ce

Roll SwiftShader from 69b79eec6533 to a98fb3f8380a (2 revisions) · 3eace05c

authored Mar 17, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/69b79eec6533..a98fb3f8380a

2021-03-17 swiftshader.regress@gmail.com Regres: Update test lists @ a0aeb64e
2021-03-16 capn@google.com Fix multiview renderpass queries

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I51bac967310d157a97f02dae659afd156973e565
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2766413
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3eace05c

Reland "Add support for Linux GPU info with Vulkan backend" · 9a839732

authored Mar 03, 2021

This is a reland of 5c09c1f8

Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile
variable for GetSystemInfoVulkan() in linux platform.

Original change's description:
> Add support for Linux GPU info with Vulkan backend
>
> 1. Add support for Linux GPU info with vulkan backend: for
> dev board without PCI support, try vulkan backend to get
> GPU info.
> 2. Fix getVulkanInstance() issue when loading non-exist lib:
> return NULL instance if open lib failed.
>
> Bug: angleproject:5717
> Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5717
Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9a839732

Roll Chromium from cffad6044951 to 60fea25f23e6 (481 revisions) · b3394db3

authored Mar 17, 2021

https://chromium.googlesource.com/chromium/src.git/+log/cffad6044951..60fea25f23e6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/03e56ea015..37b76d6fba
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/962db0501f..2408fca90b
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..629e117d9b
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/91db20bec2..752611e5f2
* tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e
* tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e
* tools/luci-go: git_revision:fd10124659e991321df2f8a5d3749687b54ceb0a..git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/e2946cfb97..67f01522b1
* tools/skia_goldctl/linux: jstGnw4Pyb9uiuH75QNEy3f6hJN7ET2TFiOVOUiMokcC..3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC
* tools/skia_goldctl/mac: F9PFp7kNc3dn_X7b1PYmPsEb3VMHDY-8pXiZ7WNi09MC..TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC
* tools/skia_goldctl/win: 5QaZrGtCcd9HFM-qeg4vP-CrEpvhqlZtkfwAtVBee2oC..wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I40046beb257703d83285249e3bd82d76e990b491
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2766582
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b3394db3

16 Mar, 2021 5 commits

Remove usages of obsolete Mac bots · 27e12398

authored Mar 12, 2021

Bug: angleproject:4483
Change-Id: I9d4d94d42ddab26b40e780ad04479ac470af7a52
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757517Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

27e12398

add cl entry points loader · 65586746

authored Mar 10, 2021

Bug: angleproject:5743
Change-Id: I61791f412e8dbc54878cd3791519ad1c4ee33399
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749595Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

65586746

Fix download_restricted_traces.py :: run_command() · 522d609b

authored Mar 16, 2021

run_command() was using the undefined variable 'cmd', rather than the
pass in parameter 'command'.

Bug: angleproject:5210
Change-Id: I5e80869b18b717835217ad14a562bb4d223d52c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765005Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

522d609b

Disable timestamp queries for some GPUs on Android · c99e405c

authored Mar 12, 2021

Copy some workaround from chromium.

Bug: chromium:702980,chromium:477514,chromium:462553,chromium:1178333
Change-Id: I9acb6ef49c91193a9e6bb03c6fc5eabf336cba9a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2756728
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

c99e405c

Roll SwiftShader from 5cdf55ff2084 to 69b79eec6533 (1 revision) · 79e39478

authored Mar 16, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/5cdf55ff2084..69b79eec6533

2021-03-15 adelva@google.com Disable named mmap usage for host/ndk Android

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ibdc669fee9d1bc6651d4afb234acbeda062c8ec2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762686
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

79e39478