Commits · 39ee36406c7b08bcd0ece5e5e2a992b59533fd47 · Chen Yisong / angle

13 May, 2021 13 commits

Translator: Fix struct/uniform separation w.r.t to arrays · 39ee3640

authored May 11, 2021

When a uniform of struct type was redeclared, the arrayness information
was not transferred.

Bug: chromium:1204861
Change-Id: Ic3f461a4aa349a73bc48568ee14b5418f0556238
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889599
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

39ee3640

Disable GL_EXT_shader_framebuffer_fetch_non_coherent on Arm/QCOM · b0c217ba

authored May 13, 2021

Thie is a shorter-term work-around to games not checking extensions
properly.

Bug: b/177320565
Bug: b/186643966
Bug: b/186783762
Change-Id: Ic348396db1d081925cd9747cdd9406f5929313b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894407Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

b0c217ba

Allow specifying GPU config on expectation check. · e601181d

authored May 11, 2021

When we load the expectations we can now specify the config at a later
point. This will make it easier to run test suites that use multiple
APIs, like angle_end2end_tests. We can instead specify the config when
we check the expectation.

Bug: angleproject:5951
Change-Id: I9607db093e4a459550a7cd6864b17adfa55e17f2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892273
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e601181d

Translator: Fix local var inits vs struct/uniform separation · c5e344b1

authored May 11, 2021

The declarations outside the global scope were being skipped in this
transformation, but if the initializer of a declaration referenced a
uniform struct that's being replaced, it should have been visited too.

Bug: chromium:1204861
Change-Id: Ie2a743126c785eb7d6e3542ba80faa4defc3509f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889598
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

c5e344b1

Capture/Replay: recreate the EGL window if contexts don't match · ee2f3302

authored May 12, 2021

In addition enable affected tests.

Bug: angleproject:5955
Change-Id: I4fb72e38a633daa4565d3c0ae7cddb6ace7226f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891775
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

ee2f3302

Roll Chromium from 3fb708290557 to b0687cb1f1ec (639 revisions) · 2303f19c

authored May 13, 2021

https://chromium.googlesource.com/chromium/src.git/+log/3fb708290557..b0687cb1f1ec

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com,jmadill@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/129bd6c0c0..5d8fd334d9
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/e72cd4587a..9b15350d89
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/43828a290e..fe582fda76
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..52e67e75f6
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6e5b0a5c45..f5c054ce53
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/c3edbeed8a..e3c17da190
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/53a9334ffe..06d525cc6f
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/luci-go: git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1..git_revision:d7393d163ecb11c44626b3b221f86efdd2861565
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/ac77520e0e..c4921c7a5b
* tools/skia_goldctl/linux: EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC..JUdOUf3QO1PSVW0LijuPE20E8IiVUgPjyUkhri9CrosC
* tools/skia_goldctl/mac: qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC..-HuOY2pAKikKFvM5odfgh_GYbDKBGhCeKfGoDG4W46sC
* tools/skia_goldctl/win: O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC..wL8AoIO8IDH7dKheA0iZneF9sE3DamLh6bBzj6I782oC
Clang version changed llvmorg-13-init-9302-g897d7bce:llvmorg-13-init-9881-g5dad3d1b
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f..06d525cc6f7770fe4aa305d73eb1fadc37865070/scripts/update.py

Bug: None
Tbr: timvp@google.com,jmadill@google.com
Change-Id: Iabcdb225075048bb3481d8cf516da157c330e2b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2893193
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

2303f19c

Add messages for framebuffer completeness errors. · bccb0d56

authored May 11, 2021

This also creates a common code path for all framebuffer
completeness errors (FramebufferStatus::Incomplete) which
helps for adding a debug breakpoint.

Bug: angleproject:5949
Change-Id: Ib102dbf86e020777e56c6dc6b78dda8ebdba2127
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2888110
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bccb0d56

Vulkan: Allow DynamicBuffer suballocation in BufferVk · e354ff1a

authored Mar 05, 2021

When allocations are made from DynamicBuffer, they suballocate from a
possibly larger BufferHelper.  In BufferVk, the offset of the
suballocation was discarded, which limited the use of DynamicBuffer to a
pool of small buffers.

This change applies any such offset that may arise from suballocations
everywhere, and makes BufferVk use a larger buffer size when the
GL_DYNAMIC_* buffer usage hints are provided.

Bug: angleproject:5719
Change-Id: I3df3317f7acff1b1b06a5e3e2bb707616a7d0512
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2738650
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e354ff1a

Remove teglAndroidUtil.cpp override · cb69b46a

authored May 12, 2021

The file was fixed in https://gerrit.khronos.org/c/vk-gl-cts/+/7296.

Bug: angleproject:5870
Change-Id: I46410985ef0e66f886a6ee2ba321725242e01ce7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892288Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

cb69b46a

Test Runner: Fixes to skipped tests. · 1d019f49

authored May 13, 2021

Uses a different token for skipped and not run tests in the json. The
token isn't standard but should only be visible when batches report
to the parent process that a test wasn't run. It shouldn't be visible
to the scripts that consume test results on the bots.

Also fixes the expected result for skipped tests to also be "SKIP".

Bug: angleproject:5951
Change-Id: I0bd7d13b2b25b583f9c42718786cb588bacd4bc6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894524Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

1d019f49

CL: device partitioning for front end and passthrough · b300dc52

authored May 09, 2021

Partitioning is the creation of sub-devices. Also add reference
counting for CL objects, which is needed now for sub-devices.

Also fix CL print format strings, since cl_ulong is actually
always 64 bit and not unsigned long.

Bug: angleproject:5904
Change-Id: I006699fad2f953ce312bca87c9b6362b5d77a18a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880665
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b300dc52

Add array bounds checks for WebGL shaders · b0d39ba2

authored May 12, 2021

WebGL shaders may contain OOB array accesses which in turn
cause undefined behavior, which may result in security
issues. This was detected as an UNKNOWN READ by UBSAN while
testing with SwANGLE.

Bug: chromium:1189110
Change-Id: I00f56e771ed0c675abb465fc3a3dc9d62ea8ed51
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892286Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

b0d39ba2

Roll SwiftShader from be169ef35238 to c4d054c6ad41 (2 revisions) · 9809122d

authored May 13, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/be169ef35238..c4d054c6ad41

2021-05-12 capn@google.com Work around MemorySanitizer scalar SSE false positives
2021-05-12 capn@google.com Work around MemorySanitizer movmsk false positives

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I01cfd7f45b12c27615f6931a26de0407383ff2f4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894130
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9809122d

12 May, 2021 8 commits

Revert "Change to module directory when loading swiftshader ICD." · 25b53ceb

authored May 12, 2021

This reverts commit 3b10dda6.

Bug: angleproject:5954
Change-Id: I6199dc099dbf42605bbfc549e39cb6477e67442c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891771
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

25b53ceb

Test Runner: Handle skipped gtests. · 9a219a14

authored May 12, 2021

GTEST_SKIP() allows us to skip tests using the GoogleTest APIs.
This CL updates our test runner code to handle these skips.

Bug: angleproject:5951
Change-Id: Idef5802c7c81bd92226f5a93281a1cea0f1b24ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2892272Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

9a219a14

Tests: Add Dr. Driving trace. · 1d1c4518

authored May 11, 2021

Test: angle_perftests --gtest_filter="*dr_driving*"
Bug: b/181871119
Bug: angleproject:5944
Change-Id: I0a95f91d68957840da7c99580db60472e44467a0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887286Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

1d1c4518

FrameCapture: Use gl*Separate functions only when required. · 51d02ca0

authored May 06, 2021

Use non-separate stencil and blend functions that do not
distinguish between front and back buffers or color and alpha,
if they apply.

This prevents capturing GLES2 functions on GLES1 contexts.

Bug: angleproject:5893
Change-Id: I8303ee5b279268ea9c21e2c6465e1b155d1cc54d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

51d02ca0

Roll SwiftShader from dcb33711bd4b to be169ef35238 (1 revision) · 57bc7ce1

authored May 12, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/dcb33711bd4b..be169ef35238

2021-05-11 swiftshader.regress@gmail.com Regres: Update test lists @ dcb33711

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: Ic3cd3631682b2cace3a6eed4ae0fe938766365fa
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891641
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

57bc7ce1

Tests: Add Summoners War trace. · 8af704bd

authored May 11, 2021

Skip the trace on Windows/Intel since it produces GL_INVALID_ENUM.

Test: angle_perftests --gtest_filter="*summoners_war*"
Bug: b/181870341
Bug: angleproject:5943
Change-Id: I99b551294eeb267311728fd6f566cd549f97e90d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887285Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

8af704bd

Roll Chromium from fff9d6fb8ddf to 3fb708290557 (495 revisions) · cf1064e6

authored May 12, 2021

https://chromium.googlesource.com/chromium/src.git/+log/fff9d6fb8ddf..3fb708290557

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/4ff4105cd8..129bd6c0c0
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/504fae9f10..43828a290e
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/93eae7d9dc..371f2bea4f
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..302ca09b2d
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cb17bc6028..6e5b0a5c45
* third_party/protobuf: https://chromium.googlesource.com/chromium/src/third_party/protobuf/+log/5243354177..66e0a5d62b
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/618ddecd59..c3edbeed8a
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/e76c8f17cf..53a9334ffe
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/luci-go: git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2..git_revision:37e5f238829f911f85b62d66670d2fbd88354ef1
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df10bb0bf8..ac77520e0e
* tools/skia_goldctl/mac: 5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC..qwctaMZfXlU0u7OsbxWgOY_sBjsUYhlqwjJRbAXX3oYC
Clang version changed llvmorg-13-init-7296-ga749bd76:llvmorg-13-init-9302-g897d7bce
Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/e76c8f17cf2833813d671674cd89f01f3a21e851..53a9334ffea6aa748ff6c1ce8a46e71a90e7bc9f/scripts/update.py

Bug: None
Tbr: timvp@google.com
Change-Id: Iff9b5446b67a948eeb60e1aa7aaacf0725714c05
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891629
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

cf1064e6

Roll VK-GL-CTS from dab93ea8f88c to 6498f4042d9f (9 revisions) · 14365e1d

authored May 11, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/dab93ea8f88c..6498f4042d9f

2021-05-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-05-06 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-05-06 juha.heiskanen@siru.fi Add TexSubImage2D format compatibility tests
2021-05-06 piotr.byszewski@mobica.com Rename all OperationId enum values
2021-05-06 juha.heiskanen@siru.fi Fix validation error 'InputNotProduced' in Amber tests
2021-05-06 rgarcia@igalia.com Decrease 3D image size in image atomic op tests
2021-05-06 venni.ihanakangas@siru.fi Fix interfaceTypeMismatch validation errors in Amber tests
2021-05-06 antto.makinen@siru.fi Add a batch of GraphicsFuzz coverage tests
2021-05-06 jari.komppa@siru.fi Cover array input to interpolateAtCentroid

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC timvp@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5952
Change-Id: Ic3a29ba2ae65ef1660c02b765a8fd767c6a5e133
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2890549Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

14365e1d

11 May, 2021 19 commits

Follow up on Vulkan headers update to 1.2.177 · 859ed396

authored May 11, 2021

Removing duplicate definitions in ANGLE.

Bug: angleproject:5905
Change-Id: Ie62ad39a1ebc0d8b0d2c005723f461bc7309eade
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889831Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

859ed396

Refactor CL platform object · 93aff937

authored May 08, 2021

Move GetPlatformInfo implementation from stubs to cl::Platform,
because stubs are meant to be small.
Also move CLPlatformImpl::Info instance to cl::Platform as it is
more efficient to be accessed from there, and more consistent with
cl::Device.

Bug: angleproject:5904
Change-Id: I4c0ba6390467d6ef357e38a5ef08f54b0a88d423
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880663
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

93aff937

Implement CL device object for front end and passthrough · e369a282

authored May 08, 2021

Bug: angleproject:5904
Change-Id: I17f6d10ed59c62fe9126d29b7de2c127c5d0039a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880662Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

e369a282

EGL: setup extension EGL_EXT_protected_content · d52ed4bd

authored Mar 25, 2021

Add extension to registry
Update hashes

Bug: angleproject:3965
Change-Id: Ie2808b8a599ae4adbf6f2f1d24db046799f594df
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2800412
Commit-Queue: Brandon Schade <b.schade@samsung.com>
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

d52ed4bd

infra: Switch Android ARM64 bots to compile-and-test. · cd535d2c

authored May 11, 2021

This will start to trigger tests on the Pixel 4 64-bit bots.

Patch Series:

1. http://crrev.com/c/2885381
2. http://crrev.com/c/2885346
3. This CL
4. http://crrev.com/c/2885384

Bug: angleproject:5941
Change-Id: Ib76fd27d0814896522aad84443f52b7f47566e85
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885383Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

cd535d2c

FrameCapture: Capture GLES1 specific states. · 4901ac64

authored May 06, 2021

Implement capturing GLES1 specific state by checking the difference to
the default state using getEnableFeature.

When getEnableFeature is called from a context version higher than 1 and
a GLES1 state is requested, an assertion is hit. Therefore the context
version needs to be determined before calling getEnableFeature.

Use the available isTextureTargetEnabled function to determine
GL_TEXTURE_2D and GL_TEXTURE_CUBE_MAP states in getEnableFeature.

Return false in isTextureTargetEnabled when mTextUnitEnables is empty,
so the vector is not accessed when not initialized, which was the case
for a default state.

Bug: angleproject:5893
Change-Id: I66ee41c3bf7a8e1f04a8a4ce0461fddc16f9a013
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877237Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

4901ac64

Vulkan: set DS layout before using it in the endRenderPass · 46a139ad

authored May 06, 2021

In CommandBufferHelper::endRenderPass(), we are checking depth stencil's
initialLayout to change storeOp to None if the layout is read only. But
the layout was set after that check, which essentially voids the
optimization.  This CL moves the finalizeDepthStencilImageLayout() call
before the layout is used.

This CL also moves the depth stencil loadOp/storeOp to a new function
finalizeDepthStencilLoadStoreOp(). When depthImage gets deleted before
renderpass ends, we could also apply the same load/store optimization
just like we did at endRenderPass() time.

Bug: b/187425444
Change-Id: I89814274352f09cbf1f7b58a91bbaf131b983fb1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877933Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

46a139ad

infra: Remove old TODO. · 6e3c5321

authored May 11, 2021

Bug: angleproject:5114
Change-Id: I3b7255cc06bffd177f0b5ee8cad12bf2aad3089e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885382
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

6e3c5321

Suppress MultithreadingTest.MultiContextClear on Linux+Nvidia · e19182ce

authored May 11, 2021

MultithreadingTest.MultiContextClear/ES3_Vulkan_NoVirtual is flaky on
linux-clang-rel NVIDIA, so it's being suppressed for now.

Bug: angleproject:5945
Change-Id: I9ef142c57b3fcf5224732edcea1650634ecc18ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2887905
Commit-Queue: Tim Van Patten <timvp@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

e19182ce

Change to module directory when loading swiftshader ICD. · 3b10dda6

authored May 05, 2021

When loading vulkan, we can be running from any directory. We need
to change to the module directory to ensure the swiftshader ICD is
loaded properly. For example, in some Chrome releases, libGLESv2.dll
and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe

Bug: chromium:1198567
Change-Id: I9e68927e512b239728fb2903d1a04702508a4948
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3b10dda6

infra: Add Android swarming spec placeholder. · 930db294

authored May 10, 2021

These will trigger tests on the Pixel 4 in standalone. For
now we do not specify any tests.

Patch Series:

1. This CL
2. http://crrev.com/c/2885346
3. http://crrev.com/c/2885383
4. http://crrev.com/c/2885384

Bug: angleproject:5941
Change-Id: Iad1bc27c316724b244fbfbf694f6e83fdf5c0507
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885381
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

930db294

FrameCapture: Don't capture shader functions on GLES1. · 83e5bb97

authored May 06, 2021

Since an internal default shader is created and captured here in the
GLES1 case, we need to check for the context version to skip capturing
glUseProgram and emit an update call in GLES1 traces.

Bug: angleproject:5893
Change-Id: Iac9bc05234fbc87c1f64264b5c12b9b117522bad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877236
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

83e5bb97

Roll vulkan-deps from d3354ebca460 to 055e71b2a367 (1 revision) · 125f128e

authored May 11, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/d3354ebca460..055e71b2a367

Changed dependencies:
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/5ef1ec1b87..0aca21bce7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I75ea4a8ae6a21e51b274f6a1dcff80c1aa924ab7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885449
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

125f128e

Roll SwiftShader from e260190edbd2 to dcb33711bd4b (3 revisions) · 07eaa8ee

authored May 11, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/e260190edbd2..dcb33711bd4b

2021-05-10 srisser@google.com Allow unrestricted depth bounds
2021-05-10 srisser@google.com Make clang-format-all.sh git aware
2021-05-10 sugoi@google.com Reduce size of SampledImageDescriptor

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: timvp@google.com
Change-Id: I3e0bdad486c078fa765c7a4ba980c89257cdbb11
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2886667
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

07eaa8ee

FrameCatpure: Move capturing default vertex attribs to function. · 078ebbcf

authored May 06, 2021

Don't capture these on GLES1, due to the unavailability of
glVertexAtrrib4fv.

Bug: angleproject:5893
Change-Id: Iafbc9219cfc0a0c1d0a55e112ee88d7180ed94f7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2877235
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

078ebbcf

FrameCapture: Add GLES1 support to CaptureVertexArrayData. · e40edf92

authored May 06, 2021

Implement CaptureVertexPointerES1 that captures specific GLES1 vertex
pointer functions depending on the attribute index.

Use GLES1 capture functions in CaptureVertexArrayData by detecting the
current context version.

Implement VertexArrayType function in GLES1Renderer to get a
ClientVertexArrayType enum from a vertex attrib index.

Bug: angleproject:5893
Change-Id: I442b2e29475ca817860388cafc120db90a0fb9c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2846838Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

e40edf92

DEPS: Add Android tombstone resolution dependencies. · eb91ebc9

authored May 07, 2021

Add third_party/android_platform and tools/python from the Chromium git
to satisfy dependencies for the build/android/tombstones.py script.

Bug: angleproject:5933
Change-Id: Ie19eec46c8cab208cde5064118ae655303e12fa7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2878848Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

eb91ebc9

Roll Chromium from 518c3462c0a9 to fff9d6fb8ddf (568 revisions) · e72fa36e

authored May 11, 2021

https://chromium.googlesource.com/chromium/src.git/+log/518c3462c0a9..fff9d6fb8ddf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC timvp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/9afdbde777..4ff4105cd8
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/af6ff0bdef..504fae9f10
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..1fbada9f29
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1039f6ca14..cb17bc6028
* third_party/r8: 9JovxpDv8ZqFl60_eHo4hT-Ez0CelcMCoM9Cv5UJMz4C..gXyBDv_fM87KnLcxvF5AGV5lwnm-JXIALYH8zrzdoaMC
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/eb9ce8c993..618ddecd59
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/dbcffda598..e76c8f17cf
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/luci-go: git_revision:91769f0e2541d15de294dfc780205e98b49f7431..git_revision:1b50bbe2f93441dd227ad6e6684fa9be4ab0dec2
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/d9766067a3..df10bb0bf8
* tools/skia_goldctl/linux: UV02xIZDvNaCcrummY2Hd5zNO4S7F3pl_ZatqFmeRboC..EWfIod1MP71b48GlHnS5Rv9JpBzeTRQ6viIPDfFUSFEC
* tools/skia_goldctl/mac: aG3drSoyskf8FOxdSDXo_p3ub85yK9mX_DmXJa605cUC..5o7ziB6qRrSdtYJwKop8-5OFmvVQcxuNkGY1DRYggMsC
* tools/skia_goldctl/win: OB_O_MOYSLYScAVrzlIsc9a0JIf54AiYzG1WNNSCtyIC..O2WsBEJgyjTsib6LvzoNqqXwfSylJFfTRxEKYr-IsocC
No update to Clang.

Bug: None
Tbr: timvp@google.com
Change-Id: I70f2c157f5165905a9d3aca98dfccb7768b87d0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885448
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

e72fa36e

Capture/Replay: reset CWD after the test ends · 2ba3763e

authored May 10, 2021

As suggested by Jamie

Bug: angleproject:5849
Change-Id: I3e548935a9119b7ca7ca392c50bcb0f58ae3e974
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882578
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2ba3763e