Capture is implemented mostly via code auto-generation. The capture
requires a bit of custom logic for each captured pointer parameter. We
handle this by using auto-generation to lay out the base template for
each GL call and then custom logic that uses ANGLE's internals to
know how much data to capture at which point. Client array pointers are
captured before each draw call.

Currently only GLES capture is supported. We write out cpp files and
an optional data file accompanying each cpp. For small data chunks we
inline them in the cpp files. For bigger chunks like texture data we
pack them into the data file.

Mid-execution capture is not yet supported. Configuring the capture is
currently only available by modifying the cpp sources. Both of these
features will be implemented in the future.

Bug: angleproject:3611
Change-Id: If6d5dac2f7bf363129d42ea9198162aef0d3a4ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1671904
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

- clarifies error for run_code_generation hashes.
- makes missing format or bug tag an error.
- check for spaces in bug tags.

Bug: angleproject:3659
Change-Id: I069e60d8acdf070961bdf342acf976ddd1138b1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689019
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Flaky hangs on Ubuntu 19.04

Bug: angleproject:3618
Change-Id: Iab85c94e90aec0f7b15fe0fbc14ae1a8d0734d48
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1689270Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

ANGLE tests try to load opengl32.dll from ANGLE directory instead of system
Bug: angleproject:3645
Change-Id: I3a8cea37252d13e915ff54ae6bbac920db16e4c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688544
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

in openGL32 proc table

Bug: angleproject:3652
Change-Id: I014fab19564972bc3bc27f733534fd3630af41b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688497
Commit-Queue: Clemen Deng <clemendeng@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

The no_gtest target wasn't sharing its header visiblity with the main
target. Fix this using public_deps.

Also rolls angle-internal to pick up MSVC build fixes.

Bug: angleproject:3654
Change-Id: I4aca1f167031c0b41d1a7f7ff4d7303a960e2839
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688500
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The functions weren't properly exposed from the
EGL_ANGLE_feature_control extension.

Bug: angleproject:1621
Change-Id: Ie91a18966a84db88d6a9a555e75cba8cea0a6521
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688498
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This allows us to return the Sync's label when validation fails for a
Sync related entry point.

BUG=angleproject:3643

Change-Id: I64e8a8855a2e3b51768c2b560fdc4696bb325351
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687120
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

New GLES3.1 vulkan tests were added to the bots. Add the results to the
ANGLE docs.

Bug: angleproject:3646
Change-Id: I503a00d38b570a1d8491acd8d1bac33723b2cbe4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688545Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Instead of storing type/size/normalized/pureInteger we instead store a
pointer to the angle::Format. This makes some code logic simpler and
will let us more easily check if a vertex attribute format changes in
calls to VertexAttribPointer or VertexAttribFormat.

This CL adds extra information to angle::Format to represent the vertex
format info needed. It also caches the channel count so that it can be
queried faster.

Also renames "Int" -> "Sint" in UtilsVk for consistency.

Bug: angleproject:3256
Change-Id: I5ef9b983dad8a58c341113c802500b89ce081566
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1684293
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/22683b409e6d..4b4b41a63499


Created with:
  gclient setdep -r ./third_party/glslang/src@4b4b41a63499

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I90385bd8f9286aba10ee3d17e73c74e699c42e9e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1688580Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Remove FAIL lines from expectations file.  After recent CLs have
landed, addtional dEQP tests are now passing on Windows.

Bug: angleproject:3190
Change-Id: I40e1f29b21d9d3bb450beac4e94377112175308a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1684226Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

To account for framebuffer flipping, `dFdy()` expressions
must be changed to:

    dFdy() * ANGLEUniforms.viewportYScale

Bug: angleproject:3487
Test: dEQP-GLES3.functional.shaders.derivate.dfdy.*
Change-Id: I38f25ba37fb8c5ae61cee5ac911df88ec4a93fef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678404
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This was removed with a previous commit to fix behavior of invariant
pragma overall, however, the flattening is still needed for the initial
translation step of webGL VSs.

This change restores the flattening as it previously existed, however it
is now only applied to VS outputs. FS inputs are no longer flattened as
the previous fixes preclude the need for that workaround any longer.

Bug: 980675
Change-Id: Ia3c0471e24cae2905eb0d7bde153091e4d3829b4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687788Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Tobin Ehlis <tobine@google.com>

It requires GLES 2.0+

This should help keep

src/tests/gl_tests/gles1/TextureParameterTest.cpp:

TextureParameterTest.NegativeEnum

green even if the extension is propagated to the frontend
from the underlying renderer.

Bug: angleproject:3639
Change-Id: I04118e060f38cb774a6897ee6ce035b540a3b60e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1686822Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>

Bug in UBOs over 65535 bytes is captured in the WebGL conformance test.
Add an ANGLE end2end test to capture this behavior.

Bug: angleproject:3388
Change-Id: I8151892d22b53a9100d26cceb124c13fdbfae844
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687116Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

- Serialize and deserialize completed shader source of
  program for saving out for glGetProgramBinary().
- Cleaned up some unnecessary includes in cpp files.
- Some refactoring within ProgramVk::ShaderInfo to minimize code
  duplication.
- Added ProgramVk::ShaderInfo::saveShaderSource and
  ProgramVk::ShaderInfo::loadShaderSource.
- Updated vk_caps_utils.cpp to enable getProgramBinary and add the
  GL_PROGRAM_BINARY_ANGLE program binary format. This follows the pattern
  for other backends.

Bug: angleproject:3216
Tests: dEQP-GLES3.functional.shader_api.program_binary*
       angle_end2end_tests --gtest_filter=ProgramBinaryTest*
Change-Id: I927a27aaf9aa3d7fac550819ee80d2676ec1d1be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1683099
Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Was skipped only on Vulkan, but it hangs on other backends too, like
D3D11.

Bug: angleproject:3629
Change-Id: I3a812d86e1765507fb03a58c6d10c6a48edc0f2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687124Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

DisplayWGL.cpp is loading the opengl32.dll in out/debug, as opposed to the system's opengl32.dll.
Want system's dll.
Bug: angleproject:3641
Change-Id: I764ef44a942a0a6c4dac7082f82ae0fd4d95a139
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687117
Commit-Queue: Clemen Deng <clemendeng@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

Since Ozone supports external target only
for images created with EGL_EXT_image_dma_buf_import

Started failing when Texture3D was enabled in
https://chromium-review.googlesource.com/c/angle/angle/+/1682782

Bug: angleproject:3188
Change-Id: I4131b51f16907d12088869b7ee02799ab1b39fec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1687980Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Also update test expectations for texture3D.

Bug: angleproject:3188
Change-Id: If8a8e0a83a86c48c2afb0c36534c1e9d4120fe47
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682782Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

Bug: angleproject:3188
Change-Id: Iac1408f8b91c6a6610a63cef236205b7dcdbd2c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682781Reviewed-by: Lingfeng Yang <lfy@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

This tests has flaky timeouts on the Win10 Intel HD Graphics 630 bot. I
can't reproduce them locally with Intel 530, so I'm going to skip the
test since it's testing unrelated behavior.

Bug: angleprojec:3629
Change-Id: I124d318a870a067f8d100275f9ab5f0a0d053bd4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682362
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

1. Write MaxActiveAttribLocation to the bitstream
2. Write Uniform Active shader info to the bitstream

Bug: angleproject:3216
Change-Id: I4f48f75de570b5fdce20e55caf62fa0d14d82646
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682745
Commit-Queue: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This perf test has quite different performance than the buffer-only
state change test.

Bug: angleproject:3256
Change-Id: I23aa08b87af371cbafa509803ae7f8cbe0ce1c58
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1684292Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3620
Change-Id: I4ef4ab3ee145e5ce9b1ebf0c2d61d0777db72c43
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1678405Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/73f010813812..22683b409e6d


Created with:
  gclient setdep -r ./third_party/glslang/src@22683b409e6d

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I9a8f278ce2d481006cd35b80e86bee6c9424986d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1686962Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e6e3e2ccc6a2..9702d47c6fe4


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@9702d47c6fe4

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: Ifc59637c3ddf90ca82677380d484a4d1fd7a4c45
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1686961Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

on Win NVIDIA GL.

Bug: angleproject:3636
Change-Id: If106efa79967fa88d2c67feb7f07309e613ab989
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1686740Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Additionally, fixes an issue where the read framebuffer was affecting
the render pass desc given to the pipeline.  This fix is included with
this CL as its test depends on glInvalidateFramebuffer.

This issue was revealed by 071d2a44 changing the order in which read and
draw framebuffers were synced.  Previously, read was synced first,
dirtying the pipeline and then draw was synced fixing it.  With the
order reversed, the read framebuffer is the last to changes the
pipeline, leaving it in an invalid state.

Bug: angleproject:3201
Bug: angleproject:3202
Change-Id: Ibebf732a3e3cc081e4865f79dcbaedb467fd9038
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682468Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

The draw-call path was outputting color unconditionally even though only
depth/stencil was written by the shader, causing flakiness.

Bug: angleproject:3200
Change-Id: I1b28e37160153863e7e6c2875c3002abf4ec176b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682729Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Replace some more HLSL hardcoded unique id tests suffix with regex

Bug: angleproject:3551
Change-Id: I4ed54092f9b2dda27702ba9412959ec3fb93a455
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1677408
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This patch is the first of a multistep process to upgrade JsonCpp
from its current legacy version to the latest version. A minor fix to
how Json::Value is used is included, as well as properly pulling in the
jsoncpp_config where jsoncpp is used, allowing for us to roll Chromium
while Angle uses the deprecated Reader/Writer classes.

After this patch is landed, the Angle dependency in Chromium can be
rolled as part of rolling JsonCpp, then Angle can update to the new
StreamWriter/CharReader classes.

Bug: 961513
Change-Id: Idd1d61270aa0a7e4a91983b4c22a24e2fdaafe49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682815Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4162de4bbfc5..73f010813812


Created with:
  gclient setdep -r ./third_party/glslang/src@73f010813812

The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=ynovikov@google.com

Change-Id: I953609167eabd1f81ff77e68aec5ead36d45b5ed
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1685015Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Also accompanying hand edits to validationES2.cpp and
Context.cpp to allow linking.

Bug: angleproject:3188
Change-Id: I89832265092fabc71bade464f0171d65038d8b0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1648454
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

This reverts commit 134d6eed.

Reason for revert: glmark2 is unable to start on Android-Q when using ANGLE as the driver.

Original change's description:
> Vulkan: pipeline cache not populated as blob cache is not set
> 
> 1. Use vkMergePipelineCaches in eglSetBlobCacheFuncsANDROID as
>    blob cache callbacks are set after eglInititalize.
> 2. Use a more proper way to save the cache data to disk.
> 
> Bug: angleproject:3318
> Change-Id: Ieb5d10ab93e7afb2aab4446b387d7f36c878a686
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1559671
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=syoussefi@chromium.org,jmadill@chromium.org,fei.yang@arm.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3318
Change-Id: I51e49bf103142e80b2c9028b3af6d3bb58cf6348
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1683820Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6ccb52b86492..e6e3e2ccc6a2


Created with:
  gclient setdep -r ./third_party/spirv-tools/src@e6e3e2ccc6a2

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=syoussefi@google.com

Change-Id: I2536e0c775a834e83d817af16092b2a40b7e2809
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682982Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Currently ANGLE vulkan query current window size every frame to detect
whether a swapchain recreation is needed, however profiling shows some
bottle neck on window size query on X11. So here removing the per frame
window size query and only depend the result of vkAcquireImage and
VkQueuePresent to detect a need for swapchain recreation.

Bug: angleproject:3535
Change-Id: I4ddf70b973d78dfcd5f8fab28e29e802edad1b2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1662759Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Ian Elliott <ianelliott@google.com>

These internal repos can hold confidential code. Also updates the GLES
1.0 conformance test configuration to pull data from angle-internal.

Bug: angleproject:3621
Change-Id: Ifb9d2a5014b0827a078cfdc85fb20c5f5335204f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1679992Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Missing some expectations for unimplemented features in GLES31 for the
KHR deqp tests. This suppresses them so the bots will run.

Bug: angleproject:3521
Change-Id: I962cf03032514d99753306d0db9c942a5124b98f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1682470
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>