- 09 Dec, 2019 7 commits
-
-
Jonah Ryan-Davis authored
Adds --deqp-egl-display-type=angle-metal for running the deqp tests on Mac. Note: does not add any test suppressions for metal. Bug: angleproject:2634 Change-Id: I8f8d3a83cf93a5b930b05af9f0075a9ce435823a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954612Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/2b89fd4e2734..0e57fc1cfa56 git log 2b89fd4e2734..0e57fc1cfa56 --date=short --first-parent --format='%ad %ae %s' 2019-12-09 oddhack@sonic.net Update for Vulkan-Docs 1.1.130 Created with: gclient setdep -r third_party/vulkan-headers/src@0e57fc1cfa56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=ianelliot@google.com Bug: None Change-Id: Ie028ebf3b6be0b833e980658b755ef428250614c Tbr: ianelliot@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957400Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b9f03f47d5f5..31916f494c2e git log b9f03f47d5f5..31916f494c2e --date=short --first-parent --format='%ad %ae %s' 2019-12-07 digit@google.com [Subzero] Remove assert that breaks Shuffle operations. 2019-12-06 bclayton@google.com SpirvShader: Use struct for MemoryVisitor callback. 2019-12-06 bclayton@google.com Regres: Update dEQP to include fence timeout fix. 2019-12-06 bclayton@google.com Vulkan: Tidy VkCommandBuffer.cpp 2019-12-06 bclayton@google.com Reactor: Rename Blend() to Shuffle() 2019-12-06 swiftshader.regress@gmail.com Regres: Update test lists @ b9f03f47 2019-12-06 bclayton@google.com Reactor: Switch swizzles over to 16-bit hex codes Created with: gclient setdep -r third_party/SwiftShader@31916f494c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Icfd2b4304841ad6d7b419d5c7d5d477faef45505 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957973Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0de87ee9a5bf..d519167d2ecb Created with: gclient setdep -r third_party/glslang/src@d519167d2ecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC ianelliot@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: ianelliot@google.com Change-Id: I29c4f44ed84166120a14025a16913a64782e4d4c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1956491Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/a3ee4384fb57..f34b9fb086b3 git log a3ee4384fb57..f34b9fb086b3 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 jeremy@lunarg.com Remove default initialized push constant ranges 2019-12-06 mark@lunarg.com tests: Add imageless framebuffer positive test 2019-12-06 mark@lunarg.com statetracker: Avoid bad derefs for imageless framebuffer cases Created with: gclient setdep -r third_party/vulkan-validation-layers/src@f34b9fb086b3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ib392ee963d7390a4584d0b0c2f6504cacb5e6d2a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957971Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e82a428605f6..983b5b4fccea Created with: gclient setdep -r third_party/spirv-tools/src@983b5b4fccea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ie7e4e811857bf0d2113ada42b723e46e2e351c3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957972Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/0a0625a3dca6..5ceb7be9a3bf git log 0a0625a3dca6..5ceb7be9a3bf --date=short --first-parent --format='%ad %ae %s' 2019-12-06 tony@lunarg.com Revert "cube: Port Wayland impl from wl-shell to xdg-shell" Created with: gclient setdep -r third_party/vulkan-tools/src@5ceb7be9a3bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I601964651ce3e66680e00c5d1cce20811b8eeb4d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1957968Reviewed-by:
-
- 07 Dec, 2019 2 commits
-
-
Shahbaz Youssefi authored
4398b2b6 made finishToSerial() in BufferVk::map() conditional to whether the serial is in use to work around a performance regression. Notes: - Prior to 087f1384, finishToSerial already did that, but that check was inadvertently removed. - finishToSerial waits for the smallest serial that's bigger than or equal to the requested serial. - The flush() call in BufferVk::map() was conditional to whether the serial is in use, but it really meant to check whether the buffer has pending commands in the graph. The end result is that there was an unnecessary flush in BufferVk::map() if we had to wait for a previous serial to finish. This change makes the flush conditional to whether the buffer has pending commands in the graph, and the finishToSerial call to whether the serial is not yet finished. Bug: angleproject:3994 Change-Id: Idca436ef2439bcc8c59396a07b2591c1dfadd669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932341Reviewed-by:
Brandon Schade <b.schade@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Xinyi He authored
Resize the defaultConfigs vector to its actual size to avoid using nullptr elements to get attributes. BUG=angleproject:4195 Change-Id: I3cbad9ee8c2c9faeaa30f72a04cf2c071f79db19 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949985 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
- 06 Dec, 2019 7 commits
-
-
Ian Elliott authored
Update the expectations file to expect these to pass on all Vulkan drivers now. Bug: angleproject:4198 Change-Id: I38982db1e23706f0063795757dfe1d8c8c45294a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955697Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Ian Elliott authored
This change ensures that the following spec language is correctly implemented: the resulting value for RENDERBUFFER_SAMPLES is guaranteed to be greater than or equal to samples and no more than the next larger sample count supported by the implementation. For example, if 2, 4, and 8 samples are supported, and if 5 samples are requested, ANGLE should use 8 samples, and return 8 when GL_RENDERBUFFER_SAMPLES is queried. Note: There is a known problem with NVIDIA OpenGL driver that causes another test to be expected to fail. Bug: angleproject:2222 Bug: angleproject:4196 Change-Id: I28921badf9568427799b0af347198b5df06c2aaa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954444Reviewed-by: -
Jonah Ryan-Davis authored
~10% or more Linux users* do not have AMD/ATI in the GL_VENDOR, only in GL_RENDERER. Our heuristics only checked GL_VENDOR, so this CL adds GL_RENDERER to the string being checked to find the vendor ID. (*According to https://feedback.wildfiregames.com/report/opengl/feature/GL_VENDOR) Bug: angleproject:4204 Change-Id: Ie89080b4431fdf02a4ca09709973ea3f271a3e84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953486Reviewed-by:
-
Jamie Madill authored
This reverts commit e20560fa. Reason for revert: Now fails on Linux CFI and also is a bit flaky. Original change's description: > Re-land "Add new test runner harness." > > Re-land changes: > > * Unit test is suppressed in ASAN > * --deqp-case is fixed > * Debug layer errors should correctly work with failure expectations > > Original message: > > The ANGLE test harness is a harness around GoogleTest that provides > functionality similar to the Chromium test harness. It supports: > > * splitting a test set into shards > * catching and reporting crashes and timeouts > * outputting to the Chromium JSON test results format > * multi-process execution > > Unit tests are added in test_utils_unittest.cpp. > > Bug: angleproject:3162 > Change-Id: I841f2b5dfe51f7f44dac68324bdf6afd418b8bfb > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948240 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Reviewed-by: Yuly Novikov <ynovikov@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> TBR=ynovikov@chromium.org,ianelliott@google.com,jonahr@google.com,jmadill@chromium.org Change-Id: Ibfd65b8b18ead3a232abb6cb75fd6489b0ff5f38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3162 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954570Reviewed-by:
-
Josh Matthews authored
Bug: angleproject:4181 Change-Id: I6940d5605e85bcf923b201be0f0f2b1f61c30ed5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944463 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bbd0694f9ab2..b9f03f47d5f5 git log bbd0694f9ab2..b9f03f47d5f5 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 digit@google.com [vulkan] Add VK_SUBGROUP_FEATURE_ARITHMETIC_BIT support 2019-12-05 bclayton@google.com Vulkan: Optimize shaderClipDistance and shaderCullDistance 2019-12-05 bclayton@google.com Vulkan: Implement shaderClipDistance and shaderCullDistance 2019-12-05 paulthomson@google.com Regres: support GCOV_PREFIX for collecting coverage 2019-12-05 chrisforbes@google.com Regres: update testlists for recent deqp roll 2019-12-05 chrisforbes@google.com Regres: Adjust exit code handling 2019-12-05 digit@google.com [vulkan] Clarify configuration macros for external memory and semaphores. 2019-12-05 amaiorano@google.com ReactorUnitTests: add unit tests for intrinsics 2019-12-05 amaiorano@google.com SubzeroReactor: implement most missing intrinsics 2019-12-05 amaiorano@google.com SubzeroReactor: add stubbed coroutine support 2019-12-05 amaiorano@google.com Subzero: fix assert for sqrt of vector float types 2019-12-05 amaiorano@google.com Subzero: hack fix for assert(Dest->hasReg()) 2019-12-05 amaiorano@google.com SubzeroReactor: fix assertion !isVectorType(Ty) 2019-12-05 amaiorano@google.com Subzero: fix assert when dumping unnamed constant 2019-12-05 chrisforbes@google.com Regres: roll deqp forward to current tip of 1.1.6 2019-12-04 sugoi@google.com Enable the fullDrawIndexUint32 feature 2019-12-04 swiftshader.regress@gmail.com Regres: Update test lists @ bbd0694f 2019-12-04 bclayton@google.com VulkanUnitTests: Fix bad comment on assembly. Created with: gclient setdep -r third_party/SwiftShader@b9f03f47d5f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I720c9e121605054c30570ccfe8f83678d4b1262b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955230Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e72b61c7c20d..a3ee4384fb57 git log e72b61c7c20d..a3ee4384fb57 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 mark@lunarg.com tests: Add tests for CmdFillBuffer offset and size 2019-12-05 mark@lunarg.com corechecks: Add offset/size checks for CmdFillBuffer Created with: gclient setdep -r third_party/vulkan-validation-layers/src@a3ee4384fb57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I175ccbba8eaf3d5c79b397422c7c32d64de8ef3f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955231Reviewed-by:
-
- 05 Dec, 2019 9 commits
-
-
Jonah Ryan-Davis authored
Linux AMD has a crash on an assert in the mesa driver that the source rectangle for blitFramebuffer be inside the framebuffer. Add Linux AMD to the existing workaround for this case. Note: this will duplicate some work on Linux AMD if the blit call is outside the framebuffer and also very large (the adjustSrcDstRegionBlitFramebuffer workaround) Bug: 1014370 Change-Id: I1afd1c92ab07dba6814d6b87ff7c3c19a19bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953487 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Ian Elliott authored
This functionality is exercised by running angle_deqp_gles31_tests with the following sets of command arguments: --gtest_filter=dEQP.GLES31/functional_texture_multisample* --use-angle=vulkan --gtest_filter=dEQP.GLES31/functional_state_query_texture_level_texture_2d_multisample* --use-angle=vulkan --gtest_filter=dEQP.GLES31/functional_state_query_texture_texture_2d_multisample_texture_immutable* --use-angle=vulkan The following are some high-level design notes: - Texture::setStorageMultisample() handles converting the "requested number of samples" to the actual number of samples used (e.g. converting 3 to 4), supported by the underlying back-end). The actual number used is stored in gl::TextureState::mImageDescs, for use by other GLES commands. - ANGLE uses the Vulkan standard sample locations/positions. If the underlying Vulkan driver's VkPhysicalDeviceLimits::standardSampleLocations is false, ANGLE limits itself to GLES 2.0 (i.e. before GLES 3.0 which adds multisample renderbuffers). - The Vulkan specification currently doesn't support ANGLE providing support for GLES 1-sample textures, because of the following Vulkan specification statement: - If the image was created with VkImageCreateInfo::samples equal to VK_SAMPLE_COUNT_1_BIT, the instruction must: have MS = 0. - At least one Vulkan driver returns different VkPhysicalDeviceLimits::*SampleCounts for different formats. Because of this, ANGLE does a logical-AND of all values in order to only support the commonly-available numbers of samples. The detailed design document is located at: https://docs.google.com/document/d/1NiM8gAR74iGGXGTE6IP1ChdDUZjhtXRuJdtEp_wGFEM/edit?usp=sharing Bug: angleproject:3565 Bug: angleproject:4103 Bug: angleproject:4104 Bug: angleproject:4196 Bug: angleproject:4197 Bug: angleproject:4198 Change-Id: I28921badf9568427799b0af347198b5df06c2db0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919982 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by: -
Shahbaz Youssefi authored
The change that introduced images to the front-end placed them at the end of the uniforms list, so the loop that was calculating the image range was starting from the end of that list. The change that introduced atomic counters to the front-end placed them at the end of the uniforms list too, but the image range loop was not adjusted to take this fact into account (neither was the sampler range loop for that matter). If a shader used both images and atomic counter buffers, the image range was calculated as empty. Similar issues would arise if the shader used both samplers and atomic counters. A test is added where a shader has a default uniform, a UBO, an SSBO, an image and an atomic counter, to make sure any combination of these resources doesn't result in a bug. Bug: angleproject:4190 Change-Id: I7818ee5258dd964215a18acfd7c3d6515b61c595 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950655 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
When a struct was involved, the required size for each field was added up, but also multiplied by its array size. However, when calculating the field size, the array size was already multipled in. This resulted in the calculated size to be larger than it actually is, resulting in failures in KHR-GLES31.core.compute_shader.shared-max. Bug: angleproject:4173 Change-Id: I900c17fa65decdeb20c3651c3342295fed2f7c61 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953483Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
-
Shahbaz Youssefi authored
The precise keyword is used in tessellation shaders but introduced in this extension. EXT_gpu_shader5 introduces a handful of features to shaders. This change only implements the `precise` keyword. Bug: angleproject:3569 Change-Id: I2252b79098eb8ba2d2faa040d7eaed7548b7051e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939851 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
Jamie Madill authored
Re-land changes: * Unit test is suppressed in ASAN * --deqp-case is fixed * Debug layer errors should correctly work with failure expectations Original message: The ANGLE test harness is a harness around GoogleTest that provides functionality similar to the Chromium test harness. It supports: * splitting a test set into shards * catching and reporting crashes and timeouts * outputting to the Chromium JSON test results format * multi-process execution Unit tests are added in test_utils_unittest.cpp. Bug: angleproject:3162 Change-Id: I841f2b5dfe51f7f44dac68324bdf6afd418b8bfb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948240Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
The tests meant to do getClientMajorVersion() >= 3, but in a few locations accidentally did > 3. Bug: angleproject:3569 Change-Id: Ie69898348982c6aae7dac265a18229c257dbfbda Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947458Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e58c080d4f02..0de87ee9a5bf Created with: gclient setdep -r third_party/glslang/src@0de87ee9a5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I8ff675710626a7197a71abb386b2b4013f27c30f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952391Reviewed-by:
-
Ian Elliott authored
This is split off from a change to implement multisampled textures for the Vulkan back-end, and will come before that change. The changes include: - Make a common utility rx::GetSamplePosition() function. D3D11 and Vulkan use the same standard sample positions/locations for 1, 2, 4, 8, and 16 samples. The D3D11 back-end has a utility function for this, which is being moved to a common location--for use by both the D3D11 and Vulkan back-ends. - Texture::setStorageMultisample() handles converting the "requested number of samples" to the actual number of samples used (e.g. converting 3 to 4), supported by the underlying back-end). The actual number used is stored in gl::TextureState::mImageDescs, for use by other GLES commands. - Change some end2end tests to not make assumptions about the supported number of samples, but to properly query what is supported. Bug: angleproject:3565 Bug: angleproject:4196 Change-Id: I1dc12fedd0f8fb4975f90d87486e443b069b7141 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948535 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
-
- 04 Dec, 2019 13 commits
-
-
Shahbaz Youssefi authored
This flag is always true now and is being removed from GN. Bug: angleproject:4026 Bug: angleproject:2344 Change-Id: I7e90d95a41cd4a9e054e3e102578db3323e999e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951525Reviewed-by:
-
Jamie Madill authored
Renaming "all" targets to reduce duplication. Also add libGLESv1_CM to "angle". And remove "shader_translator" since we already had "angle_shader_translator". An attempt to work around "invalid COFF sections" error that is popping up on the MSVC try bots. Bug: None Change-Id: I105aa5e59f67173643a3a2071b2aff345b5a6135 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947457Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:3803 Change-Id: Ib260c86c68e5b11deaec8658cd9768af9b44e086 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949629 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Shahbaz Youssefi authored
There is a bug that prevents us from running these tests on the windows bots. This change enables them on other platforms so we don't lose coverage. Bug: angleproject:3738 Change-Id: I9b546c3223499af88b347f8a01be8edb245c19a7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950654 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Jamie Madill authored
This could lead to a subtle bug: Say we use a buffer as a storage buffer and write to it. We then must issue a memory barrier before using it as a uniform buffer. However we would set the SHADER_READ bit as a read mask on a storage buffer access. This seems like it could lead to a missing barrier. Bug: angleproject:4178 Change-Id: I486002739b7fb000ffacc0a1e996784b7875e7ba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943034 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
-
shrekshao authored
Bug: 1023747 Change-Id: I8ca320432aad663e2a6d70f494692df518376258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947710Reviewed-by:
-
Courtney Goeltzenleuchter authored
The failures have been triaged and split into more specific bugs. Bug: angleproject:3601 Change-Id: Icb262a047bba78a11d710e479ad659a9fa1caf1a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948524 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Courtney Goeltzenleuchter authored
Add tracking of shared memory declarations in compute shaders. Test: angle_deqp_gles31_tests --gtest_filter=dEQP.GLES31/functional_debug_negative_coverage_callbacks_compute_exceed_shared_memory_size_limit Bug: 4173 Change-Id: If2a86d467a82f73fa5b2ee0ced752701acfe1872 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934653 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
-
Tom Anderson authored
BUG=chromium:1028799 R=jonahr CC=vasilyt Change-Id: Id17c4061b206953b1e904bf7938cb371612e33fd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948534Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fde9b750992..e72b61c7c20d git log 4fde9b750992..e72b61c7c20d --date=short --first-parent --format='%ad %ae %s' 2019-12-03 dadschoorse@gmail.com include cassert in vk_extension_helper.h Created with: gclient setdep -r third_party/vulkan-validation-layers/src@e72b61c7c20d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I647c43e868f17775548545671e283830559b3aba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950027Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b64fbfec4dcd..bbd0694f9ab2 git log b64fbfec4dcd..bbd0694f9ab2 --date=short --first-parent --format='%ad %ae %s' 2019-12-03 chrisforbes@google.com Remove Common/Types.hpp include from SpirvShader 2019-12-03 chrisforbes@google.com Regres: Add pending deqp change to fix bad graphicsfuzz tests 2019-12-03 srisser@google.com Make Vk::Stringify return std::string Created with: gclient setdep -r third_party/SwiftShader@bbd0694f9ab2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia5795718520bc2de13a5331fb3471f5d16ba5dbe Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950025Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ed4586044f2..e82a428605f6 Created with: gclient setdep -r third_party/spirv-tools/src@e82a428605f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: I84921c632e3a8f55a5c2e16d03984f5119d7ac15 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950024Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a4af7676feb0..e58c080d4f02 Created with: gclient setdep -r third_party/glslang/src@e58c080d4f02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: geofflang@google.com Change-Id: Ia950c8adef32a30ee53f05e3c9e01d8576f62f8e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950026Reviewed-by:
-
- 03 Dec, 2019 2 commits
-
-
Shahbaz Youssefi authored
This is to support the upcoming `precise` keyword. Bug: angleproject:3569 Change-Id: Idbcc8fd6f261757dbbf81b381e7a2dae938d8101 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947451Reviewed-by:
-
Shahbaz Youssefi authored
Bug: angleproject:3569 Change-Id: I7cbbaa4d1cdd4dd4268f28e06c907958cff9b4e8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947450 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
