Commits · 709dc46cbd06c98b7450d702ade3210eef831a70 · Chen Yisong / angle

14 Aug, 2015 1 commit

D3D: Fix buffer overflow in VertexBuffer.cpp. · 709dc46c

authored Aug 10, 2015

Under certain situations an integer overflow could lead to ANGLE
writing to places where it shouldn't.

BUG=518206

Change-Id: I9217685daecb160a4072fbf79c26e5bee9f4621e
Reviewed-on: https://chromium-review.googlesource.com/293820Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

709dc46c

17 Jun, 2015 1 commit

Fix support for GL_MAX_ATTRIBS attributes. · fa9744b0

authored Jun 15, 2015

An off-by-one bug slipped in that broke support for these edge case
shaders.

Bug introduced in https://chromium-review.googlesource.com/#/c/266928/

BUG=angleproject:1045
BUG=500116

Change-Id: If44f809d432221d1e17afc407d49e87e0cb7504c
Reviewed-on: https://chromium-review.googlesource.com/278240Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

fa9744b0

04 Jun, 2015 3 commits

Release egl::Surface on Texture image changes. · b3e2aa92

authored May 20, 2015

We would get into a broken state if the user would bind a Texture
to an egl::Surface, then change the Texture. This is valid in egl,
and should release the Surface when it happens.

BUG=485543

Change-Id: Idfaa305ac704f2bc579e79be816e88a23e69351b
Reviewed-on: https://chromium-review.googlesource.com/275208Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b3e2aa92

Don't enable opengl on linux unless x11 is also available. · 90d5f9b1

authored May 29, 2015

BUG=493682

Change-Id: I10d5b710fcc9b51160c3aff169d1af839212003c
Reviewed-on: https://chromium-review.googlesource.com/274036Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

90d5f9b1

Do not always use X11 for Linux builds, inherit Chromium's settings · 9b38269c

authored May 26, 2015

This fixes project generation for Chromium for non-X11 builds

BUG=angleproject:1011

Change-Id: If528f63fb186d834d56a43ca379497d99e74777e
Reviewed-on: https://chromium-review.googlesource.com/274035Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9b38269c

14 May, 2015 6 commits

Fix typo in a comment in PbufferTest · 21ce9b02

authored May 14, 2015

BUG=angleproject:892

Change-Id: I8383b0b061f613ee3592c3d7cd41135164223604
Reviewed-on: https://chromium-review.googlesource.com/271158Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

21ce9b02

Move ANGLETest back in test_utils, leaving a proxy header for Chromium · d3970de4

authored May 14, 2015

BUG=angleproject:892

Change-Id: Ibd494813be87e996096077d6e208cc92461b8f49
Reviewed-on: https://chromium-review.googlesource.com/271154Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

d3970de4

EGLWindow: remove redundant EGL_NONE to finish attrib list. · 1f67547b

authored May 14, 2015

Only one EGL_NONE is needed to signal the end of the list.

BUG=angleproject:892

Change-Id: I7de349bef9d674344ccd1b2c4801d8b42c801299
Reviewed-on: https://chromium-review.googlesource.com/271157Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

1f67547b

Revert "Add more D3D11 init errors to stats collection." · e897cecf

authored May 14, 2015

Going to rework this in favor of a sparse histogram.

BUG=477701

This reverts commit c5146c76.

Change-Id: I88ba7b461a1de04324a6ebe164037ea9081f2239
Reviewed-on: https://chromium-review.googlesource.com/271155Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

e897cecf

Revert "Revert "Make EGLQueryContextTest use ANGLE_INSTANTIATE_TEST"" · 9e7db227

authored May 11, 2015

The original commit was not the one causing the problem it was reverted
for.

This reverts commit c4738880.

BUG=angleproject:892

Change-Id: I8dee28545c3895750247635a63b73ecec4ba449c
Reviewed-on: https://chromium-review.googlesource.com/270262Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/270473Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

9e7db227

Compile the GLX EGL implementation in BUILD.gn · 47fc1fec

authored May 14, 2015

BUG=angleproject:892

Change-Id: Ifebcadab4fc4ad9fd93b9cf21b3ebdd2f4d6cfc1
Reviewed-on: https://chromium-review.googlesource.com/271164Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

47fc1fec

13 May, 2015 11 commits

Add plumbing for D3D11 device caps · ba8a0bf8

authored May 13, 2015

BUG=angleproject:1002

Change-Id: Id24783c75377ea92a73a43f2605693e07f63dc15
Reviewed-on: https://chromium-review.googlesource.com/270545Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Austin Kinross <aukinros@microsoft.com>

ba8a0bf8

Revert "Make TParseContext a class, with private data." · 749fe340

authored May 13, 2015

Causing build errors on Linux:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\third_party\angle\src\compiler\translator\translator_lib.ParseContext.obj.rsp /c ..\..\third_party\angle\src\compiler\translator\ParseContext.cpp /Foobj\third_party\angle\src\compiler\translator\translator_lib.ParseContext.obj /Fdobj\third_party\angle\src\translator_lib.cc.pdb
c:\b\build\slave\gpu_win_builder__dbg_\build\src\third_party\angle\src\compiler\translator\validateglobalinitializer.h(11) : error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\gpu_win_builder__dbg_\build\src\third_party\angle\src\compiler\translator\validateglobalinitializer.h(11) : warning C4099: 'TParseContext' : type name first seen using 'class' now seen using 'struct'
c:\b\build\slave\gpu_win_builder__dbg_\build\src\third_party\angle\src\compiler\translator\parsecontext.h(28) : see declaration of 'TParseContext'

BUG=angleproject:995

This reverts commit 6c0c2987.

Change-Id: I49a8b7df9bc8b7c4892bf3af5e2c7a6444fba890
Reviewed-on: https://chromium-review.googlesource.com/270767Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

749fe340

Make TParseContext a class, with private data. · 6c0c2987

authored May 13, 2015

BUG=angleproject:995

Change-Id: Ie077e3a4f0fd5ef840aa35edeb41d15a98b7c0ff
Reviewed-on: https://chromium-review.googlesource.com/270628Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6c0c2987

Refactor style in ParseContext.h. · 06145236

authored May 13, 2015

BUG=angleproject:995

Change-Id: I893785a068d0d5cf4afc18123896bf540e53a3e0
Reviewed-on: https://chromium-review.googlesource.com/270627Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

06145236

Revert "Add constant folding support for min,max and clamp" · 95d34aaf

authored May 13, 2015

This reverts commit 1137a2a6.

Change-Id: I1493c2706e5f08a9f0001835e663a147be85a303
Reviewed-on: https://chromium-review.googlesource.com/270782Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

95d34aaf

Fix crash in IndexDataManagerPerfTest. · 71632d0c

authored May 12, 2015

Since the gl::Buffer doesn't know about its data, the index range needs to
be computed on the raw indices instead of through the buffer.

Change-Id: I3f53822033a1a25bf5fae9132ee2ceb312eaa283
Reviewed-on: https://chromium-review.googlesource.com/270498Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

71632d0c

Roll Gmock and Gtest. · 3ba57d1b

authored May 13, 2015

This fixes the build of angle_end2end_tests on Linux/Clang.

BUG=angleproject:997

Change-Id: Ie6eca3dc0fc7114d2755892b4b02e8b47a8fa478
Reviewed-on: https://chromium-review.googlesource.com/270680Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3ba57d1b

Validate global initializer qualifiers · b0c645e2

authored May 12, 2015

Allow only constants, other globals, temporaries, and uniforms to be used
in global variable initialization for now. The spec limits global
variable initialization further to only constant expressions, but fully
implementing this has a too large compatibility cost for ESSL 1.00, so
implement it only partially. In the case of ESSL 3.00 we can use stricter
validation, since there's no legacy to worry about.

Resubmitting the change, since the previous version neglected to remove
incorrect GLSL tests.

TEST=angle_unittests, WebGL conformance tests, angle_end2end_tests
BUG=angleproject:988

Change-Id: I1bb3b8dc305689a90eadfe8cc7705e5ac3829e03
Reviewed-on: https://chromium-review.googlesource.com/270651Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

b0c645e2

perf_tests: Reduce iteration counts in some tests. · fe5f54f5

authored May 12, 2015

This gives the tests more room to breathe, and report more
precision in the final scores. Hopefully this will clear up the
issues on the bots where some tests appear to fluctuate between a 
high and low value.

BUG=468852

Change-Id: Ie2793e0a89e5ded63ba4217828076df46c393a92
Reviewed-on: https://chromium-review.googlesource.com/270497Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

fe5f54f5

Revert "Validate global initializer qualifiers" · b6a52bb4

authored May 13, 2015

Seems to be failing angle_end2end_tests:

GLSLTest.GlobalStaticAndVarying_0
GLSLTest.GlobalStaticAndVarying_1
GLSLTest_ES3.GlobalStaticAndInstanceID_0

http://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/15598

BUG=angleproject:988

This reverts commit 6caa5e81.

Change-Id: I394b571c9b4ee739721018c5287a45df49e1471c
Reviewed-on: https://chromium-review.googlesource.com/270589Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

b6a52bb4

Validate global initializer qualifiers · 6caa5e81

authored May 12, 2015

Allow only constants, other globals, temporaries, and uniforms to be used
in global variable initialization for now. The spec limits global
variable initialization further to only constant expressions, but fully
implementing this has a too large compatibility cost for ESSL 1.00, so
implement it only partially. In the case of ESSL 3.00 we can use stricter
validation, since there's no legacy to worry about.

TEST=angle_unittests, WebGL conformance tests
BUG=angleproject:988

Change-Id: I6a66f6a31130b44717dd2bef3082a0fc395a60b6
Reviewed-on: https://chromium-review.googlesource.com/270430Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

6caa5e81

12 May, 2015 14 commits

Add more D3D11 init errors to stats collection. · c5146c76

authored May 12, 2015

We ran into the UNSUPPORTED value when looking at D3D11 on a VM.
It's quite possible that systems which don't support D3D11 return
this value when initialization fails.

Also add a few more severe errors such as device removed.

BUG=477701

Change-Id: I2ebbfff5f7eed6fe3939dea86b25845a748caedc
Reviewed-on: https://chromium-review.googlesource.com/270346Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

c5146c76

Revert "Create a child window in SurfaceD3D when needed." · 6cd03cf9

authored May 12, 2015

Reverting until chromium sandbox issues are resolved.

This reverts commit b7f1a8b0.

BUG=484963
BUG=angleproject:961

Change-Id: I4b030329a322d0a96a18e6ae875d500c5f755ddd
Reviewed-on: https://chromium-review.googlesource.com/270490Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

6cd03cf9

Fix compilation of EGLSurfaceTest · e96899c4

authored May 12, 2015

BUG=angleproject:892

Change-Id: I8c999e06c8cc3567f7bb1aed23286bd7e9080616
Reviewed-on: https://chromium-review.googlesource.com/270432Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e96899c4

X11Window: implement event handling and modifiers · 43b0c221

authored May 12, 2015

BUG=angleproject:892

Change-Id: I65f251abdd28b273e2d3d574825f20bba8bb2532
Reviewed-on: https://chromium-review.googlesource.com/270452Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

43b0c221

Temporarily move back ANGLETest in end2end_tests · ac3ab882

authored May 12, 2015

This path needs to a Chrome change before it can change.

BUG=angleproject:892

Change-Id: I549737383b9720a2e7d83ee5e3145d71716f04cb
Reviewed-on: https://chromium-review.googlesource.com/270457Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ac3ab882

Revert "Make EGLQueryContextTest use ANGLE_INSTANTIATE_TEST" · c4738880

authored May 12, 2015

Broke win build

ninja: error: '../../gpu/egl_tests/EGLQueryContextTest.cpp', needed by 'obj/gpu/egl_tests/angle_end2end_tests.EGLQueryContextTest.obj', missing and no known rule to make it
This reverts commit 887dd2f1.

Change-Id: I2ceb430010628c2aa7cb242eb2bf49406d8d87db
Reviewed-on: https://chromium-review.googlesource.com/270471Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

c4738880

Make EGLQueryContextTest use ANGLE_INSTANTIATE_TEST · 887dd2f1

authored May 11, 2015

This makes it run correctly on Linux where the only platform available
is OpenGL.

BUG=angleproject:892

Change-Id: I3d72163b49b35daba702ebb5b48d010761c7fb6d
Reviewed-on: https://chromium-review.googlesource.com/270262Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

887dd2f1

Compile end2end tests on Linux · 973402fd

authored May 11, 2015

BUG=angleproject:892

Change-Id: Id4a9ddc35ae9600080e743c77476d36743a3e646
Reviewed-on: https://chromium-review.googlesource.com/270199Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/270412

973402fd

Revert "Compile end2end tests on Linux" · e45b7458

authored May 12, 2015

Build errors in Chromium:

ninja: Entering directory `C:\b\build\slave\GPU_Win_Builder\build\src\out\Release'
ninja: error: '../../gpu/egl_tests/EGLQueryContextTest.cpp', needed by 'obj/gpu/egl_tests/angle_end2end_tests.EGLQueryContextTest.obj', missing and no known rule to make it

This reverts commit be39156b.

Change-Id: I931295f16cad096e94baac9811ea2396a4182848
Reviewed-on: https://chromium-review.googlesource.com/270347Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

e45b7458

OSWindow: add optional debugging of events received · 938f1ca3

authored May 12, 2015

BUG=angleproject:830

Change-Id: Icd854ee152f15ec1de4293b5ed2ed49cb1a5fc2b
Reviewed-on: https://chromium-review.googlesource.com/270451Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

938f1ca3

Implement Pbuffers for the GLX EGL implementation · 0d3afab8

authored May 11, 2015

BUG=angleproject:892

Change-Id: I32b9bbb35d99621f16a055fb544ec0691dfcd5a0
Reviewed-on: https://chromium-review.googlesource.com/270261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

0d3afab8

Compile end2end tests on Linux · be39156b

authored May 11, 2015

BUG=angleproject:892

Change-Id: If3903f1801f4999bebaaaed2625346bfbec2243d
Reviewed-on: https://chromium-review.googlesource.com/270199Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

be39156b

Move end2end and standalone tests to gl_tests and egl_tests · 9cb9583e

authored May 11, 2015

Also introduce a test_utils directory that contains helpers used for all
types of tests.

BUG=angleproject:892

Change-Id: I9e1bff895020ffd3a109162283971a290a1098bd
Reviewed-on: https://chromium-review.googlesource.com/270198Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

9cb9583e

Add constant folding support for min,max and clamp · 1137a2a6

authored May 05, 2015

This change adds necessary mechanism to support constant folding of
built-ins that take more than one parameter and also adds constant
folding support for min, max and clamp built-ins.

BUG=angleproject:913
TESTS=dEQP tests
(126 tests started passing with this change)
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.min_*
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.max_*
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.clamp_*

Change-Id: I5d3e96ef2062116cbf164a7a42cba096bd4d5389
Reviewed-on: https://chromium-review.googlesource.com/269317Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

1137a2a6

11 May, 2015 4 commits

DisplayGLX: handle EGL_DEFAULT_DISPLAY for ANGLE_platform_angle · 4298123b

authored May 11, 2015

BUG=angleproject:892

Change-Id: I681e2b92ac2e8b853c7d1271a5518c4b77a67929
Reviewed-on: https://chromium-review.googlesource.com/270260Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

4298123b

Convert floats to integers using doubles and 64-bit integers. · c337e7ab

authored Apr 30, 2015

Avoids some edge cases that overflow or round incorrectly.

Fixes:
dEQP-GLES2.functional.state_query.floats.depth_range_getinteger
dEQP-GLES2.functional.state_query.floats.color_clear_value_getinteger
dEQP-GLES2.functional.state_query.floats.depth_clear_value_getinteger

Change-Id: Ib2c7f422dac76094c7ff6c5f8aef3fd392f68e80
Reviewed-on: https://chromium-review.googlesource.com/268510Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c337e7ab

Add a basic GLX EGL implementation · eac64633

authored May 06, 2015

BUG=angleproject:892

Change-Id: Ife9955a457d4a6fb3adce17757ccb0de7d0dd274
Reviewed-on: https://chromium-review.googlesource.com/269413Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

eac64633

Add a FunctionsGLX class to dynamically load the GLX entry points · f229cb9b

authored May 08, 2015

BUG=angleproject:892

Change-Id: I516b7d859100cb065871de8e328585a9ca817499
Reviewed-on: https://chromium-review.googlesource.com/270123Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

f229cb9b