Commits · 756aebfc7afa6d0de14e96637ef396dd7b290c2d · Chen Yisong / angle

20 Oct, 2014 4 commits

Added IInspectable EGLNativeWindowType and ICoreWindow support · 756aebfc

authored Oct 08, 2014

Change-Id: I34e443b1e194800460e441ac6cee42cf68430564
Reviewed-on: https://chromium-review.googlesource.com/224302Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

756aebfc

Fix TextureD3D::setData for depth-stencil textures. · ec6de4ec

authored Oct 20, 2014

D3D11 requires us to NULL the update region parameter when updating
depth stencil textures. For these textures, we can't always use the
subdata workaround, so disable it entirely for these textures.

BUG=angle:729
BUG=365078

Change-Id: I44258dd1b8937b1aebcb3a73de835698805537e0
Reviewed-on: https://chromium-review.googlesource.com/222911Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ec6de4ec

Fix CopyBufferSubData validation. · 24e83192

authored Oct 20, 2014

We were checking readTarget twice, instead of both read and write.

BUG=angle:800

Change-Id: I4096a9c4e0fdec9c77bfc25250923c188d2b43db
Reviewed-on: https://chromium-review.googlesource.com/224102Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

24e83192

Add c++0x flag to cflags on non-win platforms. · 0661fce4

authored Oct 03, 2014

Our previous change to use static_assert leads the new wave of c++11
features.

BUG=

Change-Id: Id6d382475daa7029109dab1017a59b5ef07c18df
Reviewed-on: https://chromium-review.googlesource.com/221267Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

0661fce4

17 Oct, 2014 4 commits

We managed to disable NPOT textures on AMD. Reenable them. · 8e929230

authored Oct 17, 2014

BUG=angle:799

Change-Id: Iaa8aee1f09c8c2ac3669d6709572f76f40f21847
Reviewed-on: https://chromium-review.googlesource.com/224042Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

8e929230

Revert "Added IInspectable EGLNativeWindowType and ICoreWindow support" due to… · 8858cf0a

authored Oct 17, 2014

Revert "Added IInspectable EGLNativeWindowType and ICoreWindow support" due to build failures on Chromium FYI bots.

This reverts commit 406a3be9.

Change-Id: Ica2abd2e557a4fd9852d85b7fc018e3d272b6edf
Reviewed-on: https://chromium-review.googlesource.com/224051Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

8858cf0a

Added IInspectable EGLNativeWindowType and ICoreWindow support · 406a3be9

authored Oct 08, 2014

Change-Id: I9ad82b7819bcca1c05e7aa60dc2baec4a7bc403c
Reviewed-on: https://chromium-review.googlesource.com/222360Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

406a3be9

Enhance shader debug output · 97049c6a

authored Oct 06, 2014

glGetTranslatedShaderSourceANGLE() returns the glsl code, the initial translated hlsl code,
the final translated hlsl code and the disassembly of the generated binary with the compiler configuration.
This enhancement is only available if the define ANGLE_GENERATE_SHADER_DEBUG_INFO exists.
This define is set in the debug configurations for the Windows platform.

BUG=angle:751

Change-Id: I8b15e8b25fbb0c0575a73cc876bf8f1fa7ed142a
Reviewed-on: https://chromium-review.googlesource.com/221059Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

97049c6a

16 Oct, 2014 2 commits

Use attributes to avoid unrolling and flatten conditionals. · 5e0c80ad

authored Oct 10, 2014

[loop] and [flatten] help avoid unrolling make more shaders compile
successfully. When unrolling has to happen, an error X3531 is generated
so we have to try compiling again without these attributes.

BUG=395048,395286

Change-Id: I91ea8ac3a822ab1f1ac24907d42326e3c6c9d9af
Reviewed-on: https://chromium-review.googlesource.com/222810Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5e0c80ad

Update Renderer11::packPixels to return Error objects. · 24d4a3c1

authored Oct 09, 2014

BUG=angle:520
BUG=394361

Change-Id: I95f2f806210ac7aea8b0c57bece610eb22d018ed
Reviewed-on: https://chromium-review.googlesource.com/222481Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

24d4a3c1

15 Oct, 2014 7 commits

Refactor TLS management. · 9d6d498c

authored Oct 10, 2014

Use cross-platform APIs and constants, and conditionally compile the
Windows-specific DllMain.

BUG=angleproject:783

Change-Id: I8fd2708ab0925cb3207010eb0e759cfc055183ab
Reviewed-on: https://chromium-review.googlesource.com/222955Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

9d6d498c

Split FenceImpl into FenceNVImpl and FenceSyncImpl, and refactor. · caa549c0

authored Oct 10, 2014

Move Windows-specific code out of Fence.cpp. Split FenceImpl
based on suggestions on previous review
https://chromium-review.googlesource.com/221805/ . Refactored
further based on code review feedback and added first unit tests.

BUG=angleproject:774

Change-Id: I630034e1788e48ddb7722016ca22da474e785798
Reviewed-on: https://chromium-review.googlesource.com/222954Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

caa549c0

Fix compile error on 32-bit builds. · 7c9e2167

authored Oct 15, 2014

BUG=angle:520

Change-Id: Ibd3f46ca565ddd96820ef52b140f7e99cf28a5c2
Reviewed-on: https://chromium-review.googlesource.com/223168Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

7c9e2167

Updated TextureStorage11 to use Error objects for D3D11 object creation. · 5dce5e29

authored Sep 10, 2014

BUG=angle:520

Change-Id: I2b4d3d2be99d4185ff1ff1c6521fbd66a1e771ae
Reviewed-on: https://chromium-review.googlesource.com/217337Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5dce5e29

Update the TextureStorage calls to associate textures to use Errors objects. · edbeae5f

authored Sep 10, 2014

BUG=angle:520

Change-Id: Ied81c25a04d7239985cc83bb20493ce0bfd372d3
Reviewed-on: https://chromium-review.googlesource.com/217336Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

edbeae5f

Added test to ensure ProgramBinary saving and loading works correctly · 993d08d9

authored Oct 10, 2014

Change-Id: I7fa88e7e3ecf812659967867e856cc1677b8359d
Reviewed-on: https://chromium-review.googlesource.com/222931Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

993d08d9

Fix PBO missing unmap in some edge cases. · 2a895637

authored Oct 10, 2014

We had missed a few unmap calls in NativeBuffer11::copyFromStoage.
This method is only called when PBOs are used in conjunction with
SubData updates or when drawing with PBOs.

BUG=angle:667

Change-Id: I04a2b78e830edb9439e25661a2676af374df439e
Reviewed-on: https://chromium-review.googlesource.com/222920Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

2a895637

14 Oct, 2014 1 commit

Fix a crash with the WebGL conformance test suite. · 964df49d

authored Oct 13, 2014

Undefined behavior caused by an overflowed enum was causing
the translator symbol table stack to not get popped correctly
when the compiler completed, causing dangling symbols who's storage
was reclaimed and reused when the allocation pool was popped.
The error occurred in the "shader-with-reserved-words" test, which
passes when the compiler fails due to the use of reserved words as
identifiers. As such, this test would pass even if the GPU process
crashes but further tests in the test suite would fail.

BUG=angle::785, 786

Change-Id: I365cb55f962f8dfe409f40532effeb10b8189432
Reviewed-on: https://chromium-review.googlesource.com/223093Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Gus Fernandez <gusfernandez@chromium.org>

964df49d

12 Oct, 2014 1 commit

Fix D3D11 Hazard warnings in Debug. · 7865b70c

authored Oct 10, 2014

BUG=angle:756
BUG=417424

Change-Id: I827f1db6bb0a3ba33f116e4cfbf8556da0e884d1
Reviewed-on: https://chromium-review.googlesource.com/221220Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

7865b70c

10 Oct, 2014 4 commits

Implement support of unary operator "+" in translator. · de1e00e1

authored Oct 09, 2014

BUG=angle:779
TEST=conformance/glsl/misc/struct-unary-operators.html

Change-Id: Ia827e07dcfc8ad3bbbc078e54336815be9027945
Reviewed-on: https://chromium-review.googlesource.com/222720Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

de1e00e1

Improve the TextureStorage11 SRV cache. · 9ad2ab33

authored Sep 09, 2014

 * Use a std::map instead of std::vector for logarithmic search time.
 * Reduce the number of structs and make them private instead of
   protected since they arn't used outside of the base class.
 * Fix the SRV cache member name.

BUG=angle:520

Change-Id: I5158c1d46523f46158c51cd68044f7c915a3de03
Reviewed-on: https://chromium-review.googlesource.com/217335Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9ad2ab33

Refactor Texture::storage methods to use gl::Error objects. · 1f8532bd

authored Sep 05, 2014

BUG=angle:520

Change-Id: I33bc8479815a587749bddc722ac9fe5a85f554cb
Reviewed-on: https://chromium-review.googlesource.com/216648Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1f8532bd

Refactor Texture::copy*Image methods to use gl::Error objects. · ef7b016a

authored Sep 04, 2014

BUG=angle:520

Change-Id: I8b6bf5d50ee0d1f796eff52919ee65823fdee6cb
Reviewed-on: https://chromium-review.googlesource.com/216647Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ef7b016a

09 Oct, 2014 5 commits

Make OSWindow a non-static member of ANGLETest. · 4119ed3d

authored Oct 01, 2014

BUG=angle:611

Change-Id: I455e1dd0ad5582191621e316c4808a2d753e9aaa
Reviewed-on: https://chromium-review.googlesource.com/219867Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4119ed3d

Add workaround for Unicode compile error. · 91f2911f

authored Oct 09, 2014

Chromium builds define UNICODE, while we don't, which confuses
the built-in IDC_ARROW macro.

With this fix, and http://crbug.com/415983, we can build
angle_perf_tests in Chromium.

BUG=angle:744

Change-Id: I268a7c11a5b5355cb2485bf10faf750972cf4e30
Reviewed-on: https://chromium-review.googlesource.com/220363Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

91f2911f

Remove perf tests dependency on gtest. · 2ff18fb6

authored Oct 09, 2014

BUG=angle:744

Change-Id: I9272e0009238680db1a87e6cb1c1c48b2ed48dd6
Reviewed-on: https://chromium-review.googlesource.com/220362Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2ff18fb6

Use Chromium perf bot output style for perf test. · fc63152a

authored Oct 09, 2014

The Chromium style output will allow the perf bots to collect data
from our performance tests.

BUG=angle:744

Change-Id: I2ffdace688004edf2918ead2a3e2aa2a6c4daf95
Reviewed-on: https://chromium-review.googlesource.com/220361Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

fc63152a

Import the testing/perf module from Chromium. · 98f87eb2

authored Oct 09, 2014

We can use these perf routines to make our performance test output
compatible with the Chromium perf bots.

BUG=angle:744

Change-Id: I75a44786d4521fc0c7d8226f10575fcfda0fa221
Reviewed-on: https://chromium-review.googlesource.com/220360Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

98f87eb2

08 Oct, 2014 6 commits

Use GL_APIENTRY and EGLAPIENTRY instead of __stdcall directly. · 67ea190d

authored Oct 06, 2014

BUG=angleproject:773

Change-Id: Iab098f787b966bf3999c22687af113cc9909593b
Reviewed-on: https://chromium-review.googlesource.com/221796Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

67ea190d

Refactor libGLESv2.gypi to allow libANGLE to be built on all platforms. · 1ce845d7

authored Oct 06, 2014

Required pulling angle_enable_d3d{9,11} into angle.gypi and definition
of angle_libangle_win_sources. Pull in those sources in BUILD.gn.

Tested with local GYP build on Windows. Did not test GN build yet.

BUG=angleproject:773

Change-Id: Ia3703fe4fa2bc8a1682c1fa1667ca36268b36cc7
Reviewed-on: https://chromium-review.googlesource.com/221785Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

1ce845d7

Updated Renderer::sync to return Error objects. · 2629856f

authored Oct 01, 2014

BUG=angle:520

Change-Id: I8f1f095977bab3848b9215cda1127a71982858b8
Reviewed-on: https://chromium-review.googlesource.com/220800Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

2629856f

Perform short-circuit unfolding on separate declarations. · fa41aa08

authored Oct 06, 2014

BUG=415694

Change-Id: I812abb21d2ab4af0b63631a23026d5860df61672
Reviewed-on: https://chromium-review.googlesource.com/221945Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

fa41aa08

Split combined declarations into separate statements. · d974db43

authored Oct 07, 2014

BUG=415694

Change-Id: I7afb08a8a5ed10bbc6f7d23638daca6982f7c88b
Reviewed-on: https://chromium-review.googlesource.com/221455Tested-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

d974db43

Updated the FenceSync and FenceNV objects to use Error objects. · 882033e7

authored Sep 30, 2014

BUG=angle:520

Change-Id: I1e49b35905d8916baadb129c8aa58a11bd721500
Reviewed-on: https://chromium-review.googlesource.com/220781Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

882033e7

07 Oct, 2014 5 commits

Add type comparison, type retrieval, original name retrieval to ShaderVariable. · ed13636a

authored Oct 03, 2014

This is needed to effectively use the new APIs to get shader variable info.

BUG=angle::770
TEST=ShaderVariableTest

Change-Id: Ia591eb567868ebe898f4a7449c64167ad212f59b
Reviewed-on: https://chromium-review.googlesource.com/221388Tested-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

ed13636a

Add needed static_casts to GLenum for compilation on Linux. · e0a2d1c5

authored Oct 06, 2014

BUG=angleproject:773

Change-Id: I8b01a1f187456eb8997fc7a620b5ecdffb872c19
Reviewed-on: https://chromium-review.googlesource.com/221810Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

e0a2d1c5

Enable TexSubImage workaround on D3D11. · 9aca059f

authored Oct 06, 2014

This workaround uses UpdateResource instead of staging buffers for
texture data updates. It improves performance for highly dynamic
textures, especially in some benchmarks, eg the turbulenz particle
demo.

Re-land, with fix to the issue with glGenerateMipmaps.

BUG=angle:729
BUG=365078

Change-Id: I4c9398e0645176c296bf95e35eab97a44eae4319
Reviewed-on: https://chromium-review.googlesource.com/221493Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9aca059f

Use ImageIndex in copyToStorage. · 6b51c1a0

authored Oct 06, 2014

Also change the image association methods in TexStorage to use
ImageIndex, for consistency and compatibility.

BUG=angle:729

Change-Id: I05afa803735c9b93ae7d623fee5e6899c9ccec28
Reviewed-on: https://chromium-review.googlesource.com/221722Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6b51c1a0

Use mTopLevel in getSubresourceIndex. · c8d13843

authored Oct 06, 2014

We need to include this in every call, so might as well handle it
automatically.

BUG=angle:729

Change-Id: I5c230408a9eb80c8cfcc3f0d3a4ea531fa173aed
Reviewed-on: https://chromium-review.googlesource.com/221760Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

c8d13843

06 Oct, 2014 1 commit

Fix image index iterator unit test. · 1ea53509

authored Oct 06, 2014

This test was checking out-of-bounds. The bug only showed up in
Linux.

BUG=angle:741

Change-Id: I4cb45fc00dbb0bf9713f735a20fb6fd04bc95140
Reviewed-on: https://chromium-review.googlesource.com/221057Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

1ea53509