Commits · 7e753cb700c8a757a5804dfb7471d1e080e1db4e · Chen Yisong / angle

03 Dec, 2019 6 commits

authored Dec 03, 2019

Bug: angleproject:4186
Change-Id: I4fcfe2553f209e191d88058fe30d31c88a61f69f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947446Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7e753cb7

GL: Make GL_EXT_texture_format_BGRA8888 enableable. · e4ac2ff3

authored Nov 28, 2019

Disable returning BGRA as an implementation read format unless
GL_EXT_texture_format_BGRA8888 is exposed.  WebGL doesn't support this extension
and returning BGRA as an implementation read format is invalid.

TEST=functional/gles3/negativebufferapi.html
TEST=functional/gles3/integerstatequery.html

BUG=angleproject:4179

Change-Id: I313721f09da0e455128b88b129bd34338d47af73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943407Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

e4ac2ff3

Use SwiftShader-based ICD generation. · c4faeb79

authored Nov 25, 2019

We moved this into the SwiftShader repo proper in:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/38491

We can remove ANGLE's custom rules. Also removes the layer generation
script which was now unused. Also cleans up the Vulkan back-end
BUILD.gn a bit.

Bug: dawn:283
Change-Id: I490e8e8fc6fcadec58aca53a157ce7c4a47def3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932340Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c4faeb79

Roll third_party/glslang/src 83af46951202..a4af7676feb0 (1 commits) · 38e5a8de

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/83af46951202..a4af7676feb0


Created with:
  gclient setdep -r third_party/glslang/src@a4af7676feb0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Iae5df5c516d75f2aa8aa1a738b627027a8a07f19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947722Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

38e5a8de

Roll third_party/vulkan-tools/src 979b531e9fff..0a0625a3dca6 (1 commits) · b00fe93c

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/979b531e9fff..0a0625a3dca6

git log 979b531e9fff..0a0625a3dca6 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 bill.hollings@brenwill.com vkcube: Replace MoltenVK surfaces with Metal

Created with:
gclient setdep -r third_party/vulkan-tools/src@0a0625a3dca6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I6fef339859da970f0416ce0d8f6f874d3af8ac98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947720Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b00fe93c

Roll third_party/spirv-tools/src 47f3eb42641b..3ed4586044f2 (1 commits) · 32c57b79

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47f3eb42641b..3ed4586044f2


Created with:
  gclient setdep -r third_party/spirv-tools/src@3ed4586044f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I43e63689ab019e69440bac9c2a92fffa7b87a838
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947721Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

32c57b79

02 Dec, 2019 10 commits

Add new test runner harness. · fb40d231

authored Dec 02, 2019

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Change-Id: Idb15f113de8eb32db12bc93542de93b08d7c1447
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1478016
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

fb40d231

Vulkan: implement external semaphore barriers · 9601a548

authored Nov 23, 2019

glWaitSemaphoreEXT and glSignalSemaphoreEXT functions optionally request
buffer and image barriers to be performed by the implementation.

If any barriers are present, a single global memory barrier is inserted
to take care of memory accesses.

In both functions, buffer and image memory barriers are used to perform
queue ownership transfers to ANGLE's queue (glWaitSemaphoreEXT) or the
EXTERNAL queue (glSignalSemaphoreEXT).

In glWaitSemaphoreEXT, the given layouts are information regarding how
the external entity (the caller) has modified the images' layouts, and
is used to update ANGLE's internal state tracking.

Bug: angleproject:3289
Bug: 1026673
Change-Id: Ic478a8813df727c89413c8ae2adf42b5c1d06069
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1933016
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>

9601a548

Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test · 190d9a81

authored Nov 29, 2019

MAX_DRAW_BUFFERS has a minimum value of 4.  This test was
unconditionally using 6 draw buffers.

Bug: angleproject:4092
Bug: angleproject:4180
Change-Id: I069874a6402da1cb007bf9504e68b9910951cf63
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944527Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

190d9a81

Add test for multithreaded shared-context resource · 745999a9

authored Nov 19, 2019

The test does this:

1. Context 1: Read Texture 1 and draw into Framebuffer 1
2. Context 2: Read Texture 1 and draw into Framebuffer 2
3. Context 1: Delete Framebuffer 1
4. Context 1: Flush
5. Context 2: Modify Texture 1

Issue is Texture 1's mCurrentReadingNodes contains one node from each
context's command graph, one of which is deleted at step 4. At step 5, a
dependency is added from both nodes (one already deleted) to a new node,
causing use-after-free.

Bug: angleproject:4130
Change-Id: I06720aec20d0b49114937f1cd9b193a4f1df9d8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1924790Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

745999a9

D3D: Log why a renderer fails to initialize. · 47a1fda2

authored Dec 02, 2019

BUG=1029091

Change-Id: I80a69f5d5294522d7229976f41ba5a61a6c2724d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1945891Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

47a1fda2

VULKAN: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d · ca1b0fb8

authored Nov 25, 2019

Add the following SWANGLE test failure to
deqp_gles31_test_expectations.txt:

dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.framebuffer_texture2d

Bug: angleproject:3590
Test: None
Change-Id: I0f234ea2d7a90e2b95220b152cb0da3822df1ef3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1933764Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tobin Ehlis <tobine@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>

ca1b0fb8

Vulkan: Textures incorrect on Android maps with Vulkan Backend · 19f9f414

authored Nov 29, 2019

The issue was fixed, but adding a regression test to avoid it
again. glMemoryBarrier inserts a memory barrier and breaks the
submission order, which causes the copyBufferToImage happens
before copyImageToBuffer and image corruption. This test fails
on commit 052167bc, and can pass on the latest build.

Bug: angleproject:4074
Change-Id: Icc42dd7b2ba167815b223085ce933682654ce760
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943848
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

19f9f414

Roll third_party/SwiftShader fb7ca1d5aca5..b64fbfec4dcd (3 commits) · 8784a928

authored Dec 02, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/fb7ca1d5aca5..b64fbfec4dcd

git log fb7ca1d5aca5..b64fbfec4dcd --date=short --first-parent --format='%ad %ae %s'
2019-11-30 bclayton@google.com VkPipeline: Replace spirv-opt list with RegisterPerformancePasses()
2019-11-29 paulthomson@google.com Regres: refactor for use as a library
2019-11-29 swiftshader.regress@gmail.com Regres: Update test lists @ fb7ca1d5

Created with:
gclient setdep -r third_party/SwiftShader@b64fbfec4dcd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Id3d9dfdb0769511da8391220411aac9726ebb6b2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946094Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8784a928

Roll third_party/spirv-tools/src b334829a91d6..47f3eb42641b (1 commits) · 0e8baa59

authored Dec 02, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b334829a91d6..47f3eb42641b


Created with:
  gclient setdep -r third_party/spirv-tools/src@47f3eb42641b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I814d0cb3b82a5218140d785421b3c69d5fb8ebd3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946095Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

0e8baa59

Roll third_party/glslang/src 38b4db48f98c..83af46951202 (1 commits) · 4c23d7fe

authored Dec 02, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/38b4db48f98c..83af46951202


Created with:
  gclient setdep -r third_party/glslang/src@83af46951202

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I4476e3fdea378cb843430a21d64d2f17e13983a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1946096Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4c23d7fe

29 Nov, 2019 7 commits

Use Vulkan rectangle lines to emulate OpenGL multisampled lines · ea0dcd4b

authored Nov 29, 2019

SwiftShader recently added support for multisampled Bresenham lines to be spec
compliant with Vulkan, so now Angle must explicitly request non-Bresenham lines
when multisampling is enabled.

Bug: angleproject:4087
Change-Id: Ie854746144894e3e0a68622e985cbd4ba7781ac3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944529
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ea0dcd4b

Ignore .git_cl_description_backup · 6935b029

authored Nov 29, 2019

depot_tools used to create this file in $HOME, but now stores it in the
current repository.

Bug: None
Change-Id: Ia127c2273eb23e7acffd5d0cf7c61e5d4f521a0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944528Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

6935b029

Update flex and bison binaries for Windows. · 5e6d6c49

authored Nov 28, 2019

These binaries were updated using update_flex_bison_binaries.py.
Please see instructions in tools/flex-bison/README.md.

flex is at version 2.6.4
bison is at version 3.3.2

Bug: 3419
Change-Id: I640621e670a918c72fbb21186893a2cc438c0eb5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943027Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

5e6d6c49

Update flex and bison binaries for Linux. · 102aa522

authored Nov 28, 2019

These binaries were updated using update_flex_bison_binaries.py.
Please see instructions in tools/flex-bison/README.md.

flex is at version 2.6.4
bison is at version 3.3.2

Bug: 3419
Change-Id: Iac8d0029b18602cc6e5f495d3b8c6bc928977500
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943029Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

102aa522

Infrastructure for uploading flex/bison binaries · 7012250a

authored Nov 25, 2019

The binaries are retrieved from MSys2 on windows and built from source
on Linux. Updates to these binaries should be infrequent enough to
not warrant a completely automated system.

Bug: angleproject:3419
Change-Id: I282f9ca14059d1fe0d88f2ffd31d02df0ea6b88f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940571Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

7012250a

Roll third_party/vulkan-validation-layers/src 61050599ec0f..4fde9b750992 (1 commits) · 87e10803

authored Nov 29, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/61050599ec0f..4fde9b750992

git log 61050599ec0f..4fde9b750992 --date=short --first-parent --format='%ad %ae %s'
2019-11-28 pdaniell@nvidia.com layers: Fix VK_KHR_separate_depth_stencil_layouts bugs

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@4fde9b750992

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I8fe4e0dfced4ccbca13d54b9e8983347c57fa03e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944049Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

87e10803

Roll third_party/SwiftShader d6e903bdc9ef..fb7ca1d5aca5 (13 commits) · c96187a9

authored Nov 29, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/d6e903bdc9ef..fb7ca1d5aca5

git log d6e903bdc9ef..fb7ca1d5aca5 --date=short --first-parent --format='%ad %ae %s'
2019-11-28 bclayton@google.com SpirvShaderEnumNames: Use spirv-tools' spvOpcodeString()
2019-11-28 bclayton@google.com Rename SpirvShader_dbg.cpp -> SpirvShaderEnumNames.cpp
2019-11-28 bclayton@google.com SpirvShader: Remove now unused includes
2019-11-28 bclayton@google.com SpirvShader: Move arithmetic ops to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move image handling to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move spec ops to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move group ops to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move memory ops to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move control flow handling to new cpp file
2019-11-28 bclayton@google.com SpirvShader: Move GLSLstd450 handling to new cpp file
2019-11-28 bclayton@google.com Pipeline: Move utility functions to ShaderCore
2019-11-28 jmadill@chromium.org Fix ICD generation (again).
2019-11-28 bclayton@google.com Regres: Use android.googlesource.com for dEQP

Created with:
gclient setdep -r third_party/SwiftShader@fb7ca1d5aca5

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ib5511403e97be57c78784cbec8619f6cb4907312
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1944048Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c96187a9

28 Nov, 2019 9 commits

Suppress failing end2end tests for ASAN builds · bc82fb14

authored Nov 28, 2019

GLSLTest_ES31.StructArraySample and
ComputeShaderTest.DispatchComputeIndirect both hit stack-buffer-overflow
errors with ASAN enabled, using the vulkan backend. Right now ASAN is
only tested on Mac, so these are only hit when Mac is using
swiftshader-vulkan.

Bug: 1029378
Change-Id: Ie590f73c29be44f683fd47fe4da139e1b5f96289
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943408Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

bc82fb14

Vulkan: fix alpha values in convert vertex shader · 82219d28

authored Nov 26, 2019

When reading vertex attributes, GLES requires the y and z components to
be filled with 0 if missing, and the alpha channel to be filled with 1.0
for float types and 1 for integer types.

At the same time, this change reduces the number of variations in this
shader.

Bug: angleproject:3192
Change-Id: I1bdf491952c296962fa9160f2d29d415eb3d570d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936708Reviewed-by: Jaedon Lee <jaedon1.lee@samsung.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

82219d28

Vulkan support for MacOS (using SwiftShader) · 5afd5ec6

authored Oct 25, 2019

Created a new WindowSurface/Display for MacOS/Vulkan, along with some
GN changes to get it working.

Bug: 1015454
Change-Id: I3f7a12f173795efe598856c702ce53b1e50831eb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1880163
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5afd5ec6

Suppress SimpleStateChange failure on Metal NVIDIA · 39f3ccda

authored Nov 28, 2019

BUG=angleproject:4177
TBR=geofflang@chromium.org

Change-Id: I642e4bd3650b5b6beb6d9b18106d787c5dbc14f6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1942348Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

39f3ccda

Add arm64 to libpng build configuration. · 6ebed542

authored Nov 27, 2019

In libpng build option, neon files were missing for arm64,
add "arm64" option to libpng build configuration.

BUG=angleproject:4026

Change-Id: I38280c8089be93de224959583091f3a151f94ab0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940017Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

6ebed542

Roll third_party/spirv-tools/src f31f26f73930..b334829a91d6 (4 commits) · 7fd3ad46

authored Nov 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f31f26f73930..b334829a91d6


Created with:
  gclient setdep -r third_party/spirv-tools/src@b334829a91d6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I5e77e15f61a924a4183ea49965e4b586374a5729
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941570Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7fd3ad46

Roll third_party/vulkan-tools/src 6f6e3371c92a..979b531e9fff (1 commits) · b9a9a3c7

authored Nov 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/6f6e3371c92a..979b531e9fff

git log 6f6e3371c92a..979b531e9fff --date=short --first-parent --format='%ad %ae %s'
2019-11-27 jeremyk@lunarg.com vkcube: Fix Cube Squishing on Resize

Created with:
  gclient setdep -r third_party/vulkan-tools/src@979b531e9fff

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I2d43213baf6132eefa9a9f660d3300c64af81a55
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941569Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b9a9a3c7

Roll third_party/SwiftShader 663dcefa22ea..d6e903bdc9ef (4 commits) · c5f45365

authored Nov 28, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/663dcefa22ea..d6e903bdc9ef

git log 663dcefa22ea..d6e903bdc9ef --date=short --first-parent --format='%ad %ae %s'
2019-11-28 sugoi@google.com Support multisampled Bresenham lines
2019-11-27 sugoi@google.com Support sample image instruction operand
2019-11-27 jmadill@chromium.org Fix ICD build when using multiple toolchains.
2019-11-27 chrisforbes@google.com gles: Only clamp default block uniform indexes

Created with:
  gclient setdep -r third_party/SwiftShader@d6e903bdc9ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: I0596f70dda8f3be71bda0d2fe48d2010f415e50e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941571Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

c5f45365

Roll third_party/vulkan-validation-layers/src 8c954d5a413d..61050599ec0f (6 commits) · 7bb0115c

authored Nov 28, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/8c954d5a413d..61050599ec0f

git log 8c954d5a413d..61050599ec0f --date=short --first-parent --format='%ad %ae %s'
2019-11-27 camden@lunarg.com layers: Fix naming convention in PD_STATE
2019-11-27 camden@lunarg.com layers: Remove CALLSTATE everywhere except BP
2019-11-27 jasuarez@igalia.com tests: Implement test for VK_KHR_timeline_semaphore
2019-11-27 jasuarez@igalia.com layers: Implement VK_KHR_timeline_semaphore validations
2019-11-27 digit+github@google.com build: Fix Vulkan headers detection with CMake
2019-11-27 jbolz@nvidia.com layers: Remove MemTrack-FreedMemRef that has moved to best_practices

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@61050599ec0f

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cwallez@google.com
Change-Id: Ib47de40f60be363ade83ea8f4591ff68ab272e28
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1941572Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

7bb0115c

27 Nov, 2019 8 commits

Reland "Vulkan: Accelerate Texture PBO updates" · fc3ec57d

authored Nov 27, 2019

This reverts commit 27d3c939.

Reason for revert: Investigation is unable to reproduce the regresion.
Shows up on the perf CI.

Original change's description:
> Revert "Vulkan: Accelerate Texture PBO updates"
> 
> This reverts commit efb45eda.
> 
> Reason for revert: Significant perf regression on several benchmarks.
> See bug for more details.
> 
> Bug: chromium:1027098
> 
> Original change's description:
> > Vulkan: Accelerate Texture PBO updates
> > 
> > If the format of the image and the PBO match,
> > use a vkCmdCopyBufferToImage transfer operation.
> > 
> > Test: angle_end2end_tests --gtest_filter=*PBOCompressedSubImage*
> >       angle_end2end_tests --gtest_filter=*PBOWithMultipleDraws*
> >       dEQP-GLES3.functional.texture.specification.tex*image*d_pbo*
> > Bug: angleproject:3777
> > Change-Id: I3f271024a635be113202a16f8893a199c194172d
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1906203
> > Reviewed-by: Cody Northrop <cnorthrop@google.com>
> > Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
> 
> TBR=cnorthrop@google.com,syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com,b.schade@samsung.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: angleproject:3777
> Change-Id: I774655962e9ab5a866b9324002fb8edae8550834
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939927
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>

TBR=cnorthrop@google.com,syoussefi@chromium.org,jmadill@chromium.org,m.maiya@samsung.com,b.schade@samsung.com

Change-Id: I8560a2e70de230eac3256a1df5eb2ecaa6f26bcf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1027098, angleproject:3777
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939852Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

fc3ec57d

Fix format/internalformat confusion · c4f889fb

authored Nov 25, 2019

Bug: angleproject:4084
Change-Id: I24a184b78bef2994a3045b141ecd72a49d66cfdf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934890Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>

c4f889fb

Fix string literal comparison in validation · 232d009d

authored Nov 27, 2019

String literals shouldn't be compared by pointer, especially if the
literal is declared in a header (so the two pointers can come from
different translation units, because the string literal might have a
different copy in each).

Use strcmp instead.

Bug: angleproject:4175
Change-Id: I6002ccb185f48928b67ce8a7b3508e427761a8c3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940568
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

232d009d

Roll chromium_revision 5fe256ab5e..d209d45ba4 (709762:719599) · 33adad19

authored Nov 27, 2019

Change log: https://chromium.googlesource.com/chromium/src/+log/5fe256ab5e..d209d45ba4
Full diff: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/258e22bc61..ebec9c5ad4
* buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/cf454b247c..6b3e658d6f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/85152663b9..72e16daaa5
* third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/403ca5ad3a..e77e1c06c8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/662cbb8d60..05979d8cad
DEPS diff: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4/DEPS

Clang version changed 64a362e7216a43e3ad44e50a89265e72aeb14294:e84b7a5fe230e42b8e6fe451369874a773bf1867
Details: https://chromium.googlesource.com/chromium/src/+/5fe256ab5e..d209d45ba4/tools/clang/scripts/update.py

TBR=jmadill@chromium.org,
BUG=None

Change-Id: I81aa1bc885ae18abddf04593245d1c394679a679
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940569Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

33adad19

Vulkan: Isolate DisplayVk.h from Display.cpp. · 2ed71c81

authored Nov 27, 2019

With this change we no longer can access Vulkan (or Volk) headers
in the ANGLE front-end. The only header that needs to be visible is
the new "DisplayVk_api.h".

This will simplify a bit of Volk integration.

Also reworks how the entry points and headers are exposed to the tests.

Bug: angleproject:3740
Change-Id: Ic1434f304619427ed6ad6370bc090ceb7858df94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1936707
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tobin Ehlis <tobine@google.com>

2ed71c81

Add EGLSurfaceTest.ResizeWindowWithDraw · 2a72553d

authored Nov 25, 2019

This test will ensure the backbuffer is also properly resized when
the window is resized.

Bug: angleproject:4167
Change-Id: I1d73f07379b4f05e453520e22ef1369f51182197
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934311
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2a72553d

Suppress -Wsizeof-array-div in dEQP. · ea1c2400

authored Nov 27, 2019

Until the upstream bug is fixed. Tracked in
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/2127

Bug: angleproject:4176
Change-Id: I094735e1153c83439db54b43545297466ef2e2c7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940570Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

ea1c2400

Metal: re-enable end2end tests · b6148c3a

authored Nov 21, 2019

Bug: angleproject:4157
Change-Id: Ia7e29c32696c84556e9ea527fc48b086b1bc4766
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940007
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

b6148c3a