Skip to content

A
angle
Switch branch/tag
  1. 18 Jan, 2019 2 commits
    • Vulkan: Store reference to context command buffer. · 85ca1895
      Jamie Madill authored 
      This frees us from checking the FB every draw. Slightly reduces time
spent in all draw methods. Improvement seen on the draw call overhead
tests. Scores went from 28.17 ns/draw to 26.76 ns/draw on my machine.

In a future improvement we could make this command buffer a dirty bit.
Currently it's a bit slower to call a handler function due to the
dispatch table. Likely we could optimize this by reverting back to a
dirty bit switch and inlining the handler functions. That is left for
future work.

Vulkan is happy enough to run multiple RenderPasses and bind different
Pipelines in the same command buffer. But ANGLE defers RenderPass init
until we submit our work. Thus we can only support one RenderPass per
secondary buffer.

Test: angle_perftests DrawCall*/vulkan_null
Bug: angleproject:3014
Change-Id: I89fd0d9e0822400a5c5a16acb5a9c400a0e71ab5
Reviewed-on: https://chromium-review.googlesource.com/c/1393905
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
    • Suppress test crashing on Mac ASAN. · 3159b2e5
      Corentin Wallez authored 
      GLSLTest_ES3.LargeNumberOfFloat4Parameters/ES3_OPENGL started crashing
after the parallel compile enablement on OpenGL and disabling the
workers didn't fix it.

BUG=angleproject:3087

Change-Id: I317b140e66b04102059486381ef70e16600fad12
Reviewed-on: https://chromium-review.googlesource.com/c/1419007Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
  3. 17 Jan, 2019 6 commits
    • Include common/platform.h where used · 5fe7c5b9
      Yuly Novikov authored 
      Bug: 922443
Change-Id: I35b9e34266d4a15f8d0769c2770801b1b0511398
Reviewed-on: https://chromium-review.googlesource.com/c/1418091Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
    • Reland "Don't call Texture::onDestroy twice for the zero textures." · d46165e3
      Geoff Lang authored 
      This reverts commit 3adcf1e4.

Reason for revert: Likely not the cause of failures seen.

Original change's description:
> Revert "Don't call Texture::onDestroy twice for the zero textures."
> 
> This reverts commit d3e0e84c.
> 
> Reason for revert: likely cause for crbug.com/922296
> 
> BUG=chromium:922296
> 
> Original change's description:
> > Don't call Texture::onDestroy twice for the zero textures.
> > 
> > The BindingPointer will call onDestroy when all references are removed, no
> > need to do it explicitly.
> > 
> > BUG=angleproject:3070
> > 
> > Change-Id: Ic5dd4da8f73e204d26d9d3a3c6e1eff9fded5411
> > Reviewed-on: https://chromium-review.googlesource.com/c/1409868
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Geoff Lang <geofflang@chromium.org>
> 
> TBR=geofflang@chromium.org,jmadill@chromium.org
> 
> Change-Id: I38097218d49940e7ac3ad914714294b019c154fd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: angleproject:3070
> Reviewed-on: https://chromium-review.googlesource.com/c/1413239
> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,cwallez@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:922296, angleproject:3070
Change-Id: I58b1c445f81e4a7f38df375fd3311043b571e834
Reviewed-on: https://chromium-review.googlesource.com/c/1417770Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
    • GL: Temporarily disable parallel shader compile. · c66cd693
      Geoff Lang authored 
      The Skia bots have been unable to roll ANGLE since parallel compile landed in
ANGLE.  Speculatively disable parallel compile using a workaround.
Failed roll: https://skia-review.googlesource.com/c/skia/+/184705

Also seen instability on Linux, Mac and Windows in 922936.

BUG=922936
BUG=849576

Change-Id: I7116b3f6541425135984c52a8077bdb98d961784
Reviewed-on: https://chromium-review.googlesource.com/c/1415729Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
    • Revert "Re-enable 2DArray Copy Texture Tests" · b3bdd2ac
      Jamie Madill authored 
      This reverts commit 91b95ce0.

Reason for revert: Tests passing in release but failing in Debug.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Debug%20%28NVIDIA%29/2556

[ RUN      ] Texture2DArrayCopy.SnormFormats/ES3_D3D11
Error getting extension string from EGL Window.
../../third_party/angle/src/tests/test_utils/ANGLETest.cpp(493): error: Expected equality of these values:
  (0x3000)
    Which is: 12288
  eglGetError()
    Which is: 12289
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x00AD4A9A+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00AEAD5A+74]
	testing::internal::AssertHelper::operator= [0x00AEA86B+75]
	ANGLETestBase::swapBuffers [0x00A743C0+256]
	ANGLETestBase::ANGLETestTearDown [0x00A73817+167]
	ANGLETest::TearDown [0x00A7671A+26]
	angle::CopyTexture3DTest::TearDown [0x002A085D+29]

[  FAILED  ] Texture2DArrayCopy.SnormFormats/ES3_D3D11, where GetParam() = ES3_D3D11 (59 ms)
[----------] 1 test from Texture2DArrayCopy (59 ms total)

[----------] 3 tests from CubeMapTextureTest
[ RUN      ] CubeMapTextureTest.RenderToFacesConsecutively/ES2_D3D11_10_0
Assertion failed: mState.surfaceSet.empty(), file ../../third_party/angle/src/libANGLE/renderer/DisplayImpl.cpp, line 23
abort() has been called
Received fatal exception EXCEPTION_BREAKPOINT
Backtrace:

Original change's description:
> Re-enable 2DArray Copy Texture Tests
> 
> Re-enables 3 tests that were previously failing on Nvidia hardware on
> D3D11. The tests seem stable after a trybot driver update.
> 
> Bug: angleproject:2896
> Change-Id: I17d76a5a67fd57ba7257ef22aa5a1371bf5ed55e
> Reviewed-on: https://chromium-review.googlesource.com/c/1308735
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

TBR=geofflang@chromium.org,jmadill@chromium.org,brandon1.jones@intel.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:2896
Change-Id: I509756e8e6433fd3d04bc68a72e7cc7647485b56
Reviewed-on: https://chromium-review.googlesource.com/c/1417771Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
    • ES31: Enable several SSBO end2end tests on D3D11 · 94d8a9a4
      Jiawei Shao authored 
      This patch enables several SSBO tests on D3D11 in ANGLE end2end
tests.

Bug: angleproject:1951
Change-Id: I1ba78133e5bbe581e8330c1c43755c174e28bf39
Reviewed-on: https://chromium-review.googlesource.com/c/1415721Reviewed-by: 's avatarJiajia Qin <jiajia.qin@intel.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
    • ParallelCompile: add GL backend support · a100d8f4
      jchen10 authored 
      For GL backend, at first each worker thread must have a naitve context
for its own to work in. These worker contexts have to be shared from
the main context, so that all shader and program objects are seen in
any context. This extends backend displays to create and destroy the
worker contexts. RendererGL manages and allocates them to the worker
threads. ShaderImpl has a new compile method added to do the actual
glCompile work in worker thread. The ProgramGL's link method is broken
down by introducing the LinkEventGL class.

Bug: chromium:849576

Change-Id: Idc2c51b4b6c978781ae77810e62c480acc67ebb5
Reviewed-on: https://chromium-review.googlesource.com/c/1373015
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: 's avatarGeoff Lang <geofflang@chromium.org>
  5. 16 Jan, 2019 9 commits
  7. 15 Jan, 2019 7 commits
  9. 14 Jan, 2019 4 commits
  11. 11 Jan, 2019 6 commits
  13. 10 Jan, 2019 6 commits