- 31 Mar, 2020 9 commits
-
-
Kenneth Russell authored
On dual-GPU MacBook Pros, the maximum number of supported samples can differ between the integrated and discrete GPUs, leading to unexpected OpenGL errors in applications. Detected with WebGL conformance tests in Safari with ANGLE as the WebGL backend. Bug: angleproject:4518 Change-Id: I54997cbb83afd76d98b16d138d117d0afdeec5e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125407Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org>
-
Cody Northrop authored
Rather than capture and replay a format that is not cross platform, limit the number of exposed binary formats to zero when FrameCapture is enabled. Test: Temple Run capture and replay Bug: b:152512564 Bug: angleproject:3662 Change-Id: I4a7bc5a353d2cdb1dceb1276a3c61bfbb74dc2f7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128327 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Jamie Madill authored
This switches where we notify the Texture class that the back-end has a dirty staging buffer. Previously we notified in every possible code site in TextureVk. Now we notify in a single centralized location in the staging buffer. This will allow us to stash clears in the staging buffer in the FramebufferVk class via RenderTargetVk. And ultimately let us defer clears to fix Manhattan's rendering feedback loop. Bug: angleproject:4517 Change-Id: I67760f133e2c58feddbba3d1062de0b966bac281 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128546Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Ancheng Qiao authored
Bug: angleproject:3983 Change-Id: I9c487cc7db5d5e22a6cff00b40e4081498ab771f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128207 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/344bd0889ac9..e157435c1e77 Created with: gclient setdep -r third_party/glslang/src@e157435c1e77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: Ie7037a9f4ab93c119eacddbfac2ebf8d903da166 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129394Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/bec7b6e29260..d712a6b03b9e git log bec7b6e29260..d712a6b03b9e --date=short --first-parent --format='%ad %ae %s' 2020-03-30 jeremyk@lunarg.com build: Update glslang commit ID in known-good.json 2020-03-30 jeremyk@lunarg.com travis: Add clang-format verions output to travis 2020-03-30 jeremyk@lunarg.com docs: Update clang-format version in docs 2020-03-28 charles@lunarg.com vulkaninfo: Fix lack of display throwing on linux Created with: gclient setdep -r third_party/vulkan-tools/src@d712a6b03b9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-tools-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I3b3438f38c4c1adbe18ddc575b93cba1f85a7fa7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129395Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1c29477aa06e..5cf1e9a31c90 git log 1c29477aa06e..5cf1e9a31c90 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 capn@google.com Fix implicit narrowing cast 2020-03-30 capn@google.com Eliminate the legacy PowerVR SDK 2020-03-30 capn@google.com Integrate PowerVR OpenGL ES samples 2020-03-30 capn@google.com Fix completeness test of OpenGL ES immutable textures 2020-03-30 cwallez@google.com Revert "MetalSurface: set layer.device to a ref of the system default device." 2020-03-30 cwallez@cwallez-macbookpro3.roam.corp.google.com MetalSurface: set layer.device to a ref of the system default device. Created with: gclient setdep -r third_party/SwiftShader@5cf1e9a31c90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: I88c367ed84cfe46586020e8c4fdbd06d46ec5b82 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129397Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/b0c27ce32864..ba07fa0be82c git log b0c27ce32864..ba07fa0be82c --date=short --first-parent --format='%ad %ae %s' 2020-03-30 charles@lunarg.com loader: fix mispelling of implement Created with: gclient setdep -r third_party/vulkan-loader/src@ba07fa0be82c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cwallez@google.com Change-Id: If5e74f8cb4e7f7c79bf8d2f8f000f0acdd69a2b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129398Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Yuly Novikov authored
dEQP.EGL/functional_sharing_gles2_multithread_random_egl_server_sync_shaders_compile_9 EGLSurfaceTest.ResizeWindow AttributeLayoutMemoryIndexed.Test Bug: angleproject:4495, angleproject:4453, angleproject:4502 Change-Id: Iad5097412372acc8ac36c742445763451c8122ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2129181Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
- 30 Mar, 2020 9 commits
-
-
Geoff Lang authored
When a new texture is bound, the texture binding state is updated before updating the active texture cache. With this ordering, it is possible to delete the currently bound texture when the binding changes and then use-after-free it when updating the active texture cache. BUG=angleproject:1065186 Change-Id: Id6d56b6c6db423755b195cda1e5cf1bcb1ee7aee Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124588 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Alexis Hetu authored
This cl adds the ability for the ReadPixels function to read other attachments than the color attachment. Checks were added for both depth and stencil attachments. A new test was added (DepthStencilFormatsTest.DepthStencilReadback) to test this new functionality. As the name mentions, it's used to test reading from the depth and stencil attachments using ReadPixels. Bug: angleproject:4295 Change-Id: I6fe9be11f05d6055a5883b4315f870e7c0ac41ad Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031702 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Corentin Wallez authored
This reverts commit 617cb015. Reason for revert: Seems to cause rolls in Chromium to fail: https://chromium-review.googlesource.com/c/chromium/src/+/2127135 Original change's description: > Enable blob cache when debugging > > We've had several issues with shader caches which are only implemented > on Android which makes them challenging to debug. > The existing BlobCache object has a default implementation that is > disabled by default. When debug layers are enabled resize the default > cache so that it gets used and provides behavior closer to Android. > This caching will be enabled when debug layers are enabled, e.g. > EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. > This is done for angle_end2end_tests and deqp tests. > > Bug: b:152292873 > Change-Id: I9dcd90a1a8da88127bf8dac25031056b7279207e > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113133 > Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> TBR=courtneygo@google.com,ianelliott@google.com,jmadill@chromium.org Change-Id: I42a445b93eff1237b05a82d2836c218b9bbbd08b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:152292873 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128106Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
-
Cody Northrop authored
This CL implements the GL_EXT_compressed_ETC1_RGB8_sub_texture extension, which was added to relax restrictions on using ETC1_RGB8_OES for subimage updates. Test: Temple Run on Android Bug: b:152512564 Change-Id: I78cfd7dfd54fab36dee59a93b3ec3bfce17e73e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123232 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Courtney Goeltzenleuchter authored
We've had several issues with shader caches which are only implemented on Android which makes them challenging to debug. The existing BlobCache object has a default implementation that is disabled by default. When debug layers are enabled resize the default cache so that it gets used and provides behavior closer to Android. This caching will be enabled when debug layers are enabled, e.g. EGL_PLATFORM_ANGLE_DEBUG_LAYERS_ENABLED_ANGLE attribute is true. This is done for angle_end2end_tests and deqp tests. Bug: b:152292873 Change-Id: I9dcd90a1a8da88127bf8dac25031056b7279207e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2113133 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/55f01953d6e9..9a0f2d99fd5d git log 55f01953d6e9..9a0f2d99fd5d --date=short --first-parent --format='%ad %ae %s' 2020-03-27 jbolz@nvidia.com tests: Test VUID-VkSparseImageMemoryBindInfo-image-02901 2020-03-27 jbolz@nvidia.com layers: Implement VUID-VkSparseImageMemoryBindInfo-image-02901 2020-03-27 jbolz@nvidia.com scripts: Make safe structs 'union' or 'struct' to match the Vulkan headers 2020-03-27 mark@lunarg.com docs: Update clang-format required version Created with: gclient setdep -r third_party/vulkan-validation-layers/src@9a0f2d99fd5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I549a97494f1f9ba332488c6653888aa4920d394b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126479Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/02e15b249b12..1c29477aa06e git log 02e15b249b12..1c29477aa06e --date=short --first-parent --format='%ad %ae %s' 2020-03-29 capn@google.com Don't expose the sampling routine cache's mutex 2020-03-29 capn@google.com Create PowerVR targets if submodule already exists 2020-03-28 bclayton@google.com Regres: Generate coverage data on nightly runs 2020-03-28 bclayton@google.com Subzero Coroutines: Use ultra-low-level marl APIs 2020-03-28 bclayton@google.com Subzero: Ensure coroutines are same-thread. 2020-03-28 capn@google.com Rename constant cache to snapshot cache 2020-03-28 capn@google.com Add sampling routine documentation 2020-03-27 sugoi@google.com Fix Android.bp following the SPIRV-Tools update 2020-03-27 bclayton@google.com Regres: Switch to building with LLVM 10 2020-03-27 bclayton@google.com Regres: Add llvm.Version.Download() to download and verify a LLVM toolchain 2020-03-27 bclayton@google.com Kokoro: Test LLVM 10 backend for ubuntu 2020-03-27 bclayton@google.com Coverage: Add 'turbo-cov': a faster reimplementation of llvm-cov 2020-03-27 capn@google.com Don't download all submodules for Kokoro tests 2020-03-27 bclayton@google.com Reactor: Disable more warnings to get LLVM 10 building 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/darwin. 2020-03-27 bclayton@google.com LLVM 10: Add configs/common and configs/linux. 2020-03-27 sugoi@google.com Update SPIR-V Tools to fd773eb50 2020-03-27 sugoi@google.com Update SPIR-V Headers to f8bf11a02 2020-03-27 digit@google.com Remove two minor compiler warnings/errors: Created with: gclient setdep -r third_party/SwiftShader@1c29477aa06e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I46d87ba91dbad14dacc8e1aac9994917912edf25 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126481Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/cc481ef27631..b0c27ce32864 git log cc481ef27631..b0c27ce32864 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 mikew@lunarg.com tests: Use complete version from header 2020-03-27 mikew@lunarg.com loader: Use complete version from header Created with: gclient setdep -r third_party/vulkan-loader/src@b0c27ce32864 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I4d3d4af2ac995fb18150c03942b4cb3969fef2b6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126482Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/99508c1ce389..344bd0889ac9 Created with: gclient setdep -r third_party/glslang/src@344bd0889ac9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Id2316c86a9281d419b78fe8f8e48fb601ef6e0a1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2126478Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 28 Mar, 2020 7 commits
-
-
Tim Van Patten authored
The varying validation is being refactored to better handle separable programs. Some additional validation is being added as well regarding: - Number of varyings (inputs vs outputs) - Precision This refactor will also allow ProgramPipelines to validate varyings between shaders that are in different Programs. Bug: angleproject:3570 Change-Id: I13f324da2ffea039e696962d6971a54f7a7b6f77 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2083847 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Tim Van Patten authored
The classes ProgramInfo and ShaderInfo are being moved into ProgramExecutableVk along with the ProgramVk members mDefaultProgramInfo and mLineRasterProgramInfo. This refactor is necessary since these members are common between ProgramVks and ProgramPipelineVks. Bug: angleproject:3570 Change-Id: I94cdb1096c6a0c007d858135af694da58d7897ff Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068901 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
To support Program Pipeline Objects, the SPIR-V transformations must be completed at draw time once all of the variable locations are known. To achieve this, the transformation work is being refactored into TransformSpirvCode() which can be called separately from GlslangGetShaderSpirvCode(). Bug: angleproject:3570 Change-Id: Ia479cb2e4b4201e37acd0859c70081cecb80d0bf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2068900 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Tim Van Patten authored
The ShaderInterfaceVariableInfoMap information is specific to each shader stage, since the locations are determined for each shader stage. This change makes mVariableInfoMap a gl::ShaderMap<> to handle this, which will make it easier to compile separable programs, determine the variable locations, and transform the SPIR-V. Bug: angleproject:3570 Change-Id: I28b71a37efe54bbcfe1dcd445fa03ee71e74f0a6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2062741 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Tim Van Patten authored
Variable locations and descriptor set/binding values are calculated multiple times: - Compiling GLSL->SPIR-V - Creating the Vulkan pipeline layout - Updating descriptor sets These values should instead be calculated once and reused throughout since they won't change without recompiling the shader program. Bug: angleproject:3570 Change-Id: I5d8767b3b2e2f741aade7fec9991eea53ee2eb98 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2067101 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Tim Van Patten authored
The ProgramExecutableVk class is being created to collect data structures that are common to both ProgramVks and ProgramPipelineVks, as well as any shared functions. This allows callers to make Program-/ProgramPipeline- specific queries without needing to know exactly which responded by querying the current ProgramExecutableVk. This will also allow the necessary data structures to only be populated and stored within the ProgramExecutableVk when necessary and reused as often as necessary. A few things are being moved into this class: - mVariableInfoMap This information will be required to defer translating the SPIR-V until when the vulkan pipeline layout is determined and the actual locations are known. This will also allow removing determining these locations twice (during GLSL->SPIR-V compilation and pipeline layout). - createPipelineLayout() - update*DescriptorSet() - Descriptor Set Layout lists - Pipeline Layout - Various other functions/members related to pipeplines, descriptor sets, etc. Bug: angleproject:3570 Change-Id: I4b5ababeafec865148783c8ffd4c15f659f4856d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055656 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Yuly Novikov authored
Were previosly FAIL, but crash on Windows SwANGLE. Bug: angleproject:4414 Change-Id: Iefe1625f7ad3eec8ba091ec3543e8cb699c62c65 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2125370Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
-
- 27 Mar, 2020 11 commits
-
-
Jamie Madill authored
This should enable some cases of limited support for feedback loops with depth/stencil buffers. For example with Manhattan and the Vulkan back-end. Increases the number of RenderPasses in Manhattan slightly. This will regress performance slightly until we can work out a better solution that is also conformant with the spec. Bug: angleproject:4517 Change-Id: I2758e6b4c2a930474c09cdc0950f3b6c34541089 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2106670 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com>
-
Tim Van Patten authored
The active samplers and images are being moved from Program into ProgramExecutable to unify interacting with them for Programs and ProgramPipelines Also, create some helper functions for gl::Program that ProgramExecutable can call to make it easier for ProgramPipeline to respond to similar queries for each of the Programs in the ProgramPipeline. Bug: angleproject:3570 Change-Id: I0b37f1a379e56b9659d82d92f6d7a546beee11cd Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2087648 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
Bug: angleproject:4517 Change-Id: I3231b129718019f83495843404cd011eb2cd480d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2122689 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tobin Ehlis <tobine@google.com>
-
Jamie Madill authored
Also includes some documentation maintenance. Bug: angleproject:4511 Change-Id: I7ecce494909f06387875ff85a10004d0c446bbaf Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124597Reviewed-by:
Geoff Lang <geofflang@chromium.org>
-
Jamie Madill authored
Currently this is a pure refactor and doesn't change any functionality. In a follow-up we can us this bit to mask out DS RTs when Manhattan and other apps render with feedback loops. Bug: angleproject:4517 Change-Id: I80ccd022d90a781506791110d11be195db8cd3e9 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2112936Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Geoff Lang authored
mImage2DUniforms was not saved with the program binary causing shaders with images to fail compilation when loaded from binary. BUG: angleproject:4519 BUG: b:152292873 Change-Id: I51581031ae1f9d4b4d986057ef3f876d809c7f24 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2124587Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
-
Tim Van Patten authored
The ProgramExecutable class is being created to collect data structures that are common to both Programs and ProgramPipelines, as well as any shared functions. This allows callers to request the current ProgramExecutable from the State and make Program-/ProgramPipeline-specific queries without needing to know exactly which responded. This will also allow the necessary data structures to only be populated and stored within the ProgramExecutable when necessary and reused as often as necessary. Bug: angleproject:3570 Change-Id: I101f08ab03421894667b4a426a04d2147489f0e1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040512 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/acbf316040c3..cc481ef27631 git log acbf316040c3..cc481ef27631 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 udknight@gmail.com docs: Fix wrong type name in InterceptFunctionName prototype Created with: gclient setdep -r third_party/vulkan-loader/src@cc481ef27631 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I8ba7480037117cce4e2ba8f5f851fa1cce890b88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123983Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/2df8c71258de..99508c1ce389 Created with: gclient setdep -r third_party/glslang/src@99508c1ce389 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I9ddd9b7cfdee4b54da8e1a36a8c46283ef09e75d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123981Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/443c2caa1714..55f01953d6e9 git log 443c2caa1714..55f01953d6e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 s.fricke@samsung.com layers: Fix renderpass2 VUID Created with: gclient setdep -r third_party/vulkan-validation-layers/src@55f01953d6e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: Ib8b7160e7c1691cec71a50509676fa739919d520 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123982Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/77090261dabc..02e15b249b12 git log 77090261dabc..02e15b249b12 --date=short --first-parent --format='%ad %ae %s' 2020-03-26 bclayton@google.com third_party: Create scripts for updating spirv-[tools|headers] 2020-03-26 capn@google.com Fix taking aspect into account for image view identifiers 2020-03-26 bclayton@google.com Kokoro: Move llvm configs into 7.0 subdirectory, create 10.0 copies. 2020-03-26 bclayton@google.com Regres: Add support for generating collated coverage info 2020-03-26 bclayton@google.com CMake: Emit coverage-toolchain.txt file next to ICD json 2020-03-26 bclayton@google.com CMake: Add SWIFTSHADER_EMIT_COVERAGE option 2020-03-26 bclayton@google.com CMake: Add option for selecting LLVM version. 2020-03-26 bclayton@google.com Merge "Initial drop of LLVM 10 to third_party/llvm-10.0" Created with: gclient setdep -r third_party/SwiftShader@02e15b249b12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I6250b123e1feed7defddeeb0197b03f7182d43e4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2123980Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 26 Mar, 2020 4 commits
-
-
Cody Northrop authored
Tested with several apps that can't be captured otherwise. Bug: angleproject:3611 Change-Id: I2ad18c3bfcab48b0b385b2a868f57369c292b602 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1998838Reviewed-by:
Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cody Northrop authored
Autoroller for glslang was paused, breaking layer build. Replaces: https://crrev/c//2119884 TBR: courtneygo@google.com Bug: b:152298150 Bug: angleproject:4510 Change-Id: I6c431a76455c991cbbb8621050dbf74acf8eea41 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121903Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/fb7f9c9bcd1d..0e78ffd1dcfc git log fb7f9c9bcd1d..0e78ffd1dcfc --date=short --first-parent --format='%ad %ae %s' 2020-03-24 oddhack@sonic.net Update for Vulkan-Docs 1.2.136 Created with: gclient setdep -r third_party/vulkan-headers/src@0e78ffd1dcfc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-headers-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=cnorthrop@google.com Bug: None Change-Id: I17d7b9ba8e96fa1e3dab15260436b71887d55536 Tbr: cnorthrop@google.com Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2121708Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/ff44f21a0178..acbf316040c3 git log ff44f21a0178..acbf316040c3 --date=short --first-parent --format='%ad %ae %s' 2020-03-23 charles@lunarg.com scripts: stubs in dispatch table lacked matching return types Created with: gclient setdep -r third_party/vulkan-loader/src@acbf316040c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-loader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I5505867022ca850e4b94e1bf4454c03ec93850a8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2119885Reviewed-by:
angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-