Commits · aa2d400a2bd179d8fd331df15d3d90a166b1592a · Chen Yisong / angle

16 Apr, 2021 9 commits

Vulkan: Add test for FBO with unequal sized attachments · aa2d400a

authored Apr 12, 2021

Before OpenGLES3.0, framebuffer object with unequal sized attachment is
considered incomplete. That restriction has been removed in ARB version
of spec and is legit use in OpenGLES 3.0. This adds a test for this
specific usage.

Bug: b/181800403
Test: FramebufferTest_ES3.AttachmentWithUnequalDimensions
Change-Id: I79608bfd8f10855c6fc47511e080ba3ca4e46c59
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824366Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Charlie Lao <cclao@google.com>

aa2d400a

Skip failing test on AMD/Linux · e8b18e79

authored Apr 16, 2021

This test was suppressed on AMD/Windows already.

Bug: angleproject:5687
Bug: angleproject:5874
Change-Id: I9b6bac81adc017f80634271063d53f3d4eebba0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2831993Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

e8b18e79

Reland "Reland "Add support for Linux GPU info with Vulkan backend"" · ed4f7cb6

authored Mar 03, 2021

This is a reland of 9a839732

Chrome Linux crash issue could be fixed in
0615bbde, let's reland this now.

Original change's description:
> Reland "Add support for Linux GPU info with Vulkan backend"
>
> This is a reland of 5c09c1f8
>
> Extra change: Add new ANGLE_HAS_VULKAN_SYSTEM_INFO compile
> variable for GetSystemInfoVulkan() in linux platform.
>
> Original change's description:
> > Add support for Linux GPU info with Vulkan backend
> >
> > 1. Add support for Linux GPU info with vulkan backend: for
> > dev board without PCI support, try vulkan backend to get
> > GPU info.
> > 2. Fix getVulkanInstance() issue when loading non-exist lib:
> > return NULL instance if open lib failed.
> >
> > Bug: angleproject:5717
> > Change-Id: I03c11da25a8787496d098f6c9d6b4c53701383e4
> > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2734375
> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> > Reviewed-by: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Jamie Madill <jmadill@chromium.org>
>
> Bug: angleproject:5717
> Change-Id: Iaaab8f512b6ec1d524d7ebb3b4252fec3cfe7dc3
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2739097
> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:5717
Change-Id: Iad6736f9137b7e9640c97fa2b9eded3fd37ac88f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821410Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

ed4f7cb6

Migrate more scripts to python3 · 14f8918c

authored Apr 16, 2021

Test: python3 scripts/run_code_generation.py
Bug: angleproject:5707
Change-Id: I5abae69c1c6bf03cc418f10beaabc80288fa1c94
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2828979Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

14f8918c

Remove 3pp files in third_party/jdk. · 69a26def

authored Apr 15, 2021

These files should not be duplicated from Chrome, they are used
as part of Chrome's rolling process for these deps.

Bug: angleproject:5839
Change-Id: If95b11585e5aa7d8f834412d41dca377c495b1fb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829330Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

69a26def

Vulkan: Handle non array type varying error case in TS · 2561c646

authored Mar 19, 2021

Tessellation control, tessellation evaluation and geometry shader
per-vertex input variables and blocks are required to be declared
as arrays. Ensure these variables meet the requirements and error
out if they don't.

Bug: angleproject:5557
Test: KHR-GLES32.core.tessellation_shader.compilation_and_linking_errors.te_non_arrayed_per_vertex_input_blocks
Change-Id: I0213fcc6fab90dea7597462a65cbbb7777e67108
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774759
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2561c646

Roll Chromium from cac0b331e3fc to 11d568cbfed1 (483 revisions) · f78ec9db

authored Apr 16, 2021

https://chromium.googlesource.com/chromium/src.git/+log/cac0b331e3fc..11d568cbfed1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/e966858a7e..e00ea2a33f
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/4ef8239f68..5d440f33b4
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c30133fce5
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b1cc5ed9e8..f959d17028
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fae4e7d723..5e7cca9ca0
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I88c789cd45eb5dbdc4d002029d4fddade79aa06c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830144
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

f78ec9db

Reland: Metal: Support importing external metal textures · f2aa9d5d

authored Apr 11, 2021

This relands I4d4a88cfbb77d8b7508b787c7fec44073d3b11b0.

Fixes:
- uninstantiated ImageTestMetal error
- failed ImageTest.ANGLEExtensionAvailability on ARM mac.

Bug: angleproject:5763
Bug: angleproject:5814
Change-Id: I906fe52baefd6be3c6e00f594795bd527df01616
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2820178Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Le Hoang Quyen <le.hoang.q@gmail.com>

f2aa9d5d

Android: Include android-deps into Android checkout. · eac31b7d

authored Apr 15, 2021

These auto-generated deps are necessary for the standalone build.
Updates the roll script to start including these automatically.

Bug: angleproject:2344
Change-Id: I389c203a2ddb971e3aeccb728cf37e232f32031e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826479
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

eac31b7d

15 Apr, 2021 14 commits

Vulkan: Implement shader buffers descriptor cache. · 0c77f3ad

authored Mar 10, 2021

Implements a descriptor set cache for UBOs, SSBOs, and atomic counter
buffers. Storage Images and framebuffer fetch input attachments are
not yet included. Requires moving the buffer barrier handling into
ContextVk, similarly to how we handle the barriers for Textures.

The packed description key for the descriptors uses a "fast" vector
with a basic minimum size. For most cases of a few buffers this will
fit easily in stack memory, but for larger programs with many buffers
we fit this into heap memory. The key has a large upper bound due to
the high ES 3.2 requirements and the need to index several values such
as the offset and binding size.

We use dynamic offsets for uniform buffers when possible. This ensures
applications like Manhattan 3.1 that use sets of common buffers with
changing offsets hit the cache most of the time.

Because of resource limits we pick at compilation time whether to use
dynamic or static descriptor sets. Mostly this applies to tests that
use a large number of uniform buffers. A future implementation could
be smart and would recompile the program with heuristics to use a
minimal number of dynamic indices.

Reduces the number of descriptor set updates from ~300 -> ~30 per frame
in Manhattan 3.1 and in Asphalt 9 from 900+ to as low as 0 per frame.

Bug: angleproject:5736
Change-Id: I5c2a3881bec90d301dab15cc86c8a70e60674ad7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757515
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

0c77f3ad

Generate CL enums in libGLESv2 · 8226dc23

authored Apr 15, 2021

Bug: angleproject:5869
Change-Id: Ie547d415bed37accef6cb62d28bc6b088a1eb810
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2829370Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: John Plate <jplate@google.com>

8226dc23

Capture/Replay: Add PPO/glProgramUniform support · fbfecbe2

authored Apr 07, 2021

Command and Conquer: Rivals requires additional frame capture API
support:
- Program Pipeline Objects
- glProgramUniform*

Bug: angleproject:5830
Change-Id: I159086f92d2dfead0a513cd17fadeda7df92f408
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2809891
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

fbfecbe2

Remove suppression for fixed CTS tests · 4f68a4ee

authored Apr 06, 2021

CTS bugs are fixed in [1] and [2].

[1]: https://gerrit.khronos.org/c/vk-gl-cts/+/7062
[2]: https://gerrit.khronos.org/c/vk-gl-cts/+/7049

Bug: angleproject:5673
Change-Id: I2d86f53a6a83bab143f89896d4d5dab3cc7b2334
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2808053Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

4f68a4ee

Vulkan: Consolidate mReadOnlyDepthStencilMode to mRenderPassUsageFlags · fb288312

authored Apr 12, 2021

Since now ImageHelper object has a mRenderPassUsageFlags tracking how it
is been used by current RenderPassCommands, we can consolidate
mReadOnlyDepthStencilMode into a bit in the mRenderPassUsageFlags. The
read only mode is just a special attachment mode, so this makes code
more consistent and able to get rid of the extra dword for
mReadOnlyDepthStencilMode.

Bug: b/181797383
Change-Id: Ie9b7be1c18c392e5b2712bdae6ab6506de8d6d34
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821942
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

fb288312

Vulkan: Support sample/render to depth texture with different LOD · 5eac3169

authored Apr 09, 2021

Previously we supported read only depth attachment that attachment and
sample are using the same texture. It was always assuming it will be
read only if the same texture is attached to FBO and same time bound to
texture unit. But we never supported if it actually writing to depth
texture, but at the different level with sampling. This is supported
OpenGL operation as long as the levels render to is outside [base_level,
max_level]. Later on, we added support of the above operation, but
limited to color buffers. This CL extends the same support of render and
sample to the same depth texture with non-overlapping levels. Android
game black desert mobile is running into this usage case.

Bug: b/181797383
Change-Id: I7ee1d52f27603f933102ad1b098684309449c406
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819487
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

5eac3169

Vulkan: Add test for render+sample depth texture with non-overlap LOD · e55462b9

authored Apr 09, 2021

Render and sample from the same texture and then bind to another FBO
without trigger texture bind should still detect the condition that it
is render and sample same texture.

Render to depth texture and sample form the same depth texture but with
non-overlapping levels should work.

Bug: b/181797383
Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLODAndFBOSwitch
Test: FramebufferTest_ES3.RenderSampleImmutableDepthTextureWithExcludedLevel
Change-Id: I0d330d6f9530eb4fea417019a627890c4a5c1154
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2819486
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>

e55462b9

Roll VK-GL-CTS from c4e6dbe68e04 to ededa67cb12a (76 revisions) · 1a146f07

authored Apr 06, 2021

https://chromium.googlesource.com/external/github.com/KhronosGroup/VK-GL-CTS.git/+log/c4e6dbe68e04..ededa67cb12a

2021-04-13 timvp@google.com Always include sys/system_properties.h for Android
2021-04-09 juha.heiskanen@siru.fi Add primitive topologies for XFB query tests
2021-04-09 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-04-09 s.fricke@samsung.com Add OpImageQuerySamples with Storage Image test
2021-04-09 jdarpinian@chromium.org EXT_multisampled_render_to_texture test using ReadPixels
2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-04-08 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2021-04-07 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-04-07 jajones@nvidia.com Add CMake detection logic for libdrm include files
2021-04-02 juha.heiskanen@siru.fi Add early fragment tests
2021-04-02 michal.jakubek@mobica.com Add tests for multisample resolve to level != 0
2021-04-02 boris.zanin@mobica.com Add coverage for 1D, 1D array and Cube array shadow images
2021-04-02 boris.zanin@mobica.com Add subgroup testing for ray tracing pipelines
2021-04-02 caio.oliveira@intel.com Test interaction between Workgroup explicit layout and zero initialization
2021-04-02 Alexander.Galazin@arm.com Merge "Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master"
2021-04-02 cheryl.wei@arm.com Add waived tests support for cts tools
2021-04-01 rgarcia@igalia.com Remove duplicate dataSafe function from deSTLUtil
2021-04-01 boris.zanin@mobica.com Add keys deqp-log-decompiled-spirv and deqp-log-empty-loginfo
2021-04-01 apinheiro@igalia.com Check for drawIndirectFirstInstance should only affect indirect draw calls
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the uniform location tests
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the multisample texture tests
2021-03-31 alexander.galazin@arm.com Support GL 4.5 in the EXT_texture_border_clamp tests
2021-03-30 alexander.galazin@arm.com Update Vulkan headers
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the geometry shading tests
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the tessellation tests
2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-30 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/master
2021-03-30 alexander.galazin@arm.com Support GL 4.5 in the copy image tests
2021-03-26 michal.jakubek@mobica.com Added tests for most-negative snorm values in images
2021-03-26 alexander.galazin@arm.com Notice of withdrawal of Vulkan CTS 1.2.2.x
2021-03-25 timvp@google.com Include sys/system_properties.h in teglAndroidUtil.cpp
2021-03-25 afdx@google.com Add a batch of GraphicsFuzz tests
2021-03-25 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-25 rgarcia@igalia.com QPA image viewer updates
2021-03-25 boris.zanin@mobica.com Fulfill OpControlBarrier requirement
2021-03-25 slawomir.cygan@intel.com Add an option to terminate after first failure, update READMEs
2021-03-25 slawomir.cygan@intel.com Terminate with an error if unrecognized arguments are passed to dEQP executable
2021-03-25 venni.ihanakangas@siru.fi Ensure only Unix paths are added to deqp.apk
2021-03-19 alexander.galazin@arm.com Merge vk-gl-cts/github-master into vk-gl-cts/master
2021-03-19 jbolz@nvidia.com Add tests to exercise 'readonly' SSBOs
2021-03-18 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-18 slawomir.cygan@intel.com Fix required features checks in shaderRecordExplicitScalarOffset_6 test case
2021-03-18 tom.cooper@arm.com Add VK_EXT_headless_surface surface tests
2021-03-18 Junda.Liu@amd.com Fix robust buffer access result checking for partially out of bound cases
2021-03-18 tapani.palli@intel.com Use linear tiling with external_memory_host tests
2021-03-18 ancheng.qiao@arm.com Fix precision issue in NearestEdgeTests shaders
2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-17 gleese@broadcom.com Enable shadow filtering tests for non-filterable formats
2021-03-17 rgarcia@igalia.com Add BGR and BGRA formats to image view tests
2021-03-17 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-17 jari.komppa@siru.fi Add tests for standard multisample positions
2021-03-17 rgarcia@igalia.com Push constant overwrite tests
2021-03-17 rgarcia@igalia.com Test large command buffers with many draw commands
2021-03-17 rgarcia@igalia.com Test barycentric coordinates in ray tracing hits
2021-03-17 rgarcia@igalia.com Add missing mandatory features
2021-03-17 venni.ihanakangas@siru.fi Ensure WSI colorspace has no effect on image contents
2021-03-17 tapani.palli@intel.com reset minSampleShading only with OpenGL Core 4.0+
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/master
2021-03-16 alexander.galazin@arm.com Merge vk-gl-cts/opengl-cts-4.6.0 into vk-gl-cts/master
2021-03-15 rgarcia@igalia.com Enable validation for all custom devices
2021-03-15 rgarcia@igalia.com Remove multiview requirement in extended dyn state tests
2021-03-15 boris.zanin@mobica.com Fix recursion depth requirement in complexcontrolflow
2021-03-15 rgarcia@igalia.com Check image extent support in watertightness tests
2021-03-15 boris.zanin@mobica.com Read deserealization size from stream
2021-03-15 gleese@broadcom.com Fix flush/invalidate in mismatched_write_op tests
2021-03-15 gleese@broadcom.com Fix sync validation for mismatched_write_op tests
2021-03-15 tapani.palli@intel.com Check if image sample count supported by VkSampleCountFlags
2021-03-15 rgarcia@igalia.com Always accumulate errors in desc set random tests
2021-03-15 syoussefi@google.com Fix missing barrier in compute test
2021-03-15 syoussefi@google.com Fix missing barrier in texture buffer test
2021-03-15 ari.suonpaa@siru.fi Replace libUI with native Android AHB API
2021-03-10 gleese@broadcom.com Add a waiver for depth bias on some Broadcom GPUs
2021-03-10 alexander.galazin@arm.com Update Vulkan/GL Readme
2021-03-10 ari.suonpaa@siru.fi Update Amber
2021-03-08 toni.salmivalli@siru.fi Add a batch of Graphicsfuzz tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vk-gl-cts-angle-autoroll
Please CC syoussefi@google.com,angle-bots+autoroll-info@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: angleproject:5816
Change-Id: I324ce9596a62771726dc4504b2341e049818f7de
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2807533Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

1a146f07

Skip TracePerfTest.Run/*_idle_heroes on Pixel 2 · c782ef19

authored Apr 15, 2021

The test crashes both with the native and Vulkan drivers.

Bug: angleproject:5867
Change-Id: I6fe3acd7050b0cb2d6f735de684b897aca0a6bb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826402Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c782ef19

Clear macros 'NEAR' and 'FAR' · a2ade894

authored Apr 13, 2021

Bug: angleproject:5861
Change-Id: Id4cccf5e06dd39c37bd4fa23965edd31633b0fef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824429Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: John Plate <jplate@google.com>

a2ade894

Tests: Add Idle Heroes trace. · ea6dd8b3

authored Apr 14, 2021

Test: angle_perftests --gtest_filter="*idle_heroes*"
Bug: b/180419827
Bug: angleproject:5865
Change-Id: Ia121c9c76b67c130534a06e5dc09ac8bd7d2efe9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826125Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Lubosz Sarnecki <lubosz.sarnecki@collabora.com>

ea6dd8b3

Capture/Replay: Enable InstancingTest.LineLoop/* tests · 6f3bd395

authored Apr 13, 2021

Bug: angleproject:5853
Change-Id: Ia1a7a1cec781dca22ab49a9189dd3560ac148216
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824435
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6f3bd395

Roll Chromium from 21426fd08f99 to cac0b331e3fc (436 revisions) · 5186af3b

authored Apr 15, 2021

https://chromium.googlesource.com/chromium/src.git/+log/21426fd08f99..cac0b331e3fc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/b30d9d1676..e966858a7e
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/5185dac7e9..4ef8239f68
* third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/5447d00cc9..10b50b69d8
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..0fb9b3ace8
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f9d141ab4d..b1cc5ed9e8
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/59d5575e12..eefe475693
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/luci-go: git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6..git_revision:4b61ac9cadfb8d19a09262c6e6f5342d9324acd0
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/fc7a3623d6..fae4e7d723
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I8ef062cf57e98b30672d8ad397b56b303595e6ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2827775
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

5186af3b

JsonSerializer: Add tests for sorting and non-unique keys · 6362dcf1

authored Apr 14, 2021

Bug: angleproject:5853
Change-Id: I85e64900a58a2706087b71769470bb33fb4e8522
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824434
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6362dcf1

14 Apr, 2021 17 commits

Capture: store some array values as vector · 212849e9

authored Apr 13, 2021

This reduces the number of values that are added with
the same key.

Bug: angleproject:5853
Change-Id: Ie13408cc7ad419dec06746dc38b753f76292fae6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824433
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

212849e9

JsonSerializer: Sort group members before writing them out · 3116c91c

authored Apr 13, 2021

Use a multimap to accumulate the values added to a group and
then add them to the Json group when it is finished.

Bug: angleproject:5853
Change-Id: Idbe82acc5f9a9671063f02bd1af039575aa52e87
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824432
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

3116c91c

Allow Chromecast tests to run on SwANGLE · 45344f05

authored Apr 14, 2021

This cl makes 2 changes allowing Chromecast tests to use
SwANGLE:
1) It sets angle_use_vulkan_display to true when using
   Chromecast, effectively allowing SwANGLE to be used
2) It sets angle_vulkan_display_mode to "headless", allowing
   it to use DisplayVkHeadless instead of DisplayVkSimple,
   which ends up using "VK_EXT_headless_surface" instead of
   "VK_KHR_display", so that it's supported by SwiftShader
   Vulkan on Chromecast.

Bug: chromium:1060139
Change-Id: Ia521ebddac14f5e34666bb9b64603bec598c41ce
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826196Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

45344f05

Upgrade overlay fonts generator to Python 3 · 90d18b03

authored Mar 10, 2021

Bug: angleproject:5707
Change-Id: I809669d7a7de16ed2e098f59067c8e1d9c44a75c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773292Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com>

90d18b03

infra: Remove osx_sdk cache. · 12342643

authored Apr 14, 2021

This is no longer necessary now that we use mac_toolchain.py.

Bug: angleproject:5114
Change-Id: I0afac641d55e9be2bd04103301aec3080d3332c8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2823859Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

12342643

Workaround for missing include in OpenCL headers · 9e1ccb24

authored Apr 14, 2021

Bug: angleproject:5759
Change-Id: Ieeb5a251e614a4df1b5362dee474b368f362e0fc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826121
Commit-Queue: John Plate <jplate@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9e1ccb24

Capture: Fix storing strings instead of scalars · 9254eb8e

authored Apr 13, 2021

Bug: angleproject:5853
Change-Id: Id63922d881ce7778236e4ab3417bf9414fc0e59b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824431
Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

9254eb8e

Revert "Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)" · c9b33729

authored Apr 14, 2021

This reverts commit 8105d9ea.

Reason for revert: Fails compilation

Original change's description:
> Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions)
>
> https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454
>
> Changed dependencies:
> * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
> * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
> * vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
> * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
> Please CC syoussefi@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
>
> Bug: None
> Tbr: syoussefi@google.com
> Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

Bug: angleproject:5864
Change-Id: I093218ed8324562830f83a26378d164a86d00ae0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826472
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

c9b33729

Roll vulkan-deps from c18d8cd5016c to a441440ae454 (23 revisions) · 8105d9ea

authored Apr 14, 2021

https://chromium.googlesource.com/vulkan-deps.git/+log/c18d8cd5016c..a441440ae454

Changed dependencies:
* glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/1481399549..e6a0e7fc76
* spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/212895d4c2..a02a9205ff
* vulkan-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers.git/+log/e1d8c4931d..f5ac258209
* vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/f563b367c7..13c4877ea2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-deps-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Id3c917a802469caf50238bc268a328b2455ffa24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2826008
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

8105d9ea

Roll SwiftShader from 77edad299907 to f32791f5d53b (3 revisions) · 9cbb7106

authored Apr 14, 2021

https://swiftshader.googlesource.com/SwiftShader.git/+log/77edad299907..f32791f5d53b

2021-04-14 swiftshader.regress@gmail.com Regres: Update test lists @ b71a5569
2021-04-13 srisser@google.com Implement depthBoundsTest
2021-04-13 capn@google.com Eliminate the OpenGL ES 1.1 implementation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: syoussefi@google.com
Change-Id: Ifdd5c4c0f35d46d16090f27638002338b7f8f1a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2825849
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9cbb7106

Roll Chromium from cb430282a083 to 21426fd08f99 (209 revisions) · 4393c0f8

authored Apr 14, 2021

https://chromium.googlesource.com/chromium/src.git/+log/cb430282a083..21426fd08f99

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromium-angle-autoroll
Please CC syoussefi@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Changed dependencies
* build: https://chromium.googlesource.com/chromium/src/build.git/+log/dde8d8929d..b30d9d1676
* testing: https://chromium.googlesource.com/chromium/src/testing/+log/edbd63483e..5185dac7e9
* third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..b226a4b7af
* third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d73d069a76..f9d141ab4d
* tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/633b99a892..59d5575e12
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/luci-go: git_revision:99ac75773c6241b6ddf82ade4c54553faa084530..git_revision:de0691397dd4daa4ae63d308fe911bb6ee8630d6
* tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/bfc3b95479..fc7a3623d6
* tools/skia_goldctl/linux: mAuXqU7IqMTl2o166z_OMy_IZxh0ajpEUPuXYy4_BfcC..R23Oztsyro8ca7QGaNGKjN7duf5fsN6I6Dq2Nwyh2YQC
* tools/skia_goldctl/mac: TH-LRMBSdzpB3b-wmecnLTut5qaef26EM-ZbtQM2CIUC..Ipkmq4bl5d7VmPVlEonzZMPLnHxMr-LaDFi8Dz_r8-8C
* tools/skia_goldctl/win: Lzfohgeqx2FAmTxtM5eYQshIXb5YBoNk73cmoh_dP3sC..QCamcihHhiASX-AasohPdhiBOtj0ikJ3fUByIMEfrEIC
No update to Clang.

Bug: None
Tbr: syoussefi@google.com
Change-Id: I25b1ee88a463e431fbdbf5d0856d9f87d7257d0c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2824767
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

4393c0f8

Capture/Replay: Support non-binary GLboolean · fdfb2b82

authored Apr 09, 2021

This CL contains two changes. One to how we print out GLboolean
values, and another to how we capture GLbooleans.

According to the spec, anything non-zero can be considered
GL_TRUE when setting state:

    When the type of internal state is boolean, zero integer or
    floating-point values are converted to FALSE and non-zero values
    are converted to TRUE.

Dota Underlords is using 0xFF for GL_TRUE.

Before the change, this manifested as:

    // logcat
    glColorMask(context = 4, red   = kUnknownGLenumString,
                             green = kUnknownGLenumString,
                             blue  = kUnknownGLenumString,
                             alpha = GL_FALSE)

    // trace
    glColorMask(GL_INVALID_ENUM, GL_INVALID_ENUM, GL_INVALID_ENUM, GL_FALSE);

After:

    // logcat
    glColorMask(context = 4, red   = 0x00FF,
                             green = 0x00FF,
                             blue  = 0x00FF,
                             alpha = GL_FALSE)

    // trace
    glColorMask(0xFF, 0xFF, 0xFF, GL_FALSE);

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: Ie53aeba8d8a40f91ee375467b325d8e6be053a98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821947
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fdfb2b82

Capture/Replay: Support glGetQueryiv · 7a95a620

authored Apr 09, 2021

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I59ced20117bde50b5b734a82cb2e5966d1b27227
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821946
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

7a95a620

Capture/Replay: Support glBufferStorageEXT · 4f723d2c

authored Apr 09, 2021

Add the entrypoint, and when a buffer is immutable, recreate it
with glBufferStorageEXT.

Test: MEC for Dota Underlords
Bug: b/185192780
Bug: angleproject:5857
Change-Id: I29b934bdff4185d19594e49e9387dd79c6031aa5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821945Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>

4f723d2c

Disable location tags in test isolates. · 68f1203d

authored Apr 13, 2021

The current setup has problems producing tags in an ANGLE checkout.

Bug: angleproject:5114
Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

68f1203d

Don't call {begin|end}DebugUtilsLabelEXT() when not enabled · 9c51f93d

authored Apr 12, 2021

The ContextVk::handleDirtyEventLogImpl() and ContextVk::endEventLog()
methods called the {begin|end}DebugUtilsLabelEXT() methods when the
VK_EXT_debug_utils extension is not enabled.  This manifests when
enabling/using VVL stand-alone (i.e. when the the debug-utils
extension is not also present).

Bug: b/183133198
Change-Id: I043b174d457a8796831184c092661f24b33c1db4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821943
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

9c51f93d

Add gclient variable to checkout traces. · bf6e074f

authored Apr 13, 2021

'checkout_angle_restricted_traces' controls if we should check out
the trace tests. We can give restricted access to partners for these
traces. Defaults to the same setting as 'checkout_angle_internal'.

Bug: angleproject:5860
Change-Id: I36efffb180b35e11e104e2c99bc89fb4be4e0708
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822232Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

bf6e074f