We would accidentally propagate include directories to the test
main target. This would show up as compile errors of the form:

In file included from ../../third_party/angle/testing/gtest/include/gtest/gtest.h:10:
../../third_party/angle/third_party/googletest/src/googletest/include/gtest/gtest.h:303:22: error: no member named 'ImplicitlyConvertible' in namespace 'testing::internal'
          !internal::ImplicitlyConvertible<T, AssertionResult>::value>::type*
           ~~~~~~~~~~^

This fixes the GN properties such that we no longer get the wrong
/testing/ and /third_party/googletest/ directories included. This
regressed when glslang was rolled.

Bug: angleproject:3088
Change-Id: I710f767cfe476454c10dacf2103b9203f1b5ee19
Reviewed-on: https://chromium-review.googlesource.com/c/1459596Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: angleproject:3138
Change-Id: If82467a0ab98d2b2f77337be41b33ee817e44e58
Reviewed-on: https://chromium-review.googlesource.com/c/1459597Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Add instance & device extensions provided by layers prior to running
VerifyExtensionsPresent() so that we won't abort when required extensions
are provided in a layer. This happens particularly on Fuchsia as the
swapchain extension is implemented in a layer.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia

Change-Id: I30385dfe55b14783a20d1410f1209d3e3ad10632
Reviewed-on: https://chromium-review.googlesource.com/c/1456487Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Michael Spang <spang@chromium.org>

This reverts commit 1f8132a1.

Reason for revert: anglebug.com/3135

Bug: angleproject:3135

Original change's description:
> Vulkan: Reduce Default Descriptor Pool Max Sets
>
> The current value of kDefaultDescriptorPoolMaxSets is 2048, which
> allocates too much memory on a Pixel device, causing Android's low
> memory killer to terminate dEQP (leading to a test failure). This change
> reduces the value of kDefaultDescriptorPoolMaxSets to 128 to reduce the
> memory usage during the test. We suspect a later change may be required
> to dynamically grow the descriptor pools and update the recycling
> behavior.
>
> dEQP-EGL.functional.multicontext.non_shared_clear
>
> Bug: angleproject:3056
> Change-Id: I8a681b509823956a58d6c08f64a23203458e075e
> Reviewed-on: https://chromium-review.googlesource.com/c/1454280
> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Tim Van Patten <timvp@google.com>

TBR=jmadill@chromium.org,timvp@google.com,syoussefi@google.com,syoussefi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: angleproject:3056
Change-Id: Iff950425141eb5028c3660ba0567a9d29e691604
Reviewed-on: https://chromium-review.googlesource.com/c/1459256
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

Vulkan allows a swapchain to be created based off of an older swapchain
that's still presenting, to support seamless window resizing.  The old
swapchain will remain alive (though no image can be acquired from it)
and automatically cleaned once no image is being presented from it.

The retired swapchain can be destroyed once all operations on its images
are completed.  We store the old swapchain next to the serial of
submission that's used for CPU throttling and defer the destroy call
until after `finishToSerial` for that serial is called.

Bug: angleproject:2942
Change-Id: Ic62a5a57b712ffa2b087f5fecde0dc8942194075
Reviewed-on: https://chromium-review.googlesource.com/c/1435634
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Bug: angleproject:3124
Change-Id: Idfcd84f92126eb7548f86f8c327887a34e3218a9
Reviewed-on: https://chromium-review.googlesource.com/c/1457025Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This CL introduces a coarse layer of dirty bits and on-demand sending of
some uniforms to the underlying driver, instead of sending all uniforms
every draw, which should improve performance in cases where not much is
changing between draws.

BUG=angleproject:2306

Change-Id: I530515dfad2e4be74c73d8659acd4fe5decaa8b0
Reviewed-on: https://chromium-review.googlesource.com/c/1361222Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Lingfeng Yang <lfy@google.com>

Bug: angleproject:3125
Change-Id: I0d185ad70b960d0c3bff971eb6658893b308352d
Reviewed-on: https://chromium-review.googlesource.com/c/1456481Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This will allow us to avoid loading the build file for
//third_party/vulkan-validation-layers on Fuchsia, since we don't want to
build the validation layers on that platform.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia (with full series)

Change-Id: Ifeb67125f5fcebf2b30ae18b760667ba7c56e4d5
Reviewed-on: https://chromium-review.googlesource.com/c/1456479
Commit-Queue: Michael Spang <spang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:3132
Change-Id: I4bbaaab732cd64e6f2f44d6a09a236533a1abc20
Reviewed-on: https://chromium-review.googlesource.com/c/1456616Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

Fuchsia needs a layer to support VK_KHR_swapchain. Add the ability for
DisplayVk subclasses to request a layer in addition to an extension.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia

Change-Id: If86c773d4bd4ebecaee4b1631d3d4975105fe849
Reviewed-on: https://chromium-review.googlesource.com/c/1456478Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Based on present mode, different values for the image count make sense.
In mailbox mode, the driver will increase the number as necessary.  In
immediate mode, two buffers suffice.  In fifo mode, we would ideally
want triple-buffering.

Bug: angleproject:2932
Change-Id: I45eec83d0292eea472b931fe81e49cde6d105c27
Reviewed-on: https://chromium-review.googlesource.com/c/1454290Reviewed-by: Ian Elliott <ianelliott@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Seems to have issues with stranger configs like the Sheild TV.

Bug: angleproject:2286
Change-Id: I12d0dedeee9fbaaecb7341d376200a1afc758f12
Reviewed-on: https://chromium-review.googlesource.com/c/1454331
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Fix malformed HLSL shader code in other locales than classic

Bug: angleproject:1433
Change-Id: I30bad0bd0cfda465ec7200e48e12800d7d8efd26
Reviewed-on: https://chromium-review.googlesource.com/c/1447862Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

The current value of kDefaultDescriptorPoolMaxSets is 2048, which
allocates too much memory on a Pixel device, causing Android's low
memory killer to terminate dEQP (leading to a test failure). This change
reduces the value of kDefaultDescriptorPoolMaxSets to 128 to reduce the
memory usage during the test. We suspect a later change may be required
to dynamically grow the descriptor pools and update the recycling
behavior.

dEQP-EGL.functional.multicontext.non_shared_clear

Bug: angleproject:3056
Change-Id: I8a681b509823956a58d6c08f64a23203458e075e
Reviewed-on: https://chromium-review.googlesource.com/c/1454280Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

Add systrace markers for various RendererVk::finish paths in order to
quickly identify cause of finishes. Also added marker to commandPool
destroy which is currently a known hotspot on some devices.

Bug: angleproject:2528
Change-Id: I5a2fc741679a58445d71a2edd6204cf9e869d236
Reviewed-on: https://chromium-review.googlesource.com/c/1454277
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

There's a lot more that can go into this perf test, but it requires
further work on the Vulkan back end.

Bug: angleproject:2999
Change-Id: Iea62bfd09639af108674dcf0a9e7c9d36ccddcef
Reviewed-on: https://chromium-review.googlesource.com/c/1437734
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Apparently IsOzone and IsLinux can both be true at the same time. This was
confounding the config detection.

Bug: angleproject:2286
Bug: chromium:928583
Change-Id: Ifd28242f396fd97447720b0c11caf8c1590f7222
Reviewed-on: https://chromium-review.googlesource.com/c/1454319Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

The Android Shield TV confing was not properly initializing on ES1/Vulkan.
Also Ozone configs were failing to initialize ES 3.0 contexts.

Bug: angleproject:2286
Bug: chromium:928583
Change-Id: I7e54cdd1bf29791dffee3c70f7ebd3a1283eb5c4
Reviewed-on: https://chromium-review.googlesource.com/c/1453480Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When releasing the thread only call makeCurrent if we have a display
to use. Calling with EGL_NO_DISPLAY is not valid (though some devices
allow it.)

Bug: angleproject:3102

Change-Id: I2cf48011294d0264d3b1cb0318a2a80715e37f60
Reviewed-on: https://chromium-review.googlesource.com/c/1436840Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>

Before we would try all the configs and filter those which fail to
init. Now we gather the System Info and if successful check a list of
supported configs. If System Info init fails we fall back to the prior
method.

This speeds up end2end tests init. It also allows for more reliable
profile captures with VTune. It also will cause a test failure if a
config unexpectedly fails. Previously we would silently pass without
running the config's test. Includes a few changes:

 * D3D reference tests are disabled. They don't appear to be working.
 * Mac ES 3.1 is disabled due to lack of support.
 * WGL on AMD Windows is disabled due to lack of ES compatibility.
 * ES 3.2 contexts are explicitly disabled.
 * Vulkan is limited to ES 2.0.
 * The Windows GLES back-end is limited to NVIDIA with ES 2.0 & 3.0.
 * A unit test that verifies the whitelist matches availability.

Bug: angleproject:2472
Change-Id: Ib72214bfbbff13c124fa15a6494d0aabb52f2e62
Reviewed-on: https://chromium-review.googlesource.com/c/1436168
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

Each image was tracking its current layout, but not the pipeline stage
it was used.  Additionally, the barrier access masks were inferred from
the layout.  This incurred two inefficiencies:

- The src pipeline stage mask often included all stages, causing
  unnecessarily heavy barriers.
- The access masks included all possible accesses by a layout, which in
  some cases was overkill, like VK_ACCESS_MEMORY_WRITE_BIT for
  VK_IMAGE_LAYOUT_GENERAL (which will eventually used for compute shader
  output).

This change instead creates an enum where each element represents the
layout, the stage and access masks when transitioning into the layout
and the stage and access masks when transitioning out of that layout.
The image will instead track a value of this enum (instead of
VkImageLayout), which allows it to create the layout transition barriers
as tight as possible, since it includes all the necessary information.

Bug: angleproject:2999
Change-Id: I91535ce06d10530a6fc217ad3b94b7e288521e25
Reviewed-on: https://chromium-review.googlesource.com/c/1440074
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Storing ImageHelper as a pointer allows the storage to be swapped or shared
with other objects.

BUG=angleproject:2668

Change-Id: I2e51f24737be59ffe9f472e9b0b592774a792cd1
Reviewed-on: https://chromium-review.googlesource.com/c/1409404
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The initial implementation called eglInitialize() and eglTerminate()
and didn't call ANGLETest::TearDown().

BUG=angleproject:2511

Change-Id: I563a84a72fe9bd20739519301023062f85446557
Reviewed-on: https://chromium-review.googlesource.com/c/1452529Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Ian Elliott <ianelliott@google.com>

To support EGL images efficiently, the pixel buffer needs to be tightly coupled
with the image it will upload data to allowing textures to upload data to EGL
images sourced from renderbuffers.  The data will be uploaded to the image in
the correct order if it comes from multiple sources and the check for pending
uploads does not need to traverse EGL image siblings.

BUG=angleproject:2668

Change-Id: Iebf59ed1e358ddc76843b8bcfac39b0363f66a3f
Reviewed-on: https://chromium-review.googlesource.com/c/1405710
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

Bug: angleproject:3125
Change-Id: I70d295d7ec1dbafc74add068165c5fbcadb48560
Reviewed-on: https://chromium-review.googlesource.com/c/1450222
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

glmark2 uses the visual id, which is discarded in angle.  This change
retrieves these ids from X11 and stores them in the egl::Config.

Bug: angleproject:3125
Change-Id: I2b524ecb71d675efa01cc9100a3dfe6fd57913f0
Reviewed-on: https://chromium-review.googlesource.com/c/1450221Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Due to bot build failures.  Partially reverts:

c09ae15c: Enable -Wextra-semi and -Wextra-semi-stmt.

TBR=jmadill@chromium.org

Bug: angleproject:3128
Change-Id: Ia3725e57d28cd899db59e1d8e760ad8ca3d5f70c
Reviewed-on: https://chromium-review.googlesource.com/c/1450659Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This initial implementation provides the extension, and always answers
that the ANativeWindow is not recordable.

BUG=angleproject:2511

Change-Id: Id3c57351dd1029bff7adf7166f9c82eee6e634b3
Reviewed-on: https://chromium-review.googlesource.com/c/1412507
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Bug: angleproject:3075
Change-Id: I34dd5d4ecded6def5a2b46369277312af0de7c8c
Reviewed-on: https://chromium-review.googlesource.com/c/1443572Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

This is useful for situations where angle is substituted for the system
library underneath an application oblivious to this change.  The
ANGLE_DEFAULT_PLATFORM variable is used when the display type is default
to control the default back-end.  Possible values are vulkan, gl and
d3d11.  If the value of this variable is not valid, or not supported by
the current platform, the usual defaults are applied.

Bug: angleproject:3125
Change-Id: I304b006e0a4149f78561038d01cede143640dafb
Reviewed-on: https://chromium-review.googlesource.com/c/1450211Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

This will prevent users from accidentally making semicolon errors in
the future.

Bug: chromium:926235
Change-Id: I79a6fa376fb1ad8f0fcf1b65b1f572a035d1f4e9
Reviewed-on: https://chromium-review.googlesource.com/c/1446493
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

This is to be able to catch issues introduced through AST manipulation
earlier than shader compilation time, improving debuggability.

Bug: angleproject:2733
Change-Id: Ic57bc72f2ab438e60f32553d602074f3d72cc4f5
Reviewed-on: https://chromium-review.googlesource.com/c/1199922Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

Includes a fix for the Fuchsia build and for -Wextra-semi.

Bug: 926235
Bug: angleproject:2475
Change-Id: If3ef575c09656989274c91dec7657465b99978b2
Reviewed-on: https://chromium-review.googlesource.com/c/1449972Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Bug: chromium:927650
Change-Id: Ib944dee7e537820af53eb12538c33e7d0c4fbd68
Reviewed-on: https://chromium-review.googlesource.com/c/1449631Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Tiny speed improvement in the perf test.

Bug: angleproject:3117
Change-Id: Ie2892772da4808615b2a810ff523602894440b64
Reviewed-on: https://chromium-review.googlesource.com/c/1350490Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Reduces the buffer nullptr checks to a single location. Also optimizes
how the transform feedback binding counter is changed.

Improves the score of the draw call vertex array change test.

Bug: angleproject:3014
Change-Id: I08ff341e08194a407c24143965a3d568e92b97b7
Reviewed-on: https://chromium-review.googlesource.com/c/1406891
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

When we use replaceChildNode function, the first argument must be the original
child node instead of the deepCopy. Otherwise, replaceChildNode will do nothing
since it will think deepCopy is a different node. In that case,
RewriteExpressionsWithShaderStorageBlockTraverser::visitAggregate will
enter an endless loop since ssbo argument is never really replaced.

Test: dEQP-GLES31.functional.ssbo.*
Bug: angleproject:1951
Change-Id: Ieb17a16ab2b3e0270328fafd7ba0944ca05f842f
Reviewed-on: https://chromium-review.googlesource.com/c/1446686Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

RenderTarget11 knows how to render to a specific mip of a texture but if
TextureStorage11 attempts to read or write to the backing resource directly
it does not select the correct subresource index.  This manifested in calls
to glTexSubImage going to the wrong mip of the resource.

Fix TextureStorage11::getSubresourceIndex to look up the correct subresource
in TextureStorage11_EGLImage.

Add a test to cover this case in ImageTest.MipLevels.

BUG=angleproject:2668

Change-Id: Id9270ab3bf9f37c7c671639bb8b7ce9578daaed6
Reviewed-on: https://chromium-review.googlesource.com/c/1422058Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This can be null and this will causes a crash in strstr(). Check for null
before dereferencing this field.

BUG=angleproject:2475
TEST=angle_end2end_tests on Fuchsia and angle_enable_vulkan_validation_layers=true

Change-Id: I76a2738365838cb2f9cb54af7637417735762b69
Reviewed-on: https://chromium-review.googlesource.com/c/1446506Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>