Skip to content

A
angle
Switch branch/tag
  1. 13 Jun, 2017 2 commits
    • Decouple ANGLETest functionality and test parameters · cdadb3ff
      Martin Radev authored 
      ANGLETest provides useful functionality for end2end tests, but it
cannot be used for tests which take other test parameters than the
platform. The patch introduces another level of abstraction by moving
all of ANGLETest's functionality to another class - ANGLETestBase -
which does not inherit from ::testing::TestWithParam<>. New tests can
either inherit from ANGLETest as before to have only platform
parameters, or they can inherit from ANGLETestBase and add handling
of custom test parameters.

Example:

// The new parameter type must inherit from PlatformParameters.
struct MyCustomParameters : PlatformParameters
{
    bool mWorkaroundState;
};

class MyTest : public ANGLETestBase,
               public ::testing::TestWithParam<MyCustomParameters>
{
    protected:
    void overrideWorkaroundsD3D(
        angle::WorkaroundsD3D *workaroundsD3D) override
    {
        workaroundsD3D->myCustomWorkaround = GetParam().mWorkaroundState;
    }

};

ANGLE_INSTANTIATE_TEST(MyTest, MyCustomParameters(ES3_D3D11(), false),
                               MyCustomParameters(ES3_D3D11(), true));

BUG=angleproject:2062
TEST=angle_end2end_tests

Change-Id: Ia36e429cff8c4c291fc87a286a1d1a3004d6fad6
Reviewed-on: https://chromium-review.googlesource.com/530945
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
    • Fix RewriteElseBlocks using a non-prefixed struct name · 9f01a0d4
      Olli Etuaho authored 
      RewriteElseBlocks used to have an issue where it could add an
unprefixed struct name to the AST in a TIntermRaw node, as opposed to
the prefixed name that the struct would be defined with. Use a proper
return statement node instead of a raw node to fix this issue and make
the code more robust.

BUG=angleproject:2061
TEST=angle_unittests

Change-Id: I3993b5093646983f038268f3a5ffe26ccdae66e8
Reviewed-on: https://chromium-review.googlesource.com/530785Reviewed-by: 's avatarCorentin Wallez <cwallez@chromium.org>
Reviewed-by: 's avatarJamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
  3. 12 Jun, 2017 5 commits
  5. 09 Jun, 2017 4 commits
  7. 08 Jun, 2017 3 commits
  9. 07 Jun, 2017 3 commits
  11. 06 Jun, 2017 5 commits
  13. 05 Jun, 2017 10 commits
  15. 02 Jun, 2017 5 commits
  17. 01 Jun, 2017 3 commits