How to build and run tests

BUG=angleproject:1607

Change-Id: I6d5c341c32a37535d59e8dae508173b5ab6664d6
Reviewed-on: https://chromium-review.googlesource.com/419798
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1637

Change-Id: I411252fa719f79c26795522ea5f1504ef460c6c0
Reviewed-on: https://chromium-review.googlesource.com/420306Reviewed-by: Jamie Madill <jmadill@chromium.org>

This seems to fail on the Nexus 6P, and possibly 5X. Does not
seem to affect some other devices.

BUG=angleproject:1660

Change-Id: I1d456b2033fb6b2a664ac24ea0a3f7ff160922ab
Reviewed-on: https://chromium-review.googlesource.com/419856Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1595
TEST=dEQP-GLES31.functional.draw_indirect.*

Change-Id: I82f5d0864e70d6e7abdccf5f10330ddfa099ec62
Reviewed-on: https://chromium-review.googlesource.com/417250
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:1661

Change-Id: Iac7af4aed2782ab839922281d29f1a9861a334e3
Reviewed-on: https://chromium-review.googlesource.com/419758Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

This affects all back-ends - we weren't saving this. Note that
bindings can only be set after program linking. The spec is fairly
clear in that any programs saved must be loadable and runnable under
the same set of state, which would include block bindings.

Also add validation for zero binary formats in GetProgramBinary.

Also add a workaround for AMD where the block bindings were not
applied properly after link, similarly to our original bug.

This CL also includes a few fixups for GLProgram (raii).

BUG=angleproject:1637

Change-Id: Iae068eb4e1e4c763aa9f9332c033e38708026c8f
Reviewed-on: https://chromium-review.googlesource.com/418393Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Macros like ASSERT and UNREACHABLE call gl::trace, which at some
point we might want to use to call the angle Platform logging code.
Standalone tests won't easily have access to the platform, so for
now just log errors in other ways.

This also corrects some logic in GLSLTest which was calling
internal methods in libANGLE when it didn't have to.

BUG=angleproject:1660

Change-Id: Idecbd97f2de7916b35bd78f5b7cd02b156ea100d
Reviewed-on: https://chromium-review.googlesource.com/419134
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

These should be using ANGLE_EXPORT, not GL_APICALL.

BUG=angleproject:1523

Change-Id: Ic262656c634209c14ac1e13203f8125c0c65cee5
Reviewed-on: https://chromium-review.googlesource.com/419133Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This change is pure refactoring and doesn't fix bugs related to
invariant declarations. Invariant declarations are supposed to accept
a list of identifiers, but this refactoring keeps the current behavior
of only accepting a single identifier in an invariant declaration.
When the bug will be fixed, the new TIntermInvariantDeclaration class
that now has only a single child node can be changed so that it may
have multiple children.

TIntermAggregate is still used for function calls, function
prototypes and function parameter lists.

BUG=angleproject:1490
TEST=angle_unittests

Change-Id: I3e22092c87e1c06445fd7e123d9922c2fcb59428
Reviewed-on: https://chromium-review.googlesource.com/419415Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

atan(y, x) is not always returning expected results on NVIDIA OpenGL
drivers between versions 367 and 375. Work around this by emulating
atan(y, x) using the regular atan(x) function. A fix to the driver is
expected in a future release.

It is most convenient to implement the vector atan(y, x) functions by
using the scalar atan(y, x) function. Support for simple dependencies
between emulated functions is added to BuiltInFunctionEmulator. In the
current implementation one function is allowed to have at most one
other function as its dependency.

BUG=chromium:672380
TEST=angle_end2end_tests

Change-Id: I9eba8b0b7979c7c7eaed353b264932e41830beb1
Reviewed-on: https://chromium-review.googlesource.com/419016
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

The patch adds handling of the 'shared' qualifier in the shader
compiler.

BUG=angleproject:1442

TEST=angle_unittests

Change-Id: Iaa288026af0faf2a30e40495faa6ea1f5ff02323
Reviewed-on: https://chromium-review.googlesource.com/413200
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=None

Change-Id: Ib201d91c586717b3027996b379240619173d828d
Reviewed-on: https://chromium-review.googlesource.com/418337Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Again using git cl format.

BUG=angleproject:650

Change-Id: I8898d00bfc6a50db50bffd2cc30c3eda7c08c6c2
Reviewed-on: https://chromium-review.googlesource.com/419097Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Using git cl format.

BUG=angleproject:650

Change-Id: I7d3f98d2b0dcfb0a8de6c35327db74e55c28d761
Reviewed-on: https://chromium-review.googlesource.com/419059Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1523
BUG=668223
TEST=conformance/more/functions/copyTexImage2DBadArgs.html

Change-Id: I5fbf4f99fa941c356ecb57d67dd47a33741ce189
Reviewed-on: https://chromium-review.googlesource.com/418944Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

In TranslatorHLSL a number of AST simplifications are done, that must
happen in a precise order for things to be correct:
 - First for-loops must be split
 - Then multideclarations must be split
 - Finally comma operators must be split

This adds tests for interaction between this passes to make sure they
are done in the right order.

BUG=668028

Change-Id: I306915b51011bb5467d117352becfd60cbe77be4
Reviewed-on: https://chromium-review.googlesource.com/417989
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

BUG=angleproject:1523

Change-Id: Icd207b2d94c1375c6f3189af42d55eac52b99603
Reviewed-on: https://chromium-review.googlesource.com/418398
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:523

Change-Id: Id54033dce15f01a0f2891533172acd8b99896e12
Reviewed-on: https://chromium-review.googlesource.com/418240
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1523

Change-Id: I685a9b884e5de73b94900c5b6016ce914b9bfe7f
Reviewed-on: https://chromium-review.googlesource.com/418458
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Result of -float is wrong on Intel Mac 10.11 drivers. Replace -float
with 0.0 - float to work around this issue.

BUG=308366
BUG=672380

Change-Id: I53bc2eda7259fff5805bec39896fc7b7a6eaf665
Reviewed-on: https://chromium-review.googlesource.com/417169Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1657

Change-Id: I5afb28485bd5ca7bdf7015f5fdcaa84ec3c02b95
Reviewed-on: https://chromium-review.googlesource.com/418710Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

BUG=chromium:671021

Change-Id: Iee0e7b1b146b53c6324da8e51d70de42487092b5
Reviewed-on: https://chromium-review.googlesource.com/418510Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

Several months of updates. Does not change the build files - will
mean the GPU.FYI bots temporarily break, and possibly there's some
flakiness on the ANGLE trybots and Optional GPU bots until the
correct suppression set is instated.

BUG=chromium:671021

Change-Id: I207be11ed37a9173f53a06554880be6ebcaee5fa
Reviewed-on: https://chromium-review.googlesource.com/418405Reviewed-by: Jamie Madill <jmadill@chromium.org>

gl_WorkGroupSize should be written into the AST as a constant node
instead of a symbol node. In correct shaders, local size is guaranteed
to have been declared before any references to gl_WorkGroupSize -
otherwise the shader translator was already generating an error.

This ensures that work group size can be used to size arrays as
specified and also works around a crash issue on NVIDIA Linux OpenGL
driver.

BUG=angleproject:1442
TEST=angle_unittests

Change-Id: I9b1a4bff16ecf2c3db1511c3702756346cdd2f6b
Reviewed-on: https://chromium-review.googlesource.com/418735
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Might be flaky, more suppressions might be needed.

BUG=angleproject:1633

Change-Id: Ic5665aadb7cbbae82639d206f29a2db859622451
Reviewed-on: https://chromium-review.googlesource.com/418399Reviewed-by: Jamie Madill <jmadill@chromium.org>

Compute shaders were added to the core OpenGL spec in version 4.3.

Also don't output GL_ARB_explicit_attrib_location extension directive
for compute shaders. This extension is only relevant for vertex and
fragment shaders.

BUG=angleproject:1442
TEST=angle_end2end_tests

Change-Id: I92021ac048b38ffbc5a61af408b37c387193389b
Reviewed-on: https://chromium-review.googlesource.com/418657Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Previously infinity and NaN resulting from constant folding would be
clamped to finite 32-bit float range when they were written in shader
output. Now they are written as a bit pattern in case the shader
version allows it.

This does not guarantee that NaNs work, but this is fine, since ESSL
3.00.6 spec has very loose requirements when it comes to NaNs.

BUG=angleproject:1654
TEST=angle_end2end_tests

Change-Id: I9997000beeaa8ed22523c22d5cf6929cdfc93f60
Reviewed-on: https://chromium-review.googlesource.com/417301
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Also add a more robust set of unit tests for this internal class.
Because the GL spec allows for succeess when packing any set of
varyings, it's impossible to write negative end to end tests. This CL
also rewrites our disabled varying packing GLSL tests as unit tests.

BUG=angleproject:1296
BUG=angleproject:1638

Change-Id: I78153742517d5c72ddb13ff59dc44ddc4af42fc2
Reviewed-on: https://chromium-review.googlesource.com/415555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This code doesn't actually call any D3D runtime methods, so it can be
included in our cross platform unit tests. Just include the varying
packing code for now.

BUG=angleproject:1296
BUG=angleproject:1638

Change-Id: I5c0ccccb00e1c13ca98448256be048f7cd0968ce
Reviewed-on: https://chromium-review.googlesource.com/417116
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Many tests were removed from mustpass at some point, and a couple
were expected to fail but passing. Also update some of the global
skip settings to use DEBUG RELEASE as a catch-all.

BUG=angleproject:989
BUG=angleproject:998
BUG=angleproject:1017
BUG=angleproject:1018
BUG=angleproject:1019
BUG=angleproject:1020
BUG=angleproject:1025
BUG=angleproject:1027
BUG=angleproject:1028
BUG=angleproject:1033
BUG=angleproject:1034
BUG=angleproject:1051
BUG=angleproject:1108
BUG=angleproject:1143
BUG=angleproject:1335
BUG=angleproject:1418
BUG=angleproject:1655
BUG=angleproject:1656

Change-Id: I731d3adeed36509ce69f72e5fcc80d0adc89cb67
Reviewed-on: https://chromium-review.googlesource.com/418063Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Otherwise when trying to add the declarations back, things might fail
because the loop initialization is a sequence and not a block.

BUG=668028

Change-Id: I8d84a25c25765e9655c16ce56604ae08f0f8176c
Reviewed-on: https://chromium-review.googlesource.com/414305
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

Many test expectations listed were not in the mustpass list, so
weren't even necessary.

BUG=angleproject:989
BUG=angleproject:1015
BUG=angleproject:1016
BUG=angleproject:1020
BUG=angleproject:1025
BUG=angleproject:1027
BUG=angleproject:1029
BUG=angleproject:1030
BUG=angleproject:1128

Change-Id: Ia18796cb3388e8528b4351cb2c81ff9793a1d250
Reviewed-on: https://chromium-review.googlesource.com/417413Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:1595
TEST=dEQP-GLES31.functional.state_query.integer.draw_indirect_buffer_binding*

Change-Id: Ib8f712fdf10411ef0b7b63742d17c3caca99137b
Reviewed-on: https://chromium-review.googlesource.com/416193Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

BUG=668223

Change-Id: I2f38b358dd4a6b9327562704dacce37f2b16acaa
Reviewed-on: https://chromium-review.googlesource.com/417192Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Constant folding arithmetic operations that involve infinity are now
handled correctly in the cases where the result is infinity or zero.
The implementation mostly relies on C++ to implement IEEE float
arithmetic correctly so that unnecessary overhead is avoided.

Constant folding arithmetic operations that result in overflow now
issue a warning but result in infinity. This is not mandated by the
spec but is a reasonable choice since it is the behavior of the
default IEEE rounding mode.

Constant folding arithmetic operations that result in NaN in IEEE will
generate a warning but the NaN is kept. This is also not mandated by
the spec, but is among the allowed behaviors.

There's no special handling for ESSL 1.00. ESSL 1.00 doesn't really
have the concept of NaN, but since it is not feasible to control
generating NaNs at shader run time either way, it should not be a big
issue if constant folding may generate them as well.

TEST=angle_unittests
BUG=chromium:661857

Change-Id: I06116c6fdd02f224939d4a651e4e62f2fd4c98a8
Reviewed-on: https://chromium-review.googlesource.com/414911Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Change "DEBUG RELEASE" modifier to "OPENGL D3D11" to be more specific.

Add D3D11 expectations.

BUG=angleproject:1442

Change-Id: If3a9704e7f16cc473fd6ea410d10eb01ae1a8008
Reviewed-on: https://chromium-review.googlesource.com/416960Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

ES 3.0 doesn't require non-constant sampler array indexing, and we
can't require it for ES 2 without breaking WebGL for some users.

BUG=671280

Change-Id: Ib04446284acc92410a90c683a3d222871de554a8
Reviewed-on: https://chromium-review.googlesource.com/416195
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

BUG=angleproject:1366

Change-Id: I9e44679754eb704b390191c28206dedc3dc7cc4f
Reviewed-on: https://chromium-review.googlesource.com/367082
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

UNIMPLEMENTED debug spam was causing the tests time time out.  We can mark them
as FAIL again once the dEQP test setup/tear down code doesn't emmit so many
messages.

Implement a couple validation cases for ES 3.1 to greatly reduce the spam.

BUG=angleproject:1647
BUG=angleproject:1442

Change-Id: Ie7b4ac8737a2df1c0ada6ad53154ddf2f37d9c3c
Reviewed-on: https://chromium-review.googlesource.com/415520
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

Change-Id: I2f96baedf10d346eaa150bab04f8f6ca3ba573b9
Reviewed-on: https://chromium-review.googlesource.com/414272Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>