Commits · cebb5aa092f92e1f727fe5e4300dbd83abd49afb · Chen Yisong / angle

11 Apr, 2014 7 commits

Fix warnings about unreferenced local variables. · cebb5aa0

authored Apr 07, 2014

BUG=angleproject:602

Change-Id: I2eb04fe6eed60b3877b14628e81c0b1fe3b68647
Reviewed-on: https://chromium-review.googlesource.com/193431Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

cebb5aa0

Handle an unknown error when exiting fullscreen on Windows 8. · 662b8481

authored Apr 11, 2014

BUG=361553

Change-Id: I6d3e843a8ae06f1bbd5313ed95e338cb0b74fef3
Reviewed-on: https://chromium-review.googlesource.com/194233Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

662b8481

Insert missing sampler cases in TType::buildMangledName. · 9bab6d8f

authored Apr 10, 2014

We were missing the cases for 2D Rect samplers and external OES
samplers. This was causing an assert in the WebGL CTS in Debug.

BUG=angle:550

Change-Id: Ieefeef6ff0f9a486bf7667c7efc60dee766f03ef
Reviewed-on: https://chromium-review.googlesource.com/194122Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9bab6d8f

Use shader optimization level 3 selectively. · 655fe36e

authored Apr 11, 2014

Default to HLSL compiler optimization level 1 and work around a compiler bug with break in nested loops by using optimization level 3.

BUG=angle:603

Change-Id: I4f7985a5648f1b5f54d80554c21aced7fc1777c2
Reviewed-on: https://chromium-review.googlesource.com/194129Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

655fe36e

Refactor buffer storage to split backing stores. · 15cba8b1

authored Apr 08, 2014

A more flexible representation of a buffer storage implementation
allows us to represent storage for D3D11 buffers, and also pack
buffer as CPU memory.

Refactoring patch only.

BUG=angle:511

Change-Id: Ie123099f6217bec6edc98594e49333d16f006a0b
Reviewed-on: https://chromium-review.googlesource.com/191033Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

15cba8b1

Pass pack state arguments instead of split parameters. · eb9baabb

authored Mar 24, 2014

Similar to unpack state, the PixelPackState struct encapsulates
all the parameters related to pixel pack buffers. Passing the
packstate makes functions more consise.

BUG=angle:511

Change-Id: If6954a5085e9b8f828cfc8892a73e7c7514b0c8a
Reviewed-on: https://chromium-review.googlesource.com/191032Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

eb9baabb

Clamp ReadPixels calls to unsigned limits in D3D11. · 1eb5bd76

authored Mar 28, 2014

GL allows reads beyond the defined pixel rectangle, although their
resultant values are undefined. D3D11 gives an error when reading
out-of-bounds, hence clamping the area satisfies both APIs.

This fixes a Renderer crash in our ReadPixels out of bounds test,
and also fixes the test to test the correct area of pixels.

BUG=angle:590

Change-Id: I12439c22d53ec6a2d69e1b8cf80f53e9c18e11f7
Reviewed-on: https://chromium-review.googlesource.com/191080Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

1eb5bd76

09 Apr, 2014 3 commits

Allow sample projects to choose ES3 & D3D version. · 96e46cd6

authored Apr 07, 2014

Passing parameters from the sample constructor allows us to test
ES3 functionality, as well as choose between D3D9 and 11.

BUG=angle:521

Change-Id: I7b9543b399450f62c5415654e8026a7c218b7e37
Reviewed-on: https://chromium-review.googlesource.com/193292Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

96e46cd6

Add a common include in the project definitions. · d095bdaa

authored Apr 07, 2014

Any projects that may be included by gyp files outside our project (chrome
or skia) may not have the same defines or ignored compiler warnings.  To
make sure that we can always compile, each project now includes a common
file with all required definitions and gyp variables.

BUG=angleproject:583

Change-Id: I702bee975d0554c51bfa03981920dfb295ffbafa
Reviewed-on: https://chromium-review.googlesource.com/189458Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d095bdaa

Remove the angle_relative_path gyp variable. · f3e6a9e0

authored Apr 07, 2014

Add a separate step to copy the scripts to the intermediate directory and
run them from there.

BUG=angleproject:583

Change-Id: I307a2810ac03c00248cba1f227f128a1517c6574
Reviewed-on: https://chromium-review.googlesource.com/193432Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f3e6a9e0

01 Apr, 2014 16 commits

Remove max level from texture storage. · bf712d0a

authored Mar 31, 2014

BUG=angle:596

Change-Id: I174e3b73c0cb675b5c9aea5722a7051a34639831
Reviewed-on: https://chromium-review.googlesource.com/192340Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

bf712d0a

Remove base level from texture storage. · fa7b76d0

authored Mar 31, 2014

BUG=angle:596

Change-Id: I66173f77b6c5aed3b8836cd2c9f1da02ae769429
Reviewed-on: https://chromium-review.googlesource.com/192056Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

fa7b76d0

Rename lod offset to top level. · f61738a5

authored Mar 31, 2014

BUG=angle:596

Change-Id: Ic256445528d6587adcf0adfd8aaba5e47778988b
Reviewed-on: https://chromium-review.googlesource.com/192055Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

f61738a5

Create a single-level SRV when not mipmapping. · e47e7363

authored Mar 27, 2014

BUG=angle:596

Change-Id: Iec5a9e43a23c0743ff8b01985a86a72c5f18a7f7
Reviewed-on: https://chromium-review.googlesource.com/192052Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

e47e7363

Pass all sampler state to getSRV. · a10c1c7e

authored Mar 27, 2014

BUG=angle:596

Change-Id: I4f97ea7c43bf12f5d986db39ae67d87074f98e82
Reviewed-on: https://chromium-review.googlesource.com/192051Tested-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

a10c1c7e

Remove the es_util project. · 73f51433

authored Mar 04, 2014

BUG=angle:521

Change-Id: Iad633bf210c36db340490f21923534697e27891b
Reviewed-on: https://chromium-review.googlesource.com/188741Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

73f51433

Port the PostSubBuffer sample to the new sample framework. · e977efc4

authored Mar 04, 2014

Add a swap method on the SampleApplication class so that samples can
override the default eglSwapBuffers function call.

BUG=angle:521

Change-Id: I3f0ba6ed182b368e6f5fe502de67d1a14267a857
Reviewed-on: https://chromium-review.googlesource.com/188740Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

e977efc4

Port the TextureWrap sample to the new sample framework. · e9b02245

authored Mar 04, 2014

Refactor the generation of checkerboard textures since they're used by
this sample and MipMap2D.

BUG=angle:521

Change-Id: I1ba8bc4927a7944eb8efad0c8aa71eba4619e457
Reviewed-on: https://chromium-review.googlesource.com/188729Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

e9b02245

Port the Stencil_Test sample to the new sample framework. · d3a4092d

authored Mar 04, 2014

Rename Stencil_Test to stencil_operations, a more fitting name for a
sample.

BUG=angle:521

Change-Id: I5412ecef12d80c3dbf54539bc7509678a35c44d5
Reviewed-on: https://chromium-review.googlesource.com/188728Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d3a4092d

Remove excess dereferences and casts. · 3b3ad1fe

authored Mar 05, 2014

The behaviour of dereferencing an array on the stack is the same as simply
using the array but it is counter-intuitive, error prone and requires a
cast to fit the required type.

Change-Id: Ib14e902293cf6dc71aaf944d57f53ea895a680ab
Reviewed-on: https://chromium-review.googlesource.com/188875Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

3b3ad1fe

Fix off-by-one error with the number of storage mip levels. · 98705b7d

authored Mar 31, 2014

This caused there to be too few mip levels in the TextureStorage and it
would be discarded if there was a modification to a lower mip.

Also modified Texture::mipLevels to return the number of mip levels rather
than the index of the smallest mip to avoid confusion.

Fixes WebGL D3D9 conformance failures in:
    mipmap-fbo

BUG=angleproject:550

Change-Id: Idf3f543487232edceb520337331b39dab2bd26ba
Reviewed-on: https://chromium-review.googlesource.com/192341Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

98705b7d

Port the Simple_VertexShader sample to the new sample framework. · f6139359

authored Mar 03, 2014

Add a Matrix type and cube gemetry generation helper functions.

BUG=angle:521

Change-Id: Ia50be1790d6f440499eea052f427762637f3c876
Reviewed-on: https://chromium-review.googlesource.com/188727Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f6139359

Port the Simple_TextureCubemap sample to the new sample framework. · 705073f7

authored Mar 03, 2014

Added helper functions for generating cube maps and sphere geometry.

BUG=angle:521

Change-Id: Ic1e8584d69793233ec6a97744b13097d55b9f287
Reviewed-on: https://chromium-review.googlesource.com/188726Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

705073f7

Add a B8G8R8X8 type for mipmaping, reading and writing D3D9 BGR textures. · ca623f3f

authored Mar 28, 2014

Fixes WebGL D3D9 conformance failures in:
    context-attributes-alpha-depth-stencil-antialias
    copy-tex-image-2d-formats.html
    texture-attachment-formats.html

BUG=angle:550

Change-Id: I09d42c5e6cf7d880841207627fd20698ed188a6a
Reviewed-on: https://chromium-review.googlesource.com/191935Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

ca623f3f

Port the Simple_Texture2D sample to the new sample framework. · 99384047

authored Mar 03, 2014

BUG=angle:521

Change-Id: Idd1889b13a751d473b1e99c4c593cd4cded972ae
Reviewed-on: https://chromium-review.googlesource.com/188725Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

99384047

Port the MultipleRenderTarget sample to the new sample framework. · 712e3f4d

authored Mar 03, 2014

Renamed to MultipleDrawBuffers and added shader loading from file.

BUG=angle:521

Change-Id: Iffeb589a95eee4409d3624c56fe3a5e4a7d5be63
Reviewed-on: https://chromium-review.googlesource.com/188724Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

712e3f4d

31 Mar, 2014 6 commits

Port the SimpleInstancing sample to the new sample framework. · 8dd592bf

authored Mar 03, 2014

Add a Vector2 type for storing texcoords and improve the sample by having
it draw several thousand instances instead of two.

BUG=angle:521

Change-Id: I87996a90000a83bc66d091c7537ea411080d7e9f
Reviewed-on: https://chromium-review.googlesource.com/188723Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8dd592bf

Fix D3D11 resource leaks. · 8b4f8f84

authored Mar 26, 2014

A few bugs, like missing destructors or Release calls were leaking
D3D resources in a few places on exit. This patch should fix all the
unreleased D3D object warnings on exit when running a sample app.

BUG=angle:589

Change-Id: Ib50df3229998938cddc2859d6f2d19ddd3a4db47
Reviewed-on: https://chromium-review.googlesource.com/190079Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

8b4f8f84

Fix D3D9 short attributes to int component type. · 0979e7aa

authored Mar 27, 2014

In the component type lexicon, we only use float/int/uint/norm,
and we were marking the D3D9 short vertex attributes as short.

This fixes the WebGL Test gl-vertexattribpointer-offsets.

BUG=angle:550

Change-Id: I3853df8bad5c98b8d0986bfa4ea73d254264ad56
Reviewed-on: https://chromium-review.googlesource.com/191950Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

0979e7aa

Use correct input stride for disabled attribs. · 1e194d31

authored Mar 27, 2014

We were using the input stride from the disabled vertex attribute.
This was breaking the gl-disabled-vertex-attrib test in D3D9.

BUG=angle:550

Change-Id: Ia5a37dc39105fe8ec92f4adbee3cfb2905e82676
Reviewed-on: https://chromium-review.googlesource.com/191932Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

1e194d31

Fix stack overflow when parsing huge expressions. · 6654bc93

authored Mar 26, 2014

The expression limit validation check needs to be in front
of other tree traversal to prevent stack overflows. Also,
call depths of sufficient size (80k+) could overflow the
depth check itself, necessitating an upper bound on initial
tree traversal.

This fixes crashes in the WebGL long-expressions bug test.

BUG=angle:584

Change-Id: Ib48294bf77a5923d230f237fbd63a36a5662e317
Reviewed-on: https://chromium-review.googlesource.com/191931Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

6654bc93

Use a heap-memory traversal to free compiler resources. · dd0d3426

authored Mar 26, 2014

The stack-memory traversal is prone to stack overflow. See the
WebGL conformance test long-expressions-should-not-crash.

BUG=angle:584

Change-Id: I02d72bc2e4101b7141d609c50303403ea8298e60
Reviewed-on: https://chromium-review.googlesource.com/191930Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Nicolas Capens <nicolascapens@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

dd0d3426

28 Mar, 2014 5 commits

Port the ParticleSystem sample to the new sample framework. · d19fae55

authored Feb 28, 2014

BUG=angle:521

Change-Id: I6d00333ac7761f15ee83a47dc3e6e3cc13c675cd
Reviewed-on: https://chromium-review.googlesource.com/188195Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d19fae55

Compile shaders with the best profile available. · 6e05c272

authored Mar 17, 2014

Instead of always compiling D3D11 shaders with shader model 4, compile
with the latest profile that the current feature level allows.

BUG=angle:495

Change-Id: I478d3d4a1aadf24d893508eee1a8c11e501bc084
Reviewed-on: https://chromium-review.googlesource.com/190340Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

6e05c272

Add support for drawing with transform feedback. · 4c5c6bbb

authored Feb 05, 2014

BUG=angle:495

Change-Id: Ib9c19130dfbc44a99998c5d6d8160bfc2b683eb9
Reviewed-on: https://chromium-review.googlesource.com/185037Tested-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

4c5c6bbb

Port the MultiTexture sample to the new sample framework. · 1b3e4b80

authored Feb 28, 2014

BUG=angle:521

Change-Id: I72f063664b43d3cfafe03c8f060076596bedea0f
Reviewed-on: https://chromium-review.googlesource.com/188194Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1b3e4b80

Port the MipMap2D sample to the new sample framework. · 9adef9ba

authored Feb 28, 2014

BUG=angle:521

Change-Id: I3b1d3a02214850bf52c1d5c468f5696076065b88
Reviewed-on: https://chromium-review.googlesource.com/188193Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

9adef9ba

27 Mar, 2014 3 commits

Adds support for EXT_map_buffer_range · 916e769a

authored Mar 27, 2014

BUG=angle:581

Change-Id: I0ab637db35afd51ff4c516bb97e954f4f2cdad3d
Reviewed-on: https://chromium-review.googlesource.com/191710Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

916e769a

Adds support for OES_mapbuffer · b3801744

authored Mar 27, 2014

BUG=angle:581

Change-Id: I05824051789a77c8169ec5830731e6155c507fc4
Reviewed-on: https://chromium-review.googlesource.com/191650Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

b3801744

Port the Hello_Triangle sample to the new sample framework. · 8776b258

authored Feb 28, 2014

BUG=angle:521

Change-Id: I887257193af3130447c4691bb72303cc978b96fe
Reviewed-on: https://chromium-review.googlesource.com/188192Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8776b258