Commits · d657e1d744e98e579d9d6a46fed64840d0affd04 · Chen Yisong / angle

05 May, 2020 4 commits

Vulkan: Defer framebuffer clears. · d657e1d7

authored Apr 24, 2020

This works by storing the deferred clears in the ImageHelper's staging
buffers. We apply the deferred clears onto the RenderPass right before
we begin to draw. Storing the clears in the ImageHelper solves problems
where we clear GL Textures in a Framebuffer and then unbind the
Textures and sample from them. Or do other commands like CopyTexImage.

Note that because the staging buffer clears only handle full-image
clears we need to immediately apply some scissored clears where before
we would use the RP. This should be a pretty rare occurrence and it is
possible to optimize that in the future.

Reduces the RenderPass count in the Manhattan "frame 10" trace from max
22 to max 20. May improve perf slightly on Android or may have effects
too small to measure. Should not regress performance.

Bug: angleproject:4517
Change-Id: I02150d531022afb903f1058f070937ec6337bd88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2142711Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d657e1d7

Roll third_party/SwiftShader b798cfa374eb..c4bbd378e95b (1 commits) · 3b0c01f4

authored May 05, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/b798cfa374eb..c4bbd378e95b

git log b798cfa374eb..c4bbd378e95b --date=short --first-parent --format='%ad %ae %s'
2020-05-04 capn@google.com Remove typeinfo from GLES exported symbols

Created with:
  gclient setdep -r third_party/SwiftShader@c4bbd378e95b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Ia2d5e9e7bf5ee8d8b98e1f80708d0fea63a7a6ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2182354Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

3b0c01f4

Roll third_party/vulkan-validation-layers/src 2f609275c00c..102687e26ec8 (15 commits) · 830ff187

authored May 05, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/2f609275c00c..102687e26ec8

git log 2f609275c00c..102687e26ec8 --date=short --first-parent --format='%ad %ae %s'
2020-05-04 mark@lunarg.com build: Install SPIRV-Headers for validation layers build
2020-05-04 s.fricke@samsung.com tests: Add VK_EXT_sample_locations VUIDs
2020-05-04 s.fricke@samsung.com layers: Add VK_EXT_sample_locations VUIDs
2020-05-04 s.fricke@samsung.com tests: Add VUID 02243 and 02245
2020-05-04 s.fricke@samsung.com layers: Add VUID 02243 and 02245
2020-05-04 s.fricke@samsung.com layers: Label RenderPass2 VUIDs
2020-05-04 spang@google.com Don't validate initial layout on external resource acquire
2020-05-04 s.fricke@samsung.com tests: Add extra support for VUID 01549
2020-05-04 s.fricke@samsung.com layers: Add support for VUID 01549
2020-05-04 s.fricke@samsung.com tests: Add extra test for multi-plane format Compatibility
2020-05-04 tony@lunarg.com tests: Set 1.1 target api for gpu tests
2020-05-04 s.fricke@samsung.com tests: Add Query VUIDs
2020-05-04 s.fricke@samsung.com layers: Add Query VUIDs
2020-05-04 s.fricke@samsung.com tests: Add VUID 00431 and 00432
2020-05-04 s.fricke@samsung.com layers: Add VUID 00431

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@102687e26ec8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: courtneygo@google.com
Change-Id: Idb7f8f11bc02964202e33a50dfd2b062239a88cd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2182355Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

830ff187

Vulkan: honor compressed texture block width/height · 2ad30d7a

authored May 04, 2020

When a texture's base or max mipmap level is changed, ANGLE creates a
new VkTexture (and potentially copies lots of data old->staging
buffer->new).  However, ANGLE wasn't looking at the texture's format,
and for a compressed format ANGLE wasn't looking at/using the texture
format's compressed block width and height.

Bug: b/155499736
Change-Id: I11a12028aee998fa23d503c2c0db39fbb49ae6ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2180881
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

2ad30d7a

04 May, 2020 14 commits

Vulkan: Add missing cache flush · 41f7bcce

authored Apr 30, 2020

DynamicBuffer are not cache coherent, thus requires flush. Also adds a
few assertion to ensure implementation matches expectation.

Bug: b/155432713
Change-Id: Iaf28786168a3bb5d746b43e030f882c4b6d005ad
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174269Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Charlie Lao <cclao@google.com>

41f7bcce

Vulkan: Update VMA integration. · ca50ad42

authored May 01, 2020

This will allow ANGLE to share the same source location as
Chromium.

Bug: chromium:1074162
Change-Id: I3ea9820cc1fe9cd0bfec81d734168213e5c1bb0b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176067Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

ca50ad42

Fix clearing the program's validation-related cache too early · 73bf99b7

authored Apr 29, 2020

When attempting to link a new program, the program must be marked
as unlinked, but the validation-related caching should not be
cleared yet, since we can still use the previously linked program
if linking fails at this point.

Added an angle end2end test which fails without this fix and
passes with this fix.

Fixes the following WebGL 1.0.4 test with SwANGLE:
conformance/programs/program-test.html

Bug: angleproject:3557
Change-Id: Ib6722ba88803979e8f292c9b7b81f85cc0304662
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2173538Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>

73bf99b7

Fix VulkanExternalImageTest on SwiftShader · 4271443d

authored Mar 04, 2020

Check isSwiftShader() for whether to load swiftshader instead of the
default ICD.

The spec says we should query GL_DEVICE_UUID_EXT & co for this, but we
haven't implemented those queries yet.

Bug: angleproject:4092
Change-Id: Ifd74d6b6706f7b1fcbe5d82a33ecf70e631e26b9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2088660Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>

4271443d

Fix issue with missing step info in generate_stats.py · 17bc7bcd

authored May 04, 2020

When the script has trouble parsing info for a step, it's supposed to
remove that step from the list of steps to not cause further problems
with the script (and log an error). Instead, it was being removed while
iterating the same list which caused malformed tables.

Bug: angleproject:4610
Change-Id: Iff8bfd77eae227907e78660183c79221d4d305a8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2180342Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

17bc7bcd

Vulkan: Move ICD overrides to a common place · 605af42e

authored Mar 04, 2020

We also need the bundled ICDs and selection logic for certain tests that
create a vulkan instance. If we don't, the tests will use default vulkan
even if ANGLE is using swiftshader-vulkan. Tests of driver specific
handle types (e..g opaque fd) will fail in this case.

Bug: angleproject:4092
Change-Id: Iff089c9341b8b533ee8634923d0177c5dbcd5cc8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2088659
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>

605af42e

Fix wrong date in ANGLE_external_objects_fuchsia revision history · 3c2d329c

authored May 02, 2020

The current timeline implies the existence of time travel.

Bug: None
Change-Id: Ic558f430912b874afc881f4841a49236f26b78dd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2178945
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

3c2d329c

Tests: Add program pipeline object tests · f623bd2e

authored Apr 14, 2020

This CL adds two program pipeline object (PPO) tests based on code
inspection during review.  They are both disabled awaiting fixes.

* The first (DetachAndModifyShader) tests a bug that shaders aren't
detached immediately on call.

* The second (DifferentTextureTypes) tests PPOs with mismatched
texture types. They should not link if the programs use a texture in
non-matching ways.

Test: ProgramPipelineTest31.DetachAndModifyShader*
Test: ProgramPipelineTest31.DifferentTextureTypes*
Bug: b/151462886
Bug: b/151449648
Bug: angleproject:3570
Change-Id: Ief0937397d31c972bf5e3a8d56b02d2dbd5a604b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2146997
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

f623bd2e

EGLWindow: Clean up some init attribute code. · 2126a107

authored May 01, 2020

EGL_CONTEXT_OPENGL_DEBUG is only exposed as of EGL 1.5.
We can also now properly test for no_error extension strings.
Do not require backwards compatible context extensions.

Fixes parts of using EGLWindow to load native EGL drivers.

Bug: angleproject:4596
Change-Id: I4de8f492f265d29f6603ed1b35b123e362699c54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176271
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

2126a107

Implement setBinaryRetrievableHint · a48f3c38

authored Apr 29, 2020

Remove the UNIMPLEMENTED() macro. Doing nothing is an acceptable
implementation at this time.

Test: Angry Birds 2
Bug: b/154930384
Change-Id: Ie46c084feb2015aa5fecdbbf2295d46e5087e3dc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172711
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

a48f3c38

Expose EGL 1.5. · 2071b5c3

authored May 01, 2020

This is helpful for figuring out if we can support the DEBUG
property when initializing an EGL context. It also will be
necessary down the line for Android.

Bug: angleproject:4596
Bug: b/154921118
Bug: angleproject:4606
Change-Id: I01c2cbaa21495e3620b7858f2a309c9a884033ec
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176277
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

2071b5c3

Roll third_party/SwiftShader 694e21400ee5..b798cfa374eb (9 commits) · 313b527b

authored May 04, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/694e21400ee5..b798cfa374eb

git log 694e21400ee5..b798cfa374eb --date=short --first-parent --format='%ad %ae %s'
2020-05-02 capn@google.com Enable the shaderStorageImageArrayDynamicIndexing feature
2020-05-02 capn@google.com Enable the shaderStorageBufferArrayDynamicIndexing feature
2020-05-02 capn@google.com Enable the shaderSampledImageArrayDynamicIndexing feature
2020-05-02 capn@google.com Enable the shaderUniformBufferArrayDynamicIndexing feature
2020-05-02 capn@google.com Implement dynamic descriptor array indexing
2020-05-02 capn@google.com Skip image sampling if no SIMD lanes are active
2020-05-01 capn@google.com Move the OFFSET() macro to Reactor
2020-05-01 amaiorano@google.com Regres: use Subzero backend by default
2020-04-30 bclayton@google.com Update Marl to 3c643dd4c

Created with:
gclient setdep -r third_party/SwiftShader@b798cfa374eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: angleproject:4071
Tbr: cnorthrop@google.com
Change-Id: I0b3b71fae13c055a352a87fac5a2f65ddb903f6a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2178983Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

313b527b

Roll third_party/vulkan-tools/src c0f34c020d9d..17019fa23604 (2 commits) · 6f2ab623

authored May 04, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/c0f34c020d9d..17019fa23604

git log c0f34c020d9d..17019fa23604 --date=short --first-parent --format='%ad %ae %s'
2020-05-01 petr_kraus@email.cz cube: Do not set VK_LAYER_PATH in VS
2020-05-01 petr_kraus@email.cz vulkaninfo: Do not set VK_LAYER_PATH in VS

Created with:
  gclient setdep -r third_party/vulkan-tools/src@17019fa23604

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Iee688a67ddc7e95144e52268b4010201e7985427
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2178982Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

6f2ab623

Roll third_party/vulkan-validation-layers/src b179a50e9c9c..2f609275c00c (8 commits) · 75d56e87

authored May 04, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/b179a50e9c9c..2f609275c00c

git log b179a50e9c9c..2f609275c00c --date=short --first-parent --format='%ad %ae %s'
2020-05-01 mark@lunarg.com tests: Add test for Qfamilyindices in EXCLUSIVE sharing mode
2020-05-01 mark@lunarg.com safe_structs: Ignore pQueueFamilyIndices if NOT CONCURRENTMODE
2020-05-01 tony@lunarg.com gpu: Blacklist Nexus Player in OOBGraphicsShaders
2020-05-01 s.fricke@samsung.com tests: Add GetDeviceQueue VUIDs
2020-05-01 s.fricke@samsung.com layers: Add GetDeviceQueue VUIDs
2020-05-01 tony@lunarg.com tests: Make api checks consistent
2020-05-01 mark@lunarg.com tests: Add BP tests for non-success return code warnings
2020-05-01 mark@lunarg.com practices: Fix messages for non-success return codes

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@2f609275c00c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: If0ca4a4afce3608b22c3cf6005ae992cee1e0afc
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2178984Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

75d56e87

01 May, 2020 19 commits

Vulkan: Minor command buffer refactor · 040e4f6f

authored May 01, 2020

Fix a couple minor nits with command buffer handling in ANGLE:
1. Make initialize() common CommandBufferHelper function
2. Reduce some common code when starting renderpass

Bug: b/154030403
Change-Id: Ie9cfcd7c053c8605b16bc2dee7f8d69418922492
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175106Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

040e4f6f

Vulkan: Improve viewport and scissor for pre-rotation · 10ee839c

authored Apr 30, 2020

Handle all 4 rotations and non-full-screen viewports & scissors.

Test: Running NBA 2K20 while flipping phone left and right (90 & 270) + watching it in Visual Studio and with Android logcat INFO messages
Bug: b/150329969
Bug: angleproject:4431
Change-Id: Icd555dbc2419aac1413452c1b306d6227784dc27
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174961
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

10ee839c

Work around strange git cl format issue. · 1c3e322c

authored May 01, 2020

For some reason this line of code confused git cl format
in that it would generate different results depending on when
it was called:

"PFNEGLSTREAMCONSUMERGLTEXTUREEXTERNALATTRIBSNVPROC
   ANGLE_EGL_StreamConsumerGLTextureExternalAttribsNV;"

I wasn't able to root cause the bug. Instead I worked around
it by changing the signatures for this file.

Bug: angleproject:4596
Change-Id: I4f18e03d27d378480b19831de51c4e85d815ca66
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2176157
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Mohan Maiya <m.maiya@samsung.com>

1c3e322c

Handle 3D texture entire-mip initialization for FBO attachments · c9e0edc2

authored Apr 30, 2020

FramebufferAttachmentObject::initializeContents clears the entire mip
level for layered textures (not including cube map). This was done by
special casing 2D array and 2D multisample array textures but did not
work for 3D.

Generalize the logic to work for all layered texture types.

Handle clearing the entire 3D texture mip in Vulkan.

TEST=conformance2/misc/uninitialized-test-2.html

BUG=angleproject:4602

Change-Id: I35bb9fc3304f0553e8de68d205b0843845bf7549
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174264Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

c9e0edc2

Capture/Replay: Refactor default uniform handling for arrays · 5b16123d

authored May 01, 2020

Instead of walking through uniform locations, walk through
the uniforms themselves and emit arrayed uniforms, which consume
multiple locations.

Test: MEC capture of Manhattan on Windows
Bug: angleproject:3662
Change-Id: Ifd25528721982847d4f0938f469a914a1cb908c5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175994
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

5b16123d

Vulkan: Migrate trace events and occlusion queries · 428e4415

authored Apr 27, 2020

Moved GPU trace event and occlusion query commands that were on the
primary command buffer to the SecondaryCommandBuffer (SCB). Putting
these commands on outside render pass SCB and flushing those commands
to primary on-demand as needed to maintain ordering of commands.

For resetQueryPool command used by occlusion query, allow the SCB
to queue up that command for inside RenderPass SCB. This avoids
ending a renderPass prematurely and allows all outstanding reset
commands to be executed before the beginRenderPass command since
the resets must occur outside of a renderPass.

This is groundwork to simplify the hand-off of SCBs from the main
thread to a worker thread. Long-term we'd like a single SCB that
can handle both inside and outside renderPass commands at the same
time to pass to the worker thread for processing into a primary CB.

Bug: b/154030403
Bug: angleproject:4603
Change-Id: Ic1023ae27a9b14435743549ea9933edf1c4b318b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2168114Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Charlie Lao <cclao@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

428e4415

doc: fix link to pre-commit try waterfall · 2aa99c12

authored May 01, 2020

Following up on
https://chromium-review.googlesource.com/c/angle/angle/+/2157888

Bug: angleproject:1944
Change-Id: Idf732e5e23277ff724c543e16f424b8d5f5385e4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175996Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

2aa99c12

Capture/Replay: Use BindAttribLocation to force MEC compat. · 942796f6

authored Apr 30, 2020

In some cases we'd end up with attributes that are optimized
out by the GL driver. BindAttribLocation forces the programs
to use the same attribute indexing numbers so that the command
stream works mostly the same even if some attributes aren't
active in the shader.

Bug: angleproject:4598
Change-Id: I2d02dd38d29a1489706ae70bcc0b262b1c076942
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174266
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

942796f6

Validation: Fix some function types. · e09f7a14

authored Apr 30, 2020

These were slightly mismatching the header types. They seemed
to link fine despite producing some warnings in a tool.

Bug: angleproject:4598
Change-Id: I19cfe4d87eca409c82a7c8cf25fff6f8a4c83ca9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175057
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>

e09f7a14

Revert "Add type for attribute locations." · 57d95828

authored Apr 30, 2020

This reverts commit 9349c143
and commit d43b0574.

It's no longer needed after we bind attribute locations before link.

Original CL message:

This will allow the capture/replay tool to easily intercept and label
attribute locations for remapping.

There's some inconsistency in implementation in the GL desktop front-
end. This is a quick fix and the full implementation is left for when
we implement the full desktop GL API set.

Bug: angleproject:4598
Change-Id: Ic510159d4d1982eff41560503cabf983a1be0381
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174076Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

57d95828

Roll third_party/glslang/src 39281fb710c3..2c53baedbb64 (2 commits) · ba0a8f73

authored May 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/39281fb710c3..2c53baedbb64


Created with:
  gclient setdep -r third_party/glslang/src@2c53baedbb64

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I6c44cacda14efcd853867ff894fff4a07b8c3779
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175795Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

ba0a8f73

Roll third_party/spirv-tools/src 49ca250b44c6..2e1d208ed9de (3 commits) · 43ce3a20

authored May 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/49ca250b44c6..2e1d208ed9de


Created with:
  gclient setdep -r third_party/spirv-tools/src@2e1d208ed9de

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I661a73a9dfeca195f798100a7b301819e1c203a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175653Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

43ce3a20

Roll third_party/vulkan-validation-layers/src 70eeffc7ca3d..b179a50e9c9c (8 commits) · 09325118

authored May 01, 2020

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/70eeffc7ca3d..b179a50e9c9c

git log 70eeffc7ca3d..b179a50e9c9c --date=short --first-parent --format='%ad %ae %s'
2020-04-30 greg@lunarg.com Add shader usage to debug printf doc
2020-04-30 tony@lunarg.com tests: Use IsPlatform to detect Mock ICD
2020-04-30 tony@lunarg.com tests: Move skip decision from blacklist to test
2020-04-30 tony@lunarg.com tests: Add physical device properties retrieval
2020-04-30 souravp@nvidia.com tests:AccelarationStructure tests
2020-04-30 souravp@nvidia.com layers: ray tracing validation
2020-04-30 s.fricke@samsung.com tests: Add Support for RP Attachment VUIDs
2020-04-30 s.fricke@samsung.com layers: Add Support for RP Attachment VUIDs

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@b179a50e9c9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC cnorthrop@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: Id504180e232459123cce37762ec67eda2490dc9f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175796Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

09325118

Roll third_party/SwiftShader 98d2cab108ce..694e21400ee5 (5 commits) · 9d01eba3

authored May 01, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/98d2cab108ce..694e21400ee5

git log 98d2cab108ce..694e21400ee5 --date=short --first-parent --format='%ad %ae %s'
2020-04-30 bclayton@google.com Vulkan/Debug: Don't step for column updates
2020-04-30 bclayton@google.com Vulkan/Debug: Fix build with clang-10.
2020-04-30 bclayton@google.com Device: Use std::unique_ptr instead of raw pointers
2020-04-30 amaiorano@google.com CMake: add graphviz generation scripts
2020-04-30 jrprice@google.com Fix null dereference in OFFSET macro

Created with:
gclient setdep -r third_party/SwiftShader@694e21400ee5

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: cnorthrop@google.com
Change-Id: I4a01136aeb38ff65ce60e444cf1be1b328f85c01
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2175654Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

9d01eba3

Vulkan: Reduce the onBufferRead/onBufferWrite API verbosity a bit · df31624e

authored Apr 30, 2020

This adds helper functions to handle common use case for onBufferRead
and onBufferWrite to reduce the API verbosity a little bit. Also fix the
transform feedback bug that we are passing in wrong access/stage flags
when it is emulated by vertex shader.

Bug: b/155122200
Change-Id: Id2549ca00cad184a90c6230dc3665aaff44dda08
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174265
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

df31624e

Vulkan: Fix dbg util label bug · 67da0051

authored Apr 30, 2020

Courtney noted this bug from a review. Should begin label on pushGroup
instead of insert label.

Bug: b/154030403
Change-Id: I5f4da5762e1ef03fe27b414740e34d2064af86b5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2171951Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

67da0051

Tweaks to presubmit script. · a89750ec

authored Apr 30, 2020

- run the same checks on 'git cl upload' as 'git cl pre'
- show the problematic line on non-ascii presubmit check

Bug: angleproject:4601
Change-Id: I321e22fd49f7a83aa062ebae01d13476e57044e3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174075
Commit-Queue: Tim Van Patten <timvp@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

a89750ec

GL: Implement EGL_EXT_image_dma_buf_import · 85ae836f

authored Mar 30, 2020

Add support for the EGL_EXT_image_dma_buf_import on EGL implementations
that support it natively. This extensin is used on ozone to import
native compositing buffers.

This patch also adds new tokens in EGL_EXT_image_dma_buf_import_modifiers
which are used in eglCreateImageKHR.

BUG=angleproject:4529

Change-Id: I49bff831b591fb19fcdcec1145c7a61f5d8020c4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2128190
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

85ae836f

Enable GL_BGRA_EXT for es backend · a56537a3

authored Apr 29, 2020

It's required on Chrome OS.
Based on spec EXT_texture_format_BGRA8888, this format is renderable.

Bug: angleproject:4594
Change-Id: Ibde0f0de18f4b8079a23f4b13123c6b5c8794a89
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2172638Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>

a56537a3

30 Apr, 2020 3 commits

Capture/Replay: Fix tool after parameter change. · d43b0574

authored Apr 30, 2020

'index' became 'indexPacked' for attribute locations. It
also changed the type.

Bug: angleproject:4598
Change-Id: I6393e09dd1d5c1a7c5d0e2ca8a67e4f7bbb05411
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2174263Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

d43b0574

Detect non-ascii characters during presubmit · f7d44736

authored Apr 29, 2020

Clang format and non-ascii characters don't get along well, which are
typically introduced when copy/pasting spec language. This CL will
detect non-ascii characters during presubmit.

Bug: angleproject:4601
Test: git cl presubmit --upload
Change-Id: I80080fc04590ad47c9756f8f969d5c7f44d41793
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2173684Reviewed-by: Shrek Shao <shrekshao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>

f7d44736

Add type for attribute locations. · 9349c143

authored Apr 29, 2020

This will allow the capture/replay tool to easily intercept and label
attribute locations for remapping.

There's some inconsistency in implementation in the GL desktop front-
end. This is a quick fix and the full implementation is left for when
we implement the full desktop GL API set.

Bug: angleproject:4598
Change-Id: Ibf11bcb8669d27265ea376494a2e3124825cf3be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2171933
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>

9349c143