- 23 Mar, 2021 9 commits
-
-
Rafael Cintron authored
Previously, D3D11 debug names were only output in debug builds. This change enables them in release builds so we can debug GPU memory consumption given traces or full memory dumps. Where it made sense, existing names were shortened for brevity. A future CL can shorten the names further by removing the words texture, SRV, DSV, etc since D3D already outputs this type information. Bug: chromium:1164111 Change-Id: Iadd6222c29dd945115e844ec28ee395ce16c139f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780564 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Peng Huang authored
Bug: chromium:1178333 Change-Id: I8f21cd1c8f815a5cd7344778d2d1b28710dc6763 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779211Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org>
-
Jamie Madill authored
This reverts commit b2e76cf5. Reason for revert: Causing MSan failures on Linux. See bug. Bug: chromium:1191344 Original change's description: > Save/Load missing members > > There are several class/struct members that are missing when a program > is serialized/deserialized. This leads to errors when attempting to link > programs that have been deserialized. For example, when drawing with a > PPO that contains programs which were created with glProgramBinary(). > > This CL adds saving/loading the missing members. > > Bug: b/182409935 > Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 > Commit-Queue: Tim Van Patten <timvp@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> Bug: b/182409935 Change-Id: I1209257ed6bb55ba2d01d92bd3305d5e3ad6ee28 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780015Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jamie Madill authored
The new name is more consistent with the other names. Refactoring change only. Bug: angleproject:5736 Change-Id: Idc47fef29040e3a422267795c4536163a6f8eb4e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779953Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/3eced2421f5a..f1617b736428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/120a8d610c..b43166a3d1 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/f13f2e366c..a9cb74b2b5 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..de74236cf7 * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/luci-go: git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb..git_revision:a5b261eb562e7790e92be27e74e6f10e8836454e * tools/skia_goldctl/linux: PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC..PgXVrZeDk45E9Zzaj8KYvPhJb728_zgB29afUe44XnUC * tools/skia_goldctl/mac: Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC..rhgkxpA8BkPWwXXCTUidbcE5xtFpN2UVjTfya2r4YJAC * tools/skia_goldctl/win: 3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC..bMHjBq4De--lL7_Tr4K31mN6LR7hkSStHG_W34ogifYC No update to Clang. Bug: angleproject:5768 Tbr: cnorthrop@google.com Change-Id: I82f74de7812ba075f6c3cd9fa0b4d724df876669 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2779806 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*real_cricket_20*" Bug: b/183165790 Bug: angleproject:5777 Change-Id: I1f350e3ea458a599396412e2c5ca80d6c7887d73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776554 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Ian Elliott authored
Bug: b/181711029 Change-Id: Ie619ba90f699dd8234cf185198cb6eeac9142758 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2780560Reviewed-by:
Ian Elliott <ianelliott@google.com> Commit-Queue: Ian Elliott <ianelliott@google.com>
-
Charlie Lao authored
filament gltf sample code is rendering to a level that is excluded from [base_level, max_level]. This is allowed by OpenGL spec. We are crashing right not. This CL adds tests for the exact usage pattern for filament. Bug: b/181800403 Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithSubImageWithBeyondMaxLevel Test: FramebufferTest_ES3.RenderAndInvalidateImmutableTextureWithBellowBaseLevelLOD Change-Id: I69bab8bc3961bbc2dcc78ba2db3c8759f277416b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2752897 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Tim Van Patten authored
There are several class/struct members that are missing when a program is serialized/deserialized. This leads to errors when attempting to link programs that have been deserialized. For example, when drawing with a PPO that contains programs which were created with glProgramBinary(). This CL adds saving/loading the missing members. Bug: b/182409935 Change-Id: I637c6cd8c174acd6da8d51433893323a32e5d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770683 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
- 22 Mar, 2021 10 commits
-
-
Cody Northrop authored
This is required in order to call __android_log_print, which can be sprinkled into the trace for debugging. Bug: b/183165790 Change-Id: I717f2ac7809172f22b7badee6f1096394a02bc14 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776553Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Tim Van Patten authored
ShaderVariable's functions and members are all mixed up. This CL reorders things to move the functions before the members, to better match ANGLE's coding style. This also adds a note that any new members that are added need to be added to gl::WriteShaderVar() and gl::LoadShaderVar(), which are actually implemented in Program.cpp, since ShaderVars.h/cpp can't include libANGLE/BinaryStream.h. There are currently several members that are missing, leading to save/load errors, which are fixed in a follow-on CL in this chain. Bug: b/182409935 Change-Id: I1381a5efffb56c0989961bbcfd405b95d59d6396 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770682 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Mohan Maiya authored
Correctly handle inactive varyings of structure type when collecting transform feedback varyings. Previously, all varyings of structure type were marked as active by mistake. Bug: angleproject:5557 Test: TransformFeedbackTest.InactiveStructureVarying* Change-Id: Ica1cbce5c551cdbb97999eeac59d09a961937615 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770680 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
We need to generate a compiler error only when the vertex index of an output variable as an l-value, in a tessellation control shader, is not the indentifier gl_InvocationID. Bug: angleproject:5557 Tests: dEQP-GLES31.functional.tessellation.shader_input_output.barrier Change-Id: Ica075b8d85916caa228f057b203ae81b27f65e2d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2758915Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Charlie Lao authored
Make the API name reflect what it does. With recent changes, this get called from places that are not releasing ImageHelper object, but is try to reference the current layout. This new name makes more sense than onImageHelperRelease (at that time when this API was introduced, it was only called when ImageHelper is being released). Bug: b/175584609 Change-Id: Ie5f5fcdbd97436724d7eb016374d8b4178e7ba1d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776261 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Jamie Madill authored
This refactors the pipeline type in the ContextVk class to also use a packed enum map. It also expands the object perf counters to store both a specific and cumulative version for use in different cases. Bug: angleproject:5736 Change-Id: I6ff78e38065eb577f2b95b1d9c4f9cc31d7f325f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774184Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Cody Northrop authored
Test: angle_perftest --gtest_filter="*avakin_life*" TBR: jmadill@google.com,timvp@google.com Bug: b/183344915 Bug: angleproject:5779 Change-Id: Iaf2d8341055d5b7c6f3c8a7a7a1fb3d1399fabc5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776746Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Cheryl Wei authored
ARM Linux doesn't support window surface resize. Bug: angleproject:4453 Change-Id: Ia8631f5191c2b3ebd822766cc7f92275aa62dff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2777578 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
Mohan Maiya authored
EXT_external_buffer spec - This extension allows the data store for an immutable buffer to be sourced from an external EGLClientBuffer, allowing sharing of EGL client buffers across APIs, across processes, and across different processing cores such as the GPU, CPU, and DSP. The intent is for a single backing memory to be reused across various processes and processors. Ensure that a glBuffer backed by external memory does not orphan the memory when glBuffer APIs like glBufferSubData or glMapBufferRangeEXT modify the glBuffer. Bug: angleproject:4380 Bug: angleproject:5073 Tests: ExternalBufferTestES31.*DoesNotCauseOrphaning*Vulkan Change-Id: I4e88f80d93ee1ba1208378121412926351d10af8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776192 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/c33e21cce932..3eced2421f5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/ba8be7fd2f..120a8d610c * testing: https://chromium.googlesource.com/chromium/src/testing/+log/55b74c093b..f13f2e366c * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..999f35f30e * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/9629038820..24cecabb89 * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/luci-go: git_revision:4eef77dde582d6065203e3249dd80477391a7dd6..git_revision:457c14d8ee933ac2c6a64a89799b9f5989483dcb * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/df4e23350e..c94714a14b * tools/skia_goldctl/linux: GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC..PFAC9ipfkYe6ZljRb8758leyPy7Jw6Dhl2dtHp0IsMYC * tools/skia_goldctl/mac: 0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC..Ht0L_bool7JJxm1K8Y4MzgKRlPhoIYiVaHruwzqROMEC * tools/skia_goldctl/win: _LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC..3Z3zEAwtATXaw6OCunrkLRtBDiMoKW34b_yeMZ82eocC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Ia49b1a9a909ceea201b65fd2f8d823e967a90ffa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2776747 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 21 Mar, 2021 1 commit
-
-
Ian Elliott authored
The "Ragnarok M: Eternal Love" game uncovered a bug where 2 contexts shared a VkCommandBuffer. The one context was used by one thread for rendering, and the other context/thread dispatched compute shaders. When the rendering thread destroyed a VkCommandBuffer, future compute dispatches crashed because the new VkCommandBuffer didn't have a compute pipeline bound. Bug: b/181711029 Change-Id: I8bc85150c1c6202e02feb84a7ccc0ad7b9c39258 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770681 Commit-Queue: Ian Elliott <ianelliott@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org>
-
- 20 Mar, 2021 1 commit
-
-
Nicolas Capens authored
Cuttlefish with SwANGLE failed to pass the android.graphics.cts. BitmapTest#testDrawingHardwareBitmapNotLeaking test, due to a timeout in dequeueBuffer (error = -110) during an EGL_BUFFER_AGE_EXT surface query. This change conservatively works around the issue by leaving EGL_EXT_buffer_age support disabled for SwiftShader. Further investigation is required to check whether this timeout can also occur with other Vulkan drivers, and if it can be addressed robustly. Bug: b/182521420 Bug: angleproject:3529 Change-Id: I54e3767e74bf922f273d8860f9f4cfc8b6589536 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774030Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Nicolas Capens <nicolascapens@google.com>
-
- 19 Mar, 2021 9 commits
-
-
Charlie Lao authored
Aztec ruins is using the same texture (but different level controlled by a uniform variable) for textureLod and rendering. This triggers vulkan validation error. This CL put it in the ignore list so that it can pass. Bug: b/175584609 Change-Id: I7623e7b448514b3c12268aa5fe154f4c2f59b059 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770686 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Charlie Lao authored
This CL adds a new layout ImageLayout::ColorAttachmentAndShaderRead. We detect that the same ImageHelper object is used for both sampler and attachment and will pick this new layout instead of ColorAttachment. Bug: b/175584609 Change-Id: I2089f59d4dc1ad4de7edab0e067797adcfa9b020 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2749479 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Mohan Maiya authored
In preparation for adding support for more YUV formats add an 'isYUV' field that tracks whether a format is a YUV format. For now it is set if the format string contains the substring 'PLANE'. This is not the case for all known YUV formats but the condition can be expanded when required. Bug: angleproject:5773 Change-Id: Icb574037dc8105584931835dab0b60e8bafa3262 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774762Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Mohan Maiya <m.maiya@samsung.com>
-
Charlie Lao authored
Right now color render target's image's layout change are done at beginRenderPass time. The problem is that the layout also depends on whether texture is also being used as a sampler or not. That information is not known when renderpass starts. We did some special treatment for depth stencil attachment so that its layout determination is deferred until endRenderPass time. This CL expands that same mechanism to color attachment as well. Right now the color attachment will still pick the same ImageLayout::ColorAttachment layout since the logic to detect it is also used for texture sampling is not there yet. Bug: b/175584609 Change-Id: Id7486174d475f894461578b31d0d40fdd90e808a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2744121Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Charlie Lao <cclao@google.com>
-
Geoff Lang authored
When images are recovered from storage due to resizing storage, they were marked as clean and not always re-copied to the new storage. Bug: angleproject:5757 Bug: chromium:1188854 Change-Id: Idd11025820433ab74ff769cd9508efcec4575c32 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2763282Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Alexey Knyazev <lexa.knyazev@gmail.com> Commit-Queue: Geoff Lang <geofflang@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/6ea3512e6349..91a2a0b15f23 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/d18bcd64fa..979319b9b1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/4f498774db..a732e4c03c * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/d5bf0be344..309d9bea09 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: Ifb1845a82a8ae3c3cd19e7023bb20048a6486ff3 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774761 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/e7ef5f7d0368..c33e21cce932 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/17a38f4bb2..ba8be7fd2f * buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/c93be42a40..4e078437d0 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/3b69bfd940..55b74c093b * third_party/abseil-cpp: https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp/+log/8e820e32d0..74cb518d98 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/168ccba7af..9629038820 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/luci-go: git_revision:ea8dc31395c76b2990112b29b02386628d795d2d..git_revision:4eef77dde582d6065203e3249dd80477391a7dd6 * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/c98db359fc..df4e23350e * tools/skia_goldctl/linux: NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC..GNchtrcB6qbKJwI4p-GTx1VGkCUsAWxKyn2kIXkyMZcC * tools/skia_goldctl/mac: Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C..0r4l0jSQ08UrxS6-MUtgrn6DegnbVTPg-1I_HWxO3JsC * tools/skia_goldctl/win: 3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC.._LtAsLqSVwpOUShHDIbQWgtPXUO4xbpf1MDMcloIAdQC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: I36906d996c7474ebf61c329ad7622f32c00ec960 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774452 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*ragnarok_m_eternal_love*" TBR: timvp@google.com,jmadill@google.com Bug: b/181800519 Bug: angleproject:5772 Change-Id: I1dcde486e909f7c2b5d59132e5f673c7e8ab1d01 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2774264Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Qin Jiajia authored
This PR strengthens below two cases: 1. Support calculate unsized array size for any type. Previously, it reported error when the type was a structure. 2. Correctly add the right paren for store function when any load/length functions are nested in it. Bug: angleproject:5734 Change-Id: I3428fa35f1481275e1d193094ceddb011f747cf1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2762655Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
-
- 18 Mar, 2021 8 commits
-
-
Jamie Madill authored
This simplifies a lot of the data structure indexing in the program executable class. Also renames the "DriverUniforms" and "InternalShader" index into a single "Internal" index. Bug: angleproject:5736 Change-Id: I2a51d8b14d5b16b438dbe636f77b11bbc045ba9a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-
Jamie Madill authored
We were using repeated code patterns in several places. Bug: angleproject:5736 Change-Id: I206783dd792c3b0f9d38027235445ec600a60d88 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2773320Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Charlie Lao authored
This is a mechanical change. Similar to constructor, the reset() function is doing initialization of data members. Move them next to each other helps adding a new data members which requires modifications to both functions. Bug: b/175584609 Change-Id: I11386677bc5c9838104025d6a4ecf6f2b58fa92c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2745842Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
-
Charlie Lao authored
This simulates aztec ruin's usage. This works properly on native OpenGL but generates validation error on vulkan backend and renders incorrect as well. Bug: b/175584609 Test: FramebufferTest_ES3.SampleFromAttachedTextureWithDifferentLOD Change-Id: I402c205a1b625669cae29ee201dddd144e0dfbde Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2743797Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Commit-Queue: Charlie Lao <cclao@google.com>
-
Gert Wollny authored
These include stubs are given in the comments within rapidjson.h and are preported as error by the presubmission check. Bug: angleproject:5765 Change-Id: Ic200a860de7337aefcd3bb0f82686d62a1349d89 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2765648Reviewed-by:
Cody Northrop <cnorthrop@google.com> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Gert Wollny <gert.wollny@collabora.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/60fea25f23e6..e7ef5f7d0368 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/37b76d6fba..17a38f4bb2 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/2408fca90b..3b69bfd940 * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c730daef75 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/752611e5f2..168ccba7af * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/luci-go: git_revision:19175e196dd495f6e092845f7d777cb5bf157b3e..git_revision:ea8dc31395c76b2990112b29b02386628d795d2d * tools/mb: https://chromium.googlesource.com/chromium/src/tools/mb/+log/67f01522b1..c98db359fc * tools/skia_goldctl/linux: 3T-SUsozYAVsudk5nd48kjHvfpos6egORLB8s7ElE8oC..NQmBkXHpEXJthTy0c6iuXDk1UgYDyQ7Fm649E7P38bAC * tools/skia_goldctl/mac: TPtcrf_XH3mB9pdK4W3N0QPZunsqJ08T7U7fWPvMnRAC..Rbel_7KQuxv_-SIkB3oT43MBYgKlr3AUwFystGNHKJ8C * tools/skia_goldctl/win: wr5p_MyXcHVxA-eHznijCeFaqR2HUo02Hw70e0CWCIoC..3sDKbIeT1dc4BYnE_uMfW71xbKa-b75KWLUwVEIJF-QC No update to Clang. Bug: angleproject:2424,angleproject:2880,angleproject:2994,angleproject:3033,angleproject:3753,angleproject:4377,angleproject:5014 Tbr: timvp@google.com Change-Id: Ib964474c19e613fedb9ab3ac0d474fc1829289ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770687 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/105af117f053..6ea3512e6349 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/b2e5b5c559..d18bcd64fa * spirv-headers: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/faa570afbc..bcf55210f1 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/478754c005..4f498774db * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/053e2bf22d..d5bf0be344 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I190a577538fb3a2178c1e82f1c9fc4e52749a322 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2770144 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
James Darpinian authored
Jeff's new rendering feedback loop test (https://github.com/KhronosGroup/WebGL/pull/3221) found a couple of issues with texture base level validation. For immutable textures the base level is clamped to the valid range, so setting an out of range base level does not make an immutable texture sampler incomplete, and we need to use the clamped value when checking for rendering feedback loops. Bug: angleproject:5768 Change-Id: Ie065709efd736f2cf75d4f980e8ac27999f80142 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2767901 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org>
-
- 17 Mar, 2021 2 commits
-
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*junes_journey*" TBR: jmadill@google.com,timvp@google.com Bug: b/182566407 Bug: angleproject:5752 Change-Id: I083507949c9bc16bf701028a678540df9a3531dc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2755840Reviewed-by:
Cody Northrop <cnorthrop@google.com> Commit-Queue: Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
This switches the tracking for the uniform, shader storage, and atomic counter buffers to use bitset masks to determine where there are active buffers. This will make iterating these buffer sets faster. Also renames the limit for atomic counter buffers to be consistent with the other buffer types. Also applies the implementation limit to atomic counter buffer bindings. This fixes out-of-bounds access on some Linux platforms that expose a large number of bindings. Bug: angleproject:5736 Change-Id: Ice801645697592d1dda6aebf0cb69767594cc0c5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2757509 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com>
-