- 19 May, 2021 6 commits
-
-
Brandon Schade authored
Added missing validation to handle in/out qualifier for geometry shaders Test: KHR-GLES32.core.geometry_shader.nonarray_input.* Bug: angleproject:5579 Change-Id: I9ee0853526ce296df1f56fb7783f9847b31e49bc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2901256 Commit-Queue: Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org>
-
Shahbaz Youssefi authored
This is the first change in a series to generate SPIR-V directly from the translator's AST, instead of the generating text GLSL and feeding it to glslang. This change implements the majority of the work needed to map AST types to SPIR-V types, and declare types and interface variables in SPIR-V. Additionally, it lays the infrastructure to conditionally enabling this path in end2end tests. No tests are currently enabled as the change doesn't actually generate code for function bodies yet. Bug: angleproject:4889 Change-Id: Iacb28b6907fd48c50e4cc5a0e7ad72f6eed241d4 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2889603 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Tim Van Patten <timvp@google.com> Reviewed-by:
-
Tim Van Patten authored
When developing in the Android source tree, 'aidegen' can be used to create an Intellij workspace. This also creates the file angle.iml in the specified module directories, though, so this CL adds angle.iml to ANGLE's .gitignore. Bug: None Change-Id: Id73380fa7750c591967aa81ec7a8c991e074a303 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2906104Reviewed-by:
-
Jamie Madill authored
Otherwise this breaks the auto-roll script. Bug: angleproject:5941 Change-Id: I9b1d850822732c41b8a73de33060ceb50b8a49ab Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2905194Reviewed-by:
-
Geoff Lang authored
This reverts commit cbbaf76b. Reason for revert: Suspecting this breaks the fuchsia_x64 bot WebGL tests. Ex: https://chromium-review.googlesource.com/c/chromium/src/+/2904812 Original change's description: > [Vulkan] Add DisplayVkNull > > Currently all DisplayVk implementations depend on VK_KHR_swapchain and > VK_KHR_surface extensions. When running Chromium on Fuchsia these > extensions are never used (content is shown on the screen using > ImagePipe API without dependency on swapchain). ANGLE still depended > on these extensions for DisplayVkFuchsia. > This CL adds DisplayVkNull, which allows to run ANGLE without dependency > on swapchain. It's usable only offscreen and cannot present content on > a surface. > > Bug: chromium:1203879 > Change-Id: I4d1307060967ffa68877c4300ea4d5590eeb2152 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2861313 > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> Bug: chromium:1203879 Change-Id: I6701ffff48fcb925f387e63b356d2d5cf360ea7e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2904183Reviewed-by:
Geoff Lang <geofflang@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/3d799e0e9b08..baa6900ec346 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/202c8abae0..e71278cc92 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/1d86b3235b..cfd1a09358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: If95c7f11ffe6a41dd200e7613d9ad4e037e2db0e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2901404 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
- 18 May, 2021 22 commits
-
-
Shahbaz Youssefi authored
This reverts commit 76181384. Reason for revert: Bug exposed by this is fixed in https://chromium-review.googlesource.com/c/angle/angle/+/2896168 Original change's description: > Vulkan: Disable BufferVk suballocation > > There are still unresolved bugs. > > Bug: angleproject:5719 > Bug: chromium:1209197 > Change-Id: I6a971c421d0ae266404d1ecbf8741a9747a4e809 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897545 > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > Commit-Queue: Tim Van Patten <timvp@google.com> Bug: angleproject:5719 Bug: chromium:1209197 Change-Id: I5c24b5f6476eab98ed5a7b90b3d1796ffc7ca106 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896169 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
-
Gert Wollny authored
This is useful to not pass a large amount of parameters around. Bug: angleproject:5965 Change-Id: I3890a0ca852729bbf74725fb9e5f4062e20e9158 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894485 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Cody Northrop <cnorthrop@google.com>
-
Jamie Madill authored
Only angle_end2end_tests and angle_unittests to start. Also adds test expectations for the Pixel 4 end2end_tests. Patch Series: 1. http://crrev.com/c/2885381 2. http://crrev.com/c/2885346 3. http://crrev.com/c/2885383 4. This CL Bug: angleproject:5941 Bug: angleproject:5946 Bug: angleproject:5947 Bug: angleproject:5981 Change-Id: Iaaea0b427513804575d0ad7773a81379ea932eb5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2885384 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org>
-
Jamie Madill authored
Uses the conditions for the expectation to determine if there's a bug. Necessary for the new loading mechanism which defers filtering. Bug: angleproject:5951 Change-Id: Ic0c65438f7f155caff72b3ceeb4e65f8184c8efc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2902666Reviewed-by:
Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Jamie Madill <jmadill@chromium.org>
-
Jonah Ryan-Davis authored
This reverts commit c8c414b0. Reason for revert: Breaking fuchsia_x64 and ANGLE autoroller Original change's description: > Reland Change to module directory when loading swiftshader ICD. > > This is a reland of commit 3b10dda6. > > Extra changes: > Be explicit about calling GetModuleHandleA > Do not use the general GetModuleHandle, which may use wide strings > > GetModuleDirectory should return the full path, not relative. > ANGLE wasn't able to locate the vulkan ICD file because it was > searching down an invalid relative path. This can be fixed by > ensuring the module directory is always the full path. > on some platforms. > > Original change's description: > > When loading vulkan, we can be running from any directory. We need > > to change to the module directory to ensure the swiftshader ICD is > > loaded properly. For example, in some Chrome releases, libGLESv2.dll > > and libvk_swiftshader.dll are in a subdirectory relative to chrome.exe > > > > Bug: chromium:1198567 > > Change-Id: I9e68927e512b239728fb2903d1a04702508a4948 > > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2873452 > > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > > Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Bug: chromium:1198567 > Bug: angleproject:5949 > Change-Id: Ib34067002c788f00b5ae2fa11d1e465f57bd7be8 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2893503 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Cody Northrop <cnorthrop@google.com> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Bug: chromium:1198567 Bug: angleproject:5949 Change-Id: Ic0be8949cc27b231be4f982ea6e22beed590d24d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2903786Reviewed-by:
-
Mohan Maiya authored
Add support for GL_EXT_texture_border_clamp. This is implemented by using VK_EXT_custom_border_color. Bug: angleproject:3577 Test: dEQP-GLES31.functional.texture.border_clamp* Change-Id: Ie9fa1eb5dd03b997b5ae182787641a53080a9e51 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2830192Reviewed-by:
-
Cody Northrop authored
Crashing on teardown. Bug: angleproject:5989 Change-Id: Ie5560f4e1dee310f5f08a7bca83a0506c20f6920 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2904126Reviewed-by:
-
Cody Northrop authored
Test: angle_perftests --gtest_filter="*sakura_school_simulator*" Tbr: timvp@google.com,jmadill@chromium.org Bug: b/188488065 Bug: angleproject:5987 Change-Id: Idf9966c32de8c2720edf1b7575722052c5cd294a Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2902443Reviewed-by:
-
Cody Northrop authored
Instead of asserting that the app is calling glDeleteBuffers on buffers we've seen created, ignore buffer names that we haven't seen. This is allowed by the spec: Buffer objects are deleted by calling void DeleteBuffers(sizei n, const uint *buffers); Unused names in buffers are silently ignored, as is the value zero. Test: SAKURA School Simulator MEC Bug: b/188488065 Bug: angleproject:5987 Change-Id: Id4704e544f644dbe3edf6efdf70b5c3ef9ccaba7 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2902442Reviewed-by: -
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/af907708adb3..0ca03fb2907c 2021-05-17 capn@google.com Update Android build files with license info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com Change-Id: I7d006bf382efebae6853979f6ee4daffd3d67aae Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2901755 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
John Plate authored
Make it possible to load libGLESv2 and OpenCL_ANGLE without adding ANGLE's binary directory to the search path. Bug: angleproject:5904 Change-Id: Ie810466b39e1101e4da5b9fd199d26683b129281 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897250 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
-
John Plate authored
Add front end object references to back end objects, which requires a significant amount of refactoring, because the back end objects have to be constructed during the construction of the front end objects, so that the references can be passed to the back end objects, which then can be passed to the front end member initialization. That would have been easier with inheritance than with PImpl. Bug: angleproject:5904 Change-Id: Ib58e6a698e76987bdd63cd8088f923424d6c622b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897249 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
-
John Plate authored
Move the OpenCl object cast from the generated entry points to the stubs and front end, to make it possible to properly use static_cast. This removes the limitation that the front end objects have to be standard layout (and makes it possible to use virtual functions), which is consistent with other front end objects. Move the back end initialization from the stubs to the entry point functions, which fixes a bug where the back ends were not initialized during validation. Move more code from the stubs to the front end, to keep the stubs light. Remove unused function `default_return_value` from `generate_entry_points.py`. Bug: angleproject:5904 Change-Id: Id999ad6c537888017bf3252c6f6e088b7d4c7984 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897245 Commit-Queue: John Plate <jplate@google.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/9b886afc6e79..2b00cebcd5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/c81ea93291..d23e13a4cf * testing: https://chromium.googlesource.com/chromium/src/testing/+log/31a90015dd..d7dc6149dd * third_party/android_deps: https://chromium.googlesource.com/chromium/src/third_party/android_deps/+log/2000d0a880..c65e9394fd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..c1e1d559b4 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd152033d0..fe7d709f05 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/5ce08a7f2e..5b8d433953 * tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang.git/+log/f6e0cbe7b7..209b045b46 Clang version changed llvmorg-13-init-9302-g897d7bce:llvmorg-13-init-10392-gd3676d4b Details: https://chromium.googlesource.com/chromium/src/tools/clang/+/f6e0cbe7b7efe0ba94157937d701077aeaab2d5b..209b045b46c0cb8893cc9ab9ac3ff54f14a8f359/scripts/update.py Bug: None Tbr: cnorthrop@google.com Change-Id: I14a9983956f53069b990589281c3fc2c312caf84 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2902751 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Alexey Knyazev authored
For completeness, added mappings of R8_SRGB and R8G8_SRGB to OpenGL and Metal. Bug: angleproject:4932 Change-Id: Ic8e44e3a94c114e985f6965fcd43fbcb8071432d Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2880661 Commit-Queue: Alexey Knyazev <lexa.knyazev@gmail.com> Reviewed-by:
-
angle-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/055e71b2a367..3d799e0e9b08 Changed dependencies: * glslang: https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/9431c53c84..202c8abae0 * spirv-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1020e394cb..f0d110e305 * vulkan-loader: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Loader.git/+log/039cea5353..a132dee142 * vulkan-tools: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/4ee5f2a8be..f89f72e105 * vulkan-validation-layers: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/0aca21bce7..1d86b3235b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC cnorthrop@google.com,timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: cnorthrop@google.com,timvp@google.com Change-Id: I548c56653d348997e000ef8bc5e644948db95889 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2901247 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Shahbaz Youssefi authored
When recreating a texture image to change a usage flag or the base/max levels, this change directly places the levels of the previous image as updates to the new image. This is instead of copying the image to a temp one and staging that. Bug: angleproject:4835 Change-Id: Ibc210b9ff0e8d11cba10b1cd9ab262c8f706cea5 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2898417 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Charlie Lao <cclao@google.com>
-
Shahbaz Youssefi authored
There was one instance of BufferVk releasing a buffer it had allocated from a DynamicBuffer. This shouldn't have happened as the DynamicBuffer owns the buffers. Bug: angleproject:5720 Change-Id: I435512f4bb099130126bf3efb48a238fcd9f3ddb Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896168 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by:
Mohan Maiya <m.maiya@samsung.com> Reviewed-by:
-
Cody Northrop authored
Test: angle_perftest --gtest_filter="*pokemon_go*" Tbr: jmadill@chromium.org,timvp@google.com Bug: b/188091629 Bug: angleproject:5968 Change-Id: I3f48957a3063fbe5a443c235b6cabf87319b17c1 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895329Reviewed-by:
-
Cody Northrop authored
Traces that have shader compiles in the middle of the run are reusing the string pointers on each go through. On some (multiple) platforms, the string pointer is no good on the second run through. This may only happen for large strings. Adding a const qualifier on the pointer itself, not just the string, avoids the issue. This has the effect of changing strings from this: const char *glShaderSource_string_0[] = { const char *glShaderSource_string_1[] = { to this: const char* const glShaderSource_string_0[] = { const char* const glShaderSource_string_1[] = { Test: Pokemon Go MEC Bug: b/188091629 Bug: angleproject:5968 Change-Id: Id6a05c955adb3e1c43d2723450be6b5278d99fba Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895328 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: -
Cody Northrop authored
Apps are querying GL_ACTIVE_UNIFORMS and then walking through them all numerically, calling glGetActiveUniform on each one. Before this CL, our trace would also walk through them all, exactly as the app. But, the active uniform count can vary on different platforms depending on how aggressive the underlying compiler is. We have at least one that does cross stage optimizations eliminating more active uniforms than others. Rather than check each call against the actual number of active uniforms, we can just drop the calls to glGetActiveUniform. We don't actually use any of the results from the call. For example, this is what we generate before this CL: glGetActiveUniform(gShaderProgramMap[144], 31, 1024, reinterpret_cast<GLsizei *>(gReadBuffer), reinterpret_cast<GLint *>(gReadBuffer), reinterpret_cast<GLenum *>(gReadBuffer), glGetActiveUniform_name_30); This has the downside of moving away from reflecting what the app actually sent down. The alternatives are too intrusive though, and we want to stay as close to speed of light as we can. Test: Pokemon Go MEC Bug: b/188091629 Bug: angleproject:5968 Change-Id: I1263f2256c6a964dac54d9997a1c1c2dceac711b Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895327 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by: -
Cody Northrop authored
Apps that create new programs during the run need to have them deleted on loop. This CL handles that. It does not handle programs that have been deleted and need to be recreated, or that have been modified otherwise. An assert has been included to catch that for future needs. With this CL, entries like this will show up in ResetReplay: ... glDeleteProgram(gShaderProgramMap[120]); glDeleteProgram(gShaderProgramMap[121]); ... Test: Pokemon Go MEC Bug: b/188091629 Bug: angleproject:5968 Change-Id: I78c425e8fe95792fc626484641d067613dfae971 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2895326 Commit-Queue: Cody Northrop <cnorthrop@google.com> Reviewed-by:
-
- 17 May, 2021 11 commits
-
-
Cody Northrop authored
Bug: angleproject:5982 Change-Id: I228c5549d7c83d5fb3eb12a097dd4bcc20f56955 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2900929Reviewed-by:
-
Jamie Madill authored
If something goes wrong in ANGLETestSetup, we can skip the test- specific setup and teardown code to prevent further errors and crashes. This is necessary for the new test expectation skips. Bug: angleproject:5951 Change-Id: Ica7b9fed18cec20e7d0e340c39dbbb44f1f8958e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896173Reviewed-by:
-
Jonah Ryan-Davis authored
This now handles the case where dladdr doesn't return any information about the filename. This was causing issues on Fuschia. Bug: chromium:1198567 Change-Id: I892106282fc930d4d26e3eecd720a11e05b8dcd8 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2896171Reviewed-by:
-
Shahbaz Youssefi authored
Prior to this change, respecifying a texture image due to usage, base or max level changes incurred a copy of every level and layer to a temporary buffer which was then staged as an update to the new image. This code was somewhat messy (for example with respect to depth/stencil images), error prone (e.g. previously had bugs with compressed textures) and disallowed further optimizations such as in anglebug.com/4835. This change does the following: - ImageHelper::SubresourceUpdate now takes ref-counted images, instead of image pointers. This allows the same image to be staged for multiple updates. - Respecifying an image is still done through a copy, but to an identical (temp) image instead of buffer, and each level of the image is staged as an update. * Further optimization is to stage the old image itself directly as updates to the new image Bug: angleproject:4835 Change-Id: I4a3ef2d616c9ab459ff65f918b0fb6d9a2161b73 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897537 Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org> Reviewed-by: -
Shahbaz Youssefi authored
Prior to this change, the transform feedback buffer offset was not stored in the descriptor set key, so if the offset changed, stale descriptor sets could be used. Bug: angleproject:5963 Change-Id: I3dec4ab9fa82092a65e9a75bdd19c5f2cf49521c Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2894513Reviewed-by:
-
Jamie Madill authored
This CL implements two features: first off we can now split the tests into several shards which we can run independently on different machines. Second it implements a simple retry mechanism that will retry a failed test a number of times and count any first passing test as a pass. Bug: angleproject:5875 Bug: angleproject:5966 Change-Id: Ieef4ea0e4eebdb286a32de3b1e3fef4f2eda0600 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897546Reviewed-by:
-
angle-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/c4d054c6ad41..af907708adb3 2021-05-14 capn@google.com Unpoison Reactor Call() arguments when MSan instrumentation is disabled 2021-05-14 capn@google.com Update Vulkan headers to version 1.2.178 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: timvp@google.com Change-Id: I4efbca5bd495ad3e56de915032e84a1790a4662e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2900022 Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
angle-autoroll authored
https://chromium.googlesource.com/chromium/src.git/+log/3b747dab7bb3..9b886afc6e79 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-angle-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Changed dependencies * build: https://chromium.googlesource.com/chromium/src/build.git/+log/00d8280637..c81ea93291 * buildtools: https://chromium.googlesource.com/chromium/src/buildtools.git/+log/b0912f9572..20b1d0fc13 * testing: https://chromium.googlesource.com/chromium/src/testing/+log/32fdfcc5af..31a90015dd * third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/{catapult_..a532699d20 * third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5ab2f3314c..cd152033d0 * third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/2b99b37874..5ce08a7f2e * tools/luci-go: git_revision:808e8d99fad90d180286ce6d176de6373a5e1398..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 * tools/luci-go: git_revision:808e8d99fad90d180286ce6d176de6373a5e1398..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 * tools/luci-go: git_revision:808e8d99fad90d180286ce6d176de6373a5e1398..git_revision:bbac8f199026d706b08e53ca46d1a9560ae580d2 * tools/skia_goldctl/linux: 6gOkUwwapS1GyCkAQb7-gPiKnvzdUOyDzkT4NzmnYJEC..BLHYEUi0wOYe5D_InWXtD8US7l_PMOrKHLuKt16L46QC * tools/skia_goldctl/mac: 43qoaMWgldhQiaXzcCNggSSWDmZQTNrK0cGEt5yysgsC..qofjOtuSqFXnMKjZ9c7c-oVh9HeWjGW4h4F3y-vrfEkC * tools/skia_goldctl/win: oodEEBUIHfKw18_-31PAsu3SFiLqvtsFDgbn6ohK5R4C..P9wyIW02W7EqtyT9cZJj6g0HOcjRHAhN5KECwmhgRjUC No update to Clang. Bug: None Tbr: timvp@google.com Change-Id: Iedbaff423759a2752c3c341a3abb6b08424515e0 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2899842 Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
-
Gert Wollny authored
When tests are run with a wildcard filter on the backend, e.g. "TEST/ES2_Vulkan*" the same tests from different backends may end up in the same trace file directory, e.g. TEST_ES2_Vulkan and TEST_ES2_Vulkan_SwiftShader. So far, when searching for the ES2_Vulkan trace files the check for trace files would them also pick up all the _SwiftShader files, and the skript would assume that the file count is wrong and skip the replay. By adding "_capture" the start of the commonly used suffix, this is avoided and replays are no longer skipped because mis-counting capture files. Bug: angleproject:5972 Change-Id: I7af54aaf51ee7070333ffe81974d866bd89dbd6f Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2897236 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
-
Gert Wollny authored
The capture/replay context differences may not be in each frame, so if the test signals that comparisons fail, don't bail if the context JSON files are not found for one frame, but continue the search until all possibly captured frames have been checked Bug: angleproject:5953 Change-Id: I8af34cc0fe4de5615fc43ef6c45915055546f507 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2891772 Commit-Queue: Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
-
Gert Wollny authored
Bug: angleproject:5938 Change-Id: I7c9ab9bebd1ec2dc572a071844a860f99d0befe6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2882580Reviewed-by:
-
- 15 May, 2021 1 commit
-
-
Charlie Lao authored
This converts webgl_conformance_vulkan_passthrough_tests/texture-size.html to an end2end test for ease of debugging. Bug: chromium:1197905 Change-Id: If77dc30e81450b277c6a02d66c076b088d069498 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2821944 Commit-Queue: Charlie Lao <cclao@google.com> Reviewed-by:
-
