Commits · e96899c43b082eb4c597bfb893107fe55cfaff68 · Chen Yisong / angle

12 May, 2015 12 commits

Fix compilation of EGLSurfaceTest · e96899c4

authored May 12, 2015

BUG=angleproject:892

Change-Id: I8c999e06c8cc3567f7bb1aed23286bd7e9080616
Reviewed-on: https://chromium-review.googlesource.com/270432Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

e96899c4

X11Window: implement event handling and modifiers · 43b0c221

authored May 12, 2015

BUG=angleproject:892

Change-Id: I65f251abdd28b273e2d3d574825f20bba8bb2532
Reviewed-on: https://chromium-review.googlesource.com/270452Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

43b0c221

Temporarily move back ANGLETest in end2end_tests · ac3ab882

authored May 12, 2015

This path needs to a Chrome change before it can change.

BUG=angleproject:892

Change-Id: I549737383b9720a2e7d83ee5e3145d71716f04cb
Reviewed-on: https://chromium-review.googlesource.com/270457Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ac3ab882

Revert "Make EGLQueryContextTest use ANGLE_INSTANTIATE_TEST" · c4738880

authored May 12, 2015

Broke win build

ninja: error: '../../gpu/egl_tests/EGLQueryContextTest.cpp', needed by 'obj/gpu/egl_tests/angle_end2end_tests.EGLQueryContextTest.obj', missing and no known rule to make it
This reverts commit 887dd2f1.

Change-Id: I2ceb430010628c2aa7cb242eb2bf49406d8d87db
Reviewed-on: https://chromium-review.googlesource.com/270471Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Zhenyao Mo <zmo@chromium.org>

c4738880

Make EGLQueryContextTest use ANGLE_INSTANTIATE_TEST · 887dd2f1

authored May 11, 2015

This makes it run correctly on Linux where the only platform available
is OpenGL.

BUG=angleproject:892

Change-Id: I3d72163b49b35daba702ebb5b48d010761c7fb6d
Reviewed-on: https://chromium-review.googlesource.com/270262Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

887dd2f1

Compile end2end tests on Linux · 973402fd

authored May 11, 2015

BUG=angleproject:892

Change-Id: Id4a9ddc35ae9600080e743c77476d36743a3e646
Reviewed-on: https://chromium-review.googlesource.com/270199Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/270412

973402fd

Revert "Compile end2end tests on Linux" · e45b7458

authored May 12, 2015

Build errors in Chromium:

ninja: Entering directory `C:\b\build\slave\GPU_Win_Builder\build\src\out\Release'
ninja: error: '../../gpu/egl_tests/EGLQueryContextTest.cpp', needed by 'obj/gpu/egl_tests/angle_end2end_tests.EGLQueryContextTest.obj', missing and no known rule to make it

This reverts commit be39156b.

Change-Id: I931295f16cad096e94baac9811ea2396a4182848
Reviewed-on: https://chromium-review.googlesource.com/270347Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

e45b7458

OSWindow: add optional debugging of events received · 938f1ca3

authored May 12, 2015

BUG=angleproject:830

Change-Id: Icd854ee152f15ec1de4293b5ed2ed49cb1a5fc2b
Reviewed-on: https://chromium-review.googlesource.com/270451Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

938f1ca3

Implement Pbuffers for the GLX EGL implementation · 0d3afab8

authored May 11, 2015

BUG=angleproject:892

Change-Id: I32b9bbb35d99621f16a055fb544ec0691dfcd5a0
Reviewed-on: https://chromium-review.googlesource.com/270261Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

0d3afab8

Compile end2end tests on Linux · be39156b

authored May 11, 2015

BUG=angleproject:892

Change-Id: If3903f1801f4999bebaaaed2625346bfbec2243d
Reviewed-on: https://chromium-review.googlesource.com/270199Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

be39156b

Move end2end and standalone tests to gl_tests and egl_tests · 9cb9583e

authored May 11, 2015

Also introduce a test_utils directory that contains helpers used for all
types of tests.

BUG=angleproject:892

Change-Id: I9e1bff895020ffd3a109162283971a290a1098bd
Reviewed-on: https://chromium-review.googlesource.com/270198Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

9cb9583e

Add constant folding support for min,max and clamp · 1137a2a6

authored May 05, 2015

This change adds necessary mechanism to support constant folding of
built-ins that take more than one parameter and also adds constant
folding support for min, max and clamp built-ins.

BUG=angleproject:913
TESTS=dEQP tests
(126 tests started passing with this change)
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.min_*
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.max_*
dEQP-GLES3.functional.shaders.constant_expressions.builtin_functions.common.clamp_*

Change-Id: I5d3e96ef2062116cbf164a7a42cba096bd4d5389
Reviewed-on: https://chromium-review.googlesource.com/269317Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

1137a2a6

11 May, 2015 12 commits

DisplayGLX: handle EGL_DEFAULT_DISPLAY for ANGLE_platform_angle · 4298123b

authored May 11, 2015

BUG=angleproject:892

Change-Id: I681e2b92ac2e8b853c7d1271a5518c4b77a67929
Reviewed-on: https://chromium-review.googlesource.com/270260Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

4298123b

Convert floats to integers using doubles and 64-bit integers. · c337e7ab

authored Apr 30, 2015

Avoids some edge cases that overflow or round incorrectly.

Fixes:
dEQP-GLES2.functional.state_query.floats.depth_range_getinteger
dEQP-GLES2.functional.state_query.floats.color_clear_value_getinteger
dEQP-GLES2.functional.state_query.floats.depth_clear_value_getinteger

Change-Id: Ib2c7f422dac76094c7ff6c5f8aef3fd392f68e80
Reviewed-on: https://chromium-review.googlesource.com/268510Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c337e7ab

Add a basic GLX EGL implementation · eac64633

authored May 06, 2015

BUG=angleproject:892

Change-Id: Ife9955a457d4a6fb3adce17757ccb0de7d0dd274
Reviewed-on: https://chromium-review.googlesource.com/269413Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

eac64633

Add a FunctionsGLX class to dynamically load the GLX entry points · f229cb9b

authored May 08, 2015

BUG=angleproject:892

Change-Id: I516b7d859100cb065871de8e328585a9ca817499
Reviewed-on: https://chromium-review.googlesource.com/270123Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

f229cb9b

Filter out unsupported platforms for value parameterized tests · 6fce6df7

authored May 11, 2015

With this most of the end2end tests pass on Linux

BUG=angleproject:997
BUG=angleproject:982

Change-Id: I6aab7d407f260ee24c5c59bf4d6055e875d3a6d6
Reviewed-on: https://chromium-review.googlesource.com/270184Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

6fce6df7

Fix pointer to int conversion warning in EGLWindow.cpp · 12fe4dc8

authored May 04, 2015

BUG=angleproject:892

Change-Id: Ic40f29c811d18efea0e081c269ca43d0170488a4
Reviewed-on: https://chromium-review.googlesource.com/269122Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/270125

12fe4dc8

Add missing EvqPointCoord to getQualifierString · 4f3b8f63

authored May 11, 2015

Also sort enums in getQualifierString in the same order as in the enum
definition.

BUG=angleproject:999
TEST=WebGL conformance tests with --gl-shader-interm-output

Change-Id: I31aa2e4b2405a090f560bf4140d9ee66271e526c
Reviewed-on: https://chromium-review.googlesource.com/269941Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4f3b8f63

Make all the samples compile under Linux · 12a8e866

authored May 07, 2015

Two-thirds of them run and work well.

BUG=angleproject:892

Change-Id: I401a7ef4fd055eda7276bd34dcf0fc6ae0deff13
Reviewed-on: https://chromium-review.googlesource.com/270124Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

12a8e866

Remove Texture serials and Texture::INCOMPLETE_TEXTURE_ID. · eaa759c4

authored Apr 02, 2015

Texture serials were not used in any place that pointers could not be used
and Texture::INCOMPLETE_TEXTURE_ID was only referenced by RendererD3D.

This was the last place that serials are used in the gl layer.

BUG=angleproject:681

Change-Id: Iad24321fba57db8ade3c9eb8f04cc20e98ded1b0
Reviewed-on: https://chromium-review.googlesource.com/263659Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

eaa759c4

Move unsupported depth stencil check to FramebufferD3D. · c2520564

authored Apr 29, 2015

BUG=angleproject:885

Change-Id: I0abc674e365d2b5b65d23e2abf741a02a1146cdd
Reviewed-on: https://chromium-review.googlesource.com/268311Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

c2520564

Roll googletest. · 440e5d4f

authored May 08, 2015

This also moves us to the Chromium googletest mirror. It may cause
conflicts with developer setups if they have the folder open when
they try to gclient sync.

BUG=angleproject:997

Change-Id: I94a629c50cb6ea6fc0020e3ec9ee93b7088d964b
Reviewed-on: https://chromium-review.googlesource.com/270108Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

440e5d4f

Optimize Texture binding by only applying referenced textures. · f51bc795

authored May 04, 2015

Update ProgramGL to track which the current values of sampler uniforms so
that only the currently applied texture units have to be bound for the
draw call.

BUG=angleproject:882

Change-Id: I280aa106172b13a5fbb31cdefba27b6691c0a0e4
Reviewed-on: https://chromium-review.googlesource.com/264803Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

f51bc795

08 May, 2015 6 commits

Add GLX EGL implementation stubs · 9477dc94

authored May 06, 2015

BUG=angleproject:892

Change-Id: I1ef1bd0ce60f4585e473f9750c748a1b41c09da2
Reviewed-on: https://chromium-review.googlesource.com/269741Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

9477dc94

Roll dEQP. · d5008157

authored May 08, 2015

BUG=angleproject:998

Change-Id: I35067bd5ed2919f918a1f1b93bef0feb934c838d
Reviewed-on: https://chromium-review.googlesource.com/270120Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d5008157

Use value-paramaterized tests instead of by type. · fa05f607

authored May 07, 2015

This should fix our non-standard template use, which causes compile
errors for the tests on GCC/Clang.

BUG=angleproject:997

Change-Id: Id1bb15231eda445f37e53a5b33d4684ec6618d8e
Reviewed-on: https://chromium-review.googlesource.com/269858Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

fa05f607

Fix issues with ProgramGL. · 0ca53786

authored May 07, 2015

 * Don't re-create the native GL program every link, some program state should
   persist between re-linking such as bound attribute locations.
 * Forward glBindAttribLocation calls to the ProgramImpl, fixes some chromium
   rendering issues because chromium always binds attribute locations,
   sometimes with gaps.
 * Query the real attrib location before inserting it into the list of attribs.
   It was unsafe to rely on the attrib having the same location as its index
   into the active attributes.

BUG=angleproject:882

Change-Id: If14b4c4c2f5ebcdaa4f7c5a890b9519d6d4e6e43
Reviewed-on: https://chromium-review.googlesource.com/269991Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0ca53786

Use a D3D11 renderer by default, when available. · 98e7d071

authored May 07, 2015

Also update SampleApplication to request the default
renderer instead of explicitely asking for d3d11

BUG=angleproject:892

Change-Id: I70c431b3c1ba78c3ce7844d7f276cc19ac17d7f5
Reviewed-on: https://chromium-review.googlesource.com/269999Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

98e7d071

Fix GetExecutablePath on Linux · 2cf30bd0

authored May 07, 2015

It was using lstat to get the size of /proc/self/exe but
it always returns 0, so we just use a big buffer on the
stack instead.

BUG=angleproject:892

Change-Id: I6d88efeb4ec5de7a78cb3668e3d78520203ad1d5
Reviewed-on: https://chromium-review.googlesource.com/269990Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

2cf30bd0

07 May, 2015 10 commits

Load the blit framebuffer extension entry points. · 0e201cb7

authored May 04, 2015

Change-Id: I654f944aea25661d3fb1e2381b93780771300f32
Reviewed-on: https://chromium-review.googlesource.com/269144Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0e201cb7

eglGetPlatformDisplayEXT: validate device types are set only on d3d · 6db6e0ae

authored May 06, 2015

BUG=angleproject:892

Change-Id: I0fa089f299abaab406384a05b096de19f04f3a5e
Reviewed-on: https://chromium-review.googlesource.com/269771Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/269829

6db6e0ae

EGLSurfaceTest: specify the device type only on d3d platform · 06394f66

authored May 07, 2015

BUG=angleproject:892

Change-Id: If09cf30122d97590f07447147e6d54c2e4157f9e
Reviewed-on: https://chromium-review.googlesource.com/269828Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

06394f66

EGLWindow: specify the device type only on d3d platform · bf9e4050

authored May 06, 2015

BUG=angleproject:892

Change-Id: I0406e26910f5a012ccb9e533af18e831522161b1
Reviewed-on: https://chromium-review.googlesource.com/269666Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/269827

bf9e4050

Make util/win32 follow ANGLE conventions better · ec0b1362

authored May 06, 2015

BUG=angleproject:892

Change-Id: I1ad366e16b135649fe1b0351081f9971db84df50
Reviewed-on: https://chromium-review.googlesource.com/269665Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Corentin Wallez <cwallez@chromium.org>

ec0b1362

Use stream operators for appending to InfoLog. · f611316b

authored May 07, 2015

Also add a helper class to keep the previous behaviour of
automatically appending a newline after every new message.

BUG=angleproject:992

Change-Id: I0ff5d2846175cf19de7a6af295af24a92451456f
Reviewed-on: https://chromium-review.googlesource.com/268744Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

f611316b

Use a std::stringstream for Program's InfoLog. · 71c3b2c7

authored May 07, 2015

This should help WebKit avoid needing to apply a local patch.
Also clean up the style in this file a bit.

BUG=angleproject:307,angleproject:992

Change-Id: I41ecf7cbfa20b469b3731215ef28cb36253ba186
Reviewed-on: https://chromium-review.googlesource.com/269849Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

71c3b2c7

Add test for HLSL "pow" constant folding bug. · 4052dfc8

authored May 06, 2015

This covers 'pow-of-small-constant-in-user-defined-function' from
the WebGL CTS. Leave disabled until we have a proper fix.

BUG=angleproject:851

Change-Id: I41a4ad9354e32bb2d48894d75676a9dfe226e9d8
Reviewed-on: https://chromium-review.googlesource.com/269747Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

4052dfc8

Revert "EGLWindow: specify the device type only on d3d platform" · 4ea209f1

authored May 07, 2015

Causing failures in EGLSurfaceTest.MakeCurrentTwice on Windows

BUG=angleproject:892

This reverts commit 118e7195.

Change-Id: Ifbb17d1c9bc0390abadbfb8f78cf14dbf1bb8e83
Reviewed-on: https://chromium-review.googlesource.com/269950Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4ea209f1

Revert "eglGetPlatformDisplayEXT: validate device types are set only on d3d" · 4c825e68

authored May 07, 2015

Depends on patch which is causing a failure in EGLSurfaceTest.MakeCurrentTwice

BUG=None

This reverts commit 0e7ee498.

Change-Id: I7d11900c784bdb2a8963a824e89019b39a184cbe
Reviewed-on: https://chromium-review.googlesource.com/269856Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

4c825e68