Commits · ea24759ffcbd798022ed80dfeef76cc8c7bbdb54 · Chen Yisong / angle

28 Aug, 2014 2 commits

Remove remnants of old PCH code. · ea24759f

authored Aug 28, 2014

Remove the precompiled.cpp file which was producing a build warning,
and rename the header to make it clear we no longer support PCH.

BUG=angle:

Change-Id: I944081ae477b1478ca9c18924fb02bb920d420a7
Reviewed-on: https://chromium-review.googlesource.com/214187Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ea24759f

Fix row-major layout tracking in interface blocks. · a6f267f9

authored Aug 27, 2014

Some block field types, such as nested structs, were bugged. This
only affects our "CollectVariables" path, not our current HLSL
UBO path.

BUG=angle:466

Change-Id: I2b8daf58aa7ec1ad06a80d38f57e76087eacccdc
Reviewed-on: https://chromium-review.googlesource.com/213503Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

a6f267f9

27 Aug, 2014 11 commits

Refactoring Shader objects (Take 2) · f05cdee4

authored Aug 27, 2014

This change refactors shaders to no longer be dependent on D3D-only concepts.

BUG=angle:731
Change-Id: I1006112f1d31b7e41bd14bd3225ea157b7d6c6c9
Reviewed-on: https://chromium-review.googlesource.com/214467Tested-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

f05cdee4

Revert "Refactoring Shader objects" · e54be46a

authored Aug 27, 2014

This reverts commit 537dfde5.

Change-Id: I5eb8923ac8f78877e6e77a8cd897021e56ee004a
Reviewed-on: https://chromium-review.googlesource.com/214466Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

e54be46a

Refactoring Shader objects · 537dfde5

authored Aug 20, 2014

This change refactors shaders to no longer be dependent on D3D-only concepts.

BUG=angle:731
Change-Id: I4fc1efeba9df4f873b3d7c8ba6f67f00b6532b9c
Reviewed-on: https://chromium-review.googlesource.com/213803Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Brandon Jones <bajones@chromium.org>

537dfde5

Fix GetUniform validation. · 549c7fdf

authored Aug 25, 2014

We were missing a check for an out-of-bounds Uniform, which could
cause us to miss an error and also give assertion failures.

BUG=angle:571

Change-Id: I844658a82ce13ea179a2358a202733c54bc2c0c7
Reviewed-on: https://chromium-review.googlesource.com/212934Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

549c7fdf

Refactor GetUniform validator helpers. · 78f41805

authored Aug 25, 2014

BUG=angle:571

Change-Id: I7b36c7af38b102a24dc0e5d5d87fc042533e90af
Reviewed-on: https://chromium-review.googlesource.com/212933Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

78f41805

Move GetUniform size validation to top layer. · 99a1e985

authored Aug 25, 2014

BUG=angle:571

Change-Id: Ie7064cf85f6a125ccd6cdf1bff89443520e2a06d
Reviewed-on: https://chromium-review.googlesource.com/212932Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

99a1e985

Use shared compile helpers in the ANGLE tests. · 5599c8f6

authored Aug 26, 2014

BUG=angle:730

Change-Id: Ib3bd646c73355449105e6cf79bdcf0a14b391fd2
Reviewed-on: https://chromium-review.googlesource.com/213550Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5599c8f6

Add some shared utility methods to the utils project. · 5704d6e8

authored Aug 26, 2014

BUG=angle:730

Change-Id: I268c7f76ee9a14ab82f646ae8ebf4eed100bf86d
Reviewed-on: https://chromium-review.googlesource.com/213509Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5704d6e8

Use EGLWindow in ANGLETests. · 62af5467

authored Aug 26, 2014

This completes the refactor to use the same code for EGL and OS
Window creation for samples and tests.

BUG=angle:730
TEST=angle_tests

Change-Id: Ib6de89f5bf83c0730a66f662cd1f87351f36a5f7
Reviewed-on: https://chromium-review.googlesource.com/213297Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

62af5467

Move GetUniform validation to the validation layer. · 0063c517

authored Aug 25, 2014

BUG=angle:571

Change-Id: Id1b7afb22d8bd52dbf7f95f4e8cac3fc8f798596
Reviewed-on: https://chromium-review.googlesource.com/212931Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

0063c517

Fixes a compilation error when ANGLE_DEFAULT_D3D11 is defined. · 10f05630

authored Aug 25, 2014

Change-Id: I09853b4565d5458ce4c318611a6495ec265fa8de
Reviewed-on: https://chromium-review.googlesource.com/213899Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

10f05630

26 Aug, 2014 12 commits

Allow app to specify EGL Window extra parameters. · 3757a5ae

authored Aug 26, 2014

Extra parameters include pixel bit sizes, swap interval
and if we want multisampling. This gives parity between
the tests and samples EGL creation options.

BUG=angle:730

Change-Id: I68d619c2ea141794f0089456bb6bba3d3b1c2a07
Reviewed-on: https://chromium-review.googlesource.com/213296Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3757a5ae

Use OSWindow with angle_tests for Window management. · 8add0eb7

authored Aug 26, 2014

BUG=angle:730

Change-Id: I409fd4f4e00eb0d8d964b0ac199fa6f675a36df8
Reviewed-on: https://chromium-review.googlesource.com/213295Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>

8add0eb7

Fix interface block static use tracking. · b547ddf5

authored Aug 25, 2014

The current code couldn't handle some uses of interface blocks,
such as blocks with instance names.

BUG=angle:466

Change-Id: I0a3746f277af0538cede30232532c6788412da1c
Reviewed-on: https://chromium-review.googlesource.com/213502Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

b547ddf5

Refactor ShaderVariables to store fields in the base. · 42bcf32e

authored Aug 25, 2014

Instead of only storing structure information in Varyings, Uniforms
and Interface Block Fields, store it in the base class. Also only
store base variable information for struct fields, instead of fully
typed information. This works because stuff like interpolation type,
invariance, and other properties are for the entire variable, not
individual fields.

Also add new fields for interface block instance name, varying
invariance and structure name for all struct types.

BUG=angle:466

Change-Id: If03fc071e6becb7aad6dea5093989bba7daee69e
Reviewed-on: https://chromium-review.googlesource.com/213501Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

42bcf32e

Reduce CPU texture usage in D3D11 where possible · 6982260b

authored Aug 12, 2014

Change-Id: I3186d78fa0a5c676611806c6f553c5c7ad06f56a
Reviewed-on: https://chromium-review.googlesource.com/212118Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

6982260b

Fix some MSVC warnings about possible truncation of int -> char. · 71117e2c

authored Aug 25, 2014

BUG=81439
TEST=none

Change-Id: Iedf02bf374e4992fc4c8ee050eff76f4f05708ac
Reviewed-on: https://chromium-review.googlesource.com/214065Reviewed-by: Kenneth Russell <kbr@chromium.org>
Tested-by: Peter Kasting <pkasting@chromium.org>

71117e2c

Refactored TransformFeedback for multi-platform ANGLE and added tests. · db8ae16b

authored Aug 25, 2014

Added angle_implementation_unit_tests target designed for testing the
cross-platform code in libGLESv2, and libGLESv2_static target as a
dependency. The goal is to incorporate these tests into Chromium's
angle_unittests target on all platforms; however, more work is needed
to make libGLESv2's common code compile on non-Windows platforms, so
this is an intermediate step.

BUG=angle:719

Change-Id: Ifc44a779352294e857d6e913d9b997a60674c443
Reviewed-on: https://chromium-review.googlesource.com/214105Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Kenneth Russell <kbr@chromium.org>

db8ae16b

Move some methods of VertexDataManager to helper methods. · 6d113802

authored Aug 25, 2014

Refactoring patch only.

BUG=angle:571

Change-Id: Ic318b4c4366e33b8d33f6003dd39f660f40d354a
Reviewed-on: https://chromium-review.googlesource.com/210649Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

6d113802

Move validation from IndexDataManager to the API. · ae3000b4

authored Aug 25, 2014

This validates all necessary buffer sizes for element array
buffers in the validation layer, before we start the draw.

BUG=angle:571

Change-Id: I602744ca1ea493e9f0f7e1ccbeb85fc4ae5c9f5a
Reviewed-on: https://chromium-review.googlesource.com/210648Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ae3000b4

Add OSWindow::setVisible. · 83da0ec5

authored Aug 22, 2014

BUG=angle:730

Change-Id: I9c9e2f3b694ba57df359906cd8517ede60af632d
Reviewed-on: https://chromium-review.googlesource.com/213294Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

83da0ec5

Add a Resize method to OSWindow. · 25f0e5e3

authored Aug 22, 2014

BUG=angle:730

Change-Id: I64106f05eb4188305eb34bbabe7d1cde037e1948
Reviewed-on: https://chromium-review.googlesource.com/213293Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

25f0e5e3

Extract validation from VertexDataManager.cpp to the API. · 2b97681b

authored Aug 25, 2014

We can check for buffer overflow at draw validation time, before
processing any vertex data.

BUG=angle:571

Change-Id: I4f49629b98c17ca28e25baed74cad4ae5341b20f
Reviewed-on: https://chromium-review.googlesource.com/210647Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

2b97681b

25 Aug, 2014 13 commits

Hard-limit the number of uniform vectors in D3D11. · 1fecbc85

authored Aug 25, 2014

Before the Caps were added, the maximum fragment and vertex shader uniform
vectors were hard-limited to 1024. When increasing them to the D3D11
maximums, the WebGL test uniforms/gl-uniform-arrays would time out.
Reverting the limit until the test can succeed with higher limits.

BUG=407309

Change-Id: Ifb7015bdeb3d32d7dcd124cfedbea5f7e2c25a5e
Reviewed-on: https://chromium-review.googlesource.com/213824Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

1fecbc85

Add a new invariant declaration operator. · 3b5c2dae

authored Aug 19, 2014

BUG=angle:711

Change-Id: I54a48b636a68c317b8d44ee2d578847b80095289
Reviewed-on: https://chromium-review.googlesource.com/213500Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3b5c2dae

Clean up copyimage.h · 268b6bcd

authored Jul 09, 2014

Change-Id: Ie4b81bb37dbbe6a9584dfc6a6c92670a9b73cda5
Reviewed-on: https://chromium-review.googlesource.com/207374Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

268b6bcd

Adds a required EGL_BAD_MATCH case to eglMakeCurrent · 70d457d8

authored Aug 15, 2014

BUG=angle:723

Change-Id: I12bb763acc70cb0737adf460226242023357b368
Reviewed-on: https://chromium-review.googlesource.com/212701Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

70d457d8

Optimize dynamic buffers. · 3e3813f7

authored Aug 25, 2014

In D3D11, we would previously always use a staging buffer to proxy
data to the GPU. This change allows users which specify DYNAMIC_DRAW
to skip the staging buffer as long as they only write to index or
vertex buffers.

This improves performance on all tested GPU vendors, but in D3D11
on AMD and Intel our SubData calls are still significantly slower
than in D3D9.

BUG=angle:705
BUG=365078

Change-Id: I4f83164176d67ff00119bdd0a6a80d7c84fd0f03
Reviewed-on: https://chromium-review.googlesource.com/213813Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

3e3813f7

Add BufferStorage11::setData. · dbd74a09

authored Aug 25, 2014

This helper method will be useful for implementing dynamic buffers.

BUG=angle:705

Change-Id: I8461a59724fb8866b36059c9ef5b838f072cc63a
Reviewed-on: https://chromium-review.googlesource.com/213812Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

dbd74a09

Clean up copyvertex.h · 45965b10

authored Jul 09, 2014

 * Move "private" functions into copyvertex.inl.
 * Capitalize global function names give them more descriptive names.
 * Use size_t for all dimensions.
 * Use uint8_t pointers instead of unsigned char pointers.

Change-Id: I408cf7ebb28655c5811ad18979a20f4273d278cd
Reviewed-on: https://chromium-review.googlesource.com/207373Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

45965b10

Add caps for vertex and fragment shader limits from tables 6.31 and 6.32. · 301d161d

authored Jul 09, 2014

BUG=angle:658

Change-Id: I98509aa16caf74c3e4e28852e8b59aedd903f03a
Reviewed-on: https://chromium-review.googlesource.com/207372Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

301d161d

Add caps from the 6.29 table. · 900013cd

authored Jul 07, 2014

BUG=angle:658

Change-Id: I392f581b1aea445d60f507c1fa897c4348c1a137
Reviewed-on: https://chromium-review.googlesource.com/207371Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

900013cd

Fix compilation error due to bad merge. · 0f796ace

authored Aug 25, 2014

Change-Id: I54b3e0423e41b86b28d93fdce8d4d2d3304d56cf
Reviewed-on: https://chromium-review.googlesource.com/213822Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0f796ace

Added check to avoid accessing possible NULL renderer pointer. · 40f93a24

authored Aug 06, 2014

Change-Id: I38524e7d3c74656902151e004d3aa47555531fd5
Reviewed-on: https://chromium-review.googlesource.com/211203Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

40f93a24

Fixed memory leak in Renderbuffer class. Offscreen objects backbuffer texture… · 75c42f45

authored Aug 11, 2014

Fixed memory leak in Renderbuffer class. Offscreen objects backbuffer texture /shader resource view, depth stencil texture/shader resource views were leaking during swapchain resize operations.

Change-Id: Iee83a14d043eecc465e6ffb8e21a6449def38e9b
Reviewed-on: https://chromium-review.googlesource.com/211834Reviewed-by: Shannon Woods <shannonwoods@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

75c42f45

Create an Error object to represent GL errors. · da5777cf

authored Jul 11, 2014

BUG=angle:520

Change-Id: I1a54e6f308b5b0f310c725a7771af737a77ecd42
Reviewed-on: https://chromium-review.googlesource.com/209619Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

da5777cf

22 Aug, 2014 2 commits

Move the index range cache to gl::Buffer. · ef9d63ec

authored Aug 04, 2014

Because we want to move all validation to the API layer, we need to
move the index validation to the API layer. This means exposing the
index cache to the validation layer.

In the future we will probably want a way to skip index validation
when it's not necessary, or the chosen back-end handles index
validation on its own.

BUG=angle:571

Change-Id: Iee1618e669bc28abf7e0709ca4a03b4727b1383e
Reviewed-on: https://chromium-review.googlesource.com/210646Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ef9d63ec

Fix std140 UBO layouts. · 33a74bde

authored Aug 18, 2014

A call to "prePadding" instaed of "prePaddingString" was confusing
the HLSL output engine.

A separate bug was causing HLSL errors because HLSL puts all cbuffer
members in a flattened namespace, which caused our internal padding
variables to overlap.

BUG=angle:725

Change-Id: I69a01fefa430a83e433385c64a532a69e6851ae8
Reviewed-on: https://chromium-review.googlesource.com/212930Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

33a74bde