Commits · eef221310f5e49009bda43ce340db66e31768598 · Chen Yisong / angle

06 Dec, 2019 2 commits

Roll third_party/SwiftShader bbd0694f9ab2..b9f03f47d5f5 (18 commits) · eef22131

authored Dec 06, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/bbd0694f9ab2..b9f03f47d5f5

git log bbd0694f9ab2..b9f03f47d5f5 --date=short --first-parent --format='%ad %ae %s'
2019-12-05 digit@google.com [vulkan] Add VK_SUBGROUP_FEATURE_ARITHMETIC_BIT support
2019-12-05 bclayton@google.com Vulkan: Optimize shaderClipDistance and shaderCullDistance
2019-12-05 bclayton@google.com Vulkan: Implement shaderClipDistance and shaderCullDistance
2019-12-05 paulthomson@google.com Regres: support GCOV_PREFIX for collecting coverage
2019-12-05 chrisforbes@google.com Regres: update testlists for recent deqp roll
2019-12-05 chrisforbes@google.com Regres: Adjust exit code handling
2019-12-05 digit@google.com [vulkan] Clarify configuration macros for external memory and semaphores.
2019-12-05 amaiorano@google.com ReactorUnitTests: add unit tests for intrinsics
2019-12-05 amaiorano@google.com SubzeroReactor: implement most missing intrinsics
2019-12-05 amaiorano@google.com SubzeroReactor: add stubbed coroutine support
2019-12-05 amaiorano@google.com Subzero: fix assert for sqrt of vector float types
2019-12-05 amaiorano@google.com Subzero: hack fix for assert(Dest->hasReg())
2019-12-05 amaiorano@google.com SubzeroReactor: fix assertion !isVectorType(Ty)
2019-12-05 amaiorano@google.com Subzero: fix assert when dumping unnamed constant
2019-12-05 chrisforbes@google.com Regres: roll deqp forward to current tip of 1.1.6
2019-12-04 sugoi@google.com Enable the fullDrawIndexUint32 feature
2019-12-04 swiftshader.regress@gmail.com Regres: Update test lists @ bbd0694f
2019-12-04 bclayton@google.com VulkanUnitTests: Fix bad comment on assembly.

Created with:
gclient setdep -r third_party/SwiftShader@b9f03f47d5f5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I720c9e121605054c30570ccfe8f83678d4b1262b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955230Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

eef22131

Roll third_party/vulkan-validation-layers/src e72b61c7c20d..a3ee4384fb57 (2 commits) · b2c2d667

authored Dec 06, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/e72b61c7c20d..a3ee4384fb57

git log e72b61c7c20d..a3ee4384fb57 --date=short --first-parent --format='%ad %ae %s'
2019-12-05 mark@lunarg.com tests: Add tests for CmdFillBuffer offset and size
2019-12-05 mark@lunarg.com corechecks: Add offset/size checks for CmdFillBuffer

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@a3ee4384fb57

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I175ccbba8eaf3d5c79b397422c7c32d64de8ef3f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1955231Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b2c2d667

05 Dec, 2019 9 commits

Linux AMD crash when src blit region outside framebuffer · 11e6944e

authored Dec 05, 2019

Linux AMD has a crash on an assert in the mesa driver that the source rectangle
for blitFramebuffer be inside the framebuffer. Add Linux AMD to the existing
workaround for this case.
Note: this will duplicate some work on Linux AMD if the blit call is outside
the framebuffer and also very large (the adjustSrcDstRegionBlitFramebuffer
workaround)

Bug: 1014370
Change-Id: I1afd1c92ab07dba6814d6b87ff7c3c19a19bdc0e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953487
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

11e6944e

Vulkan: Implement multisample textures · 4576f1d0

authored Dec 05, 2019

This functionality is exercised by running angle_deqp_gles31_tests with the
following sets of command arguments:

  --gtest_filter=dEQP.GLES31/functional_texture_multisample* --use-angle=vulkan

  --gtest_filter=dEQP.GLES31/functional_state_query_texture_level_texture_2d_multisample* --use-angle=vulkan

  --gtest_filter=dEQP.GLES31/functional_state_query_texture_texture_2d_multisample_texture_immutable* --use-angle=vulkan

The following are some high-level design notes:

- Texture::setStorageMultisample() handles converting the "requested number of
  samples" to the actual number of samples used (e.g. converting 3 to 4),
  supported by the underlying back-end).  The actual number used is stored in
  gl::TextureState::mImageDescs, for use by other GLES commands.

- ANGLE uses the Vulkan standard sample locations/positions.  If the underlying
  Vulkan driver's VkPhysicalDeviceLimits::standardSampleLocations is false,
  ANGLE limits itself to GLES 2.0 (i.e. before GLES 3.0 which adds multisample
  renderbuffers).

- The Vulkan specification currently doesn't support ANGLE providing support
  for GLES 1-sample textures, because of the following Vulkan specification
  statement:

  - If the image was created with VkImageCreateInfo::samples equal to
    VK_SAMPLE_COUNT_1_BIT, the instruction must: have MS = 0.

- At least one Vulkan driver returns different
  VkPhysicalDeviceLimits::*SampleCounts for different formats.  Because of
  this, ANGLE does a logical-AND of all values in order to only support the
  commonly-available numbers of samples.

The detailed design document is located at:
https://docs.google.com/document/d/1NiM8gAR74iGGXGTE6IP1ChdDUZjhtXRuJdtEp_wGFEM/edit?usp=sharing

Bug: angleproject:3565
Bug: angleproject:4103
Bug: angleproject:4104
Bug: angleproject:4196
Bug: angleproject:4197
Bug: angleproject:4198
Change-Id: I28921badf9568427799b0af347198b5df06c2db0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1919982
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>

4576f1d0

Fix image/sampler uniform range in presence of atomic counters · d68bf3e2

authored Dec 04, 2019

The change that introduced images to the front-end placed them at the
end of the uniforms list, so the loop that was calculating the image
range was starting from the end of that list.

The change that introduced atomic counters to the front-end placed them
at the end of the uniforms list too, but the image range loop was not
adjusted to take this fact into account (neither was the sampler range
loop for that matter).

If a shader used both images and atomic counter buffers, the image range
was calculated as empty.  Similar issues would arise if the shader used
both samplers and atomic counters.

A test is added where a shader has a default uniform, a UBO, an SSBO, an
image and an atomic counter, to make sure any combination of these
resources doesn't result in a bug.

Bug: angleproject:4190
Change-Id: I7818ee5258dd964215a18acfd7c3d6515b61c595
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950655
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

d68bf3e2

Fix compute shared memory size validation · 6e532b8c

authored Dec 05, 2019

When a struct was involved, the required size for each field was added
up, but also multiplied by its array size. However, when calculating
the field size, the array size was already multipled in.

This resulted in the calculated size to be larger than it actually is,
resulting in failures in KHR-GLES31.core.compute_shader.shared-max.

Bug: angleproject:4173
Change-Id: I900c17fa65decdeb20c3651c3342295fed2f7c61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1953483Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

6e532b8c

Vulkan: EXT_gpu_shader5 support: precise · 795a3559

authored Dec 03, 2019

The precise keyword is used in tessellation shaders but introduced in
this extension.

EXT_gpu_shader5 introduces a handful of features to shaders.  This
change only implements the `precise` keyword.

Bug: angleproject:3569
Change-Id: I2252b79098eb8ba2d2faa040d7eaed7548b7051e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1939851
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

795a3559

Re-land "Add new test runner harness." · e20560fa

authored Dec 04, 2019

Re-land changes:

 * Unit test is suppressed in ASAN
 * --deqp-case is fixed
 * Debug layer errors should correctly work with failure expectations

Original message:

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Change-Id: I841f2b5dfe51f7f44dac68324bdf6afd418b8bfb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948240Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e20560fa

Fix tests checking for major version > 3 · af52f9c6

authored Dec 03, 2019

The tests meant to do getClientMajorVersion() >= 3, but in a few
locations accidentally did > 3.

Bug: angleproject:3569
Change-Id: Ie69898348982c6aae7dac265a18229c257dbfbda
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947458Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

af52f9c6

Roll third_party/glslang/src e58c080d4f02..0de87ee9a5bf (1 commits) · 362168eb

authored Dec 05, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/e58c080d4f02..0de87ee9a5bf


Created with:
  gclient setdep -r third_party/glslang/src@0de87ee9a5bf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I8ff675710626a7197a71abb386b2b4013f27c30f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1952391Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

362168eb

Improve current multisampled renderbuffer/texture support · 5f857839

authored Dec 04, 2019

This is split off from a change to implement multisampled textures for
the Vulkan back-end, and will come before that change.  The changes
include:

- Make a common utility rx::GetSamplePosition() function.  D3D11 and
  Vulkan use the same standard sample positions/locations for 1, 2, 4,
  8, and 16 samples.  The D3D11 back-end has a utility function for
  this, which is being moved to a common location--for use by both the
  D3D11 and Vulkan back-ends.

- Texture::setStorageMultisample() handles converting the "requested number of
  samples" to the actual number of samples used (e.g. converting 3 to 4),
  supported by the underlying back-end).  The actual number used is stored in
  gl::TextureState::mImageDescs, for use by other GLES commands.

- Change some end2end tests to not make assumptions about the supported number
  of samples, but to properly query what is supported.

Bug: angleproject:3565
Bug: angleproject:4196
Change-Id: I1dc12fedd0f8fb4975f90d87486e443b069b7141
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948535
Commit-Queue: Ian Elliott <ianelliott@google.com>
Reviewed-by: Ian Elliott <ianelliott@google.com>

5f857839

04 Dec, 2019 13 commits

Remove build_apk_secondary_abi from gn files · 2719fa44

authored Dec 04, 2019

This flag is always true now and is being removed from GN.

Bug: angleproject:4026
Bug: angleproject:2344
Change-Id: I7e90d95a41cd4a9e054e3e102578db3323e999e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1951525Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

2719fa44

gn: Minor improvements. · e3c25715

authored Dec 03, 2019

Renaming "all" targets to reduce duplication. Also add libGLESv1_CM to
"angle". And remove "shader_translator" since we already had
"angle_shader_translator".

An attempt to work around "invalid COFF sections" error that is popping
up on the MSVC try bots.

Bug: None
Change-Id: I105aa5e59f67173643a3a2071b2aff345b5a6135
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947457Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

e3c25715

Vulkan: Optimize unused uniform cleanup in glslang wrapper · fab10c23

authored Dec 04, 2019

Bug: angleproject:3803
Change-Id: Ib260c86c68e5b11deaec8658cd9768af9b44e086
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1949629
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

fab10c23

Re-enable atomic counter tests on !windows · c3f0352d

authored Dec 04, 2019

There is a bug that prevents us from running these tests on the windows
bots.  This change enables them on other platforms so we don't lose
coverage.

Bug: angleproject:3738
Change-Id: I9b546c3223499af88b347f8a01be8edb245c19a7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950654
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

c3f0352d

Vulkan: Fold read access into write flags on buffer writes · 61c6aecc

authored Nov 28, 2019

This could lead to a subtle bug:

Say we use a buffer as a storage buffer and write to it. We then must
issue a memory barrier before using it as a uniform buffer. However we
would set the SHADER_READ bit as a read mask on a storage buffer
access. This seems like it could lead to a missing barrier.

Bug: angleproject:4178
Change-Id: I486002739b7fb000ffacc0a1e996784b7875e7ba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943034
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>

61c6aecc

Turn on fboRenderMipmap for D3D11 · a654d351

authored Dec 02, 2019

Bug: 1023747
Change-Id: I8ca320432aad663e2a6d70f494692df518376258
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947710Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Shrek Shao <shrekshao@google.com>

a654d351

Split out core.compute_shader expectations · b40c65ce

authored Dec 03, 2019

The failures have been triaged and split into more specific bugs.

Bug: angleproject:3601
Change-Id: Icb262a047bba78a11d710e479ad659a9fa1caf1a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948524
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>

b40c65ce

Add Compute Shared Memory Size Validation · 33a00efd

authored Nov 27, 2019

Add tracking of shared memory declarations in compute shaders.

Test:
  angle_deqp_gles31_tests --gtest_filter=dEQP.GLES31/functional_debug_negative_coverage_callbacks_compute_exceed_shared_memory_size_limit

Bug: 4173
Change-Id: If2a86d467a82f73fa5b2ee0ced752701acfe1872
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934653
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

33a00efd

Expose GL_ARB_sync for GL · 5f3456e3

authored Dec 03, 2019

BUG=chromium:1028799
R=jonahr
CC=vasilyt

Change-Id: Id17c4061b206953b1e904bf7938cb371612e33fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1948534Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>

5f3456e3

Roll third_party/vulkan-validation-layers/src 4fde9b750992..e72b61c7c20d (1 commits) · 006a1554

authored Dec 04, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-ValidationLayers.git/+log/4fde9b750992..e72b61c7c20d

git log 4fde9b750992..e72b61c7c20d --date=short --first-parent --format='%ad %ae %s'
2019-12-03 dadschoorse@gmail.com include cassert in vk_extension_helper.h

Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@e72b61c7c20d

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I647c43e868f17775548545671e283830559b3aba
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950027Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

006a1554

Roll third_party/SwiftShader b64fbfec4dcd..bbd0694f9ab2 (3 commits) · 154167f2

authored Dec 04, 2019

https://swiftshader.googlesource.com/SwiftShader.git/+log/b64fbfec4dcd..bbd0694f9ab2

git log b64fbfec4dcd..bbd0694f9ab2 --date=short --first-parent --format='%ad %ae %s'
2019-12-03 chrisforbes@google.com Remove Common/Types.hpp include from SpirvShader
2019-12-03 chrisforbes@google.com Regres: Add pending deqp change to fix bad graphicsfuzz tests
2019-12-03 srisser@google.com Make Vk::Stringify return std::string

Created with:
gclient setdep -r third_party/SwiftShader@bbd0694f9ab2

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ia5795718520bc2de13a5331fb3471f5d16ba5dbe
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950025Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

154167f2

Roll third_party/spirv-tools/src 3ed4586044f2..e82a428605f6 (3 commits) · 089c4716

authored Dec 04, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3ed4586044f2..e82a428605f6


Created with:
  gclient setdep -r third_party/spirv-tools/src@e82a428605f6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I84921c632e3a8f55a5c2e16d03984f5119d7ac15
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950024Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

089c4716

Roll third_party/glslang/src a4af7676feb0..e58c080d4f02 (1 commits) · b939b4a7

authored Dec 04, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/a4af7676feb0..e58c080d4f02


Created with:
  gclient setdep -r third_party/glslang/src@e58c080d4f02

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Ia950c8adef32a30ee53f05e3c9e01d8576f62f8e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1950026Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b939b4a7

03 Dec, 2019 15 commits

Translator: Rename TIntermInvariantDeclaration to ..GlobalQualifier.. · 249cb200

authored Dec 03, 2019

This is to support the upcoming `precise` keyword.

Bug: angleproject:3569
Change-Id: Idbcc8fd6f261757dbbf81b381e7a2dae938d8101
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947451Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

249cb200

glslang.l: refactor extension checks · a5045ac3

authored Dec 03, 2019

Bug: angleproject:3569
Change-Id: I7cbbaa4d1cdd4dd4268f28e06c907958cff9b4e8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947450
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

a5045ac3

Automatically call flex/bison if necessary · 5efb36b9

authored Nov 25, 2019

ANGLE translator's parser code generation is changed to use the binaries
of flex/bison stored in the cloud. scripts/run_code_generation.py now
automatically runs these files if the input files change.

Bug: angleproject:3419
Change-Id: Icce4247f93b27baf8ee12dbb16112fa2cc98c111
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1940572Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

5efb36b9

Vulkan: Fix WaW same-layout image transitions · 62a93045

authored Dec 02, 2019

These transitions were incorrectly handled by an execution barrier
alone, but that's not per spec.  Write-after-write hazards always need a
memory barrier.

Bug: angleproject:3347
Bug: angleproject:3554
Change-Id: Id2d2579888e0b59e589fcdd52416363f2cf5cf97
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943546Reviewed-by: Tobin Ehlis <tobine@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>

62a93045

Revert "Add new test runner harness." · 8f31872c

authored Dec 03, 2019

This reverts commit fb40d231.

Reason for revert: Has a bug with the ASan build and also has a few
bugs with ANGLE standalone test expectations an filter.

Bug: chromium:1030192
Bug: angleproject:4193

Original change's description:
> Add new test runner harness.
> 
> The ANGLE test harness is a harness around GoogleTest that provides
> functionality similar to the Chromium test harness. It supports:
> 
>  * splitting a test set into shards
>  * catching and reporting crashes and timeouts
>  * outputting to the Chromium JSON test results format
>  * multi-process execution
> 
> Unit tests are added in test_utils_unittest.cpp.
> 
> Bug: angleproject:3162
> Change-Id: Idb15f113de8eb32db12bc93542de93b08d7c1447
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1478016
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

TBR=ynovikov@chromium.org,jonahr@google.com,jmadill@chromium.org

Change-Id: I647e747571784b1ca7c1d0687193c70a63eb08d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:3162
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947456Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

8f31872c

D3D9: Log the exact error code generated by D3D9 device creation. · f0f46772

authored Dec 03, 2019

BUG=1029091

Change-Id: I552627dd18d0d5b48c02bff12c9368c724a65f54
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947448Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

f0f46772

Skip flaky BlendMinMaxTest.RGBA16F/ES2_Metal. · ff83dabf

authored Dec 03, 2019

BUG=angleproject:4185

Change-Id: I236d4372ab22e9083d00cf13fa2ad682a1d42f14
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947447Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

ff83dabf

Link to the autoroller configuration directory in the wrangling doc. · fc2dd450

authored Dec 03, 2019

BUG=angleproject:1944

Change-Id: I3f6e50fbc93948416c32070418a4f24a51a3c1bd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947452Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

fc2dd450

Remove an unused .gn file. · 98e8be88

authored Dec 03, 2019

The almost identical one in third_party/vulkan-loader/src/BUILD.gn
is used instead, and this one is unused.

Bug: None
Change-Id: I9d1acfdec019fb4bc74ed4869014edbf9fd64ca5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947449
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

98e8be88

Fix UWP build · 7e753cb7

authored Dec 03, 2019

Bug: angleproject:4186
Change-Id: I4fcfe2553f209e191d88058fe30d31c88a61f69f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947446Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

7e753cb7

GL: Make GL_EXT_texture_format_BGRA8888 enableable. · e4ac2ff3

authored Nov 28, 2019

Disable returning BGRA as an implementation read format unless
GL_EXT_texture_format_BGRA8888 is exposed.  WebGL doesn't support this extension
and returning BGRA as an implementation read format is invalid.

TEST=functional/gles3/negativebufferapi.html
TEST=functional/gles3/integerstatequery.html

BUG=angleproject:4179

Change-Id: I313721f09da0e455128b88b129bd34338d47af73
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1943407Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

e4ac2ff3

Use SwiftShader-based ICD generation. · c4faeb79

authored Nov 25, 2019

We moved this into the SwiftShader repo proper in:
https://swiftshader-review.googlesource.com/c/SwiftShader/+/38491

We can remove ANGLE's custom rules. Also removes the layer generation
script which was now unused. Also cleans up the Vulkan back-end
BUILD.gn a bit.

Bug: dawn:283
Change-Id: I490e8e8fc6fcadec58aca53a157ce7c4a47def3c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1932340Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

c4faeb79

Roll third_party/glslang/src 83af46951202..a4af7676feb0 (1 commits) · 38e5a8de

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/83af46951202..a4af7676feb0


Created with:
  gclient setdep -r third_party/glslang/src@a4af7676feb0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/glslang-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: Iae5df5c516d75f2aa8aa1a738b627027a8a07f19
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947722Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

38e5a8de

Roll third_party/vulkan-tools/src 979b531e9fff..0a0625a3dca6 (1 commits) · b00fe93c

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools.git/+log/979b531e9fff..0a0625a3dca6

git log 979b531e9fff..0a0625a3dca6 --date=short --first-parent --format='%ad %ae %s'
2019-12-02 bill.hollings@brenwill.com vkcube: Replace MoltenVK surfaces with Metal

Created with:
gclient setdep -r third_party/vulkan-tools/src@0a0625a3dca6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I6fef339859da970f0416ce0d8f6f874d3af8ac98
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947720Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

b00fe93c

Roll third_party/spirv-tools/src 47f3eb42641b..3ed4586044f2 (1 commits) · 32c57b79

authored Dec 03, 2019

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/47f3eb42641b..3ed4586044f2


Created with:
  gclient setdep -r third_party/spirv-tools/src@3ed4586044f2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: geofflang@google.com
Change-Id: I43e63689ab019e69440bac9c2a92fffa7b87a838
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1947721Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>

32c57b79

02 Dec, 2019 1 commit

Add new test runner harness. · fb40d231

authored Dec 02, 2019

The ANGLE test harness is a harness around GoogleTest that provides
functionality similar to the Chromium test harness. It supports:

 * splitting a test set into shards
 * catching and reporting crashes and timeouts
 * outputting to the Chromium JSON test results format
 * multi-process execution

Unit tests are added in test_utils_unittest.cpp.

Bug: angleproject:3162
Change-Id: Idb15f113de8eb32db12bc93542de93b08d7c1447
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1478016
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>

fb40d231