Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1415754

BUG=angleproject:2368

Change-Id: Ic2c71b36e7b08560e158fd3dbf10b2fe225f1364
Reviewed-on: https://chromium-review.googlesource.com/935148
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2383

Change-Id: If22c7f7c15b7bbe89b859281b28c2b9695e34a1d
Reviewed-on: https://chromium-review.googlesource.com/945415Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

There was a mistake in one of the texture offset function names being
checked. Fix it and add a test making sure that a similar mistake
cannot slip in again.

BUG=angleproject:2387
TEST=angle_unittests

Change-Id: I2dddfbdc2836f9e7e94ca6573a8f3689eecf7eb2
Reviewed-on: https://chromium-review.googlesource.com/946254Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

These functions have the same name in the ESSL 100 extension, creating
a possibility for conflicts. This adds a convenient way to test for
regressions when refactoring the symbol table.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I9716524a0ea85064ba5f3ee8e7adfbdfc59d257e
Reviewed-on: https://chromium-review.googlesource.com/945989Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

TSymbolTable API can be cleaned up further now that we have separate
logic for inserting builtins and user-defined symbols.

BUG=angleprojec:2267
TEST=angle_unittests

Change-Id: I7a228891ecdf4696e50868b9e7dfc2a50b5d8e92
Reviewed-on: https://chromium-review.googlesource.com/941301
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:2341,angleproject:2382

Change-Id: I5bcc0938e2d86165022cc80afda6b11c801ef5ed
Reviewed-on: https://chromium-review.googlesource.com/944711Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>

This will reduce binary size by a few kilobytes once we store mangled
names of functions as constexpr strings.

This still keeps mangled names human readable.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ia63980bd511c701a93e2c5e247d24578c7d7f332
Reviewed-on: https://chromium-review.googlesource.com/943101
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Would not compile locally on Linux without adding #include <algorithm>.

BUG=none

Change-Id: I2f817faf681234c0e7eeeda0ad837e8285d9071a
Reviewed-on: https://chromium-review.googlesource.com/941613
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Luc Ferron <lucferron@chromium.org>

These types were over-generalized. All use cases featured
arrays of resources attached to single parent resources. The
channel ID is sufficient to identify the child resource in the
parent, and having variadic template arguments wasn't necessary.

Futhermore we can rename these types to use the common Observer
pattern. This should make them more readable to new developers.

Also update some classes to inherit from Subject instead of
having a member Subject. This cleans up the code in a few places.

This should lead to a simpler refactor to allow dependent dirty
bits notifications in the Vulkan back-end.

In the following patch the signal_utils files will be renamed. They
are not renamed in this patch to ensure git history is preserved.

Bug: angleproject:2372
Change-Id: I17a3f2c8d92afd4bb3cba2d378c3a2e8a6d7fb11
Reviewed-on: https://chromium-review.googlesource.com/936690Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2376
TEST=dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.invalidate_sub_framebuffer

Change-Id: Ie1ca30f29d7583c86130f46d4e6b5c7211eee63a
Reviewed-on: https://chromium-review.googlesource.com/938367Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

It was passing the attribute size, not the stride, so it worked only
when they were the same.
Enable corresponding tests.

BUG=angleproject:2310

Change-Id: Ie3ab13567c16c302aa9aeda5d059e5fd4eb92b4e
Reviewed-on: https://chromium-review.googlesource.com/875304
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Enable more parts of AttributeLayoutTest because:
- partial Vulkan support for vertex data in client memory has landed
- we can work around bugs which prevented some parts from working
- we have more fine-grained control over which parts to run

Avoid glBufferSubData to work around ANGLE bug 2374.

Let subclasses decide about skipping test cases.  For example on Vulkan
indexed draw with vertex data in client memory is not supported yet.

BUG=angleproject:1683

Change-Id: Id073334299bd1a642b2518ccb3c47ebd8ff010d9
Reviewed-on: https://chromium-review.googlesource.com/933943Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

Line loops aren't supported in Vulkan directly, so we use line strips with
an indexed buffer to emulate them. To hide the complexity of that, I've created
the LineLoopHandler class in vk_utils.

Bug: angleproject:2335

Change-Id: Id3e020d27e5265565e61e96d3fd0187c4fe2b152
Reviewed-on: https://chromium-review.googlesource.com/931421
Commit-Queue: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

BUG=angleproject:1729
TEST=dEQP-GLES31.functional.state_query.indexed.atomic_counter_buffer_binding_getbooleani_v

Change-Id: I3f6975ecc0e69f487f66ff65d613307fcaa6eb08
Reviewed-on: https://chromium-review.googlesource.com/939106Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

When the mask is zero, no buffers are copied in BlitFramebuffer. But we still
need to check all the error situations. So mask of zero should be put in
blitFramebuffer not the validation file.

Meanwhile, we adjust the checking sequence to pass the deqp case.

BUG=angleproject:2375
TEST=dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.blit_framebuffer

Change-Id: I73c78ffb8853153f70fc30e8ae0e704e08e454ac
Reviewed-on: https://chromium-review.googlesource.com/938573Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

We were using a src offset instead of a dest offset. The staging
buffer should always start at the zero offset, while the dest
buffer (the real buffer) should use the offset argument to
Buffer*Data.

Bug: angleproject:2374
Change-Id: I9ee702709d9c15945935f4eae25f308b71e0d1e8
Reviewed-on: https://chromium-review.googlesource.com/937022
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>

This patch adds the link validation on geometry shader varyings.

According to SPEC, geometry shader inputs should not be treated
as arrays for the purpose of interface matching.

This patch also moves the checks on fragment input bindings into
a single function.

BUG=angleproject:1941
TEST=angle_end2end_tests
     dEQP-GLES31.functional.shaders.linkage.es31.geometry.varying.*

Change-Id: Ib3ca64e28683e9688edc9432d43ff5a70c86117e
Reviewed-on: https://chromium-review.googlesource.com/929866Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1395107

BUG=angleproject:2370

Change-Id: Id0c0cecbe14c1c0a1b3de18b0ccf70d00af81a80
Reviewed-on: https://chromium-review.googlesource.com/935454Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This patch adds missing checks for querying GL_COMPUTE_WORK_GROUP_SIZE
by glGetProgramiv.

When querying GL_COMPUTE_WORK_GROUP_SIZE, an INVALID_OPERATION error
should be generated when this program hasn't been linked successfully
or it doesn't contain any objects to form a compute shader.

BUG=angleproject:2324
TEST=angle_end2end_tests
     dEQP-GLES31.functional.debug.negative_coverage.get_error.compute.invalid_program_query

Change-Id: I13dcebef8a0abede5c18a038d4cf915ee4164e2e
Reviewed-on: https://chromium-review.googlesource.com/933627
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

BUG=angleproject:2169

Change-Id: Ib3fb699058f76d0eb810a9691ea1d64311dadbb1
Reviewed-on: https://chromium-review.googlesource.com/929650
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2373

Change-Id: I5edd9db6ef6101b0ad75f71fdcdfbb1261100583
Reviewed-on: https://chromium-review.googlesource.com/936421Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Since the length of the hash is known prior to compilation, it can be
compared with script-generated hashes.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ia0a78dfd450c4ea2d526da7f3495b9750dcbd1af
Reviewed-on: https://chromium-review.googlesource.com/931884Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

TString was being used in some places where it was not really needed.
Clean these up.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: Ib7fd26f9c6b6b885433c840a9520393908f1f902
Reviewed-on: https://chromium-review.googlesource.com/887068Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

This is going to guard against regressions when symbol table init is
optimized.

TEST=angle_unittests
BUG=angleproject:2267

Change-Id: Iec7b9814f4af215dc0b3e8a39c8cfab004451836
Reviewed-on: https://chromium-review.googlesource.com/931883Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1415754

BUG=angleproject:2369

Change-Id: I99cae322eb70ea3920eb296fd590abccded6dab4
Reviewed-on: https://chromium-review.googlesource.com/935149Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This patch fixes a bug in function ConvertToGLint. This function
should convert ParamType into GLint instead of GLenum.

This patch can fix the bug that no errors are generated when trying
to set negative base level or max level by glTexParameteri because
ConvertToGLint always incorrectly converts a negative integer into
an unsigned integer in ValidateTexParameterBase.

BUG=angleproject:2371
TEST=angle_end2end_tests
     dEQP-GLES31.functional.debug.negative_coverage.get_error.texture.texparameter*
Change-Id: Id5baf3430ae574a083bcc40a7a8f7db1cb2d07ed
Reviewed-on: https://chromium-review.googlesource.com/933923Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jiajia Qin <jiajia.qin@intel.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1415754

BUG=angleproject:2367

Change-Id: I69a75c38c6811752df6da9c3cba5901c9d8ab8c4
Reviewed-on: https://chromium-review.googlesource.com/935281Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

BUG=angleproject:2366

Change-Id: Ic398da0b86caef577140808a87fcc2e74ed28dc0
Reviewed-on: https://chromium-review.googlesource.com/935144Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

INVALID_VALUE error should be generated not INVALID_OPERATION if indirect
is not a multiple of the size, in basic machine units, of uint.

Meanwhile, we put the validation of indirect before indirect buffer so that
the corresponding deqp cases can pass.

BUG=angleproject:2324

Change-Id: I223ec1893a6dd613f84e51a98f02d5f79482952f
Reviewed-on: https://chromium-review.googlesource.com/929900Reviewed-by: Jiawei Shao <jiawei.shao@intel.com>
Reviewed-by: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

This change will add memory qualifier checking for binaryNode in case the
memory qualifier information is lost.

BUG=angleproject:1951
TEST=angle_unittests

Change-Id: I3f0cfd7d8a059753cf3c982ee0a977b4b0fd0128
Reviewed-on: https://chromium-review.googlesource.com/929877
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

This patch adds the missing check on the shader version for compute
and geometry shaders, which can fix a bug that ANGLE GLSL compiler
doesn't report a compile error when compiling an empty compute or
geometry shader in version 100 or 300.

This patch also updates the original compiler tests on the check of
shader version. In these tests, the compile errors are all caused by
illegal layouts instead of shader versions, which is against the
purpose of the tests.

This patch also fixes an incorrect case that used an empty compute
shader in version 300.

BUG=angleproject:1442, angleproject:1941
TEST=angle_unittests

Change-Id: Ic26bb8eb312dbc0cec6a879997d0ae7a2e625a0f
Reviewed-on: https://chromium-review.googlesource.com/910715
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

Camel casing is removed from the enums where it differs from the GLSL
spec. This way it's easier to autogenerate code for built-in
functions mapped to operators.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I2490d5d0e8ffb45eba343f225f76779e63381a65
Reviewed-on: https://chromium-review.googlesource.com/929361Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>

An error will be generated either way if the extension symbols are
used incorrectly since each use of an extension function or variable
checks whether the extension is enabled.

We now also track extension in unmangled built-in names, so that
redefining built-ins of extensions that are not enabled can be
supported.

This includes refactoring the shader extension tests to share a common
helper class ShaderExtensionTest.

BUG=angleproject:2267
TEST=angle_unittests

Change-Id: I9cc5e9bd62fa07796e69256a6a9a493531a62446
Reviewed-on: https://chromium-review.googlesource.com/926526
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

BUG=809881

Change-Id: I69c58c93597aea5a5c25298908592ce1ab4a957b
Reviewed-on: https://chromium-review.googlesource.com/929984Reviewed-by: Luc Ferron <lucferron@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

Rendering with depth buffer disabled and stencil buffer enabled
leads to memory leak if we set viewport a large size on Intel
windows platforms. Add an end2end test case to catch this driver
bug.

TEST=DepthStencilFormatsTestES3.DrawWithLargeViewport/ES3_D3D11

BUG=782317

Change-Id: I16efb9459717e94e2edb5d5eb5dc24f47d746ea3
Reviewed-on: https://chromium-review.googlesource.com/858430
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

Test various ways of organizing attributes: in memory or buffer object,
sequential or interleaved.
Test different types of vertex data.
Test non-indexed draw, indices in buffer, indices in memory.
Test starting at vertex zero and higher.

BUG=angleproject:1683

Change-Id: I54a752679b31bbb3f573c922d59da69a18302daa
Reviewed-on: https://chromium-review.googlesource.com/898608
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

There was a map() without a corresponding unmap().
Add a test which does multiple indexed draws, triggering the problem.

BUG=angleproject:2310

Change-Id: Id33d66f24de2005ec3f9958d33ab4c2630b49dc5
Reviewed-on: https://chromium-review.googlesource.com/875318Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>

This should also fix the VS project generation. Thanks to Jeff Gilbert
from Mozilla for sharing a list of missing files.

Bug: angleproject:2360
Change-Id: Ideab28a0169cd7aabb6a7bd3aac3a5832443f023
Reviewed-on: https://chromium-review.googlesource.com/922874Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This also renames CommandBufferNode to CommandGraphNode. It also
renames some of the intenal members to more closely represent the
tree relationships (parents/children). This should clean up the
command graph classes and make them a bit easier to understand.

Bug: angleproject:2361
Change-Id: I024bffcc7f4157c78072ef902a3c40a07a08b18a
Reviewed-on: https://chromium-review.googlesource.com/922121Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

This shared state will be read-only visible in the RenderbufferImpl
class. It mirrors existing structs for Textures, Buffers, and other
classes. It allows the implementation class to have a read-only view
as to the current GL state of an object.

This will be useful to the Vulkan back-end, which would like to know
the current Renderbuffer state before having to redefine the storage.
If the current parameters match, it might not have to redefine the
storage at all.

The solution involves passing around the gl::RenderbufferState
through various factory methods.

Also name the Renderbuffer implementation pointer consistently and
make it use std::unique_ptr.

Bug: angleproject:2347
Change-Id: Ied6e0358e24e74a7fedbe4aea692edee909b5838
Reviewed-on: https://chromium-review.googlesource.com/922457
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>