Commits · ffe38e1c2b2a959ff2faa2da06cc584f37975e0d · Chen Yisong / angle

14 Jan, 2015 10 commits

Fixed WinRT ARM build break. ARM cannot use SSE. · ffe38e1c

authored Jan 14, 2015

Change-Id: I9a55d37db148f82b255e2c7ff414e79259e2c4e1
Reviewed-on: https://chromium-review.googlesource.com/240476Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

ffe38e1c

Split the flush and finish commands into separate methods. · 129753af

authored Jan 09, 2015

Improves the readability of the implementations and more closely mirrors
the GL commands.

Change-Id: Ifa7bc55751d50271eb01fd87e4efdc69f00c2c48
Reviewed-on: https://chromium-review.googlesource.com/239845Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

129753af

Move egl texture binding to the base texture class. · 7c973eaa

authored Dec 19, 2014

It's still only valid to bind a 2D texture but the validation layer
verifies that.

BUG=angle:681

Change-Id: I744dc32f9bd0f69b1e1235b8feef7e796167d033
Reviewed-on: https://chromium-review.googlesource.com/236931Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

7c973eaa

Remove references to the Image class from gl::Texture and rx::TextureImpl. · d03e10e2

authored Dec 18, 2014

BUG=angle:681

Change-Id: I83659f47cbe9f22ff5ad0cf54471544bd14775aa
Reviewed-on: https://chromium-review.googlesource.com/236690Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

d03e10e2

Refactor Texture to track image information for size and format queries. · a9be0dc6

authored Dec 17, 2014

BUG=angle:681

Change-Id: Ifb3f52d6348e4479181e66f1c39578f49e9dcf76
Reviewed-on: https://chromium-review.googlesource.com/235613Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

a9be0dc6

Add Gregoire to CONTRIBUTORS. · 24d5811b

authored Jan 13, 2015

Change-Id: I3e2a1f627de891c13964501f78314f84794cbded
Reviewed-on: https://chromium-review.googlesource.com/240422Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shannon Woods <shannonwoods@chromium.org>

24d5811b

Clean up BuiltInFunctionEmulator public interface · 80a5a6c6

authored Jan 12, 2015

This removes all language-specific bits from BuiltInFunctionEmulator
parent class, and makes the public interface of BuiltInFunctionEmulator
minimal.

Writing comments around emulated function definitions is removed from
OutputHLSL, they are not necessary as the emulated function definitions
are just another part of the shader header.

Change-Id: I9abf57d86f4e37b0674d7dfafe653298f205dd27
Reviewed-on: https://chromium-review.googlesource.com/240230Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

80a5a6c6

Implement simple ESSL3 matrix functions · e39706d0

authored Dec 30, 2014

Add support for built-in functions outerProduct, determinant, transpose
and the variations of matrixCompMult that were previously unsupported.

BUG=angle:859

Change-Id: Ie2b9cf83cd80c5a886c6d4eb190c7ce25a32d0a4
Reviewed-on: https://chromium-review.googlesource.com/239873Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

e39706d0

Use BuiltInFunctionEmulatorHLSL for all emulated functions · e17e3197

authored Jan 02, 2015

Implementation of missing built-in functions is a separate concern from
outputting the intermediate tree itself as HLSL, so it makes sense to
have all of the built-in emulation in a class that is separate from
OutputHLSL. Being able to reuse the same logic for different emulated
functions also makes the code more compact.

Change-Id: Id503dc3a5c5e743ec65722add56d6ba216a03a7f
Reviewed-on: https://chromium-review.googlesource.com/239872Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

e17e3197

Fix null check after addUnaryMath is called for a built-in function · 2aafa18b

authored Jan 08, 2015

The intermTypedNode pointer null check should be done before the pointer
is used, not after. In practice the pointer should never be null if
IntermUnary::promote() is consistent with the built-in function table,
but it's useful to have the null check as a fail-safe when developing.

Change-Id: I24e0d7399ef9d628f474e99fbca08dbd67fdd8c3
Reviewed-on: https://chromium-review.googlesource.com/240411Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

2aafa18b

13 Jan, 2015 6 commits

Revert "Fix Linux build, and update BUILD.gn." · 433c85d3

authored Jan 13, 2015

Still more build failures, different ones this time.

This reverts commit 9f8a57c6.

Change-Id: I7bea8e24403d92ca4ecb2ee0f24f9e065db5366d
Reviewed-on: https://chromium-review.googlesource.com/240550Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

433c85d3

Fix Linux build, and update BUILD.gn. · 9f8a57c6

authored Jan 13, 2015

Re-land with fixes for Android.

We were getting multiply defined symbol errors on Linux for some
stuff in the common sources. Switch to using a static lib target
for the common sources, and also sync BUILD.gn with the latest gyp.

BUG=angle:773

Change-Id: Id3edecc633b1c4be205558137c91baf87f256156
Reviewed-on: https://chromium-review.googlesource.com/240145Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9f8a57c6

Move the block layout code to translator. · 9e0478f6

authored Jan 13, 2015

This code is easily accessible from the translator, with the proper
export calls. This facilitates adding a common static library, since
this code calls some methods in translator.

BUG=angle:773

Change-Id: I0c50098ec3f67c2df7749b3c2518be0a9fd939e2
Reviewed-on: https://chromium-review.googlesource.com/240093Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

9e0478f6

Implement support for ES 3.0 instanced arrays · 2c7ea058

authored Jan 07, 2015

BUG=angle:863

Change-Id: I3918c478b33b26b2b179a7f8dd6e4210ecb0cf5c
Reviewed-on: https://chromium-review.googlesource.com/239170Tested-by: Gregoire Payen de La Garanderie <Gregory.Payen@imgtec.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

2c7ea058

Add more options to translator sample · 32855688

authored Dec 04, 2014

Adds precision emulation and WebGL 2 and GLES3 specs as options. The
example command line is also fixed.

Change-Id: Ia45eca1815724a63b26662ee0cadecf9dfea51f9
Reviewed-on: https://chromium-review.googlesource.com/236793Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

32855688

Refactor defining emulated functions in BuiltInFunctionEmulator · f6bdb312

authored Jan 09, 2015

This removes the fixed enumeration of emulated functions in favor of a
dynamic map. This makes the code more compact and flexible. The main
benefit is that maintaining the list emulated functions is a lot simpler
now.

Change-Id: Ic9951a496b9f021c76ad5b4c3daccd89af5ac093
Reviewed-on: https://chromium-review.googlesource.com/239871Tested-by: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Nicolas Capens <capn@chromium.org>

f6bdb312

12 Jan, 2015 7 commits

Don't use SSE functions on Android. · 0875f85d

authored Jan 12, 2015

These methods are unavailable on ARM platforms.

Also fix a sequencing bug that caused us to incorrectly define the
Android platform as Linux.

BUG=angle:773

Change-Id: Id2b47acdd5b574c618ac86641a1a8238fbb4a2c3
Reviewed-on: https://chromium-review.googlesource.com/240095Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

0875f85d

Don't use std::is_fundamental on Android. · ce4c0001

authored Jan 12, 2015

This method is unavailable due to being c++11.

BUG=angle:773

Change-Id: I995e03c26b5d3103fab963d8fb1eddc5050cf5b5
Reviewed-on: https://chromium-review.googlesource.com/240096Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ce4c0001

Avoid using std::map::at. · 5864ac26

authored Jan 12, 2015

This c++11 method call is unavailable on Android.

BUG=angle:773

Change-Id: I08064c3f18e387a2ed2496a3fb2912486546843f
Reviewed-on: https://chromium-review.googlesource.com/240094Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

5864ac26

Adds microbenchmark for resizing vs. creating new textures · 6fdb4ffd

authored Jan 10, 2015

Change-Id: I21a20250492b6b19181386890afd5e1a911ee055
Reviewed-on: https://chromium-review.googlesource.com/240091Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

6fdb4ffd

Adds a sample to demonstrate TRIANGLE_FAN vs TRIANGLES performance. · 1c394f40

authored Jan 05, 2015

Change-Id: Ic8f3d3e66904638cfdeab71aa6c19188f2a1b286
Reviewed-on: https://chromium-review.googlesource.com/238520Reviewed-by: Nicolas Capens <capn@chromium.org>
Tested-by: Shannon Woods <shannonwoods@chromium.org>

1c394f40

Allow zero output variable ES3 shaders. · b4463148

authored Dec 19, 2014

We were assuming at least one variable, when some shaders could
legitimately use zero. This was causing assertions in the
dEQP shader.function tests.

BUG=angle:855

Change-Id: I7e4aa52a1c6ba98d4a396f4c642816ff95115fd5
Reviewed-on: https://chromium-review.googlesource.com/240144Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Olli Etuaho <oetuaho@nvidia.com>

b4463148

Implement hyperbolic function support for ESSL 3.00 · 5c9cd3d1

authored Dec 18, 2014

Emulating arc hyperbolic functions is required on HLSL, where they do
not exist natively. For this, BuiltInFunctionEmulator is split into GLSL
and HLSL subclasses. The GLSL subclass handles the pre-existing built-in
emulation implemented for working around OSX bugs, and the HLSL subclass
handles emulating asinh, acosh and atanh on HLSL.

BUG=angle:855

Change-Id: I0dfeffb862ac27ba7f9ecf5492ec31d9d952b273
Reviewed-on: https://chromium-review.googlesource.com/236861Reviewed-by: Nicolas Capens <capn@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

5c9cd3d1

09 Jan, 2015 7 commits

Fix "start" vertex being applied for instanced buffers. · d4b55a00

authored Jan 09, 2015

In GLES, the start vertex only applies to non-instanced vertex
attributes.

BUG=angle:864
BUG=447140

Change-Id: Idd2afbfbd4c2e76e06b2704cc002fae26b353109
Reviewed-on: https://chromium-review.googlesource.com/239843Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d4b55a00

Update WebGL expecations. · ab549dad

authored Jan 09, 2015

Change-Id: Ic318a929f43a48f0e957add5fab4bc3362be47b0
Reviewed-on: https://chromium-review.googlesource.com/239954Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ab549dad

Revert "Fix Linux build, and update BUILD.gn." · 04184fb0

authored Jan 09, 2015

This reverts commit ed409f93.

Change-Id: I208a2c43c73e99ae95988c6d81ed64691bd8a99f
Reviewed-on: https://chromium-review.googlesource.com/239900Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Jamie Madill <jmadill@chromium.org>

04184fb0

Fix signed/unsigned missmatch on 32-bit builds. · 8fed1f71

authored Jan 09, 2015

BUG=angle:681

Change-Id: I6144359acd1611a13b0a582d3a31019138bb941c
Reviewed-on: https://chromium-review.googlesource.com/239844Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

8fed1f71

Fix Linux build, and update BUILD.gn. · ed409f93

authored Jan 07, 2015

We were getting multiply defined symbol errors on Linux for some
stuff in the common sources. Switch to using a static lib target
for the common sources, and also sync BUILD.gn with the latest gyp.

BUG=angle:773

Change-Id: I212284cfa90cd117a784a5f17057f47dd08900d1
Reviewed-on: https://chromium-review.googlesource.com/239193Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ed409f93

Merge the Texture set*Image methods and use objects for sizes and offsets. · 0a4f1e27

authored Dec 17, 2014

BUG=angle:681

Change-Id: If2e981c522ca5ba3eab4484594cb41aa23800ec4
Reviewed-on: https://chromium-review.googlesource.com/236261Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

0a4f1e27

Use typed tests for the gles conformance tests. · ea878cb9

authored Jan 08, 2015

BUG=angle:497

Change-Id: I396411cc7c07047ef2fab70605de39287aaea879
Reviewed-on: https://chromium-review.googlesource.com/239515Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ea878cb9

08 Jan, 2015 9 commits

Fixed WinRT compilation to use non static C runtime because of Windows Store requirements. · cf5d48fa

authored Jan 06, 2015

Change-Id: I310e4909aaa94c90eecd610e6c7cbbde3c19b777
Reviewed-on: https://chromium-review.googlesource.com/238532Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

cf5d48fa

Fixed failed compilation for WinRT to use OutputDebugStringA for non wide strings. · 7318b7cb

authored Jan 08, 2015

Change-Id: If012660d4b895399fe5e3226dea25a8c7f78c8ac
Reviewed-on: https://chromium-review.googlesource.com/239504Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Cooper Partin <coopp@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

7318b7cb

Add EGL extensions structs. · 40856813

authored Dec 11, 2014

BUG=angle:658

Change-Id: Iffb26caf16416313abc114ba779e6311f2c00848
Reviewed-on: https://chromium-review.googlesource.com/234760Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

40856813

Implement float-integer conversions for ESSL 3.00 · e8d2c072

authored Jan 08, 2015

The implementation uses asint, asuint and asfloat in the HLSL output.

BUG=angle:865

Change-Id: I6b48298e18c7b3b0bdeac522b375ebc4eab7cf4e
Reviewed-on: https://chromium-review.googlesource.com/239520Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Tested-by: Olli Etuaho <oetuaho@nvidia.com>

e8d2c072

Fix multisample framebuffer validation ASSERT · d2cf3ad3

authored Jan 07, 2015

Change-Id: I1b02ed7209f30549c17f46aeb3726ba1254df3ea
Reviewed-on: https://chromium-review.googlesource.com/239270Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

d2cf3ad3

Disable some extensions on D3D11 Feature Level 9_3 which aren't supported · cf4432c3

authored Jan 07, 2015

BUG=angle:858

Change-Id: Ib2b2b2b54ba25654ea80b5cb1c59b74ed0379b68
Reviewed-on: https://chromium-review.googlesource.com/239271Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

cf4432c3

Disable shared texture support on D3D11 FL9_3 · ab989891

authored Jan 07, 2015

BUG=angle:858

Change-Id: I0fe3baf811d561584f7d24f6da665c6934e32b2a
Reviewed-on: https://chromium-review.googlesource.com/239272Tested-by: Austin Kinross <aukinros@microsoft.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

ab989891

Remove an unused mRenderer member from Program and initialize TF members. · ce5d66e8

authored Jan 07, 2015

BUG=angle:731

Change-Id: Ie11c80ce1f3a8c3d08145dfb4a075ac0e022ae38
Reviewed-on: https://chromium-review.googlesource.com/239218Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

ce5d66e8

Add a test for rendering to cube map faces. · 5879598b

authored Jan 07, 2015

BUG=angle:849

Change-Id: I9986e45256da6f4cdbd375dad95037464fbcf299
Reviewed-on: https://chromium-review.googlesource.com/239219Reviewed-by: Jamie Madill <jmadill@chromium.org>
Tested-by: Geoff Lang <geofflang@chromium.org>

5879598b

07 Jan, 2015 1 commit

Print ERR() errors to the debug output on Windows. · 14aa40f0

authored Jan 07, 2015

We can switch this on for Debug only. This will help developers
catch bugs more easily, and will only show up for internal
errors and major performance caveats. Currently it's far too easy
to miss these messages - it requires manually modifying debug.h,
looking at a text file and potentially also running Chromium with
an special flag.

BUG=angle:663

Change-Id: I75b3bd05fbc75d21607b9957134db8e8990c77b1
Reviewed-on: https://chromium-review.googlesource.com/239191Tested-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

14aa40f0