- 20 Mar, 2019 3 commits
-
-
Chris Forbes authored
I'm about to build some more on top of this; don't want to write it multiple times. Change-Id: I9ca84536f47b886e9f03edcaa6dc5dfe6e34091d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26688Tested-by:
Chris Forbes <chrisforbes@google.com> Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Nicolas Capens authored
Intermediate::Scalar was defined as RValue<SIMD::Float>, even though it can hold integers as well. Use abstract Reactor values instead which don't have a statically defined type. This change does not yet avoid bitcasting on access. The EmitLoad() implementation still assumes values come in as float. Bug b/128539387 Change-Id: I18f449ebf68db7ddd81679d6d028911e6c02fc38 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26868 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
Ben Clayton <bclayton@google.com> Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: Ibfb2c1126253d98d15016b464e79e06f4d1bac8a Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27570Reviewed-by:
-
- 19 Mar, 2019 11 commits
-
-
Chris Forbes authored
Previously this was left uninitialized, with exciting results when a shader used it for buffer indexing etc. Bug: b/126871859 Test: dEQP-VK.*push_constant* Test: dEQP-VK.glsl.* Test: dEQP-VK.spirv_assembly.* Change-Id: I57fb9e22cbe57a87072b1039a7d799bedd28ae91 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27628 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
-
Chris Forbes authored
Bug: b/128690261 Bug: b/128872954 Test: dEQP-VK.*push_constant* Test: dEQP-VK.glsl.* Test: dEQP-VK.spirv_assembly.* Change-Id: I0f8d103288777cd03347b32366ed5c5606e38b8d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27588 Presubmit-Ready: Chris Forbes <chrisforbes@google.com> Reviewed-by:
-
Chris Forbes authored
- Proper support for calculating offsets in explicit-layout storage classes (push constant, uniform, and storage buffer) according to the Offset, ArrayStride and MatrixStride decorations. - Plumb a block of push constant data throughout the pipeline - Implement push constant update commands Bug: b/128690261 Bug: b/128872954 Test: dEQP-VK.*push_constant* Test: dEQP-VK.glsl.* Test: dEQP-VK.spirv_assembly.* Change-Id: I7d5a66ac4aafd6b637b4693eb6ce96a327b4904e Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27528Tested-by:
-
Nicolas Capens authored
Also copy the DLLs to build/ This makes it consistent with the CMake build. Bug b/116336664 Bug b/29024574 Change-Id: I747a52383492c3ec5493f1a232cbbf5c98aec219 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27608 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Chris Forbes authored
Treat OpUndef identically to OpConstantNull for now. Change-Id: I721f2bf5e053d6a8d6f563272b1d44b6636a157c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27529Tested-by:
-
Ben Clayton authored
List most common failures on the daily report. Change-Id: Ia07f73601727f71e5f2abee7c40886e2a05209bb Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27472Reviewed-by:
-
Ben Clayton authored
Confusingly the "Code-Review" label uses 'Value' for -1 / +1, and 'Approved' for +2s. Changes that were ready to land were not being prioritized over no-code review. Change-Id: Ia31adcbbba70b2f52b9abc7299f4bafdcdb8fe48 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27170Tested-by:
-
Ben Clayton authored
If a test failed to build, an error was logged to stdout, but the error was not posted to the change. This meant the change would be picked up by regres again, and the process would repeat ad-infinitum. Posting of the build error used to work, but was broken by bfaf4e825b. Change-Id: I1e59f0d2e5ee26eb002aa2c596dc5491e48a9c87 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27169Tested-by:
-
Nicolas Capens authored
Cube textures must be cube complete to generate mipmaps, but when the base level is undefined the glGenerateMipmap command must be silently ignored. This was previously leading to a null dereference. Bug chromium:924022 Bug https://gitlab.khronos.org/opengl/API/issues/72 Change-Id: I5d6e8533118e554efa12045fc376126c7b00f263 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27491 Presubmit-Ready: Nicolas Capens <nicolascapens@google.com> Tested-by:
-
Nicolas Capens authored
Bug b/126126820 Change-Id: Iaf3991d58c64995018ba0d15773b65d463e03fad Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27549Reviewed-by:
-
SwiftShader Regression Bot authored
Change-Id: I5aab5f50bad232227a7bf3af1dd40396c0f208a5 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27449Reviewed-by:
-
- 18 Mar, 2019 8 commits
-
-
Chris Forbes authored
Bug: b/118386749 Change-Id: I4d6150907a0afea8eeff28334dae1e4af6309075 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/26309Tested-by:
-
Chris Forbes authored
Bug: b/128715612 Change-Id: I1e9859d2cf001bfb341a49ad4f8fc9ef52c9fa5b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27508Tested-by:
-
Alexis Hetu authored
Because we need to dereference dispatchable objects in order to get the underlying object, we need to first check for VK_NULL_HANDLE to avoid crashing. Bug b/116336664 Change-Id: Ia903dcc6142d5e7f283da8fbef0f43bae3ca243f Tests: dEQP-VK.api.null_handle.free_command_buffers Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27388Reviewed-by:
-
Nicolas Capens authored
This duplicates the folder for now. The old one will be removed once the service has been switched over to the new one. Bug b/126742833 Change-Id: Idba255cb8dad165559c56cb614fa915089c3858d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27489Tested-by:
-
Nicolas Capens authored
The /build directory is checked into the repository so the 'mkdir build' produced an error that it already exists. We'll switch to using Kokoro for CI as soon as it completely replaces all uses of Travis CI. Bug b/115784742 Change-Id: Ie04edccbb7a875f105353eec203fcabce2f33bc3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27488Tested-by:
-
Ben Clayton authored
36411219 had preprocessor issues on Windows. This should now work on all platforms. I had to change UNIMPLEMENTED() and UNREACHABLE() to always take a format parameter to make this work on MSVC. This doesn't seem like a terrible thing though - especially if we can incorporate the frequency of hit UNIMPLEMENTED()'s to steer our focus. Change-Id: Idc58dbe6caa3fb51e085c3b236904c640091deec Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27468 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
-
Ben Clayton authored
Bug: b/126126820 Change-Id: I0df0841952dcaa9c8376847704a9697b9c9e9894 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27093 Presubmit-Ready: Ben Clayton <bclayton@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Ben Clayton authored
Test: dEQP-VK.subgroups.builtin_var.compute.* Bug: b/126871859 Change-Id: Ida9cb49548ec984039d8730d50be7c8b22c3bfb8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27092 Presubmit-Ready: Ben Clayton <bclayton@google.com> Tested-by:
-
- 16 Mar, 2019 6 commits
-
-
SwiftShader Regression Bot authored
Change-Id: Idbe4177c0031c858b0886c8c3c8ebe8e92d2614b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27448Reviewed-by:
-
Chris Forbes authored
Bug: b/128715612 Test: dEQP-VK.pipeline.stencil.format.* Change-Id: I4789c0ff77c43e91fc7cbd7e2aceab0b1ba9cdb3 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27429Tested-by:
-
Chris Forbes authored
The mask was previously dropped on the floor here, and the imageview's only mask used instead. This would produce incorrect results when a renderpass begin operation had different load ops for depth vs stencil aspect. Bug: b/128715612 Change-Id: I2bf4051e16c027737b65cd5bc5193a94cf891c36 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27428Tested-by:
-
Chris Forbes authored
This is the `other` remainder from OpFMod, which we already had. Uses the existing RValue<Float4> % RValue<Float4> operator wiring; the only plumbing I had to fix was that llvm emits a call to fmodf, which was made available in ExternalFunctionSymbolResolver. Test: dEQP-VK.spirv_assembly.instruction.compute.opfrem.all Test: dEQP-VK.spirv_assembly.instruction.graphics.frem.* Bug: b/126873455 Change-Id: I81fbfd8f9e5cab6ac2f16319edda031a122e3a4d Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27370Tested-by:
-
Chris Forbes authored
Bug: b/126873455 Test: dEQP-VK.glsl.operator.common_functions.mod.* Change-Id: I7f261e7bd4dda72b18594cd7e2ee7044bc60466b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27369Tested-by:
-
Chris Forbes authored
This can be treated exactly the same as OpAccessChain. Bug: b/128690261 Bug: b/127950082 Test: dEQP-VK.spirv_assembly.instruction.compute.opinboundsaccesschain.* Change-Id: I65312ad48e461ec83e6999c6a899820e91e2a68b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27368Tested-by:
-
- 15 Mar, 2019 12 commits
-
-
Nicolas Capens authored
Booleans and integer types smaller than 32-bit are not readily supported as arguments by Subzero. Was broken by https://swiftshader-review.googlesource.com/27251 Change-Id: I0803037100b107ca9f7b627c2effd0493b8ab1a8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27390Tested-by:
-
Ben Clayton authored
Breaks windows build. This reverts commit 36411219. Change-Id: I89286d25ed0e362f16e981d3c4d39a4661ee02c2 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27329 Presubmit-Ready: Ben Clayton <bclayton@google.com> Reviewed-by:
-
Nicolas Capens authored
Bug b/123360006 Change-Id: Ie29b1fea3607ad0da2fb48cf3a5248e976c2cf5f Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27389Tested-by:
-
Chris Forbes authored
Bug: b/126873455 Tests: dEQP-VK.spirv_assembly.* Change-Id: I8b6b6329b37469b9779178488f96fc62c341997b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27308Tested-by:
-
Chris Forbes authored
Test: dEQP-VK.spirv_assembly.*srem* Bug: b/126873455 Change-Id: I9f5f519f7dac72ef7c7b45e88451fcb9dae0b3f8 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27270Tested-by:
-
Chris Forbes authored
We don't support the depth bounds test so these values do nothing; there is no validity requirement placed on these values Bug: b/118386749 Change-Id: I6e75181df6c2b497e91e2fa7a2029d408f8bacbe Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27269Tested-by:
-
Chris Forbes authored
These have been fully implemented for some time. Bug: b/124058197 Change-Id: I8146c0902aa0c4caa974e5af5b1a36104846934c Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27268Reviewed-by:
-
Chris Forbes authored
The inliner leaves the original functions. If we want the simplicity of not thinking about functions, we have to remove them. Change-Id: I0d0c7f8d3de21095b52d86a4c62015287eda32cc Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27272Tested-by:
-
Ben Clayton authored
Test: dEQP-VK.subgroups.builtin_var.compute.* Bug: b/126871859 Change-Id: If1585778ca5a85e2b8a66f4ddf6a58050620a112 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27089Reviewed-by:
-
Alexis Hetu authored
Extra useless deallocations weren't cleaned up properly. Removed them. Bug b/123244275 Change-Id: I418a4c09a870748551a92c1abb3986e94b32ba92 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27289Tested-by:
-
Alexis Hetu authored
Enable sRGB conversion when filtering sRGB images Tests: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Bug b/119620767 Change-Id: If56a3f74fbf3ee576d9baab44722a13a1ad0d436 Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27288Tested-by:
-
Alexis Hetu authored
The following changes are done in this cl: - Added multilayer support in Blitter::blit() - Fixed Image::texelOffsetBytesInStorage() for cubes, since there's a 1 pixel border around it, so pixel offset (0,0,0) should be an extra line (1 pixel offset in Y) + 1 pixel (1 pixel offset in X) from the beginning of the buffer - Added a number of out of bounds memory access asserts, which helped debug this issue. Fixed failures in: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Note: The only failures left in that category are related to filtering sRGB images, which most likely happens in the wrong colorspace. Tests: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.generate_mipmaps.* Bug b/119620767 Change-Id: I6f18271cb23070eb8f2de3b1d5b35b7021c0ca8b Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/27229Reviewed-by:
-
