- 26 Feb, 2019 6 commits
-
-
Nicolas Capens authored
VertexProcessor multiSampling state was eliminated. Change-Id: I0507c80faff9e00b36d26ea96e3bc3a8e837d574 Reviewed-on: https://swiftshader-review.googlesource.com/c/25569Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
Microsoft's x86-64 calling convention ABI requires registers XMM6-15 to be preserved by the callee: https://docs.microsoft.com/en-us/cpp/build/x64-calling-convention?view=vs-2017#calling-convention-defaults Currently only the System V calling convention's behavior is supported, which does not have any callee-saved XMM registers. Fixing this properly is non-trivial and this bug is blocking other projects, so a temporary workaround is to limit Subzero to use only scratch registers XMM0-XMM5. Bug chromium:931926 Bug swiftshader:22 Change-Id: If3fde2295fc65fc52042124afe7dfc46873cce3f Reviewed-on: https://swiftshader-review.googlesource.com/c/25568Tested-by:
-
Ben Clayton authored
StorageClass, sizeInComponents, isBuiltInBlock are all attributes of the Type, not the Object. Add 'type' field to Object so type information can easily be looked up regardless of definition opcode. Add 'element' field to Type, simplifying the likes of WalkAccessChain. Fixes the weird edge case of OpVariable's sizeInComponents being the size of the pointee, not its type (the pointer). Bug: b/126126820 Change-Id: I2d1d93e03ee0253a87f831031c3b2806b1d80de0 Reviewed-on: https://swiftshader-review.googlesource.com/c/25408 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Ben Clayton <bclayton@google.com>
-
Ben Clayton authored
Prevents you from mixing them up by mistake, and provides better self-documentation on function signatures. Bug: b/126126820 Change-Id: I21ce20ded434ca3d5d03ebf3f9027cf6f6b5386f Reviewed-on: https://swiftshader-review.googlesource.com/c/25068Reviewed-by:
-
Chris Forbes authored
The vertex processor doesn't need to know. V3: also remove from GL side, which didn't use it either. Change-Id: Id0624fb2700222be6238a8449b32b334755a45e7 Reviewed-on: https://swiftshader-review.googlesource.com/c/25332Tested-by:
Chris Forbes <chrisforbes@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Hernan Liatis authored
MAKE_VULKAN_INSTANCE_ENTRY never got undefined Bug: b/125417927 Change-Id: I0fd5d8054748ff6279a65a5086e9a717441e583f Reviewed-on: https://swiftshader-review.googlesource.com/c/25469Reviewed-by:
Hernan Liatis <hliatis@google.com>
-
- 25 Feb, 2019 8 commits
-
-
Hernan Liatis authored
Extension checking in vkCreateInstance would simply loop through the first extension requested. This bug did not show up earlier (or at all) because erroneous situations would cause early exits in the loader. Bug: b/125943360 Change-Id: Id664f46d09dce1b3530670ae826314b26797b5be Reviewed-on: https://swiftshader-review.googlesource.com/c/25368Tested-by:
-
Alexis Hetu authored
Initial basic implementation of PipelineLayout. The information stored in the PipelineLayout will be used, among other things, to properly bind descriptor sets affected by a dynamic offset. Bug b/118386749 Change-Id: I05fa6f9c7740cf79a802a5276e2d88f6e6e4ebe7 Reviewed-on: https://swiftshader-review.googlesource.com/c/24948Tested-by:
Corentin Wallez <cwallez@google.com> Reviewed-by:
-
Chris Forbes authored
Change-Id: Iacb323b4cc0c0b0373791b3aa3a5f0b4dcaffa44 Reviewed-on: https://swiftshader-review.googlesource.com/c/25428Tested-by:
-
Alexis Hetu authored
Two consecutive eglBindTexImage calls on the same buffer (texture) would eventually result in a crash if the texture is released before the egl surfaces, so this assert is meant to perform an early detection of a harder to detect future issue. Bug chromium:932986 chromium:929088 Change-Id: I10b3892fe06d491c8a0a09dec84678b25f49c6ab Reviewed-on: https://swiftshader-review.googlesource.com/c/25128Tested-by:
-
Ben Clayton authored
4c9f04bb added the build directory, so drop the docs for `mkdir`. Change-Id: Idc7437c0c72666f2c115bb0ddbd753a3179dba79 Reviewed-on: https://swiftshader-review.googlesource.com/c/24508Reviewed-by:
-
Chris Forbes authored
All vulkan resource access will be through descriptors. We don't need any of this context-side state. Bug: b/125909515 Change-Id: Id6d1da0f8a851e057dd3a16fc844b6a70cf9b935 Reviewed-on: https://swiftshader-review.googlesource.com/c/25330 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Chris Forbes authored
Vulkan doesn't have user clip planes in the legacy GL sense -- there is an optional feature to supply GLSL1.30-style clip distances out of the vertex shader, but the actual plane handling is the shader's problem. We also don't support this optional feature. Bug: b/125909515 Change-Id: I6dfc3eda613982112786a52517d1cd126146c590 Reviewed-on: https://swiftshader-review.googlesource.com/c/25329Reviewed-by:
-
Chris Forbes authored
Bug: b/125909515 Change-Id: I18f1ed398d85a914863f4b93a2795637e20028b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/25328Reviewed-by:
-
- 23 Feb, 2019 1 commit
-
-
Chris Forbes authored
There are some horrible hacks in here -- the draw command should not be doing anywhere near this much work -- but this gets us to first triangle. Passes: dEQP-VK.api.smoke.triangle Bug: b/124177079 Change-Id: I4240cb8cdce2f4bbb804e88e66d1695ab0b0e41e Reviewed-on: https://swiftshader-review.googlesource.com/c/25212Tested-by:
-
- 22 Feb, 2019 9 commits
-
-
Chris Forbes authored
Bug: b/124177079 Change-Id: I8e55607c8ff7f9c2d2356268bedf170cf27eeb99 Reviewed-on: https://swiftshader-review.googlesource.com/c/25268Tested-by:
-
Ben Clayton authored
Change-Id: I88d914d9aa30291e938b65519ebfecb577c5d33e Reviewed-on: https://swiftshader-review.googlesource.com/c/25170 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
Raymond Chiu <chiur@google.com> Reviewed-by:
-
Chris Forbes authored
These instructions don't require any work in the emit phase. Change-Id: I1f82e785afe9a3e3871637349fca3eac3435ab6c Reviewed-on: https://swiftshader-review.googlesource.com/c/25189Tested-by:
-
Chris Forbes authored
Vulkan does not have alpha test. Apps are expected to use discard in the shader instead. Change-Id: Idc1d8d2a74f5728cf70c653a5139a0ca1674ca37 Reviewed-on: https://swiftshader-review.googlesource.com/c/25211Tested-by:
-
Chris Forbes authored
This is required to have the vertex fetch state actually available at JIT time. Bug: b/124177079 Change-Id: Ibb548c372ee349d3a5312bb46dddcf13257dc294 Reviewed-on: https://swiftshader-review.googlesource.com/c/25188 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Tested-by:
-
Chris Forbes authored
Previously we had only supported simple integer constants, as that was enough to parse array declarations etc. Fully implement constants, including large null objects, and constant composites constructed out of other constants. Bug: b/124934655 Change-Id: Ia1087f62a2bd75a3ca2f784ea24b0b3f01984ad9 Reviewed-on: https://swiftshader-review.googlesource.com/c/25148Tested-by:
-
Ben Clayton authored
Disabled by default by the request of Nicolas. Bug: b/123933266 Change-Id: Ie1217dc6c96ec85c9daf8246de785c8729386634 Reviewed-on: https://swiftshader-review.googlesource.com/c/25015Tested-by:
-
Hernan Liatis authored
The above function, while listed with the device functions, was using MAKE_VULKAN_INSTANCE_ENTRY() instead of MAKE_VULKAN_DEVICE_ENTRY() Bug: b/125417927 Change-Id: I66865468f50b2db3f6904fab40f79db3346431a2 Reviewed-on: https://swiftshader-review.googlesource.com/c/25209 Kokoro-Presubmit: Hernan Liatis <hliatis@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Hernan Liatis authored
Needed to call VkCreateXXXSurfaceKHR() functions, where XXX is the platform name. Bug: b/125405086 Change-Id: Id0de2ee02bd3b7d5b37eda202fb26e4ad3265bf3 Reviewed-on: https://swiftshader-review.googlesource.com/c/25208 Kokoro-Presubmit: Hernan Liatis <hliatis@google.com> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
- 21 Feb, 2019 4 commits
-
-
Ben Clayton authored
The clipper and blitter were being destructed before the worker threads were stopped. Also nullify after deleting other fields - this would have been much harder to detect if the clipper and blitter were not already being nullified after destruction. Tested with: ./unittests --gtest_repeat=100 --gtest_filter=SwiftShaderTest.TransformFeedback_DrawArraysInstanced Bug: b/124288179 Change-Id: Iefea829dfb8556c877c0a086253c5924c54aa638 Reviewed-on: https://swiftshader-review.googlesource.com/c/24748Reviewed-by:
-
Ben Clayton authored
Addressing this one toolchain at a time, as not all warning names are the same across toolchains. Bug: b/123933266 Change-Id: I618ebafb5ff18a885c71a8e2fa1943befc6786b6 Reviewed-on: https://swiftshader-review.googlesource.com/c/25014 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
This was being incorrectly sized by the number of functions, not the highest label in use. While investigating this, I've realized that the sanity checks to ensure there are no dead functions was never going to fire as the function list was built from the list of called functions. Instead I've changed the function scanning pass to look for labels starting a LABEL-RET pair. Bug: b/125183107 Change-Id: Ic921097ed42a96b52f1ab7c9590c02fb3552b565 Reviewed-on: https://swiftshader-review.googlesource.com/c/25168Tested-by:
-
Ben Clayton authored
Reproduces the issues reported by b/125183107. Bug: b/125183107 Change-Id: If0f2ab3fcc8c065409fdbbc6df670f78a78fa3f7 Reviewed-on: https://swiftshader-review.googlesource.com/c/25169Tested-by:
-
- 20 Feb, 2019 12 commits
-
-
Chris Forbes authored
Bug: b/124177079 Change-Id: I0dbcd154c2a28c43d9895e264cc794fc2ed289f2 Reviewed-on: https://swiftshader-review.googlesource.com/c/25029Reviewed-by:
-
Chris Forbes authored
Bug: b/124177079 Change-Id: I1779ed78ccfdb6c77bcf55ba109ae93fc75171ff Reviewed-on: https://swiftshader-review.googlesource.com/c/24989Tested-by:
-
Chris Forbes authored
This was completely broken -- we weren't walking down the type tree at all. Bug: b/124388146 Change-Id: I359d121403c3413e74427fadf57fd4c3d52f7661 Reviewed-on: https://swiftshader-review.googlesource.com/c/25088Tested-by:
-
Chris Forbes authored
Bug: b/124534397 Change-Id: Icfe0d83b0e8df648c90ba7f250924ad28dd06b55 Reviewed-on: https://swiftshader-review.googlesource.com/c/25108Reviewed-by:
-
Chris Forbes authored
The vast majority of values in a SPIRV program are intermediates -- they are guaranteed written to exactly once, by the instruction which defines them. Initially we had treated these the same as mutable (stack) variables, but that produces wasteful code full of loads and stores. Instead, represent intermediate values as a bundle of RValue<Float4>, representing an rvalue float-sized value per SIMD lane. Introduce the new type Intermediate to hold these bundles to allow incremental construction of the individual RValue<Float4> objects within the bundle. Bug: b/124534397 Change-Id: Ibb663773100d017de117111705b530b092f87ea2 Reviewed-on: https://swiftshader-review.googlesource.com/c/24968Tested-by:
-
Ben Clayton authored
Change-Id: Ifbcb30da30b912a1a60f5799717869c8d56cd90b Reviewed-on: https://swiftshader-review.googlesource.com/c/25018 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
Bug: b/123933266 Change-Id: I3e5f028ab323f361840a6326a1b7834995e8b8e3 Reviewed-on: https://swiftshader-review.googlesource.com/c/25017 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
This produces a non-silenceable warning about enum fields being too small to store all enum values. Nicolas agreed we can just drop the bitpacking for vulkan state. Bug: b/123933266 Change-Id: Idf09be3ef122fca70da8d877a211368b7fd8a995 Reviewed-on: https://swiftshader-review.googlesource.com/c/25013Reviewed-by:
-
Nico Weber authored
Bug: chromium:926235 Change-Id: I9d5a28e1dd2ee6619ee0fefcd9f3798ca22be45b Reviewed-on: https://swiftshader-review.googlesource.com/c/25048Reviewed-by:
Nico Weber <thakis@chromium.org> Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
-
Ben Clayton authored
Bug: b/123933266 Change-Id: If8fa478aa65f5c0046ca635a8d133911f8a59977 Reviewed-on: https://swiftshader-review.googlesource.com/c/25010 Kokoro-Presubmit: kokoro <noreply+kokoro@google.com> Reviewed-by:
-
Ben Clayton authored
Lost in the noise of other warnings Bug: b/123933266 Change-Id: I4c4eecb55a364c9afacf52b790f43f9d5c9640cb Reviewed-on: https://swiftshader-review.googlesource.com/c/25012Tested-by:
-
Ben Clayton authored
Fixes warnings about switch statements not handling all enum values. Bug: b/123933266 Change-Id: I0372ebf2412452622eb99ea7bba7ebc5cedd385c Reviewed-on: https://swiftshader-review.googlesource.com/c/25009Tested-by:
-
