Bug: b/149328074
Change-Id: Ia5af4622f2a024ea08395f7b7412e086fdb34c39
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41270Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

From VK_EXT_external_memory_host, there is a type of VkDeviceMemory
that takes a pointer to host mapped foreign memory, where the
underlying memory is owned by the host, not the device.
This is used by ANGLE on Mac when creating a VkDeviceMemory given an
IOSurface.

Tests: dEQP-VK.*
Bug: chromium:1965434
Change-Id: I944a5d3cd23ad8b193f58981829a8847419a4b0d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/39968
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Jonah Ryan-Davis <jonahr@google.com>

Fixes another hairy bug in condition-variable timeouts, adds docs

Changes:
    a047dd0bb Include benchmarks on project's README.md
    4c702da52 Scheduler: Fix lock state on Fiber::wait timeout.
    b4e305525 Docs: Add documentation for marl::Scheduler.
    5f18ac0e0 ConditionVariable: Delete copy and move constructors
    f78eb441f Scheduler: document requirement to unbind() before destruction
    9f9f6d32e Defer benchmark - avoid benchmark::DoNotOptimize()
    3b610e902 Fix compiler warnings with MARL_FIBERS_USE_UCONTEXT
    0dbab1184 Scheduler: Delete copy and move constructors / assignment ops.
    cbef55d58 Kokoro: Build benchmarks
    e923c3d96 Rework the 'hello task' example to be more idiomatic

Commands:
    git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash

Bug: b/140546382
Change-Id: I3412287ec95bdf761d84fd9f0dffae8f08bcec3c

a047dd0bb Include benchmarks on project's README.md
4c702da52 Scheduler: Fix lock state on Fiber::wait timeout.
b4e305525 Docs: Add documentation for marl::Scheduler.
5f18ac0e0 ConditionVariable: Delete copy and move constructors
f78eb441f Scheduler: document requirement to unbind() before destruction
9f9f6d32e Defer benchmark - avoid benchmark::DoNotOptimize()
3b610e902 Fix compiler warnings with MARL_FIBERS_USE_UCONTEXT
0dbab1184 Scheduler: Delete copy and move constructors / assignment ops.
cbef55d58 Kokoro: Build benchmarks
e923c3d96 Rework the 'hello task' example to be more idiomatic

git-subtree-dir: third_party/marl
git-subtree-split: a047dd0bbbd6a65ee4d03d0ceb4fedfa56da02a5

Bug: b/140546382
Change-Id: I2045aad2afc0918003117561dfe49aafbb4ef13a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41048
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Change-Id: If4a2966a3ce353a45c0d1f14e59993ef34a8af25
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41168
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

After the normal build and unit tests run, incrementally build
ReactorUnitTests with REACTOR_ENABLE_PRINT enabled, and run only the
unit tests that exercise the print code. This should add very little
extra time to our Kokoro builds, while ensuring we don't break the
rr::Print stuff.

Bug: b/149328074
Change-Id: I26c0db727c8edd269243f17192020a3435893c14
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41148
Presubmit-Ready: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

* CMake: add REACTOR_ENABLE_PRINT to enable rr::Print macros (default 0).
  When enabled, defines ENABLE_RR_PRINT. Formerly, ENABLE_RR_PRINT was
  only defined in NDEBUG builds.
* CMake: REACTOR_EMIT_PRINT_LOCATION enables REACTOR_ENABLE_PRINT.
* Add missing includes of Print.hpp.
* Fix rr::Print compilation of non-const pointers.
* Fix rr::Print compilation of Int2 and UInt2.
* Fix rr::Print of Float outputting in square brackets.
* Fix rr::Print of Bool to output a '1' or '0' for 'true' and 'false'.
* Add unit tests for rr::Print of all primitive and Reactor types.
* Includes changes bclayton@ made to output "true"/"false" for Bool,
  and to correctly compare against implementation-specific printf of
  pointers.

Bug: b/149328074
Change-Id: Ibb17985201f1c2b432539cd1153293d1e1cbb5bb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41108Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

SwiftShader segfaults when trying to resolve missed symbol. The symbol is requested at least on ARM32 (armv7l).

Bug: b/149229646
Change-Id: I5436b244c2e7ec9a0d557f57697adbdb5e29a0cb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41089
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Change-Id: I3c8451ca5036da69021a117d68d3aae55cce96fc
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41128
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Marl now exposes this as PUBLIC on the target, so it is automatically and implicitly included.

Bug: b/140546382
Change-Id: I9ed331559c7b5cccad3065b4fadeca8380d6e910
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40973
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Two changes landed that failed style checks

Bug: None - just reformatting.
Change-Id: Id021ad6c4c87f0499428af6fb65ffbd83fd65116
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41090
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Files that are #included in a non-standard header way usually have a .inc or .inl extension.
Reactor already has Reactor/Traits.inl, so let's be consistent and stick with this extension.

Bug: b/148778720
Change-Id: Ie69951c254921b9cf86c3ab201533a3b21489b97
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40977
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

* changes:
  Update Marl to 246091e81
  Squashed 'third_party/marl/' changes from 14e4d862a..246091e81

Accorading to GCC and Clang documents, march=mipsel/mips64el doesn't
really exist. So we use real CPU arch instead, and apply '-EL' flag
to indicate endianess. Also, to deal with link failure, we add '-mxgot'
to increase GOT size.

Change-Id: I21706da3423412c968f6e80a9d21f5266255a0cf
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41028Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

The team debated whether this was legal or not at the time.
It seems that at least one of Android's compilers generates code that stomps the list data after the `std::initializer_list` is declared and before it is used.

Switch to using regular C arrays with constexpr / std::array.

Fixes: b/149235682
Change-Id: Ief95dc4c6b4aee0c181bbe34aff19aa95f5fac8c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41051Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

This cl adds support for the VK_KHR_separate_depth_stencil_layouts.
It doesn't add any new functionality, since SwiftShader has
historically supported quad layout stencil and non quad layout depth.

Bug: b/148881874
Change-Id: I6ed77ee1261bfda1468595474cf0840564f2553d
Tests: dEQP-VK.*
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41068
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

This cl adds support for the VK_KHR_create_renderpass2. It doesn't
add any new functionality and ignores any new performance hints
that are part of this extension, but it properly supports the new
API entries that are part of this extension.

Bug: b/148884281
Tests: dEQP-VK.*

Change-Id: I15d9d00658e65380f4e93e59299a8c5e5212f95e
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40988
Presubmit-Ready: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

This reverts commit 5f5a0648.

Reason for revert: Breaks Android build

 ld.lld: error: undefined symbol: __aeabi_idivmod
 >>> referenced by LLVMJIT.cpp:547 (external/swiftshader/src/Reactor/LLVMJIT.cpp:547)
 >>> LLVMJIT.o:((anonymous namespace)::JITRoutine::JITRoutine(std::__1::unique_ptr<llvm::Module, std::__1::default_delete<llvm::Module> >, llvm::Function**, unsigned int, rr::Config const&)::'lambda'(llvm::StringRef const&)::operator()(llvm::StringRef const&) const) in archive <omitted>/libswiftshader_llvm.a

Change-Id: I153ac3a3a9bc395201024d4b38e43c064691a5ad
Bug: None - build fix.
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41088Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

SwiftShader segfaults when trying to resolve missed symbol. The symbol is requested at least on ARM32 (armv7l)..

Change-Id: I96dd157afc1832ef39daaf46d818c8033820d86b
Bug: b/149229646
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41049Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Kokoro-Presubmit: Lingfeng Yang <lfy@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

`DEBUG` has been defined by some projects as a preprocessor macro.
Rename to fix builds.

Fixes: b/149238449
Change-Id: I9a77321504c7097a5c59dde8b918b52650a90c0f
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41050Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Includes a fix for a severe race condition, MIPS64 support and tools for comparing benchmarks.

Changes:
    246091e81 Implement support for MIPS64
    2b3e3fe6d Core: Rework fiber scheduling to fix broken behavior.
    a10646182 Add tool to diff benchmarks.
    2c9624c1b Kokoro: Print test output to logs.
    36208b483 Use SAL annotations more aggressively in the scheduler.
    492edc979 Add benchmarks using google benchmark
    32102554d Add new 'hello task' example, add to README.md
    9b860935b CMake: Make the marl target's include directory public
    8cdb1b1f0 CMakeLists.txt: Make it easier to specify third_party vars.
    e25626a8e CMakeLists: Don't repeatedly include MARL_OS_LIBS

Commands: git subtree pull --prefix third_party/marl https://github.com/google/marl master --squash

Bug: b/140546382
Change-Id: Ide16cac37ce47eb2e8e0d7468f747cf299c749b8

246091e81 Implement support for MIPS64
2b3e3fe6d Core: Rework fiber scheduling to fix broken behavior.
a10646182 Add tool to diff benchmarks.
2c9624c1b Kokoro: Print test output to logs.
36208b483 Use SAL annotations more aggressively in the scheduler.
492edc979 Add benchmarks using google benchmark
32102554d Add new 'hello task' example, add to README.md
9b860935b CMake: Make the marl target's include directory public
8cdb1b1f0 CMakeLists.txt: Make it easier to specify third_party vars.
e25626a8e CMakeLists: Don't repeatedly include MARL_OS_LIBS

git-subtree-dir: third_party/marl
git-subtree-split: 246091e814658337b22f212c97d0659ea3673c9f

0aef6454 added a new dependency on Reactor/EmulatedReactor.cpp which was not referenced by Android.bp. Add it to fix the build.

Bug: b/145754674
Change-Id: Id9bac3c9e94edc97959b2a8c1d4abe10f7b78719
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40976Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

As was done with LLVM (https://swiftshader-review.googlesource.com/c/SwiftShader/+/35988),
implement Sinh and Cosh in terms of Exp for Subzero. Both backends now
call into EmulatedReactor. This is not the right solution, as Reactor
should be implemented in terms of std cosh/sinh or intrinsics, as per
b/149110874.

Bug: b/145754674
Change-Id: I8f513e46fb4af270a847343e4b561927aaad1560
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41009Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Bug: b/144825072
Change-Id: I17def9659c0d0bc4761e4b1b0673fe248ab31cf5
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/41008Reviewed-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

Delete Reactor/DebugAndroid.cpp and Reactor/DebugAndroid.hpp for the same reasons explained in the parent change.

The System / Reactor debug implementations are still not merged, but at least they're now consistent.
System/Debug requires `UNIMPLEMENTED()` to have a bug number for each message, but reactor has a whole bunch of ancient uses without any mention of a bug. I don't have the context to create these bugs, so for now I've created a temporary `UNIMPLEMENTED_NO_BUG()` variant. With this we can easily grep the codebase to locate these usages and create bugs as needed.

Bug: b/146051794
Bug: b/144093703
Change-Id: Id5208f924e63dae7443f95aab5b601a290c297e7
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40969
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>

Many opcode are not actual statements, but opcodes for declaring types, decorations, capabilities, etc. Single line stepping over these is pointless as they do not actually do anything at execution time.

Just ignore them.

Bug: b/148778720
Change-Id: I0f55fe4b7308f33119dcea4012bc837c375ad5c3
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40830
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

`SWIFTSHADER_LOGGING_LEVEL` controls how much logging we perform.
It defaults to `INFO`, so logs at `DEBUG` level are not printed by default.

Bug: b/146051794
Change-Id: I2037d1c912b24ee8d2e6543074850b65bbbd988a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40975Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

Add the missing dependency from WSI -> System.

Bug: b/146051794
Change-Id: I15a48f37d764c339c8c032589625b6d173df76b9
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40974Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Delete Vulkan/VkDebug.hpp and Vulkan/VkDebug.cpp, use System/Debug.hpp from now on.

Also delete System/DebugAndroid.hpp and System/DebugAndroid.cpp.
These declared yet another version of the debug macros, along with the
AndroidEnterDebugger() function. None of this stuff is actually used
for the Android platform builds, and this change brings in logcat support
to the standard set of macros.

Bug: b/146051794
Change-Id: Ib52ec6af34cdf4ac390c73cb331239d81bed6e06
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40968
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Refactor the code so that logging level can be included.

Bug: b/144093703
Change-Id: I266384b7f971109214ae8d435209478ba705bc66
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40951
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Time the Fibonacci function in iterations of 8^N, where N=[0..8]

Bug: b/148660286
Change-Id: Ief391a7f6181c5907de128f5c983ac32aeadfae0
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40949Tested-by: Ben Clayton <bclayton@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>

Bug: b/148660286
Change-Id: I790653cd32736fe5d2ff5d511e42fd232032cadb
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40948
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Alexis Hétu <sugoi@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

Unpoison all buffers we store to.

Bug: b/140204746
Change-Id: I211d799b294932affe82cb310ed02d0c0ed5149a
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40908Tested-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

All places this was raised look like safe usage to me.

Also shuffled some CMake code around so that compiler
warning settings all sit next to each other.

Fixes: b/148842417
Change-Id: I262d0fdacc7a88092cad0890504b0e475f750d47
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40835
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

These used to assert.
Instead of asserting, let the compiler warn about unhandled cases - there's already a `return "<unknown>"` statement below the switch.

Credit to Dan Sinclair who did all the hard work here.

Bug: None - maintenance fix for legacy code
Change-Id: I010a1d6228961a80a15523ff1a2c6db522b7756d
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40833
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>

The compiler would produce an `OPCODE_ELSE` with no preceeding `OPCODE_IF`, causing hilarity downstream in the VertexProgram and PixelProgram.

Credit to Dan Sinclair who did all the hard work here.

Bug: None - surfaced when rolling a new version of SPIR-V cross.
Change-Id: I8a937a4d24768dbcc125c3fff834342bd8d0ef29
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40832Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Tested-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>

The environment variables were being modified incorrectly, introducing
blank lines, which Windows doesn't like, leading to the spawned deqp
process having a blank env var table.

Change-Id: Id034594219397809667670f9f7fb26f67ee7d87c
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40888Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Tested-by: Antonio Maiorano <amaiorano@google.com>

this can break the android build.
Keep the current vk_swiftshader.lds for the other purposes

Bug: b/148822450
Change-Id: I791b216cc05606ebf51f95d051bb658c0be388fe
Reviewed-on: https://swiftshader-review.googlesource.com/c/SwiftShader/+/40868
Kokoro-Presubmit: Lingfeng Yang <lfy@google.com>
Kokoro-Presubmit: kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Tested-by: Lingfeng Yang <lfy@google.com>