- 13 Sep, 2017 1 commit
-
-
Nicolas Capens authored
Some applications may not call eglReleaseThread() before terminating a thread, which can cause a minor memory leak. pthread_key_create() supports specifying a destructor callback to implicitly free the thread-local storage on thread termination. On Windows we use the DLL_THREAD_DETACH signal to free it explicitly. This change also simplifies TLS management by removing the ability to set a new value. Bug swiftshader:80 Change-Id: I249ca519c1c9ab722e570516d0931cb17ea081bb Reviewed-on: https://swiftshader-review.googlesource.com/12068Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 11 Sep, 2017 1 commit
-
-
Nicolas Capens authored
The stencil test compares the unsigned masked reference value against the unsigned masked stencil value. But because x86 vector instructions only support signed comparison, we have to add 0x80 to both sides. However, this offset was incorrectly added before the masking. Bug b/64683344 Change-Id: I49748e25d8d99e1c2b3c87d3dbe74a9dba75fb1c Reviewed-on: https://swiftshader-review.googlesource.com/12028Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 05 Sep, 2017 1 commit
-
-
Nicolas Capens authored
eglReleaseThread() was leaking some memory because even though it deletes the 'current' thread state, it was inadvertently getting re-allocated when recording the success error state. Change-Id: I92efb1b34e62a21998b4fc19aaeba6473b06548b Reviewed-on: https://swiftshader-review.googlesource.com/11968Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 01 Sep, 2017 1 commit
-
-
Nicolas Capens authored
Emulated vectors have fewer elements than their underlying type, e.g. v4i16 is stored in the lower half of a v8i16 vector, but for constant vector construction we need to provide values for all the elements of the underlying vector. Bug b/65124545 Change-Id: Iaf942c4d517b1d4d464894ec501f7d339ae86438 Reviewed-on: https://swiftshader-review.googlesource.com/11908Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 31 Aug, 2017 2 commits
-
-
Nicolas Capens authored
Change-Id: Ia4feb6791c6da8dc4beef86aab7eb4fa06af461b Reviewed-on: https://swiftshader-review.googlesource.com/11869Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Jiyong Park authored
When BOARD_VNDK_VERSION is set, a vendor lib cannot link against a platform lib and is not provided with global include path. So, some internal libraries such as swiftshader_top_[release|debug] were also marked as vendor module and dependency to some header libs (libhardware_headers, libnativebase_headers, etc.) were added explicitly. Bug: 64704866 Test: lunch sdk_gphone_x86-user, BOARD_VNDK_VERSION=current m -j libEGL_swiftshader libGLESv1_CM_swiftshader libGLESv2_swiftshader successful Change-Id: I37851c9876f7f7c247bbc5d6e18946cb5bf72fa2 Reviewed-on: https://swiftshader-review.googlesource.com/11868Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 17 Aug, 2017 2 commits
-
-
Alexis Hetu authored
Removing the "STRICT_CONFORMANCE" restriction from Chromium. This allows OpenGL ES3 context creation when using the flag "--use-gl=swiftshader", which is the case when running layout tests. This does not allow WebGL 2 content to be used when using the flag "--disable-gpu". This will require extra validation on the Chromium side. Change-Id: Ic4770c1acbc454a954e1ce813ebed9ed3aee5cd2 Reviewed-on: https://swiftshader-review.googlesource.com/11750Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
Implemented glGetFragDataLocation. There's very little coverage for this function in dEQP, but the one test that uses it passes. Change-Id: I6cfc93d7eaad54f23c922e45dafee9cba3401c83 Note: Chromium's ES3 path requires this function to be implemented. Reviewed-on: https://swiftshader-review.googlesource.com/11728Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 16 Aug, 2017 1 commit
-
-
Alexis Hetu authored
- GL_MAX_PROGRAM_TEXEL_OFFSET and GL_MIN_PROGRAM_TEXEL_OFFSET were technically already properly implemented, since the spec mentions that the behavior outside of these limits is undefined, and SwiftShader has no actual hard limit for these parameters. - GL_MAX_TEXTURE_LOD_BIAS also has no hard limit in SwiftShader, other than the limit imposed on LOD itself, so that limit was used for GL_MAX_TEXTURE_LOD_BIAS. Change-Id: I60b15b7f7a0febbc3e6582caff6c6a414a5d4964 Reviewed-on: https://swiftshader-review.googlesource.com/11709Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 14 Aug, 2017 1 commit
-
-
Robert Liao authored
SwiftShader requests the optimized flags for debug buidls for performance. This leads to an incompatible use of /O1 and /RTC1. BUG=chromium:755195 Change-Id: I53b6f99a67d0b8d5fc5932b677ee278aca300702 Reviewed-on: https://swiftshader-review.googlesource.com/11594Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Robert Liao <robliao@chromium.org>
-
- 12 Aug, 2017 2 commits
-
-
Nicolas Capens authored
Travis CI by default uses XCode 7.3 on Mac OS X, which does not support the C++11 thread_local keyword expected by Subzero. Request XCode 8 GM instead. Change-Id: I0afa7804997ff5b5a6bbfe7829ba6134fe3d54ca Reviewed-on: https://swiftshader-review.googlesource.com/11548Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
matrix.include adds to the default builds which use Ubuntu Precise which doesn't come with C++11 support by default. Change-Id: I3c009bedc62aefd3363f749bb3cb22e9bc36fb9a Reviewed-on: https://swiftshader-review.googlesource.com/11528Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 11 Aug, 2017 2 commits
-
-
Nicolas Capens authored
Change-Id: I36a39720b34ccc58276f9943bf6ef289b1af9b1e Reviewed-on: https://swiftshader-review.googlesource.com/11511Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Subzero requires full C++11 support, which isn't available on Android versions prior to Marshmallow. Change-Id: Icf09a51b525a1503f72441c969a9e364306096bd Reviewed-on: https://swiftshader-review.googlesource.com/11488Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 10 Aug, 2017 2 commits
-
-
Alexis Hetu authored
The SwiftShader library, when used to render Layout Tests in Debug, causes too many timeouts. For that reason, we need the Debug version of the library have better overall performance. In Debug, the "default_optimization" defaults to "no_optimization". See: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?l=1698 In Release, "default_optimization" defaults to "optimize", so in order to at least use the same optimization flags in both case, we replace "default_optimization" by "optimize" in Debug. The Win 7 (dbg) bot ran successfully with this change (the telemetry_tests were failing when building the full Release version of the SwiftShader library with the Debug version of Chromium). Change-Id: I3529160b539319e26f9898d2588536d378c3ee01 Reviewed-on: https://swiftshader-review.googlesource.com/11469Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
This follows the GLSL ES 1.0 and 3.0 specs more strictly. Change-Id: I323e90ef0a1588109e2cb7988136a9520e501a6d Reviewed-on: https://swiftshader-review.googlesource.com/5065Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 09 Aug, 2017 2 commits
-
-
Nicolas Capens authored
~mask[i % size] is the same as mask[~i % size] because it's just an expansion of i, so there's no need for invMask[] to store the former. Change-Id: I754732a2c4978281d35037941ecb74448ab78a8e Reviewed-on: https://swiftshader-review.googlesource.com/3258Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Branimir Karadžić authored
A timestamp query records the current time when it's issued, not when the data is being retrieved. Change-Id: Idb6e7fe6736a5b54bd23ef1613eaf953da86aa08 Reviewed-on: https://swiftshader-review.googlesource.com/5771Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 08 Aug, 2017 2 commits
-
-
Alexis Hetu authored
This cl simply makes the code compile on Ozone. It does not implement the FrameBufferOzone class, but provides a skeleton for it, which can be implemented by people on the ChromeOS team. Change-Id: Ib77e20b00e8208d992c80f47b5ba55e00254c812 Reviewed-on: https://swiftshader-review.googlesource.com/11348Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
There's an issue with the new debug specific path in the build files. Rolling back these changes in order to do the DEPS roll while the investigation on this issue continues. Change-Id: I9c2174d3ec2ab4e8f817c7cae32f69af1728c6c2 Reviewed-on: https://swiftshader-review.googlesource.com/11328Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
- 05 Aug, 2017 1 commit
-
-
Nicolas Capens authored
This enables swizzling of Int4 and UInt4 types using swizzle operators. Change-Id: I83fe5b472433d84a7b092e18eb78a919fb39b03b Reviewed-on: https://swiftshader-review.googlesource.com/8530Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 04 Aug, 2017 12 commits
-
-
Nicolas Capens authored
Known projects avoid using HAL_PIXEL_FORMAT_RGB_888 because we have no immediate desire to support it (for performance reasons), but other users may run into unexpected issues that previously would leave no trace. Change-Id: Idc606809117f8e0b200b4b38c58ba24696e7193c Reviewed-on: https://swiftshader-review.googlesource.com/11311Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
We currently don't support EGL configs/surfaces with sRGB formats. Change-Id: Ie23a5121bec784fe807c03feae19442fece3f1d7 Reviewed-on: https://swiftshader-review.googlesource.com/11268Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
This should allow to compile on the OZONE platform without hitting the X11 include library problem. The change is imported from: https://cs.chromium.org/chromium/src/third_party/khronos/EGL/eglplatform.h Change-Id: I3b3acc139865797ce6c4173991f15840e91f5935 Reviewed-on: https://swiftshader-review.googlesource.com/11308Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
Updated EGL and KHR headers as is, with one minor patch applied in the ANDROID section of the eglplatform.h files. Other files are unmodified from their Khronos version. Change-Id: I2147df6bf36c7ec4c5cd6d32f8863b512a356112 Reviewed-on: https://swiftshader-review.googlesource.com/11310Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
Switching SwiftShader on ChromeOS from LLVM to Subzero. Change-Id: Ica9ac278272f99b94d365f03fbd7a4860ad3503d Reviewed-on: https://swiftshader-review.googlesource.com/11309Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
Fixed a few types in function signatures so that base and derived classes signatures match. Change-Id: Ide9b9c78ff05be785b512451a36c836f35bd1f3d Reviewed-on: https://swiftshader-review.googlesource.com/5463Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
Change-Id: I4e0e956bd34f5ec2a3c38208cb99ac476ec26623 Reviewed-on: https://swiftshader-review.googlesource.com/11290Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
The functions relating to ANativeWindow have been split off from libandroid into libnativewindow as part of project Treble. Change-Id: I59850e4ba4145e49735698901dc2ba3480c68509 Reviewed-on: https://swiftshader-review.googlesource.com/11229Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Older compiler versions warned about unknown attributes with -Wattributes instead of -Wunknown-attributes. Use both and suppress warnings about unknown warnings options too. Change-Id: I22252426e73d4984471b9b8415479bd7b57ba0c5 Reviewed-on: https://swiftshader-review.googlesource.com/11289Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Forward declare ANativeWindow, and remove <hardware/gralloc.h> where GrallocAndroid.hpp already includes it. Change-Id: Idebd4c40280960ff00cd51b6633c1c84a8cf7de2 Reviewed-on: https://swiftshader-review.googlesource.com/11288Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
Older versions of Android using stlport were failing to compile with an "assert has been defined before inclusion of assert.h header" error. Change-Id: If8e13eb08c35a34d082d99f8f57188bc55697f59 Reviewed-on: https://swiftshader-review.googlesource.com/11270Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Nicolas Capens authored
This change has been part of the Android NDK since API 18, corresponding with Android 4.3 Jelly Bean MR2. Change-Id: I6df06f46c286ce89ea56913684e43d558917d1a8 Reviewed-on: https://swiftshader-review.googlesource.com/11269Tested-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
- 03 Aug, 2017 3 commits
-
-
Nico Weber authored
In particular, https://reviews.llvm.org/D36281 Bug: chromium:495204 Change-Id: I48afb5b8dd594ce1b43c6ca9fb20638d40119236 Reviewed-on: https://swiftshader-review.googlesource.com/11248Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nico Weber <thakis@google.com>
-
Alexis Hetu authored
The 'optimize_max' option is not meant to be used by default for Release builds. These use the 'optimize' config. See comment here for explanation: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?l=1572 Change-Id: I7af8e3e4c7e92c60f38841b75998e2b488a5ffde Reviewed-on: https://swiftshader-review.googlesource.com/11228Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Nicolas Capens authored
This enables using half-float vertex data for OpenGL ES 2.0. Note that GL_HALF_FLOAT_OES does not have the same value as GL_HALF_FLOAT. Change-Id: I0a7a55b7904fe797cdbb86627c8d0a1cc07d2d0a Reviewed-on: https://swiftshader-review.googlesource.com/1500Reviewed-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Tested-by:
Nicolas Capens <nicolascapens@google.com>
-
- 02 Aug, 2017 4 commits
-
-
Alexis Hetu authored
On the mac_optional_gpu_tests_rel bot, a -Wall flag cancels out the -Wno-unused-local-typedef warning suppression and causes the build to fail. Attempting to reorder the configs order to solve the issue. Change-Id: Ic790f5cb7803be4749616d826e1368ef76e2c889 Reviewed-on: https://swiftshader-review.googlesource.com/11212Reviewed-by:
Nicolas Capens <nicolascapens@google.com> Reviewed-by:
Alexis Hétu <sugoi@google.com> Tested-by:
Alexis Hétu <sugoi@google.com>
-
Alexis Hetu authored
GL_R11F_G11F_B10F was missing from a utility function, causing some dEQP tests to fail. Simply adding it fixes most R11F_G11F_B10F related tests in: functional.fbo.* functional.fragment_out.* functional.pbo.* Change-Id: I0d77f1c9c01aff106e266853e81b4cf45f748bc1 Reviewed-on: https://swiftshader-review.googlesource.com/11211Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
A few more warnings suppression were missing after the last build file change. Added them here to hopefully fix build issues. Change-Id: I80371a3ae59920dccf9c64a36c96d0341e7e39f5 Reviewed-on: https://swiftshader-review.googlesource.com/11210Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-
Alexis Hetu authored
The '-Wall' flag is already specified in Chromium and this '-Wall' flag invalidates any previous '-Wno-*' flags. Removing it solves the compilation issue. Change-Id: Iceefb63ff7e04c55884cf26bbde0d62ffb74b217 Reviewed-on: https://swiftshader-review.googlesource.com/11208Tested-by:
Alexis Hétu <sugoi@google.com> Reviewed-by:
Nicolas Capens <nicolascapens@google.com>
-